@saluzi/saluzi-edu 0.2.63 → 0.2.64

package/packages/remote-control-server/src/routes/v1/environments.ts

@@ -1,93 +1,24 @@
 import { Hono } from 'hono'
-import type { Context, Next } from 'hono'
 import { randomUUID } from 'node:crypto'
 import {
   registerEnvironment,
   deregisterEnvironment,
   reconnectEnvironment,
+  updatePollTime,
 } from '../../services/environment'
-import {
-  apiKeyAuth,
-  acceptCliHeaders,
-  extractBearerToken,
-} from '../../auth/middleware'
-import { validateApiKey } from '../../auth/api-key'
-import { resolveToken } from '../../auth/token'
-import { resolveSessionToken } from '../../auth/session'
+import { acceptCliHeaders, apiKeyAuth } from '../../auth/middleware'
+import { bridgeAuth, resolveUserIdUuid } from '../../auth/bridge-auth'
 import { getDb } from '../../db/sqlite'
+import { isSessionClosedStatus } from '../../services/session'
 import {
   storeBindEnvSessionsToTeam,
   storeGetEnvironment,
   storeGetEnvironmentOwnership,
+  storeListSessionsByEnvironment,
 } from '../../store'
 
 const app = new Hono()
 
-/**
- * Combined auth for bridge endpoint: accepts session tokens (rct_*),
- * in-memory issueToken tokens, or admin API keys. Also falls back to
- * apiKeyAuth's X-Username header support for CLI bridges.
- */
-async function bridgeAuth(c: Context, next: Next) {
-  const bearer = extractBearerToken(c)
-  if (bearer) {
-    // Admin API key
-    if (validateApiKey(bearer)) {
-      c.set('userId', c.req.header('X-Username') || c.req.query('username'))
-      c.set('isApiAdmin', true)
-      await next()
-      return
-    }
-    // In-memory token
-    const username = resolveToken(bearer)
-    if (username) {
-      c.set('userId', username)
-      await next()
-      return
-    }
-    // SQLite session token
-    try {
-      const db = getDb()
-      const userId = resolveSessionToken(bearer, db)
-      if (userId) {
-        c.set('userId', userId)
-        await next()
-        return
-      }
-    } catch (err) {
-      console.error('[bridge] DB error during session token resolution:', err)
-      return c.json({ error: 'Database unavailable' }, 503)
-    }
-  }
-  // Fall back to apiKeyAuth (handles X-Username + API key from body/header)
-  return apiKeyAuth(c, next)
-}
-
-/**
- * Resolve a userId value (UUID or username) to a users.id UUID.
- * Returns null if no matching user exists.
- *
- * bridgeAuth's three token paths return different userId shapes:
- * - resolveSessionToken (rct_* SQLite token) → users.id (UUID)
- * - resolveToken (in-memory token) → username (string)
- * - validateApiKey + X-Username → X-Username header value (arbitrary string)
- *
- * Only UUIDs that exist in the users table can become env owners, so a
- * client-controlled X-Username value can't create an owner for a
- * non-existent user — resolveUserIdUuid is the safety gate.
- */
-function resolveUserIdUuid(
-  db: ReturnType<typeof getDb>,
-  value: string,
-): string | null {
-  const row = db
-    .query(
-      'SELECT id FROM users WHERE id = $value OR username = $value LIMIT 1',
-    )
-    .get({ $value: value }) as { id: string } | null
-  return row?.id ?? null
-}
-
 /** Result of validateTeamBinding — rendered by the route layer. */
 type TeamBindingCheck =
   | { ok: true; audit?: string }
@@ -299,6 +230,10 @@ app.post('/bridge', acceptCliHeaders, bridgeAuth, async c => {
     teamId: teamId || null,
     claimToken,
     claimExpiresAt,
+    // Session Attach wait mode: worker registered without creating a session,
+    // polling for the Web UI to bind one (surfaces as attach_waiting).
+    session_mode:
+      typeof body.session_mode === 'string' ? body.session_mode : null,
   })
 
   // Link environment to team if X-Team-Id was provided
@@ -342,6 +277,45 @@ app.post('/bridge', acceptCliHeaders, bridgeAuth, async c => {
   return c.json(result, 200)
 })
 
+/** GET /v1/environments/:id/assignment — Session Attach wait-mode poll.
+ *  A worker registered with session_mode:'attach' polls this endpoint while
+ *  waiting for the Web UI to bind a session (POST /v1/sessions/:id/attach).
+ *  Returns the first open, non-ACP session on the environment, or
+ *  assigned:false to keep waiting. Long-polling is unnecessary — the worker
+ *  already runs a poll loop cadence for work items. */
+app.get('/:id/assignment', acceptCliHeaders, bridgeAuth, async c => {
+  const envId = c.req.param('id')!
+  const env = storeGetEnvironment(envId)
+  if (!env || env.status !== 'active') {
+    return c.json(
+      { error: { type: 'not_found', message: 'Environment not found' } },
+      404,
+    )
+  }
+  // The attach-wait worker has no work item in flight, so the work-poll
+  // route never refreshes its heartbeat. This poll IS its liveness signal:
+  // without touching lastPollAt the disconnect monitor flips the env to
+  // disconnected after the idle timeout, assignment starts 404ing, and the
+  // CLI silently spins until its 24h deadline (P0-2).
+  updatePollTime(envId)
+  const assigned = storeListSessionsByEnvironment(envId)
+    .filter(s => !isSessionClosedStatus(s.status))
+    .filter(s => s.source !== 'acp')
+    .sort((a, b) => b.updatedAt.getTime() - a.updatedAt.getTime())[0]
+  if (!assigned) {
+    return c.json({ assigned: false }, 200)
+  }
+  return c.json(
+    {
+      assigned: true,
+      session_id: assigned.id,
+      title: assigned.title,
+      status: assigned.status,
+    },
+    200,
+  )
+})
+
 /** DELETE /v1/environments/bridge/:id — Deregister */
 app.delete('/bridge/:id', acceptCliHeaders, apiKeyAuth, async c => {
   const envId = c.req.param('id')!