@saltcorn/server 1.3.1-beta.0 → 1.3.1-beta.10

package/routes/menu.js

@@ -119,6 +119,8 @@ const menuForm = async (req) => {
           "View",
           "Page",
           "Page Group",
+          "Admin Page",
+          "User Page",
           "Link",
           "Header",
           "Dynamic",
@@ -150,6 +152,39 @@ const menuForm = async (req) => {
         options: pages.map((r) => r.name),
         showIf: { type: "Page" },
       },
+      {
+        name: "admin_page",
+        label: req.__("Admin Page"),
+        input_type: "select",
+        class: "item-menu",
+        options: [
+          "Tables",
+          "Views",
+          "Pages",
+          "About application",
+          "Modules",
+          "Users and security",
+          "Site structure",
+          "Files",
+          "Events",
+          "Settings",
+        ],
+        showIf: { type: "Admin Page" },
+      },
+      {
+        name: "user_page",
+        label: req.__("User Page"),
+        input_type: "select",
+        class: "item-menu",
+        options: [
+          "Notifications",
+          "User settings",
+          "Login",
+          "Logout",
+          "Signup",
+        ],
+        showIf: { type: "User Page" },
+      },
       {
         name: "viewname",
         label: req.__("View"),
@@ -247,6 +282,16 @@ const menuForm = async (req) => {
         required: true,
         showIf: { type: "Dynamic" },
       },
+      {
+        name: "user_menu_header",
+        label: req.__("User menu header"),
+        sublabel: req.__("Some themes display this header differently"),
+        type: "Bool",
+        class: "item-menu",
+        required: false,
+        default: false,
+        showIf: { type: "Header" },
+      },
       {
         name: "text",
         label: req.__("Text label"),
@@ -263,6 +308,8 @@ const menuForm = async (req) => {
             "Dynamic",
             "Search",
             "Action",
+            "Admin Page",
+            "User Page",
           ],
         },
       },
@@ -274,7 +321,16 @@ const menuForm = async (req) => {
           html: `<button type="button" id="myEditor_icon" class="btn btn-outline-secondary"></button>`,
         },
         showIf: {
-          type: ["View", "Page", "Page Group", "Link", "Header", "Action"],
+          type: [
+            "View",
+            "Page",
+            "Page Group",
+            "Link",
+            "Header",
+            "Action",
+            "Admin Page",
+            "User Page",
+          ],
         },
       },
       {
@@ -282,7 +338,16 @@ const menuForm = async (req) => {
         class: "item-menu",
         input_type: "hidden",
         showIf: {
-          type: ["View", "Page", "Page Group", "Link", "Header", "Action"],
+          type: [
+            "View",
+            "Page",
+            "Page Group",
+            "Link",
+            "Header",
+            "Action",
+            "Admin Page",
+            "User Page",
+          ],
         },
       },
       {
@@ -301,6 +366,8 @@ const menuForm = async (req) => {
             "Dynamic",
             "Search",
             "Action",
+            "Admin Page",
+            "User Page",
           ],
         },
       },
@@ -343,7 +410,16 @@ const menuForm = async (req) => {
         type: "Bool",
         required: false,
         class: "item-menu",
-        showIf: { type: ["View", "Page", "Page Group", "Link"] },
+        showIf: {
+          type: [
+            "View",
+            "Page",
+            "Page Group",
+            "Link",
+            "Admin Page",
+            "User Page",
+          ],
+        },
       },
       {
         name: "in_modal",
@@ -351,7 +427,16 @@ const menuForm = async (req) => {
         type: "Bool",
         required: false,
         class: "item-menu",
-        showIf: { type: ["View", "Page", "Page Group", "Link"] },
+        showIf: {
+          type: [
+            "View",
+            "Page",
+            "Page Group",
+            "Link",
+            "Admin Page",
+            "User Page",
+          ],
+        },
       },
       {
         name: "style",
@@ -369,6 +454,8 @@ const menuForm = async (req) => {
             "Header",
             "Dynamic",
             "Action",
+            "Admin Page",
+            "User Page",
           ],
         },
         attributes: {
@@ -403,6 +490,8 @@ const menuForm = async (req) => {
             "Search",
             "Separator",
             "Action",
+            "Admin Page",
+            "User Page",
           ],
         },
         sublabel: req.__("Not all themes support all locations"),
@@ -628,14 +717,17 @@ router.post(
   "/action/:rndid",
   error_catcher(async (req, res, next) => {
     const state = getState();
-    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModeEnabled = state.getConfig(
+      "maintenance_mode_enabled",
+      false
+    );
 
     if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
       res.status(503).json({ error: "in maintenance mode" });
       return;
     }
     next();
-  }),
+  })
 );
 
 const getIcons = () => {

package/routes/notifications.js

@@ -32,14 +32,19 @@ router.use(
   })
 );
 
-const notificationSettingsForm = () => {
+const notificationSettingsForm = (user) => {
   const fields = [{ name: "notify_email", label: "Email", type: "Bool" }];
-  if (getState().getConfig("enable_push_notify", false))
-    fields.push({
-      name: "notify_push",
-      label: "Push",
-      type: "Bool",
-    });
+  if (getState().getConfig("enable_push_notify", false)) {
+    const policyByRole = getState()?.getConfig("push_policy_by_role") || {};
+    const pushPolicy = policyByRole[user?.role_id || 100] || "Default on";
+    if (!["Always", "Never"].includes(pushPolicy)) {
+      fields.push({
+        name: "notify_push",
+        label: "Push",
+        type: "Bool",
+      });
+    }
+  }
 
   return new Form({
     action: `/notifications/settings`,
@@ -74,12 +79,23 @@ router.get(
             }
       );
 
-    const form = notificationSettingsForm();
+    const form = notificationSettingsForm(req.user);
     const user = await User.findOne({ id: req.user?.id });
     form.values = {
       notify_email: user?._attributes?.notify_email,
-      notify_push: user?._attributes?.notify_push,
     };
+
+    if (getState().getConfig("enable_push_notify", false)) {
+      let notifPushAttr = user?._attributes?.notify_push;
+      if (notifPushAttr === undefined) {
+        const policyByRole = getState()?.getConfig("push_policy_by_role") || {};
+        const pushPolicy = policyByRole[user.role_id || 100] || "Default on";
+        if (pushPolicy === "Default on") notifPushAttr = true;
+        else if (pushPolicy === "Default off") notifPushAttr = false;
+      }
+      form.values.notify_push = notifPushAttr;
+    }
+
     const notifyCards = nots.length
       ? nots.map((not) => ({
           type: "card",
@@ -193,11 +209,23 @@ router.post(
   loggedIn,
   error_catcher(async (req, res) => {
     const user = await User.findOne({ id: req.user.id });
-    const form = notificationSettingsForm();
+    const form = notificationSettingsForm(req.user);
     form.validate(req.body || {});
     const _attributes = { ...user._attributes, ...form.values };
+
+    // apply push enabled policy if needed
+    if (getState().getConfig("enable_push_notify", false)) {
+      const policyByRole = getState()?.getConfig("push_policy_by_role") || {};
+      const pushPolicy = policyByRole[user.role_id || 100] || "Default on";
+      if (pushPolicy === "Always") _attributes.notify_push = true;
+      else if (pushPolicy === "Never") _attributes.notify_push = false;
+      else if (_attributes.notify_push === undefined) {
+        _attributes.notify_push = pushPolicy === "Default on";
+      }
+    }
+
     await user.update({ _attributes });
-    const pushEnabled = !!_attributes.notify_push;
+    const pushEnabled = _attributes.notify_push;
     const allSubs = getState().getConfig("push_notification_subscriptions", {});
     const newSubs = { ...allSubs };
     if (!pushEnabled && newSubs[req.user.id]) {

package/routes/page.js

@@ -46,18 +46,21 @@ const findPageOrGroup = (pagename) => {
 
 const runPage = async (page, req, res, tic) => {
   const role = req.user && req.user.id ? req.user.role_id : 100;
+  // let resultCollector = {};
   if (role <= page.min_role) {
     const contents = await page.run(req.query, { res, req });
     const title = scan_for_page_title(contents, page.title);
     const tock = new Date();
     const ms = tock.getTime() - tic.getTime();
-    if (!isTest())
+
+    if (!isTest()) {
       Trigger.emitEvent("PageLoad", null, req.user, {
         text: req.__("Page '%s' was loaded", page.name),
         type: "page",
         name: page.name,
         render_time: ms,
       });
+    }
     if (contents.html_file) await sendHtmlFile(req, res, contents.html_file);
     else
       res.sendWrap(

package/routes/pageedit.js

@@ -174,7 +174,9 @@ const pageBuilderData = async (req, context) => {
   const actions = [
     "GoBack",
     ...Object.entries(stateActions)
-      .filter(([k, v]) => !v.requireRow && !v.disableInBuilder)
+      .filter(
+        ([k, v]) => !v.requireRow && !v.disableInBuilder && !v.disableIf?.()
+      )
       .map(([k, v]) => k),
   ];
   const triggers = await Trigger.find({
@@ -199,6 +201,7 @@ const pageBuilderData = async (req, context) => {
   const actionsNotRequiringRow = Trigger.action_options({
     notRequireRow: true,
     apiNeverTriggers: true,
+    forBuilder: true,
     builtInLabel: "Page Actions",
     builtIns: ["GoBack"],
   });

package/routes/plugins.js

@@ -238,7 +238,7 @@ const cfg_link = (req, row) => {
   if (plugin.configuration_workflow)
     return a(
       {
-        class: "btn btn-secondary btn-sm d-inline me-1",
+        class: "btn btn-secondary btn-sm d-inline-block",
         role: "button",
         href: `/plugins/configure/${encodeURIComponent(row.name)}`,
         title: req.__("Configure plugin"),
@@ -256,7 +256,7 @@ const cfg_link = (req, row) => {
 const info_link = (req, row) =>
   a(
     {
-      class: "btn btn-secondary btn-sm d-inline",
+      class: "btn btn-secondary btn-sm d-inline-block me-1",
       role: "button",
       href: `/plugins/info/${encodeURIComponent(row.name)}`,
       title: req.__("Information about plugin"),
@@ -306,7 +306,7 @@ const store_item_html = (req) => (item) => ({
       !item.installed &&
         item.plugin &&
         div(
-          { class: "me-2 d-inline" },
+          { class: "d-inline" },
           post_btn(
             `/plugins/install/${encodeURIComponent(item.name)}`,
             req.__("Install"),
@@ -331,10 +331,11 @@ const store_item_html = (req) => (item) => ({
             onClick: "press_store_button(this)",
           }
         ),
-
-      item.installed && item.plugin && cfg_link(req, item),
-      item.installed && item.plugin && info_link(req, item),
-
+      div(
+        { class: "btn-group", role: "group" },
+        item.installed && item.plugin && cfg_link(req, item),
+        item.installed && item.plugin && info_link(req, item)
+      ),
       item.installed &&
         item.pack &&
         post_btn(

package/routes/tables.js

@@ -1309,6 +1309,17 @@ router.post(
       } else rest.ownership_formula = null;
       await db.withTransaction(async () => {
         await table.update(rest);
+        // Update table field's min_role_write attributes
+        const fields = table.getFields();
+
+        for (const f of fields) {
+          if (f.attributes?.min_role_write) {
+            f.attributes.min_role_write = parseInt(rest.min_role_write);
+            await f.update({
+              attributes: f.attributes,
+            });
+          }
+        }
       });
       await getState().refresh_tables();
       if (!req.xhr) {

package/routes/view.js

@@ -43,7 +43,10 @@ router.get(
   ["/:viewname", "/:viewname/*slug"],
   error_catcher(async (req, res) => {
     const state = getState();
-    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModeEnabled = state.getConfig(
+      "maintenance_mode_enabled",
+      false
+    );
     const maintenanceModePage = state.getConfig("maintenance_mode_page", "");
 
     if (
@@ -242,7 +245,10 @@ router.post(
   "/:viewname/:route",
   error_catcher(async (req, res, next) => {
     const state = getState();
-    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModeEnabled = state.getConfig(
+      "maintenance_mode_enabled",
+      false
+    );
 
     if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
       res.status(503).json({ error: "in maintenance mode" });
@@ -287,7 +293,10 @@ router.post(
   ["/:viewname", "/:viewname/*slug"],
   error_catcher(async (req, res, next) => {
     const state = getState();
-    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModeEnabled = state.getConfig(
+      "maintenance_mode_enabled",
+      false
+    );
     if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
       res.status(503).send("Page Unavailable: in maintenance mode");
       return;

package/serve.js

@@ -209,7 +209,6 @@ const initMaster = async ({ disableMigrate }, useClusterAdaptor = true) => {
     const state = getState();
     if (state) {
       await state.setConfig("joined_log_socket_ids", []);
-      await state.setConfig("joined_real_time_socket_ids", []);
     }
   });
   if (useClusterAdaptor) setupPrimary();
@@ -291,7 +290,8 @@ const onMessageFromWorker =
       ///ie from saltcorn
       //broadcast
       Object.entries(cluster.workers).forEach(([wpid, w]) => {
-        if (wpid !== pid) w.send(msg);
+        //if it is plugin refresh, we need sender to get it as wll
+        if (wpid !== pid || msg?.refresh_plugin_cfg) w.send(msg);
       });
       workerDispatchMsg(msg); //also master
       return true;
@@ -383,6 +383,13 @@ module.exports =
               masterState.listeningTo.add(id);
             }
           });
+          getState().sendMessageToWorkers = (msg) => {
+            Object.entries(cluster.workers).forEach(([wpid, w]) => {
+              w.send(msg);
+            });
+            workerDispatchMsg(msg); //also master
+          };
+
           if (masterState.listeningTo.size < useNCpus)
             setTimeout(initMasterListeners, 250);
         };
@@ -421,12 +428,21 @@ module.exports =
 
       if (forkAnyWorkers) {
         for (let i = 0; i < useNCpus; i++) addWorker(cluster.fork());
+        getState().sendMessageToWorkers = (msg) => {
+          Object.entries(cluster.workers).forEach(([wpid, w]) => {
+            w.send(msg);
+          });
+          workerDispatchMsg(msg); //also master
+        };
 
         cluster.on("exit", (worker, code, signal) => {
           console.log(`worker ${worker.process.pid} died`);
           addWorker(cluster.fork());
         });
       } else {
+        getState().sendMessageToWorkers = (msg) => {
+          workerDispatchMsg(msg); //also master
+        };
         await nonGreenlockWorkerSetup(appargs, port, host);
         runScheduler({
           port,
@@ -545,11 +561,26 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
       .emit("log_msg", { text: msg, time, level });
   });
 
-  // Real-time collaboration emitter
+  // Real-time collaboration emitter (tied to views)
   getState().setCollabEmitter((tenant, type, data) => {
     io.of("/").to(`_${tenant}_collab_room_`).emit(type, data);
   });
 
+  // dynamic updates emitter (for run_js_actions)
+  getState().setDynamicUpdateEmitter((tenant, data, userIds) => {
+    if (userIds) {
+      for (const userId of userIds) {
+        io.of("/")
+          .to(`_${tenant}:${userId}_dynamic_update_room`)
+          .emit("dynamic_update", data);
+      }
+    } else {
+      io.of("/")
+        .to(`_${tenant}_dynamic_update_room`)
+        .emit("dynamic_update", data);
+    }
+  });
+
   io.of("/").on("connection", (socket) => {
     socket.on("join_room", ([viewname, room_id]) => {
       const ten = get_tenant_from_req(socket.request) || "public";
@@ -597,7 +628,7 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
           callback({ status: "error", msg: err.message || "unknown error" });
         }
       };
-      if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
+      if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
       else await f();
     });
 
@@ -614,13 +645,6 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
           if (view.min_role < role_id)
             throw new Error("Not authorized to join collaboration room");
           socket.join(`_${tenant}_collab_room_`);
-          const socketIds = await getState().getConfig(
-            "joined_real_time_socket_ids"
-          );
-          socketIds.push(socket.id);
-          await getState().setConfig("joined_real_time_socket_ids", [
-            ...socketIds,
-          ]);
           if (typeof callback === "function") callback({ status: "ok" });
         } catch (err) {
           getState().log(1, `Socket join_collab_room: ${err.stack}`);
@@ -628,7 +652,30 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
             callback({ status: "error", msg: err.message || "unknown error" });
         }
       };
-      if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
+      if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
+      else await f();
+    });
+
+    // join_dynamic_update_room for events emitted from run_js_actions
+    socket.on("join_dynamic_update_room", async (callback) => {
+      const tenant =
+        get_tenant_from_req(socket.request, subdomainOffset) || "public";
+      const f = async () => {
+        try {
+          const enabled = getState().getConfig("enable_dynamic_updates", true);
+          if (!enabled) throw new Error("Dynamic updates are not enabled");
+          const user = socket.request.user;
+          if (!user) throw new Error("Not authorized");
+          socket.join(`_${tenant}_dynamic_update_room`);
+          socket.join(`_${tenant}:${user.id}_dynamic_update_room`);
+          if (typeof callback === "function") callback({ status: "ok" });
+        } catch (err) {
+          getState().log(1, `Socket join_dynamic_update_room: ${err.stack}`);
+          if (typeof callback === "function")
+            callback({ status: "error", msg: err.message || "unknown error" });
+        }
+      };
+      if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
       else await f();
     });
 
@@ -636,12 +683,20 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
       const tenant =
         get_tenant_from_req(socket.request, subdomainOffset) || "public";
       const f = async () => {
-        const socketIds = await getState().getConfig("joined_log_socket_ids");
-        const newSocketIds = socketIds.filter((id) => id !== socket.id);
-        await getState().setConfig("joined_log_socket_ids", newSocketIds);
+        const state = getState();
+        if (state) {
+          const socketIds = state.getConfig("joined_log_socket_ids");
+          const newSocketIds = socketIds.filter((id) => id !== socket.id);
+          await state.setConfig("joined_log_socket_ids", newSocketIds);
+        } else {
+          console.error("No state found in socket disconnect");
+          console.error("The current tenantSchema is:", db.getTenantSchema());
+          console.error("The current tenant from request is:", tenant);
+          console.error("node version:", process.version);
+        }
       };
-      if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
-      else f();
+      if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
+      else await f();
     });
   });
 
@@ -689,8 +744,8 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
             callback({ status: "error", msg: err.message || "unknown error" });
           }
         };
-        if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
-        else f();
+        if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
+        else await f();
       }
     );
     socket.on("write_to_stream", async (data, callback) => {
@@ -752,8 +807,8 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
             }
           });
       };
-      if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
-      else f();
+      if (tenant && tenant !== "public") await db.runWithTenant(tenant, f);
+      else await f();
     });
   });
 };

package/tests/admin.test.js

@@ -387,7 +387,7 @@ describe("actions", () => {
       .send("table_id=2")
       .send("name=mynewaction")
       .send("when_trigger=Insert")
-      .expect(toRedirect("/actions/configure/3"));
+      .expect(toRedirect("/actions/configure/7"));
   });
   it("show edit", async () => {
     const app = await getApp({ disableCsrf: true });
@@ -451,9 +451,9 @@ describe("actions", () => {
       .send("action=run_js_code")
       .send("when_trigger=API+call")
       .send("min_role=1")
-      .expect(toRedirect("/actions/configure/4"));
+      .expect(toRedirect("/actions/configure/8"));
     await request(app)
-      .post("/actions/configure/4")
+      .post("/actions/configure/8")
       .set("Cookie", loginCookie)
       .send("code=return 27")
       .expect(toRedirect("/actions/"));

package/tests/auth.test.js

@@ -166,6 +166,7 @@ describe("AuthTest forgot password", () => {
       .post("/auth/reset")
       .send("email=staff1@foo.com")
       .send("password=bazzRGGR65zoo")
+      .send("confirm_password=bazzRGGR65zoo")
       .send("token=" + token)
       .expect(toRedirect("/auth/login"));
     await request(app)

package/tests/viewedit.test.js

@@ -208,6 +208,7 @@ describe("viewedit new List", () => {
       .send("contextEnc=" + ctx)
       .send("stepName=Options")
       .send("_row_click_type=Nothing")
+      .send("_cell_valign=Middle")
       .set("Cookie", loginCookie)
       .expect(toRedirect("/viewedit"));
   });
@@ -332,6 +333,7 @@ describe("viewedit new List with one field", () => {
       .send("contextEnc=" + ctx)
       .send("stepName=Options")
       .send("_row_click_type=Nothing")
+      .send("_cell_valign=Middle")
       .set("Cookie", loginCookie)
       .expect(toRedirect("/viewedit"));
   });