@saltcorn/server 1.3.0-beta.0 → 1.3.0-beta.10

package/routes/page.js

@@ -145,8 +145,23 @@ const runPageGroup = async (pageGroup, req, res, tic) => {
 router.get(
   "/:pagename",
   error_catcher(async (req, res) => {
-    const { pagename } = req.params;
     const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModePage = state.getConfig("maintenance_mode_page", "");
+
+    if (
+      maintenanceModeEnabled &&
+      (!req.user || req.user.role_id > 1) &&
+      maintenanceModePage
+    ) {
+      const maintenancePage = await Page.findOne({ name: maintenanceModePage });
+      if (maintenancePage) {
+        await runPage(maintenancePage, req, res, new Date());
+        return;
+      }
+    }
+
+    const { pagename } = req.params;
     state.log(
       3,
       `Route /page/${pagename} user=${req.user?.id}${
@@ -177,6 +192,13 @@ router.post(
   "/:pagename/preview",
   isAdmin,
   error_catcher(async (req, res) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
+      res.status(503).json({ error: "in maintenance mode" });
+      return;
+    }
+
     const { pagename } = req.params;
     const page = await Page.findOne({ name: pagename });
     if (!page) {
@@ -191,6 +213,13 @@ router.post(
 router.post(
   "/:pagename/action/:rndid",
   error_catcher(async (req, res) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
+      res.status(503).json({ error: "in maintenance mode" });
+      return;
+    }
+
     const { pagename, rndid } = req.params;
     const role = req.user && req.user.id ? req.user.role_id : 100;
     const db_page = await Page.findOne({ name: pagename });

package/routes/registry.js

@@ -19,12 +19,14 @@ const {
   details,
   summary,
 } = require("@saltcorn/markup/tags");
-const Table = require("@saltcorn/data/models/table");
 const { isAdmin, error_catcher } = require("./utils");
 const { send_infoarch_page } = require("../markup/admin.js");
+const Table = require("@saltcorn/data/models/table");
 const View = require("@saltcorn/data/models/view");
 const Page = require("@saltcorn/data/models/page");
 const Form = require("@saltcorn/data/models/form");
+const Trigger = require("@saltcorn/data/models/trigger");
+const Plugin = require("@saltcorn/data/models/plugin");
 const {
   table_pack,
   view_pack,
@@ -40,8 +42,8 @@ const {
   event_log_pack,
   install_pack,
 } = require("@saltcorn/admin-models/models/pack");
-const Trigger = require("@saltcorn/data/models/trigger");
 const { getState } = require("@saltcorn/data/db/state");
+const { sleep } = require("@saltcorn/data/utils");
 /**
  * @type {object}
  * @const
@@ -81,6 +83,10 @@ router.get(
       {},
       { orderBy: "name", nocase: true }
     );
+    const all_plugins = await Plugin.find(
+      { name: { not: { in: ["base", "sbadmin2"] } } },
+      { orderBy: "name", nocase: true }
+    );
     const isRoot = db.getTenantSchema() === db.connectObj.default_schema;
 
     const all_configs_obj = await getState().getAllConfigOrDefaults();
@@ -91,7 +97,7 @@ router.get(
       }))
       .filter((c) => isRoot || !c.root_only);
 
-    let tables, views, pages, triggers, configs;
+    let tables, views, pages, triggers, configs, plugins;
     if (q) {
       const qlower = q.toLowerCase();
       const includesQ = (s) => s.toLowerCase().includes(qlower);
@@ -113,12 +119,17 @@ router.get(
         return includesQ(JSON.stringify(pack));
       });
       configs = all_configs.filter((c) => includesQ(JSON.stringify(c)));
+      plugins = all_plugins.filter(
+        (p) =>
+          includesQ(p.name) || includesQ(JSON.stringify(p.configuration || {}))
+      );
     } else {
       tables = all_tables;
       views = all_views;
       pages = all_pages;
       triggers = all_triggers;
       configs = all_configs;
+      plugins = all_plugins;
     }
     const li_link = (etype1, ename1) =>
       li(
@@ -224,6 +235,20 @@ router.get(
 
         edContents = renderForm(mkForm(trpack), req.csrfToken());
         break;
+      case "module":
+        const plugin = all_plugins.find((p) => p.name === ename);
+        cfg_link =
+          `${ename} ${etype}` +
+          a(
+            {
+              class: "ms-1 me-3",
+              href: `/plugins/configure/${encodeURIComponent(ename)}`,
+            },
+            "Configure ",
+            i({ class: "fas fa-cog" })
+          );
+        edContents = renderForm(mkForm(plugin.configuration), req.csrfToken());
+        break;
     }
     send_infoarch_page({
       res,
@@ -315,6 +340,16 @@ router.get(
                       configs.map((t) => li_link("config", t.name))
                     )
                   )
+                ),
+                li(
+                  details(
+                    { open: q || etype === "module" },
+                    summary("Modules"),
+                    ul(
+                      { class: "ps-3" },
+                      plugins.map((m) => li_link("module", m.name))
+                    )
+                  )
                 )
               )
             ),
@@ -372,7 +407,25 @@ router.post(
         break;
     }
     await db.withTransaction(async () => {
-      await install_pack(pack);
+      if (etype === "module") {
+        const plugin = await Plugin.findOne({ name: ename });
+        if (!plugin) throw new Error(`Module ${ename} not found`);
+        let module = getState().plugins[plugin.name];
+        if (!module) {
+          module =
+            getState().plugins[getState().plugin_module_names[plugin.name]];
+        }
+        if (module.configuration_workflow) {
+          const flow = module.configuration_workflow();
+          if (flow?.onStepSave) await flow.onStepSave({}, {}, entVal);
+          if (flow?.onDone) {
+            const doneRes = await flow.onDone(entVal);
+            if (doneRes?.cleanup) await doneRes.cleanup();
+          }
+        }
+        plugin.configuration = entVal;
+        await plugin.upsert();
+      } else await install_pack(pack);
     });
     switch (etype) {
       case "table":
@@ -390,6 +443,13 @@ router.post(
       case "config":
         await getState().refresh_config();
         break;
+      case "module":
+        getState().processSend({
+          refresh_plugin_cfg: ename,
+          tenant: db.getTenantSchema(),
+        });
+        await sleep(500);
+        break;
     }
     res.redirect(
       `/registry-editor?etype=${etype}&ename=${encodeURIComponent(

package/routes/search.js

@@ -365,6 +365,16 @@ const syntax_help_link = (req) => {
  */
 router.get(
   "/",
+  error_catcher(async (req, res, next) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+
+    if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
+      res.status(503).send("Page Unavailable: in maintenance mode");
+      return;
+    }
+    next();
+  }),
   error_catcher(async (req, res) => {
     const min_role = getState().getConfig("min_role_search");
     const role = (req.user || {}).role_id || 100;

package/routes/tables.js

@@ -72,6 +72,7 @@ const {
   removeAllWhiteSpace,
   comparingCaseInsensitive,
   validSqlId,
+  interpolate,
 } = require("@saltcorn/data/utils");
 const { EOL } = require("os");
 
@@ -934,14 +935,12 @@ router.get(
       if (user_can_edit_views) {
         let create_basic_link = "";
         if (views.length === 0) {
-          create_basic_link = post_btn(
-            `/table/create-basic-views/${table.id}`,
-            "Create basic views",
-            req.csrfToken(),
+          create_basic_link = a(
             {
-              btnClass: "btn-outline-secondary",
-              formClass: "d-inline me-2",
-            }
+              class: "btn btn-outline-secondary ms-2",
+              href: `javascript:ajax_modal('/table/create-basic-views/${table.id}')`,
+            },
+            req.__("Create basic views")
           );
         }
         viewCard = {
@@ -2452,6 +2451,77 @@ router.post(
   })
 );
 
+const basicViewForm = async (table, req) => {
+  const tables = await Table.find();
+  const vts = viewtemplates_with_create_basic_option();
+  return new Form({
+    submitLabel: req.__("Create views"),
+    action: `/table/create-basic-views/${table.id}`,
+    formStyle: "vert",
+    fields: [
+      {
+        type: "String",
+        label: "View naming convention",
+        name: "naming_convention",
+        attributes: { spellcheck: false },
+        sublabel:
+          "Use <code>{{ }}</code> to access: <code>viewpattern</code>, <code>tablename</code>",
+      },
+      {
+        type: "String",
+        label: "Template table",
+        name: "template_table",
+        attributes: { options: tables.map((t) => t.name) },
+        help: {
+          topic: "Template tables",
+        },
+      },
+      ...vts.map((vt) => ({
+        type: "Bool",
+        label: vt,
+        name: vt,
+        default: true,
+      })),
+    ],
+  });
+};
+
+const viewtemplates_with_create_basic_option = () => {
+  const vts = [];
+  Object.entries(getState().viewtemplates).forEach(([nm, obj]) => {
+    if (obj.createBasicView) vts.push(nm);
+  });
+  return vts;
+};
+
+router.get(
+  "/create-basic-views/:id",
+  isAdminOrHasConfigMinRole("min_role_edit_tables"),
+  isAdminOrHasConfigMinRole("min_role_edit_views"),
+  error_catcher(async (req, res) => {
+    const { id } = req.params;
+
+    const table = Table.findOne({ id });
+    if (!table) {
+      req.flash("error", `Table not found`);
+      res.redirect(`/table`);
+      return;
+    }
+    res.set("Page-Title", req.__("Create basic views"));
+    const form = await basicViewForm(table, req);
+    form.values.naming_convention = getState().getConfig(
+      "viewgen_naming_convention"
+    );
+    form.values.template_table = getState().getConfig(
+      "viewgen_template_table",
+      ""
+    );
+    const page = renderForm(form, req.csrfToken());
+
+    res.send(page);
+  })
+);
+
 router.post(
   "/create-basic-views/:id",
   isAdminOrHasConfigMinRole("min_role_edit_tables"),
@@ -2465,68 +2535,76 @@ router.post(
       res.redirect(`/table`);
       return;
     }
+    const form = await basicViewForm(table, req);
+    form.validate(req.body || {});
+    if (form.hasErrors) {
+      req.flash("error", req.__("An error occurred"));
+      res.redirect(`/table/${table.id}`);
+      return;
+    }
+
+    if (
+      form.values.naming_convention &&
+      form.values.naming_convention !==
+        getState().getConfig("viewgen_naming_convention")
+    )
+      await getState().setConfig(
+        "viewgen_naming_convention",
+        form.values.naming_convention
+      );
+    if (
+      form.values.template_table !==
+      getState().getConfig("viewgen_template_table")
+    )
+      await getState().setConfig(
+        "viewgen_template_table",
+        form.values.template_table
+      );
+
     await db.withTransaction(async () => {
+      const getName = (viewtemplate) =>
+        interpolate(form.values.naming_convention, {
+          viewpattern: viewtemplate,
+          tablename: table.name,
+        }).trim();
+      const all_views_created = {};
+      const vts = viewtemplates_with_create_basic_option();
+      vts.forEach((vt) => {
+        if (form.values[vt]) all_views_created[vt] = getName(vt);
+      });
+
       const initial_view = async (table, viewtemplate) => {
-        const configuration = await initial_config_all_fields(
-          viewtemplate === "Edit"
-        )({ table_id: table.id });
-        //console.log(configuration);
-        const name = `${viewtemplate} ${table.name}`;
+        const isEdit = viewtemplate === "Edit";
+        const vtObj = getState().viewtemplates[viewtemplate];
+        const name = getName(viewtemplate);
+        const template_view = form.values.template_table
+          ? View.findOne({
+              table_id: Table.findOne(form.values.template_table).id,
+              viewtemplate,
+            })
+          : undefined;
+        const configuration = await vtObj.createBasicView({
+          table,
+          viewname: name,
+          all_views_created,
+          template_table: form.values.template_table
+            ? Table.findOne(form.values.template_table)
+            : undefined,
+          template_view,
+        });
         const view = await View.create({
           name,
           configuration,
           viewtemplate,
           table_id: table.id,
-          min_role: 100,
+          attributes: template_view?.attributes,
+          min_role: isEdit ? table.min_role_write : table.min_role_read,
         });
         return view;
       };
-      const list = await initial_view(table, "List");
-      const edit = await initial_view(table, "Edit");
-      const show = await initial_view(table, "Show");
-      await View.update(
-        {
-          configuration: {
-            ...list.configuration,
-            columns: [
-              ...list.configuration.columns,
-              {
-                type: "ViewLink",
-                view: `Own:Show ${table.name}`,
-                view_name: `Show ${table.name}`,
-                link_style: "",
-                view_label: "Show",
-                header_label: "Show",
-              },
-              {
-                type: "ViewLink",
-                view: `Own:Edit ${table.name}`,
-                view_name: `Edit ${table.name}`,
-                link_style: "",
-                view_label: "Edit",
-                header_label: "Edit",
-              },
-              {
-                type: "Action",
-                action_name: "Delete",
-                action_style: "btn-primary",
-              },
-            ],
-            view_to_create: `Edit ${table.name}`,
-          },
-        },
-        list.id
-      );
-      await View.update(
-        {
-          configuration: {
-            ...edit.configuration,
-            view_when_done: `List ${table.name}`,
-            destination_type: "View",
-          },
-        },
-        edit.id
-      );
+      for (const vtnm of Object.keys(all_views_created)) {
+        await initial_view(table, vtnm);
+      }
     });
     await getState().refresh_views();
     res.redirect(`/table/${table.id}`);

package/routes/view.js

@@ -9,6 +9,7 @@ const Router = require("express-promise-router");
 const View = require("@saltcorn/data/models/view");
 const Table = require("@saltcorn/data/models/table");
 const Trigger = require("@saltcorn/data/models/trigger");
+const Page = require("@saltcorn/data/models/page");
 
 const { text, style, div } = require("@saltcorn/markup/tags");
 const {
@@ -41,11 +42,27 @@ module.exports = router;
 router.get(
   ["/:viewname", "/:viewname/*slug"],
   error_catcher(async (req, res) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    const maintenanceModePage = state.getConfig("maintenance_mode_page", "");
+
+    if (
+      maintenanceModeEnabled &&
+      (!req.user || req.user.role_id > 1) &&
+      maintenanceModePage
+    ) {
+      const maintenancePage = await Page.findOne({ name: maintenanceModePage });
+      if (maintenancePage) {
+        const tic = new Date();
+        await maintenancePage.run(req.query, { res, req });
+        return;
+      }
+    }
+
     const { viewname } = req.params;
     const query = { ...req.query };
     const view = await View.findOne({ name: viewname });
     const role = req.user && req.user.id ? req.user.role_id : 100;
-    const state = getState();
     state.log(
       3,
       `Route /view/${viewname} user=${req.user?.id}${
@@ -223,6 +240,16 @@ router.post(
  */
 router.post(
   "/:viewname/:route",
+  error_catcher(async (req, res, next) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+
+    if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
+      res.status(503).json({ error: "in maintenance mode" });
+      return;
+    }
+    next();
+  }),
   error_catcher(async (req, res) => {
     const { viewname, route } = req.params;
     const role = req.user && req.user.id ? req.user.role_id : 100;
@@ -258,6 +285,15 @@ router.post(
  */
 router.post(
   ["/:viewname", "/:viewname/*slug"],
+  error_catcher(async (req, res, next) => {
+    const state = getState();
+    const maintenanceModeEnabled = state.getConfig("maintenance_mode_enabled", false);
+    if (maintenanceModeEnabled && (!req.user || req.user.role_id > 1)) {
+      res.status(503).send("Page Unavailable: in maintenance mode");
+      return;
+    }
+    next();
+  }),
   setTenant,
   error_catcher(async (req, res) => {
     const { viewname } = req.params;

package/routes/viewedit.js

@@ -416,7 +416,7 @@ router.get(
           class: "mt-0",
           titleAjaxIndicator: true,
           title: req.__(
-            `%s view - %s on %s`,
+            viewrow.table_name ? `%s view - %s on %s` : `%s view - %s`,
             viewname,
             viewrow.viewtemplate,
             viewrow.table_name

package/s3storage.js

@@ -12,7 +12,7 @@ function createS3Client() {
       secretAccessKey: getState().getConfig("storage_s3_access_secret"),
       accessKeyId: getState().getConfig("storage_s3_access_key"),
     },
-    region: getState().getConfig("storage_s3_region"),
+    region: getState().getConfig("storage_s3_region") || "us-east-1",
     endpoint: getState().getConfig("storage_s3_endpoint"),
   });
 }

package/serve.js

@@ -183,7 +183,10 @@ const initMaster = async ({ disableMigrate }, useClusterAdaptor = true) => {
   }
   eachTenant(async () => {
     const state = getState();
-    if (state) await state.setConfig("joined_log_socket_ids", []);
+    if (state) {
+      await state.setConfig("joined_log_socket_ids", []);
+      await state.setConfig("joined_real_time_socket_ids", []);
+    }
   });
   if (useClusterAdaptor) setupPrimary();
 };
@@ -518,6 +521,11 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
       .emit("log_msg", { text: msg, time, level });
   });
 
+  // Real-time collaboration emitter
+  getState().setCollabEmitter((tenant, type, data) => {
+    io.of("/").to(`_${tenant}_collab_room_`).emit(type, data);
+  });
+
   io.of("/").on("connection", (socket) => {
     socket.on("join_room", ([viewname, room_id]) => {
       const ten = get_tenant_from_req(socket.request) || "public";
@@ -569,6 +577,38 @@ const setupSocket = (subdomainOffset, pruneSessionInterval, ...servers) => {
       else await f();
     });
 
+    // or join the room more generally and later register views ??
+    socket.on("join_collab_room", async (viewname, callback) => {
+      const tenant =
+        get_tenant_from_req(socket.request, subdomainOffset) || "public";
+      const f = async () => {
+        try {
+          const view = View.findOne({ name: viewname });
+          if (!view) throw new Error(`View ${viewname} not found`);
+          const user = socket.request.user;
+          const role_id = user ? user.role_id : 100;
+          if (view.min_role < role_id)
+            throw new Error("Not authorized to join collaboration room");
+          socket.join(`_${tenant}_collab_room_`);
+          const socketIds = await getState().getConfig(
+            "joined_real_time_socket_ids"
+          );
+          socketIds.push(socket.id);
+          await getState().setConfig(
+            "joined_real_time_socket_ids",
+            [...socketIds]
+          );
+          if (typeof callback === "function") callback({ status: "ok" });
+        } catch (err) {
+          getState().log(1, `Socket join_collab_room: ${err.stack}`);
+          if (typeof callback === "function")
+            callback({ status: "error", msg: err.message || "unknown error" });
+        }
+      };
+      if (tenant && tenant !== "public") db.runWithTenant(tenant, f);
+      else await f();
+    });
+
     socket.on("disconnect", async () => {
       const tenant =
         get_tenant_from_req(socket.request, subdomainOffset) || "public";

package/systemd.js

@@ -66,7 +66,7 @@ module.exports =
       notify.ready();
       const watchdogInterval = notify.watchdogInterval();
       if (watchdogInterval && watchdogInterval > 0) {
-        const interval = Math.floor(watchdogInterval / 2);
+        const interval = Math.floor(watchdogInterval / 3);
         setInterval(() => {
           watchDog(interval, notify, opts);
         }, interval);

package/tests/api.test.js

@@ -223,6 +223,57 @@ describe("API read", () => {
       );
   });
 });
+describe("API count", () => {
+  it("should count books for public simple", async () => {
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/books/count")
+      .expect(succeedJsonWith((count) => count === 2));
+  });
+
+  // it("should count books for public fts", async () => {
+
+  it("should count books for public with search", async () => {
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/books/count?pages=967")
+      .expect(succeedJsonWith((count) => count === 1));
+  });
+  it("should count with fkey args ", async () => {
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/patients/count/?favbook=1")
+      .set("Cookie", loginCookie)
+      .expect(succeedJsonWith((count) => count === 1));
+  });
+  it("should count with fkey args with no value", async () => {
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/patients/count/?favbook=")
+      .set("Cookie", loginCookie)
+      .expect(succeedJsonWith((count) => count === 0));
+  });
+  it("should count books for public with search and one field", async () => {
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/books/count/?fields=author&pages=967")
+      .expect(succeedJsonWith((count) => count === 1));
+  });
+  it("should not allow public count access to patients", async () => {
+    const app = await getApp({ disableCsrf: true });
+    await request(app).get("/api/patients/count").expect(notAuthorized);
+  });
+  it("should allow staff count access to patients", async () => {
+    const loginCookie = await getStaffLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/api/patients/count")
+      .set("Cookie", loginCookie)
+      .expect(succeedJsonWith((count) => count === 2));
+  });
+});
 describe("API post", () => {
   it("should post books", async () => {
     const loginCookie = await getAdminLoginCookie();

package/tests/clientjs.test.js

@@ -253,4 +253,20 @@ test("unique_field_from_rows test", () => {
     "bar"
   );
   expect($("#mkuniq11").val()).toBe("bar104");
+  $("body").append(`<input id="mkuniq12" value="YPL240724A"></div>`);
+  unique_field_from_rows(
+    [
+      { foo: "YPL240724A2" },
+      { foo: "YPL240724A1_COPY-1" },
+      { foo: "YPL240724A1" },
+    ],
+    "mkuniq12",
+    "foo",
+    false,
+    1,
+    true,
+    "Digits",
+    "YPL240724A"
+  );
+  expect($("#mkuniq12").val()).toBe("YPL240724A3");
 });