@saltcorn/server 1.1.4-beta.1 → 1.1.4-beta.11

package/routes/api.js

@@ -407,23 +407,35 @@ router.get(
                   target: field?.attributes?.summary_field,
                 };
             });
-            rows = await table.getJoinedRows({
-              where: qstate,
-              joinFields,
-              limit: use_limit,
-              offset: use_offset,
-              orderDesc:
-                (sortDesc && sortDesc !== "false") || tabulator_dir == "desc",
-              orderBy: orderByField?.name || undefined,
-              forPublic: !(req.user || user),
-              forUser: req.user || user,
-            });
+            try {
+              rows = await table.getJoinedRows({
+                where: qstate,
+                joinFields,
+                limit: use_limit,
+                offset: use_offset,
+                orderDesc:
+                  (sortDesc && sortDesc !== "false") || tabulator_dir == "desc",
+                orderBy: orderByField?.name || undefined,
+                forPublic: !(req.user || user),
+                forUser: req.user || user,
+              });
+            } catch (e) {
+              console.error(e);
+              res.json({ error: "API error" });
+              return;
+            }
           }
           if (tabulator_pagination_format) {
-            res.json({
-              last_page: Math.ceil((await table.countRows()) / +tabulator_size),
-              data: rows.map(limitFields(fields)),
-            });
+            const count = await table.countRows();
+            if (count === null)
+              res.json({
+                data: rows.map(limitFields(fields)),
+              });
+            else
+              res.json({
+                last_page: Math.ceil(count / +tabulator_size),
+                data: rows.map(limitFields(fields)),
+              });
           } else res.json({ success: rows.map(limitFields(fields)) });
         } else {
           getState().log(3, `API get ${table.name} not authorized`);

package/routes/common_lists.js

@@ -205,7 +205,7 @@ const view_dropdown = (view, req, on_done_redirect_str = "") =>
       a(
         {
           class: "dropdown-item",
-          href: `javascript:ajax_modal('/admin/snapshot-restore/view/${view.name}')`,
+          href: `javascript:ajax_modal('/admin/snapshot-restore/view/${view.name}${on_done_redirect_str}')`,
         },
         '<i class="fas fa-undo-alt"></i>&nbsp;' + req.__("Restore")
       ),
@@ -284,7 +284,7 @@ const tagsDropdown = (tags, altHeader, req) =>
         {
           class: "dropdown-item",
           // TODO check url why view for page, what do we need for page group
-          href: `tag`,
+          href: `/tag`,
         },
         req.__("Manage tags...")
       )
@@ -391,7 +391,7 @@ const viewsList = async (
                   filterOnTag ? `Tag:${filterOnTag.name}` : undefined,
                   req
                 ),
-                key: (r) => tagBadges(r),
+                key: (r) => (r.id ? tagBadges(r) : ""),
               },
             ]),
         {
@@ -674,12 +674,12 @@ const trigger_dropdown = (trigger, req, on_done_redirect_str = "") =>
     a(
       {
         class: "dropdown-item",
-        href: `javascript:ajax_modal('/admin/snapshot-restore/trigger/${trigger.name}')`,
+        href: `javascript:ajax_modal('/admin/snapshot-restore/trigger/${trigger.name}${on_done_redirect_str}')`,
       },
       '<i class="fas fa-undo-alt"></i>&nbsp;' + req.__("Restore")
     ),
     post_dropdown_item(
-      `/actions/clone/${trigger.id}`,
+      `/actions/clone/${trigger.id}${on_done_redirect_str}`,
       '<i class="far fa-copy"></i>&nbsp;' + req.__("Duplicate"),
       req
     ),
@@ -734,11 +734,22 @@ const getTriggerList = async (
       { label: req.__("Name"), key: "name" },
       {
         label: req.__("Test run"),
-        key: (r) => link(`/actions/testrun/${r.id}`, req.__("Test run")),
+        key: (r) =>
+          link(
+            `/actions/testrun/${r.id}${on_done_redirect_str}`,
+            req.__("Test run"),
+            {
+              onclick: `press_store_button(this)`,
+            }
+          ),
       },
       {
         label: req.__("Configure"),
-        key: (r) => link(`/actions/configure/${r.id}`, req.__("Configure")),
+        key: (r) =>
+          link(
+            `/actions/configure/${r.id}${on_done_redirect_str}`,
+            req.__("Configure")
+          ),
       },
       ...(tagId
         ? []

package/routes/fields.js

@@ -307,12 +307,7 @@ const fieldFlow = (req) =>
       try {
         await db.withTransaction(async () => {
           if (context.id) {
-            const field = await Field.findOne({ id: context.id });
-
-            if (fldRow.label && field.label != fldRow.label) {
-              fldRow.name = Field.labelToName(fldRow.label);
-            }
-
+            const field = await Field.findOne({ id: context.id });          
             await field.update(fldRow);
             Trigger.emitEvent(
               "AppChange",

package/routes/infoarch.js

@@ -16,12 +16,22 @@ const {
   send_admin_page,
   config_fields_form,
   save_config_from_form,
+  upload_language_pack,
 } = require("../markup/admin.js");
 const { getState } = require("@saltcorn/data/db/state");
-const { div, a, i, text, button } = require("@saltcorn/markup/tags");
-const { mkTable, renderForm, post_delete_btn } = require("@saltcorn/markup");
+const { span, div, a, i, text, button } = require("@saltcorn/markup/tags");
+const {
+  mkTable,
+  renderForm,
+  post_delete_btn,
+  post_btn,
+} = require("@saltcorn/markup");
 const Form = require("@saltcorn/data/models/form");
 const Snapshot = require("@saltcorn/admin-models/models/snapshot");
+const { stringify } = require("csv-stringify");
+const csvtojson = require("csvtojson");
+const { hasLLM, translate } = require("@saltcorn/data/translate");
+const { escapeHtml } = require("@saltcorn/data/utils");
 
 /**
  * @type {object}
@@ -175,6 +185,17 @@ router.get(
                       })
                     : "",
               },
+              {
+                label: req.__("Language CSV"),
+                key: (r) =>
+                  a(
+                    {
+                      href: `/site-structure/localizer/download-pack/${r.locale}`,
+                    },
+                    i({ class: "fas fa-download me-2" }),
+                    req.__("Download")
+                  ),
+              },
               {
                 label: req.__("Delete"),
                 key: (r) =>
@@ -187,13 +208,17 @@ router.get(
             ],
             Object.values(cfgLangs)
           ),
-          a(
-            {
-              href: "/site-structure/localizer/add-lang",
-              class: "btn btn-primary mt-1",
-            },
-            i({ class: "fas fa-plus-square me-1" }),
-            req.__("Add language")
+          div(
+            { class: "d-flex mt-1" },
+            a(
+              {
+                href: "/site-structure/localizer/add-lang",
+                class: "btn btn-primary me-2",
+              },
+              i({ class: "fas fa-plus-square me-1" }),
+              req.__("Add language")
+            ),
+            upload_language_pack(req)
           )
         ),
       },
@@ -201,6 +226,75 @@ router.get(
   })
 );
 
+router.get(
+  "/localizer/download-pack/:lang",
+  isAdmin,
+  error_catcher(async (req, res) => {
+    const { lang } = req.params;
+    if (lang === "__proto__" || lang === "constructor") {
+      res.redirect(`/`);
+      return;
+    }
+    const cfgLangs = getState().getConfig("localizer_languages");
+
+    if (!cfgLangs[lang]) {
+      req.flash("error", req.__("Language not found"));
+      return res.redirect(`/site-structure/localizer`);
+    }
+    const default_lang =
+      Object.values(cfgLangs).find((lobj) => lobj.is_default)?.locale ||
+      getState().getConfig("default_locale", "en");
+
+    const cfgStrings = getState().getConfig("localizer_strings", {});
+    const translation = cfgStrings[lang] || {};
+    const strings = getState()
+      .getStringsForI18n()
+      .map((s) => ({ [default_lang]: s, [lang]: translation[s] || s }));
+    res.type("text/csv");
+    res.setHeader("Content-Disposition", `attachment; filename="${lang}.csv"`);
+    res.setHeader("Cache-Control", "no-cache");
+    res.setHeader("Pragma", "no-cache");
+    stringify(strings, {
+      header: true,
+      columns: [default_lang, lang],
+      quoted: true,
+    }).pipe(res);
+  })
+);
+
+router.post(
+  "/localizer/upload-language-pack",
+  isAdmin,
+  setTenant, // TODO why is this needed?????
+  error_catcher(async (req, res) => {
+    if (req.files?.file?.tempFilePath) {
+      const cfgLangs = getState().getConfig("localizer_languages");
+      const default_lang =
+        Object.values(cfgLangs).find((lobj) => lobj.is_default)?.locale ||
+        getState().getConfig("default_locale", "en");
+      const cfgStrings = getState().getConfigCopy("localizer_strings");
+
+      try {
+        const rows = await csvtojson().fromFile(req.files?.file?.tempFilePath);
+        const langs = Object.keys(rows[0]).filter((k) => k !== default_lang);
+        for (const lang of langs)
+          for (const row of rows) {
+            const defstring = row[default_lang];
+            if (cfgStrings[lang]) cfgStrings[lang][defstring] = row[lang];
+            else cfgStrings[lang] = { [defstring]: row[lang] };
+          }
+        await getState().setConfig("localizer_strings", cfgStrings);
+
+        req.flash("success", `Updated languages: ${langs.join(", ")}`);
+      } catch (e) {
+        console.error(e);
+        req.flash("error", e.message);
+      }
+    }
+    res.redirect(`/site-structure/localizer`);
+  })
+);
+
 /**
  * @name get/localizer/add-lang
  * @function
@@ -253,7 +347,21 @@ router.get(
         above: [
           {
             type: "card",
-            contents: [renderForm(form, req.csrfToken())],
+            contents: [
+              renderForm(form, req.csrfToken()),
+              hasLLM() &&
+                renderForm(
+                  new Form({
+                    fields: [],
+                    action: `/site-structure/localizer/translate-llm/${lang}`,
+                    submitLabel: req.__("Translate with LLM"),
+                    onSubmit: "press_store_button(this)",
+
+                    submitButtonClass: "btn-secondary",
+                  }),
+                  req.csrfToken()
+                ),
+            ],
           },
           !is_default && {
             type: "card",
@@ -263,18 +371,35 @@ router.get(
                 [
                   {
                     label: req.__("In default language"),
-                    key: "in_default",
+                    key: (r) => escapeHtml(r.in_default),
                   },
                   {
                     label: req.__("In %s", form.values.name),
                     key: (r) =>
-                      div(
-                        {
-                          "data-inline-edit-dest-url": `/site-structure/localizer/save-string/${lang}/${encodeURIComponent(
-                            r.in_default
-                          )}`,
-                        },
-                        r.translated
+                      span(
+                        div(
+                          {
+                            "data-inline-edit-dest-url": `/site-structure/localizer/save-string/${lang}/${encodeURIComponent(
+                              r.in_default
+                            )}`,
+                            "data-inline-edit-unescape": "true",
+                            class: "d-inline",
+                          },
+                          escapeHtml(r.translated)
+                        ),
+                        r.in_default !== r.translated &&
+                          post_btn(
+                            `/site-structure/localizer/delete-string/${lang}/${encodeURIComponent(
+                              r.in_default
+                            )}`,
+                            "",
+                            req.csrfToken(),
+                            {
+                              icon: "fas fa-trash-alt",
+                              btnClass: "btn-sm btn-xs btn-link link-danger",
+                              formClass: "d-inline",
+                            }
+                          )
                       ),
                   },
                 ],
@@ -288,6 +413,57 @@ router.get(
   })
 );
 
+router.post(
+  "/localizer/translate-llm/:lang/",
+  isAdmin,
+  error_catcher(async (req, res) => {
+    const { lang, defstring } = req.params;
+    if (
+      lang === "__proto__" ||
+      defstring === "__proto__" ||
+      lang === "constructor"
+    ) {
+      res.redirect(`/`);
+      return;
+    }
+    const cfgLangs = getState().getConfig("localizer_languages");
+
+    if (!cfgLangs[lang]) {
+      req.flash("error", req.__("Language not found"));
+      return res.redirect(`/site-structure/localizer`);
+    }
+    const default_lang =
+      Object.values(cfgLangs).find((lobj) => lobj.is_default)?.locale ||
+      getState().getConfig("default_locale", "en");
+    let count = 0;
+    for (const defstring of getState().getStringsForI18n()) {
+      const cfgStrings = getState().getConfigCopy("localizer_strings", {});
+      if (
+        cfgStrings[lang][defstring] &&
+        cfgStrings[lang][defstring] !== defstring
+      )
+        continue;
+      if (count >= 20) break;
+      count += 1;
+      const translated = await translate(defstring, lang, default_lang);
+      if (cfgStrings[lang]) cfgStrings[lang][defstring] = translated;
+      else cfgStrings[lang] = { [defstring]: translated };
+      await getState().setConfig("localizer_strings", cfgStrings);
+    }
+    if (count == 20)
+      req.flash(
+        "success",
+        req.__(
+          `Translated %s strings. Click 'Translate with LLM' again to continue`,
+          count
+        )
+      );
+    else
+      req.flash("success", req.__(`Finished translating %s strings.`, count));
+    res.redirect(`/site-structure/localizer/edit/${lang}`);
+  })
+);
+
 /**
  * @name post/localizer/save-string/:lang/:defstring
  * @function
@@ -308,9 +484,28 @@ router.post(
       return;
     }
     const cfgStrings = getState().getConfigCopy("localizer_strings");
-    if (cfgStrings[lang])
-      cfgStrings[lang][defstring] = text((req.body || {}).value);
-    else cfgStrings[lang] = { [defstring]: text((req.body || {}).value) };
+    if (cfgStrings[lang]) cfgStrings[lang][defstring] = (req.body || {}).value;
+    else cfgStrings[lang] = { [defstring]: (req.body || {}).value };
+    await getState().setConfig("localizer_strings", cfgStrings);
+    res.redirect(`/site-structure/localizer/edit/${lang}`);
+  })
+);
+
+router.post(
+  "/localizer/delete-string/:lang/:defstring",
+  isAdmin,
+  error_catcher(async (req, res) => {
+    const { lang, defstring } = req.params;
+    if (
+      lang === "__proto__" ||
+      defstring === "__proto__" ||
+      lang === "constructor"
+    ) {
+      res.redirect(`/`);
+      return;
+    }
+    const cfgStrings = getState().getConfigCopy("localizer_strings");
+    if (cfgStrings[lang]) delete cfgStrings[lang][defstring];
     await getState().setConfig("localizer_strings", cfgStrings);
     res.redirect(`/site-structure/localizer/edit/${lang}`);
   })

package/routes/list.js

@@ -19,6 +19,7 @@ const {
   i,
   text,
   button,
+  a,
   input,
   label,
   form,
@@ -31,6 +32,7 @@ const {
 } = require("./utils");
 const moment = require("moment");
 const { getState } = require("@saltcorn/data/db/state");
+const { comparingCaseInsensitive } = require("@saltcorn/data/utils");
 
 /**
  * @type {object}
@@ -127,19 +129,26 @@ router.post(
 const typeToGridType = (t, field) => {
   const jsgField = { field: field.name, title: field.label, editor: true };
   if (t.name === "String" && field.attributes && field.attributes.options) {
-    jsgField.editor = "select";
+    jsgField.editor = "list";
 
     const values = field.attributes.options.split(",").map((o) => o.trim());
     if (!field.required) values.unshift("");
 
     jsgField.editorParams = { values };
   } else if (t === "Key" || t === "File") {
-    jsgField.editor = "select";
-    const values = {};
-
-    field.options.forEach(({ label, value }) => (values[value] = label));
+    jsgField.editor = "list";
+    const values = [];
+    const valuesObj = {};
+    field.options
+      .sort(comparingCaseInsensitive("label"))
+      .forEach(({ label, value }) => {
+        //en space. tabulator workaround
+        const l = label === "" ? "\u2002" : label;
+        values.push({ label: l, value });
+        valuesObj[value] = l;
+      });
     jsgField.editorParams = { values };
-    jsgField.formatterParams = { values };
+    jsgField.formatterParams = { values: valuesObj };
     jsgField.formatter = "__lookupIntToString";
   } else if (t.name === "Float" || t.name === "Integer") {
     jsgField.editor = "number";
@@ -373,6 +382,21 @@ router.get(
                   },
                   form(
                     { class: "px-2" },
+                    a(
+                      {
+                        onclick: `event.stopPropagation();allnonecols(true,this)`,
+                        href: "javascript:;",
+                      },
+                      "All"
+                    ),
+                    " | ",
+                    a(
+                      {
+                        onclick: `event.stopPropagation();allnonecols(false,this)`,
+                        href: "javascript:;",
+                      },
+                      "None"
+                    ),
                     fields.map((f) =>
                       div(
                         { class: "form-check" },
@@ -403,7 +427,7 @@ router.get(
                   if(typeof v === "string" && v.startsWith("__"))
                     col[k] = window[v.substring(2)];
                 })
-              })   
+              })
               window.tabulator_table_primary_key = "${table.pk_name}";
               window.tabulator_table = new Tabulator("#jsGrid", {
                   ajaxURL:"/api/${encodeURIComponent(
@@ -411,22 +435,34 @@ router.get(
                   )}?tabulator_pagination_format=true${
                     table.versioned ? "&versioncount=on" : ""
                   }",                   
-                  layout:"fitColumns", 
+                  layout:"fitData", 
                   columns,
                   height:"100%",
                   pagination:true,
                   paginationMode:"remote",
                   paginationSize:20,
-                  clipboard:true,
-                  persistence:true, 
-                  persistenceID:"table_tab_${table.name}",
+                  clipboard:true,                 
                   movableColumns: true,
                   ajaxContentType:"json",
                   sortMode:"remote",
+                  resizableColumnGuide:true,                  
+                  columnDefaults:{
+                      resizable:true,
+                      maxWidth:500
+                  },
                   initialSort:[
                     {column:"${table.pk_name}", dir:"asc"},
                   ],                 
               });
+              window.allnonecols= (do_show, e) =>{
+                columns.forEach(col=>{
+                  if(col.frozen && !do_show) return;
+                  if (do_show) window.tabulator_table.showColumn(col.field);
+                  else window.tabulator_table.hideColumn(col.field);
+                  $(e).closest("form").find("input").prop("checked", do_show)
+                })            
+              }
+
               window.tabulator_table.on("cellEdited", function(cell){
                 const row = cell.getRow().getData()
                 const fieldName = cell.getColumn().getField()

package/routes/menu.js

@@ -413,7 +413,7 @@ const menuForm = async (req) => {
         //default: "Standard",
         attributes: {
           inline: true,
-          options: "Standard, Mobile Bottom, Secondary Menu",
+          options: ["Standard", "Mobile Bottom", "Secondary Menu"],
         },
       },
     ],

package/routes/plugins.js

@@ -102,7 +102,7 @@ const pluginForm = (req, plugin) => {
         name: "source",
         type: getState().types.String,
         required: true,
-        attributes: { options: "npm,local,github,git" },
+        attributes: { options: ["npm", "local", "github", "git"] },
         sublabel: req.__(
           "Source of module for install. Few options:" +
             "npm - download from npm repository," +

package/routes/registry.js

@@ -374,6 +374,23 @@ router.post(
     await db.withTransaction(async () => {
       await install_pack(pack);
     });
+    switch (etype) {
+      case "table":
+        await getState().refresh_tables();
+        break;
+      case "view":
+        await getState().refresh_views();
+        break;
+      case "page":
+        await getState().refresh_pages();
+        break;
+      case "trigger":
+        await getState().refresh_triggers();
+        break;
+      case "config":
+        await getState().refresh_config();
+        break;
+    }
     res.redirect(
       `/registry-editor?etype=${etype}&ename=${encodeURIComponent(
         ename

package/routes/tables.js

@@ -1018,7 +1018,8 @@ router.get(
     // Table Data card
     const dataCard = div(
       { class: "d-flex text-center" },
-      div({ class: "mx-auto" }, h4(`${nrows}`), req.__("Rows")),
+      nrows !== null &&
+        div({ class: "mx-auto" }, h4(`${nrows}`), req.__("Rows")),
       div(
         { class: "mx-auto" },
         a(
@@ -1246,6 +1247,7 @@ router.post(
         res.redirect(`/table/new`);
       } else if (rest.provider_name && rest.provider_name !== "-") {
         const table = await Table.create(name, rest);
+        await getState().refresh_tables();
         res.redirect(`/table/provider-cfg/${table.id}`);
       } else {
         delete rest.provider_name;
@@ -1902,7 +1904,9 @@ router.post(
 const renameForm = (table_id, req) =>
   new Form({
     action: `/table/rename/${table_id}`,
-    labelCols: 3,
+    blurb: req.__(
+      "You may need to adjust view relations associated with this table after renaming it"
+    ),
     fields: [
       {
         name: "name",
@@ -1910,6 +1914,14 @@ const renameForm = (table_id, req) =>
         type: "String",
       },
     ],
+    additionalButtons: [
+      {
+        label: req.__("Cancel"),
+        class: "btn btn-danger",
+        onclick: "history.back()",
+      },
+    ],
+    values: { name: Table.findOne({ id: table_id })?.name },
   });
 
 /**
@@ -2352,6 +2364,7 @@ const get_provider_workflow = (table, req) => {
   workflow.onDone = async (ctx) => {
     const { table_id, ...configuration } = await oldOnDone(ctx);
     await table.update({ provider_cfg: configuration });
+    await getState().refresh_tables();
 
     return {
       redirect: `/table/${table.id}`,

package/routes/tag_entries.js

@@ -7,6 +7,7 @@ const {
   label,
   text,
 } = require("@saltcorn/markup/tags");
+const db = require("@saltcorn/data/db");
 
 const Tag = require("@saltcorn/data/models/tag");
 const TagEntry = require("@saltcorn/data/models/tag_entry");
@@ -192,7 +193,11 @@ router.post(
     const fieldName = idField(entitytype);
     const auth = checkEditPermission(entitytype, req.user);
     if (!auth) req.flash("error", "Not authorized");
-    else await tag.addEntry({ [fieldName]: +entityid });
+    else
+      await db.withTransaction(async () => {
+        await tag.addEntry({ [fieldName]: +entityid });
+      });
+
     let redirectTarget =
       req.query.on_done_redirect &&
       is_relative_url("/" + req.query.on_done_redirect)