@saltcorn/server 1.1.3-beta.4 → 1.1.3-beta.6

package/CHANGELOG.md

@@ -2,14 +2,22 @@
 
 ## 1.1.3 - In beta
 
+* List view: Row click can now open in a new tab, in a popup, or can run an action.
+
+* Create basic views: if a table had no views, a button on the table page 
+  allows you to build basic views for the table with a single click
+
 * Workflows: 
     - UserForm new question type: Multiple checks
     - Options for Multiple checks and Multiple choice can use interpolations (`{{ }}`)
       so options can be dynamically generated from the context
+    - Improve UX for editing For Loops.
+    - UserForm multiple choice switch to dropdown if >5 options
 
 ### Fixes
 
 * Fix serving JSDoc (Table, File, User links in run_js_code)
+* Destination redirect on login now works on custom login forms and with external identity providers
 
 ## 1.1.2 - Released 4 March 2025
 

package/auth/routes.js

@@ -197,7 +197,7 @@ const resetForm = (body, req) => {
  * @param {boolean} noMethods
  * @returns {object}
  */
-const getAuthLinks = (current, noMethods) => {
+const getAuthLinks = (current, noMethods, req) => {
   const links = { methods: [] };
   const state = getState();
   if (current !== "login") links.login = "/auth/login";
@@ -205,11 +205,14 @@ const getAuthLinks = (current, noMethods) => {
     links.signup = "/auth/signup";
   if (current !== "forgot" && state.getConfig("allow_forgot"))
     links.forgot = "/auth/forgot";
+  const dest = req?.query?.dest
+    ? `?dest=${encodeURIComponent(req.query.dest)}`
+    : "";
   if (!noMethods)
     Object.entries(getState().auth_methods).forEach(([name, auth]) => {
       const url = auth.postUsernamePassword
-        ? `javascript:$('form.login').attr('action','/auth/login-with/${name}').submit();`
-        : `/auth/login-with/${name}`;
+        ? `javascript:$('form.login').attr('action','/auth/login-with/${name}${dest}').submit();`
+        : `/auth/login-with/${name}${dest}`;
       links.methods.push({
         icon: auth.icon,
         label: auth.label,
@@ -303,7 +306,7 @@ router.get(
         res.sendAuthWrap(
           req.__(`Login`),
           loginForm(req),
-          getAuthLinks("login")
+          getAuthLinks("login", false, req)
         );
       else {
         const resp = await login_form.run_possibly_on_page(
@@ -311,13 +314,13 @@ router.get(
           req,
           res,
           false,
-          true
+          { hiddenLoginDest: true }
         );
         if (!resp) {
           res.sendAuthWrap(
             req.__(`Login`),
             loginForm(req),
-            getAuthLinks("login")
+            getAuthLinks("login", false, req)
           );
         } else if (login_form.default_render_page) {
           const page = Page.findOne({ name: login_form.default_render_page });
@@ -328,7 +331,11 @@ router.get(
         } else res.sendAuthWrap(req.__(`Login`), resp, { methods: [] });
       }
     } else
-      res.sendAuthWrap(req.__(`Login`), loginForm(req), getAuthLinks("login"));
+      res.sendAuthWrap(
+        req.__(`Login`),
+        loginForm(req),
+        getAuthLinks("login", false, req)
+      );
   })
 );
 
@@ -585,7 +592,6 @@ router.get(
           language: req.__({ phrase: "Language", locale }),
           email: req.__({ phrase: "E-mail", locale }),
           password: req.__({ phrase: "Password", locale }),
-
         };
       });
 
@@ -1217,6 +1223,7 @@ router.get(
     } else {
       const auth = getState().auth_methods[method];
       if (auth) {
+        if (req.query?.dest) res.cookie("login_dest", req.query.dest);
         const passportParams =
           typeof auth.parameters === "function"
             ? auth.parameters(req)
@@ -1259,6 +1266,7 @@ router.post(
         typeof auth.parameters === "function"
           ? auth.parameters(req)
           : auth.parameters;
+      if (req.query?.dest) res.cookie("login_dest", req.query.dest);
       passport.authenticate(method, passportParams)(
         req,
         res,
@@ -1289,6 +1297,12 @@ const loginCallback = (req, res) => () => {
   } else {
     Trigger.emitEvent("Login", null, req.user);
     req.flash("success", req.__("Welcome, %s!", req.user.email));
+    if (req.cookies["login_dest"]) {
+      res.clearCookie("login_dest");
+      res.redirect(req.cookies["login_dest"]);
+      return;
+    }
+
     res.redirect("/");
   }
 };