@saltcorn/server 1.1.0-beta.9 → 1.1.1-beta.0

package/routes/plugins.js

@@ -57,7 +57,11 @@ const fs = require("fs");
 const path = require("path");
 const { get_latest_npm_version } = require("@saltcorn/data/models/config");
 const { flash_restart } = require("../markup/admin.js");
-const { sleep, removeNonWordChars } = require("@saltcorn/data/utils");
+const {
+  sleep,
+  removeNonWordChars,
+  getFetchProxyOptions,
+} = require("@saltcorn/data/utils");
 const { loadAllPlugins } = require("../load_plugins");
 const npmFetch = require("npm-registry-fetch");
 const PluginInstaller = require("@saltcorn/plugins-loader/plugin_installer");
@@ -609,7 +613,8 @@ router.get(
     } else {
       try {
         const pkgInfo = await npmFetch.json(
-          `https://registry.npmjs.org/${plugin.location}`
+          `https://registry.npmjs.org/${plugin.location}`,
+          getFetchProxyOptions()
         );
         if (!pkgInfo?.versions)
           throw new Error(req.__("Unable to fetch versions"));

package/routes/registry.js

@@ -7,6 +7,7 @@ const {
   domReady,
   a,
   div,
+  h4,
   i,
   text,
   button,
@@ -40,6 +41,7 @@ const {
   install_pack,
 } = require("@saltcorn/admin-models/models/pack");
 const Trigger = require("@saltcorn/data/models/trigger");
+const { getState } = require("@saltcorn/data/db/state");
 /**
  * @type {object}
  * @const
@@ -79,7 +81,17 @@ router.get(
       {},
       { orderBy: "name", nocase: true }
     );
-    let tables, views, pages, triggers;
+    const isRoot = db.getTenantSchema() === db.connectObj.default_schema;
+
+    const all_configs_obj = await getState().getAllConfigOrDefaults();
+    const all_configs = Object.entries(all_configs_obj)
+      .map(([name, v]) => ({
+        ...v,
+        name,
+      }))
+      .filter((c) => isRoot || !c.root_only);
+
+    let tables, views, pages, triggers, configs;
     if (q) {
       const qlower = q.toLowerCase();
       const includesQ = (s) => s.toLowerCase().includes(qlower);
@@ -100,11 +112,13 @@ router.get(
         const pack = await trigger_pack(t);
         return includesQ(JSON.stringify(pack));
       });
+      configs = all_configs.filter((c) => includesQ(JSON.stringify(c)));
     } else {
       tables = all_tables;
       views = all_views;
       pages = all_pages;
       triggers = all_triggers;
+      configs = all_configs;
     }
     const li_link = (etype1, ename1) =>
       li(
@@ -124,7 +138,7 @@ router.get(
         action: `/registry-editor?etype=${etype}&ename=${encodeURIComponent(
           ename
         )}${qlink}`,
-
+        formStyle: "vert",
         values: { regval: JSON.stringify(jsonVal, null, 2) },
         fields: [
           {
@@ -177,6 +191,14 @@ router.get(
         const ppack = await page_pack(all_pages.find((v) => v.name === ename));
         edContents = renderForm(mkForm(ppack), req.csrfToken());
         break;
+      case "config":
+        const config = all_configs.find((t) => t.name === ename);
+        edContents =
+          h4(config.label) +
+          (config.blurb || "") +
+          (config.sublabel || "") +
+          renderForm(mkForm(config.value), req.csrfToken());
+        break;
       case "trigger":
         const trigger = all_triggers.find((t) => t.name === ename);
         const trpack = await trigger_pack(trigger);
@@ -282,6 +304,16 @@ router.get(
                       triggers.map((t) => li_link("trigger", t.name))
                     )
                   )
+                ),
+                li(
+                  details(
+                    { open: q || etype === "CONFIG" }, //
+                    summary("Configuration"),
+                    ul(
+                      { class: "ps-3" },
+                      configs.map((t) => li_link("config", t.name))
+                    )
+                  )
                 )
               )
             ),
@@ -309,7 +341,14 @@ router.post(
     const qlink = q ? `&q=${encodeURIComponent(q)}` : "";
 
     const entVal = JSON.parse(req.body.regval);
-    let pack = { plugins: [], tables: [], views: [], pages: [], triggers: [] };
+    let pack = {
+      plugins: [],
+      tables: [],
+      views: [],
+      pages: [],
+      triggers: [],
+      config: {},
+    };
 
     switch (etype) {
       case "table":
@@ -324,6 +363,9 @@ router.post(
       case "trigger":
         pack.triggers = [entVal];
         break;
+      case "config":
+        pack.config[ename] = entVal;
+        break;
     }
     await install_pack(pack);
     res.redirect(

package/routes/tables.js

@@ -56,7 +56,7 @@ const {
 } = require("@saltcorn/data/models/discovery");
 const { getState } = require("@saltcorn/data/db/state");
 const { cardHeaderTabs } = require("@saltcorn/markup/layout_utils");
-const { tablesList, viewsList } = require("./common_lists");
+const { tablesList, viewsList, getTriggerList } = require("./common_lists");
 const {
   InvalidConfiguration,
   removeAllWhiteSpace,
@@ -757,6 +757,8 @@ router.get(
     const triggers = table.id ? Trigger.find({ table_id: table.id }) : [];
     triggers.sort(comparingCaseInsensitive("name"));
     let fieldCard;
+    const nPrimaryKeys = fields.filter((f) => f.primary_key).length;
+
     if (fields.length === 0) {
       fieldCard = [
         h4(req.__(`No fields defined in %s table`, table.name)),
@@ -818,28 +820,25 @@ router.get(
         { hover: true }
       );
       fieldCard = [
+        nPrimaryKeys > 1 &&
+          div(
+            { class: "alert alert-danger", role: "alert" },
+            i({ class: "fas fa-exclamation-triangle" }),
+            "This table has composite primary keys which is not supported in Saltcorn. A procedure to introduce a single autoincrementing primary key is available.",
+            post_btn(
+              `/table/repair-composite-primary/${table.id}`,
+              "Add autoincrementing primary key",
+              req.csrfToken(),
+              { btnClass: "btn-danger" }
+            )
+          ),
+
         tableHtml,
         inbound_refs.length > 0
           ? req.__("Inbound keys: ") +
             inbound_refs.map((tnm) => link(`/table/${tnm}`, tnm)).join(", ") +
             "<br>"
           : "",
-        triggers.length
-          ? req.__("Table triggers: ") +
-            triggers
-              .map((t) =>
-                link(
-                  `/actions/configure/${
-                    t.id
-                  }?on_done_redirect=${encodeURIComponent(
-                    `table/${table.name}`
-                  )}`,
-                  t.name
-                )
-              )
-              .join(", ") +
-            "<br>"
-          : "",
         !table.external &&
           !table.provider_name &&
           a(
@@ -851,7 +850,8 @@ router.get(
           ),
       ];
     }
-    var viewCard;
+    let viewCard;
+    let triggerCard = "";
     if (fields.length > 0) {
       const views = await View.find(
         table.id ? { table_id: table.id } : { exttable_name: table.name }
@@ -884,6 +884,25 @@ router.get(
             req.__("Create view")
           ),
       };
+
+      triggerCard = {
+        type: "card",
+        id: "table-triggers",
+        title: req.__("Triggers on table"),
+        contents:
+          (triggers.length
+            ? await getTriggerList(triggers, req)
+            : p("Triggers run actions in response to events on this table")) +
+          a(
+            {
+              href: `/actions/new?table=${encodeURIComponent(
+                table.name
+              )}&on_done_redirect=${encodeURIComponent(`table/${table.name}`)}`,
+              class: "btn btn-primary",
+            },
+            req.__("Create trigger")
+          ),
+      };
     }
     const models = await Model.find({ table_id: table.id });
     const modelCard = div(
@@ -1078,6 +1097,7 @@ router.get(
             ]
           : []),
         ...(viewCard ? [viewCard] : []),
+        ...(triggerCard ? [triggerCard] : []),
         {
           type: "card",
           title: req.__("Edit table properties"),
@@ -1111,7 +1131,7 @@ router.post(
     const v = req.body;
     if (typeof v.id === "undefined" && typeof v.external === "undefined") {
       // insert
-      v.name = v.name.trim()
+      v.name = v.name.trim();
       const { name, ...rest } = v;
       const alltables = await Table.find({});
       const existing_tables = [
@@ -1162,6 +1182,7 @@ router.post(
       let notify = "";
       if (!rest.versioned) rest.versioned = false;
       if (!rest.has_sync_info) rest.has_sync_info = false;
+      rest.is_user_group = !!rest.is_user_group;
       if (rest.ownership_field_id === "_formula") {
         rest.ownership_field_id = null;
         const fmlValidRes = expressionValidator(rest.ownership_formula);
@@ -1922,7 +1943,7 @@ router.post(
     const table = Table.findOne({ name });
 
     try {
-      await table.deleteRows({}, req.user);
+      await table.deleteRows({}, req.user, true);
       req.flash("success", req.__("Deleted all rows"));
     } catch (e) {
       req.flash("error", e.message);
@@ -2074,3 +2095,20 @@ router.post(
     respondWorkflow(table, workflow, wfres, req, res);
   })
 );
+
+router.post(
+  "/repair-composite-primary/:id",
+  isAdmin,
+  error_catcher(async (req, res) => {
+    const { id } = req.params;
+
+    const table = Table.findOne({ id });
+    if (!table) {
+      req.flash("error", `Table not found`);
+      res.redirect(`/table`);
+      return;
+    }
+    await table.repairCompositePrimary();
+    res.redirect(`/table/${table.id}`);
+  })
+);

package/routes/tenant.js

@@ -355,7 +355,12 @@ router.post(
               ...tenant_letsencrypt_sites,
             ]);
             if (req.user?.role_id === 1) {
-              req.flash("success", req.__("Tenant created. Certificate will be acquired on first visit."));
+              req.flash(
+                "success",
+                req.__(
+                  "Tenant created. Certificate will be acquired on first visit."
+                )
+              );
               res.redirect("/tenant/list");
               return;
             }
@@ -416,6 +421,7 @@ router.get(
       return;
     }
     const tens = await db.select("_sc_tenants");
+    const locale = getState().getConfig("default_locale", "en");
     send_infoarch_page({
       res,
       req,
@@ -442,7 +448,8 @@ router.get(
               },
               {
                 label: req.__("Created"),
-                key: (r) => (r.created ? localeDateTime(r.created) : ""),
+                key: (r) =>
+                  r.created ? localeDateTime(r.created, {}, locale) : "",
               },
               {
                 label: req.__("Information"),
@@ -486,6 +493,7 @@ const tenant_settings_form = (req) =>
       "tenant_template",
       "tenant_baseurl",
       "tenant_create_unauth_redirect",
+      "tenant_inherit_cfgs",
       { section_header: req.__("Tenant application capabilities") },
       "tenants_install_git",
       "tenants_set_npm_modules",

package/routes/viewedit.js

@@ -151,14 +151,6 @@ const viewForm = async (req, tableOptions, roles, pages, values) => {
           "The view name is part of the URL when it is shown alone."
         ),
       }),
-      new Field({
-        label: req.__("Description"),
-        name: "description",
-        type: "String",
-        sublabel: req.__(
-          "Description allows you to give more information about the view."
-        ),
-      }),
       new Field({
         label: req.__("View pattern"),
         name: "viewtemplate",
@@ -200,6 +192,14 @@ const viewForm = async (req, tableOptions, roles, pages, values) => {
         required: true,
         options: roles.map((r) => ({ value: r.id, label: r.role })),
       }),
+      new Field({
+        label: req.__("Description"),
+        name: "description",
+        type: "String",
+        sublabel: req.__(
+          "Description allows you to give more information about the view."
+        ),
+      }),
       new Field({
         name: "page_title",
         label: req.__("Page title"),

package/wrapper.js

@@ -193,7 +193,9 @@ const get_headers = (req, version_tag, description, extras = []) => {
         state.logLevel
       }, _sc_globalCsrf = "${req.csrfToken()}", _sc_version_tag = "${version_tag}"${
         locale ? `, _sc_locale = "${locale}"` : ""
-      };</script>`,
+      }, _sc_lightmode = ${JSON.stringify(
+        state.getLightDarkMode?.(req.user) || "light"
+      )};</script>`,
     },
     { css: `/static_assets/${version_tag}/saltcorn.css` },
     { script: `/static_assets/${version_tag}/saltcorn-common.js` },