@saltcorn/server 1.0.0-beta.9 → 1.0.0-rc.10

package/tests/fields.test.js

@@ -350,6 +350,38 @@ describe("Field Endpoints", () => {
       .set("Cookie", loginCookie)
       .expect(toInclude(" is: <pre>2</pre>"));
   });
+  it("should show on stored expression with joinfield", async () => {
+    const loginCookie = await getAdminLoginCookie();
+    const table = Table.findOne({ name: "books" });
+
+    const ctx = encodeURIComponent(JSON.stringify({ table_id: table.id }));
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .post("/field/test-formula")
+      .send({
+        formula: "publisher.name",
+        tablename: "books",
+        stored: true,
+      })
+      .set("Cookie", loginCookie)
+      .expect(toInclude(" is: <pre>"));
+  });
+  it("should fail on non-stored expression with joinfield", async () => {
+    const loginCookie = await getAdminLoginCookie();
+    const table = Table.findOne({ name: "books" });
+
+    const ctx = encodeURIComponent(JSON.stringify({ table_id: table.id }));
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .post("/field/test-formula")
+      .send({
+        formula: "publisher.name",
+        tablename: "books",
+        stored: false,
+      })
+      .set("Cookie", loginCookie)
+      .expect(400);
+  });
   it("should show calculated", async () => {
     const loginCookie = await getAdminLoginCookie();
     const table = Table.findOne({ name: "books" });

package/tests/plugin_install.test.js

@@ -112,3 +112,238 @@ describe("Tenant cannot install unsafe plugins", () => {
     });
   }
 });
+
+describe("Stable versioning install", () => {
+  /*
+    empty_sc_test_plugin:
+      - starts without engine property but from the second version on it has
+    empty_sc_test_plugin_two:
+      - has no engine property in any version
+  */
+  beforeEach(async () => {
+    for (const plugin of [
+      "@christianhugoch/empty_sc_test_plugin",
+      "@christianhugoch/empty_sc_test_plugin_two",
+    ]) {
+      const dbPlugin = await Plugin.findOne({ name: plugin });
+      if (dbPlugin) await dbPlugin.delete();
+    }
+  });
+  it("installs latest", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin_two",
+        location: "@christianhugoch/empty_sc_test_plugin_two",
+        source: "npm",
+        version: "latest",
+      })
+    );
+    const dbPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(dbPlugin).not.toBe(null);
+    expect(dbPlugin.version).toBe("0.0.3");
+  });
+
+  it("installs and downgrades latest", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "latest",
+      }),
+      true
+    );
+    const dbPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(dbPlugin).not.toBe(null);
+    expect(dbPlugin.version).toBe("0.0.6");
+  });
+
+  it("installs a fixed version", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "0.0.5",
+      })
+    );
+    const dbPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(dbPlugin).not.toBe(null);
+    expect(dbPlugin.version).toBe("0.0.6");
+  });
+
+  it("installs and downgrades a fixed version", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "0.0.6",
+      }),
+      true
+    );
+    const dbPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(dbPlugin).not.toBe(null);
+    expect(dbPlugin.version).toBe("0.0.6");
+  });
+});
+
+describe("Stable versioning upgrade", () => {
+  beforeEach(async () => {
+    for (const plugin of [
+      "@christianhugoch/empty_sc_test_plugin",
+      "@christianhugoch/empty_sc_test_plugin_two",
+    ]) {
+      const dbPlugin = await Plugin.findOne({ name: plugin });
+      if (dbPlugin) await dbPlugin.delete();
+    }
+  });
+
+  it("upgrades to latest", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin_two",
+        location: "@christianhugoch/empty_sc_test_plugin_two",
+        source: "npm",
+        version: "0.0.1",
+      }),
+      true
+    );
+    const oldPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(oldPlugin).not.toBe(null);
+    expect(oldPlugin.version).toBe("0.0.1");
+
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        id: oldPlugin.id,
+        name: "@christianhugoch/empty_sc_test_plugin_two",
+        location: "@christianhugoch/empty_sc_test_plugin_two",
+        source: "npm",
+        version: "latest",
+      }),
+      true
+    );
+    const newPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(newPlugin).not.toBe(null);
+    expect(newPlugin.version).toBe("0.0.3");
+  });
+
+  it("upgrades to latest with downgrade", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "0.0.1",
+      }),
+      true
+    );
+    const oldPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(oldPlugin).not.toBe(null);
+    expect(oldPlugin.version).toBe("0.0.1");
+
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        id: oldPlugin.id,
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "latest",
+      }),
+      true
+    );
+    const newPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(newPlugin).not.toBe(null);
+    expect(newPlugin.version).toBe("0.0.6");
+  });
+
+  it("upgrades to fixed version", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin_two",
+        location: "@christianhugoch/empty_sc_test_plugin_two",
+        source: "npm",
+        version: "0.0.1",
+      }),
+      true
+    );
+    const oldPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(oldPlugin).not.toBe(null);
+    expect(oldPlugin.version).toBe("0.0.1");
+
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        id: oldPlugin.id,
+        name: "@christianhugoch/empty_sc_test_plugin_two",
+        location: "@christianhugoch/empty_sc_test_plugin_two",
+        source: "npm",
+        version: "0.0.3",
+      }),
+      true
+    );
+    const newPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(newPlugin).not.toBe(null);
+    expect(newPlugin.version).toBe("0.0.3");
+  });
+
+  it("upgrades to fixed version with downgrade", async () => {
+    const loadAndSaveNewPlugin = load_plugins.loadAndSaveNewPlugin;
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "0.0.1",
+      }),
+      true
+    );
+    const oldPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(oldPlugin).not.toBe(null);
+    expect(oldPlugin.version).toBe("0.0.1");
+
+    await loadAndSaveNewPlugin(
+      new Plugin({
+        id: oldPlugin.id,
+        name: "@christianhugoch/empty_sc_test_plugin",
+        location: "@christianhugoch/empty_sc_test_plugin",
+        source: "npm",
+        version: "0.0.6",
+      }),
+      true
+    );
+    const newPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(newPlugin).not.toBe(null);
+    expect(newPlugin.version).toBe("0.0.6");
+  });
+});

package/tests/plugins.test.js

@@ -10,6 +10,7 @@ const {
   toInclude,
   toNotInclude,
   toRedirect,
+  toSucceed,
   resetToFixtures,
 } = require("../auth/testhelp");
 const db = require("@saltcorn/data/db");
@@ -308,6 +309,7 @@ describe("config endpoints", () => {
       .post("/admin")
       .send("site_name=FooSiteName")
       .send("multitenancy_enabled=on")
+      .send("plugins_store_endpoint=https://store.saltcorn.com/api/extensions")
       .set("Cookie", loginCookie)
       .expect(toRedirect("/admin/"));
     await request(app)
@@ -316,3 +318,141 @@ describe("config endpoints", () => {
       .expect(toInclude(">FooSiteName<"));
   });
 });
+
+const installPlugin = async (name, version) => {
+  const loginCookie = await getAdminLoginCookie();
+  const app = await getApp({ disableCsrf: true });
+  await request(app)
+    .post("/plugins")
+    .send(
+      `name=${encodeURIComponent(name)}&location=${encodeURIComponent(
+        name
+      )}&source=npm&version=${version}`
+    )
+    .set("Cookie", loginCookie)
+    .expect(toRedirect("/plugins"));
+};
+
+const setupPluginVersion = async (name, version) => {
+  let oldPlugin = await Plugin.findOne({
+    name: name,
+  });
+  if (!oldPlugin) await installPlugin(name, version);
+  else {
+    oldPlugin.version = version;
+    await oldPlugin.upsert();
+  }
+  return await Plugin.findOne({
+    name: name,
+  });
+};
+describe("Upgrade plugin to supported version", () => {
+  it("upgrades to latest", async () => {
+    const oldPlugin = await setupPluginVersion(
+      "@christianhugoch/empty_sc_test_plugin_two",
+      "0.0.1"
+    );
+    expect(oldPlugin.version).toBe("0.0.1");
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/plugins/upgrade")
+      .set("Cookie", loginCookie)
+      .expect(toRedirect("/plugins"));
+    const upgradedPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(upgradedPlugin.version).toBe("0.0.3");
+  });
+
+  it("upgrades to the most current fixed version", async () => {
+    const oldPlugin = await setupPluginVersion(
+      "@christianhugoch/empty_sc_test_plugin_two",
+      "0.0.1"
+    );
+    await oldPlugin.upsert();
+    expect(oldPlugin.version).toBe("0.0.1");
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .post(
+        `/plugins/install/${encodeURIComponent(
+          "@christianhugoch/empty_sc_test_plugin_two"
+        )}`
+      )
+      .send("version=0.0.3")
+      .set("Cookie", loginCookie)
+      .expect(toRedirect("/plugins"));
+    const upgradedPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin_two",
+    });
+    expect(upgradedPlugin.version).toBe("0.0.3");
+  });
+
+  it("upgrades with a downgrade of the latest version", async () => {
+    const oldPlugin = await setupPluginVersion(
+      "@christianhugoch/empty_sc_test_plugin",
+      "0.0.1"
+    );
+    expect(oldPlugin.version).toBe("0.0.1");
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/plugins/upgrade")
+      .set("Cookie", loginCookie)
+      .expect(toRedirect("/plugins"));
+    const upgradedPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(upgradedPlugin.version).toBe("0.0.6");
+  });
+
+  it("upgrades with a downgrade of the most current fixed version", async () => {
+    const oldPlugin = await setupPluginVersion(
+      "@christianhugoch/empty_sc_test_plugin",
+      "0.0.1"
+    );
+    expect(oldPlugin.version).toBe("0.0.1");
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .post(
+        `/plugins/install/${encodeURIComponent(
+          "@christianhugoch/empty_sc_test_plugin"
+        )}`
+      )
+      .send("version=0.1.0")
+      .set("Cookie", loginCookie)
+      .expect(toRedirect("/plugins"));
+    const upgradedPlugin = await Plugin.findOne({
+      name: "@christianhugoch/empty_sc_test_plugin",
+    });
+    expect(upgradedPlugin.version).toBe("0.0.6");
+  });
+});
+
+describe("install a different version dialog", () => {
+  it("sends the dialog", async () => {
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get("/plugins/versions_dialog/any-bootstrap-theme")
+      .set("Cookie", loginCookie)
+      .expect(toInclude(["0.5.14", "0.5.14", "0.5.13", "0.5.12", "0.1.0"]));
+  });
+
+  it("filters not supported versions", async () => {
+    await installPlugin("@christianhugoch/empty_sc_test_plugin", "latest");
+    const loginCookie = await getAdminLoginCookie();
+    const app = await getApp({ disableCsrf: true });
+    await request(app)
+      .get(
+        `/plugins/versions_dialog/${encodeURIComponent(
+          "@christianhugoch/empty_sc_test_plugin"
+        )}`
+      )
+      .set("Cookie", loginCookie)
+      .expect(toInclude(["0.0.1", "0.0.2", "0.0.3", "0.0.4", "0.0.5", "0.0.6"]))
+      .expect(toNotInclude("0.1.0"));
+  });
+});