@saltcorn/copilot 0.8.2 → 0.8.3

package/app-constructor/run_task.js

@@ -1,15 +1,15 @@
-const Field = require("@saltcorn/data/models/field");
 const Table = require("@saltcorn/data/models/table");
-const Form = require("@saltcorn/data/models/form");
 const MetaData = require("@saltcorn/data/models/metadata");
 const View = require("@saltcorn/data/models/view");
+const Page = require("@saltcorn/data/models/page");
 const Trigger = require("@saltcorn/data/models/trigger");
-const { findType } = require("@saltcorn/data/models/discovery");
-const { save_menu_items } = require("@saltcorn/data/models/config");
+const Plugin = require("@saltcorn/data/models/plugin");
 const db = require("@saltcorn/data/db");
 const WorkflowRun = require("@saltcorn/data/models/workflow_run");
 const User = require("@saltcorn/data/models/user");
-const { viewname } = require("./common");
+const { getState } = require("@saltcorn/data/db/state");
+const { viewname, TaskType } = require("./common");
+const { PromptGenerator } = require("./prompt-generator");
 
 /**
  * @param {number} md_id - MetaData id of the task to run
@@ -21,65 +21,84 @@ const runTask = async (md_id, req) => {
   });
 
   if (!md) return { error: "Task not found" };
-  const spec = await MetaData.findOne({
-    type: "CopilotConstructMgr",
-    name: "spec",
-  });
-  if (!spec) return { error: "Specification not found" };
+
+  const taskType = md.body.task_type || TaskType.FEATURE;
+
   const agent_action = new Trigger({
     action: "Agent",
     when_trigger: "Never",
     configuration: {
       viewname: viewname,
       sys_prompt:
-        "Each task creates exactly one view or one page. " +
-        "Never create more than one view or page per task, even if the description mentions multiple. " +
-        "Call the view or page tool exactly once and then stop.",
+        taskType === TaskType.PLUGIN
+          ? "Each task installs exactly one plugin from the Saltcorn plugin store. " +
+            "Use the Install Plugin skill to find and install it. Call the skill once and then stop."
+          : taskType === TaskType.DATA_MODEL
+          ? "Each task creates or modifies database tables/fields or configures platform-level settings (such as custom roles). " +
+            "Use the database design tool for schema changes. Use the Registry editor (set_entity) for platform configuration such as creating custom roles. " +
+            "Call only the tools needed for the task and then stop. Do not create any views, pages, or triggers."
+          : "Each task creates exactly one primary artifact: one view, one page, or one workflow trigger. " +
+            "Never create more than one view or page per task, even if the description mentions multiple. " +
+            "Exception: if the task description explicitly says to both create a workflow trigger AND update an existing view to add an action button for it, do both — create the workflow first, then update the specified view. " +
+            "After completing the primary artifact (and the explicitly described action button update, if any), stop.",
       prompt: "{{prompt}}",
-      skills: [
-        { skill_type: "Generate Page", yoloMode: true },
-        { skill_type: "Database design", yoloMode: true },
-        { skill_type: "Generate Workflow", yoloMode: true },
-        { skill_type: "Generate trigger", yoloMode: true },
-        { skill_type: "Generate View", yoloMode: true },
-        { skill_type: "Install Plugin", yoloMode: true },
-        { skill_type: "Registry editor", yoloMode: true },
-      ],
+      skills:
+        taskType === TaskType.PLUGIN
+          ? [{ skill_type: "Install Plugin", yoloMode: true }]
+          : taskType === TaskType.DATA_MODEL
+          ? [
+              { skill_type: "Database design", yoloMode: true },
+              { skill_type: "Registry editor", yoloMode: true },
+            ]
+          : [
+              { skill_type: "Generate Page", yoloMode: true },
+              { skill_type: "Generate Workflow", yoloMode: true },
+              { skill_type: "Generate trigger", yoloMode: true },
+              { skill_type: "Generate View", yoloMode: true },
+              { skill_type: "Install Plugin", yoloMode: true },
+              { skill_type: "Registry editor", yoloMode: true },
+            ],
     },
   });
-  const prompt = `You are engaged in building the following application:
-
-Description: ${spec.body.description}
-Audience: ${spec.body.audience}
-Core features: ${spec.body.core_features}
-Out of scope: ${spec.body.out_of_scope}
-Visual style: ${spec.body.visual_style}
-
-Important: The database schema is already fully implemented. Do NOT use generate_tables or modify any tables or fields — all tables and fields already exist.
-
-Important: Some fields are non-stored (virtual) calculated fields — they have no database column and are computed on-the-fly by Saltcorn. Never include such fields in modify_row, SQL UPDATE statements, or recalculate_stored_fields calls. Only fields that exist as actual database columns (regular fields and stored calculated fields) can be written. If a calculated field needs updating, it will refresh automatically when the fields it depends on change.
-
-Important: The "users" table is built-in. Passwords are platform-managed — never add a password field to a view. Signup uses the built-in page at /auth/signup, login at /auth/login. Do NOT create triggers for registration or email verification — the platform handles this natively.
-
-Important: On landing pages, place Log in / Create account buttons in no more than two locations (e.g. navbar and one hero call-to-action). Do not repeat them in a third "Get started" section or anywhere else. For links that take an already-authenticated user to their dashboard, use href="/" — not /auth/login.
-
-Important: Do not name any page or view "Admin dashboard" — that name is reserved by the Saltcorn platform. For pages intended for role 1 (admin), use a name like "App admin dashboard" or prefix it with the application name (e.g. "Law Firm admin dashboard").
-
-Important: When creating a page or view, always set min_role based on the intended audience: 1 for admin-only, 40 for staff and above, 80 for logged-in users and above, 100 for public. Never default to public (100) unless the page or view is explicitly intended for unauthenticated users (e.g. a landing page). A dashboard or view for clients/users is role 80, a staff page or view is role 40, an admin page or view is role 1.
 
-Important: Two-factor authentication (2FA/TOTP) is fully built into the platform. To configure it, call set_entity directly with entity_type "system-configuration-value" and entity_name "twofa_policy_by_role". The entity_definition must be the plain JSON object itself — for example: {"1": "Mandatory", "100": "Disabled"}. Do NOT wrap it in {"type": "json", "value": ...} or any other envelope. Read the current value first with get_entity and merge rather than overwrite. Do NOT create a workflow or trigger to do this.
+  const generator = await PromptGenerator.createInstance();
+  if (!generator.spec) return { error: "Specification not found" };
+  const prompt = generator.taskExecPrompt(taskType, md.body.description);
 
-Important: To set a page as the home page for a role, call set_entity directly with entity_type "system-configuration-value" and entity_name "home_page_by_role". The value is a JSON object mapping role IDs to page names — Role IDs: public=100, user=80, staff=40, admin=1. The entity_definition must be the plain JSON object itself — for example: {"100": "landing", "80": "client_dashboard"}. Do NOT wrap it in {"type": "json", "value": ...} or any other envelope. Read the current value first with get_entity so you can merge rather than overwrite. Do NOT create a workflow or trigger to do this — use set_entity directly.
+  const safeReq =
+    req?.__ && req?.getLocale
+      ? req
+      : {
+          ...req,
+          __: req?.__ || ((s) => s),
+          getLocale: req?.getLocale || (() => "en"),
+          user: req?.user,
+        };
 
-Important: If the task description mentions adding a viewlink, linking rows to another view, or a button that opens another view from a list — that viewlink column MUST be present in the finished view. Do not skip it. Viewlinks require calling get_relation_paths first to obtain the relation string before generating the layout.
-
-Important: Before creating or updating any view or page that embeds, links to, or opens another view (including viewlinks, action buttons, and ajax_modal calls), call list_entities (entity_type "view") to get all existing view names. Only reference views that appear in that list — never invent a name or assume a view exists. If a view is not in the list, omit the reference entirely. Do the same for pages: call list_entities (entity_type "page") before linking to any page by name.
-
-Your task now is:
-${md.body.description}`;
-  const safeReq = req?.__ ? req : { ...req, __: (s) => s, user: req?.user };
+  const tableNamesBefore =
+    taskType === TaskType.DATA_MODEL
+      ? new Set((await Table.find({})).map((t) => t.name))
+      : null;
+  const viewNamesBefore =
+    taskType === TaskType.FEATURE && md.body.phase_idx !== undefined
+      ? new Set((await View.find({})).map((v) => v.name))
+      : null;
+  const pageNamesBefore =
+    taskType === TaskType.FEATURE && md.body.phase_idx !== undefined
+      ? new Set((await Page.find({})).map((p) => p.name))
+      : null;
+  const pluginNamesBefore =
+    taskType === TaskType.PLUGIN && md.body.phase_idx !== undefined
+      ? new Set((await Plugin.find({})).map((p) => p.name))
+      : null;
 
   await md.update({ body: { ...md.body, status: "Running" } });
+  try {
+    getState().emitDynamicUpdate(db.getTenantSchema(), {
+      eval_js:
+        "if(typeof copilotRefreshTasks==='function')copilotRefreshTasks();",
+    });
+  } catch (_) {}
   try {
     const actionres = await agent_action.runWithoutRow({
       row: { prompt },
@@ -98,25 +117,133 @@ ${md.body.description}`;
       user: safeReq.user,
     });
     const updatedRun = await WorkflowRun.findOne({ id: run_id });
-    const lastInteraction =
-      updatedRun.context.interactions[
-        updatedRun.context.interactions.length - 1
-      ];
-    const lastText =
-      typeof lastInteraction.content === "string"
-        ? lastInteraction.content
-        : lastInteraction.content.text
-        ? lastInteraction.content.text
-        : Array.isArray(lastInteraction.content)
-        ? lastInteraction.content[0].text
-        : lastInteraction.content;
+    const extractText = (content) => {
+      if (!content) return "";
+      if (typeof content === "string") return content;
+      if (
+        typeof content === "object" &&
+        !Array.isArray(content) &&
+        content.text
+      )
+        return content.text;
+      if (Array.isArray(content)) {
+        const tb = content.find((b) => b?.type === "text" && b?.text);
+        return tb?.text || "";
+      }
+      return "";
+    };
+    const interactions = updatedRun.context.interactions || [];
+    let lastText = "";
+    for (let i = interactions.length - 1; i >= 0; i--) {
+      const t = extractText(interactions[i]?.content);
+      if (t) {
+        lastText = t;
+        break;
+      }
+    }
+    if (!lastText) lastText = md.body.description || md.body.name || "";
     await MetaData.create({
       type: "CopilotConstructMgr",
       name: "progress",
-      body: { text: lastText, run_id, task_id: md.id },
+      body: {
+        text: lastText,
+        run_id,
+        task_id: md.id,
+        phase_idx: md.body.phase_idx ?? null,
+      },
       user_id: req?.user?.id,
     });
     await md.update({ body: { ...md.body, status: "Done", run_id } });
+    if (
+      taskType === TaskType.DATA_MODEL &&
+      tableNamesBefore &&
+      md.body.phase_idx !== undefined
+    ) {
+      const tablesAfter = await Table.find({});
+      const newTables = tablesAfter.filter(
+        (t) => !t.name.startsWith("_sc_") && !tableNamesBefore.has(t.name)
+      );
+      for (const table of newTables) {
+        await MetaData.create({
+          type: "CopilotConstructMgr",
+          name: "table_phase",
+          body: {
+            table_name: table.name,
+            phase_idx: md.body.phase_idx,
+            phase_name: md.body.phase_name,
+          },
+          user_id: req?.user?.id,
+        });
+      }
+    }
+    if (
+      taskType === TaskType.PLUGIN &&
+      pluginNamesBefore &&
+      md.body.phase_idx !== undefined
+    ) {
+      const pluginsAfter = await Plugin.find({});
+      for (const p of pluginsAfter.filter(
+        (p) => !pluginNamesBefore.has(p.name)
+      )) {
+        await MetaData.create({
+          type: "CopilotConstructMgr",
+          name: "plugin_phase",
+          body: {
+            plugin_name: p.name,
+            phase_idx: md.body.phase_idx,
+            phase_name: md.body.phase_name,
+          },
+          user_id: req?.user?.id,
+        });
+      }
+    }
+    if (
+      taskType === TaskType.FEATURE &&
+      viewNamesBefore &&
+      md.body.phase_idx !== undefined
+    ) {
+      const viewsAfter = await View.find({});
+      for (const v of viewsAfter.filter((v) => !viewNamesBefore.has(v.name))) {
+        await MetaData.create({
+          type: "CopilotConstructMgr",
+          name: "view_phase",
+          body: {
+            view_name: v.name,
+            viewtemplate: v.viewtemplate,
+            phase_idx: md.body.phase_idx,
+            phase_name: md.body.phase_name,
+          },
+          user_id: req?.user?.id,
+        });
+      }
+      const pagesAfter = await Page.find({});
+      for (const p of pagesAfter.filter((p) => !pageNamesBefore.has(p.name))) {
+        await MetaData.create({
+          type: "CopilotConstructMgr",
+          name: "view_phase",
+          body: {
+            view_name: p.name,
+            viewtemplate: "page",
+            phase_idx: md.body.phase_idx,
+            phase_name: md.body.phase_name,
+          },
+          user_id: req?.user?.id,
+        });
+      }
+    }
+    try {
+      const phaseIdx = md.body.phase_idx;
+      getState().emitDynamicUpdate(db.getTenantSchema(), {
+        eval_js:
+          "if(typeof copilotRefreshTasks==='function')copilotRefreshTasks();" +
+          (taskType === TaskType.DATA_MODEL
+            ? "if(typeof copilotRefreshSchema==='function')copilotRefreshSchema();"
+            : "") +
+          (phaseIdx != null
+            ? `if(typeof copilotRefreshPhaseProgress==='function')copilotRefreshPhaseProgress(${phaseIdx});`
+            : ""),
+      });
+    } catch (_) {}
   } catch (e) {
     await md.update({ body: { ...md.body, status: "To do" } });
     throw e;
@@ -161,7 +288,11 @@ const runNextTask = async (once = false) => {
     const taskUser = startable[0].user_id
       ? await User.findOne({ id: startable[0].user_id })
       : null;
-    await runTask(startable[0].id, { user: taskUser, __: (s) => s });
+    await runTask(startable[0].id, {
+      user: taskUser,
+      __: (s) => s,
+      getLocale: () => "en",
+    });
     if (!once) await runNextTask();
   } else if (!once) {
     const settings = await MetaData.findOne({