@salla.sa/twilight-components 2.14.512 → 2.14.513

package/dist/collection/components/salla-products-list/salla-products-list.js

@@ -623,32 +623,64 @@ export class SallaProductsList {
             ? this.currentCategoryIdFilter
             : Helper.getProductsSourceValue(this.source, this.sourceValue);
     }
-    logFetchError(errorPhase, error, fetchPath, http, response) {
+    getResponseHeader(headers, name) {
+        if (!headers)
+            return undefined;
+        if (typeof headers.get === 'function') {
+            return headers.get(name) || undefined;
+        }
+        const record = headers;
+        const direct = record[name] ?? record[name.toLowerCase()];
+        if (typeof direct === 'string')
+            return direct;
+        if (Array.isArray(direct) && typeof direct[0] === 'string')
+            return direct[0];
+        return undefined;
+    }
+    logFetchError(errorPhase, error, fetchPath, http) {
         try {
-            const body = response && typeof response === 'object' ? response : null;
-            const sourceValue = this.getSourceValue();
+            const errorName = error instanceof Error ? error.name : undefined;
+            const errorMessage = error instanceof Error ? error.message : String(error);
+            const responseUrl = http?.url || fetchPath;
+            const cfRay = this.getResponseHeader(http?.headers, 'cf-ray');
+            const cfMitigated = this.getResponseHeader(http?.headers, 'cf-mitigated');
+            const server = this.getResponseHeader(http?.headers, 'server');
+            const cloudflareBlock = cfMitigated?.toLowerCase() === 'challenge' ||
+                (http?.status === 403 &&
+                    (!!cfRay || !!server?.toLowerCase().includes('cloudflare')));
+            const errorDetails = `${errorName || ''} ${errorMessage}`;
+            let failureType = errorPhase === 'processing' ? 'processing' : 'unknown';
+            // Fetch-specific classifiers must not overwrite processing failures
+            // (e.g. append/render errors whose message mentions timeout or whose path has /null).
+            if (errorPhase === 'fetch') {
+                if (cloudflareBlock) {
+                    failureType = 'cloudflare';
+                }
+                else if (/(?:^|\/)null(?:[/?#]|$)/i.test(responseUrl || '')) {
+                    failureType = 'invalid_url';
+                }
+                else if (/timeout|timed out|abort/i.test(errorDetails)) {
+                    failureType = 'timeout';
+                }
+                else if (!http?.status && /fetch|network|load failed|connection/i.test(errorDetails)) {
+                    failureType = 'network';
+                }
+                else if (http?.status) {
+                    failureType = 'http';
+                }
+            }
             salla.analytics?.log('salla::products.list.fetch.error', {
                 errorPhase,
+                failureType,
+                cloudflareBlock,
                 source: this.getSource(),
-                sourceValue: typeof sourceValue === 'string' && sourceValue.length > 200
-                    ? `${sourceValue.slice(0, 200)}…`
-                    : Array.isArray(sourceValue)
-                        ? { length: sourceValue.length }
-                        : sourceValue,
                 pageIndex: this.infiniteScroll?.pageIndex,
-                fetchPath,
                 httpStatus: http?.status,
-                httpStatusText: http?.statusText,
-                responseUrl: http?.url,
-                ...(body && {
-                    dataCount: Array.isArray(body.data) ? body.data.length : undefined,
-                    responseKeys: Object.keys(body).slice(0, 15),
-                    filtersCount: Array.isArray(body.filters) ? body.filters.length : undefined,
-                }),
-                errorMessage: error instanceof Error ? error.message : String(error),
-                ...(errorPhase === 'processing' && error instanceof Error && error.stack
-                    ? { errorStack: error.stack.slice(0, 500) }
-                    : {}),
+                responseUrl,
+                cfRay,
+                cfMitigated,
+                errorName,
+                errorMessage: errorMessage.slice(0, 500),
             });
         }
         catch {
@@ -734,7 +766,7 @@ export class SallaProductsList {
             catch (error) {
                 console.error('Error during load:', error);
                 const res = httpResponse;
-                this.logFetchError('processing', error, typeof path === 'string' ? path : undefined, res, response);
+                this.logFetchError('processing', error, typeof path === 'string' ? path : undefined, res);
             }
             finally {
                 this.isProcessing = false;
@@ -821,6 +853,16 @@ export class SallaProductsList {
             source: Helper.getApiSource(this.getSource()),
             source_value: this.getSourceValue(),
             limit: this.limit,
+        })
+            .catch(error => {
+            const response = error?.response;
+            const responseUrl = response?.request?.responseURL || error?.config?.url;
+            this.logFetchError('fetch', error, responseUrl, {
+                status: response?.status,
+                url: responseUrl,
+                headers: response?.headers,
+            });
+            throw error;
         })
             .then(async (response) => {
             if (!response.data.length) {