@salesforcedevs/dx-components 1.40.7-bug-fix-alpha → 1.40.7-scroll-1

package/src/modules/dx/treeItem/treeItem.css

@@ -2,44 +2,6 @@
 
 :host {
     display: block;
-
-    /* Keep a stable containing block; z-index still lifts the open menu. */
-    position: relative;
-}
-
-/* Lift this row above later sibling pickers while its menu is open. */
-:host(:focus-within) {
-    z-index: 2;
-}
-
-.tree-item-row {
-    display: flex;
-    align-items: center;
-    min-width: 0;
-    position: relative;
-}
-
-/* The tile's keyboard focus layers fill this row, picker included. isolate
-   keeps the fill above the row's background and below its content. Only while
-   focus is inside: a row that is always isolated traps its picker's menu. */
-.tree-item-row:focus-within {
-    isolation: isolate;
-}
-
-.tree-item-row dx-tree-tile {
-    flex: 1;
-    min-width: 0;
-}
-
-.tree-item-version-picker {
-    flex: 0 0 auto;
-    margin-right: var(--dx-g-spacing-lg);
-    overflow: visible;
-}
-
-.tree-item-row-selected {
-    background: var(--dx-g-cloud-blue-vibrant-95);
-    box-shadow: inset var(--dx-g-spacing-xs) 0 0 0 var(--dx-g-blue-vibrant-40);
 }
 
 button {

package/src/modules/dx/treeItem/treeItem.html

@@ -1,5 +1,5 @@
 <template>
-    <div class={rowClass}>
+    <a href={href} target={target} onclick={onLinkClick} tabindex="-1">
         <dx-tree-tile
             href={href}
             is-root={isRoot}
@@ -7,26 +7,12 @@
             is-expanded={isExpanded}
             has-children={hasChildren}
             is-selected={isSelected}
-            is-contained-selection={isContainedSelection}
             oniconclick={onIconClick}
             show-arrow={isParent}
             target={target}
             is-external-link={isExternalLink}
-            has-version-picker={showVersionPicker}
-            onclick={onLinkClick}
         ></dx-tree-tile>
-        <dx-version-picker
-            if:true={showVersionPicker}
-            class="tree-item-version-picker"
-            small="true"
-            versions={versionPickerOptions}
-            selected-version={selectedVersion}
-            latest-version={isLatestVersion}
-            onchange={onVersionChange}
-            onclick={onVersionPickerClick}
-            onmousedown={onVersionPickerClick}
-        ></dx-version-picker>
-    </div>
+    </a>
     <img
         if:true={showChildrenLoading}
         class="tree-children-loading"
@@ -39,7 +25,6 @@
                 key={child.key}
                 tree-node={child}
                 selected-key={selectedKey}
-                language={language}
             ></dx-tree-item>
         </template>
     </template>

package/src/modules/dx/treeItem/treeItem.ts

@@ -2,28 +2,12 @@ import { LightningElement, api } from "lwc";
 import { InternalTreeNode } from "typings/custom";
 import { track } from "dxUtils/analytics";
 import { isInViewport } from "dxUtils/browser";
-import type { TopicVersionOption } from "dxUtils/topicVersion";
-import {
-    firstContentNode,
-    getTopicVersionKey,
-    getVersionPickerOptions,
-    isParentOnlyTopic,
-    normalizePath,
-    persistTopicVersion,
-    resolveSelectedVersion,
-    shouldShowTopicVersionPicker
-} from "dxUtils/topicVersion";
 
 const DEFAULT_TARGET = "_self";
 
-type VersionedInternalTreeNode = InternalTreeNode & {
-    versions?: TopicVersionOption[];
-};
-
 export default class TreeItem extends LightningElement {
     @api selectedKey?: string;
     @api isRoot: boolean = false;
-    @api language?: string;
 
     @api
     public get treeNode() {
@@ -36,7 +20,7 @@ export default class TreeItem extends LightningElement {
         this.isChildrenLoading = (node && node.isChildrenLoading) || false;
     }
 
-    private _treeNode!: VersionedInternalTreeNode;
+    private _treeNode!: InternalTreeNode;
     private isExpanded: boolean = false;
     private isChildrenLoading: boolean = false;
     private rootParentLabel: string = "";
@@ -46,22 +30,9 @@ export default class TreeItem extends LightningElement {
     }
 
     private get isSelected(): boolean {
-        if (isParentOnlyTopic(this._treeNode)) {
-            return false;
-        }
         return this._treeNode.key === this.selectedKey && !this.isExternalLink;
     }
 
-    private get rowClass(): string {
-        return this.isSelected && this.showVersionPicker
-            ? "tree-item-row tree-item-row-selected"
-            : "tree-item-row";
-    }
-
-    private get isContainedSelection(): boolean {
-        return this.isSelected && this.showVersionPicker;
-    }
-
     private get hasChildren(): boolean {
         return !!(
             this.treeNode &&
@@ -112,48 +83,8 @@ export default class TreeItem extends LightningElement {
         return `${parentLabels.reverse().join(":")}:${this.treeNode.label}`;
     }
 
-    private get versions(): TopicVersionOption[] | undefined {
-        return this._treeNode?.versions;
-    }
-
-    private get versionPickerOptions(): TopicVersionOption[] | undefined {
-        return getVersionPickerOptions(this._treeNode);
-    }
-
-    private get showVersionPicker(): boolean {
-        return shouldShowTopicVersionPicker(
-            this.versions,
-            this._treeNode?.showForwardArrow
-        );
-    }
-
-    private get selectedVersion(): TopicVersionOption | undefined {
-        return resolveSelectedVersion(this._treeNode, this.language);
-    }
-
-    private get topicVersionKey(): string {
-        return getTopicVersionKey(this._treeNode, this.language);
-    }
-
-    private get isLatestVersion(): boolean {
-        return (
-            !!this.selectedVersion &&
-            this.selectedVersion.id === this.versions?.[0]?.id
-        );
-    }
-
     private get href(): string | undefined {
-        if (isParentOnlyTopic(this._treeNode)) {
-            const contentNode = firstContentNode(this._treeNode);
-            return (
-                contentNode?.link?.href ||
-                contentNode?.name ||
-                this.selectedVersion?.link?.href ||
-                ""
-            );
-        }
         return (
-            this.selectedVersion?.link?.href ||
             (this._treeNode.link && this._treeNode.link.href) ||
             this._treeNode.name ||
             ""
@@ -173,23 +104,6 @@ export default class TreeItem extends LightningElement {
                 setExpanded: this.setExpanded.bind(this)
             });
         }
-
-        // Remember this topic's resolved version (own URL, descendant URL, or
-        // session) so sibling pickers stay independent for the tab.
-        const selected = this.selectedVersion;
-        const topicKey = this.topicVersionKey;
-        if (this.versions?.length && selected && topicKey) {
-            persistTopicVersion(topicKey, selected.id);
-        }
-    }
-
-    private onVersionChange(event: CustomEvent): void {
-        event.stopPropagation();
-        persistTopicVersion(this.topicVersionKey, event.detail);
-    }
-
-    private onVersionPickerClick(event: Event): void {
-        event.stopPropagation();
     }
 
     renderedCallback(): void {
@@ -218,14 +132,10 @@ export default class TreeItem extends LightningElement {
     }
 
     private preventDefaultLinkBehavior(event: Event) {
-        // Nodes with no link.href (AMF items use name) must not follow the
-        // anchor. Parent-only topics are excluded: their href is the child page.
-        // Otherwise cancel only an empty href or a click on the current path.
+        // prevent page refresh if href isn't present or link is already active
         if (
-            (!this._treeNode.link?.href &&
-                !isParentOnlyTopic(this._treeNode)) ||
-            !this.href ||
-            normalizePath(this.href) === normalizePath(window.location.pathname)
+            !this._treeNode.link?.href ||
+            this._treeNode.link?.href === window.location.pathname
         ) {
             event.preventDefault();
         }
@@ -245,14 +155,10 @@ export default class TreeItem extends LightningElement {
                 this.sendGtm(event);
                 return;
             }
-            // No copied destination. A markdown descendant is selected below.
-            // A chain with no content page only expands.
-            if (!firstContentNode(this._treeNode)?.link?.href) {
-                const isSelectAction = false;
-                this.doExpand(isSelectAction);
-                this.sendGtm(event);
-                return;
-            }
+            const isSelectAction = false;
+            this.doExpand(isSelectAction);
+            this.sendGtm(event);
+            return;
         }
 
         if (this.isParent) {
@@ -261,12 +167,8 @@ export default class TreeItem extends LightningElement {
         }
 
         this.sendGtm(event);
-        const contentNode = isParentOnlyTopic(this._treeNode)
-            ? firstContentNode(this._treeNode)
-            : undefined;
         this.fireEvent("tileselected", {
-            name: contentNode?.name || this._treeNode.name,
-            ...(contentNode?.key ? { key: contentNode.key } : {}),
+            name: this._treeNode.name,
             isExternalLink: this.isExternalLink
         });
     }
@@ -284,8 +186,8 @@ export default class TreeItem extends LightningElement {
         this.dispatchEvent(
             new CustomEvent(type, {
                 detail: {
-                    key: this._treeNode.key,
-                    ...detail
+                    ...detail,
+                    key: this._treeNode.key
                 },
                 bubbles: true,
                 composed: true

package/src/modules/dx/treeTile/treeTile.css

@@ -66,10 +66,6 @@
     white-space: nowrap;
 }
 
-.tile-with-version-picker {
-    padding-right: var(--dx-g-spacing-xs);
-}
-
 .tile-with-children .tile-label {
     order: 2;
 }
@@ -217,56 +213,3 @@ a:visited.tile-root,
 a:link.tile-root {
     color: var(--dx-g-blue-vibrant-20);
 }
-
-/* Keyboard focus matches dx-dropdown-option: a light fill, a 2px blue inset
-   ring, and a white inner band. The layers fill dx-tree-item's row (it sets
-   position: relative), so a version picker beside the link sits inside the
-   focus box. Undo the shared tree item focus box (commonTreeItem) first. */
-:host .sidebar-item:focus-visible {
-    margin: 0;
-    padding: 6px var(--dx-g-spacing-lg) 6px
-        var(--dx-g-global-header-padding-horizontal);
-    outline: none;
-    border-radius: 0;
-}
-
-/* Keep the picker row's 4px right padding on focus, so the label does not rewrap. */
-:host .tile-with-version-picker:focus-visible {
-    padding-right: var(--dx-g-spacing-xs);
-}
-
-:host .sidebar-item:focus-visible .indentation {
-    padding-top: 0;
-    padding-bottom: 0;
-    outline: none;
-}
-
-:host .sidebar-item:focus-visible::before,
-:host .sidebar-item:focus-visible::after {
-    content: "";
-    position: absolute;
-    inset: 0;
-    pointer-events: none;
-}
-
-:host .sidebar-item:focus-visible::before {
-    z-index: -1;
-    background: var(--dx-g-cloud-blue-vibrant-95);
-}
-
-:host .sidebar-item:focus-visible::after {
-    z-index: 1;
-    box-shadow: inset 0 0 0 2px var(--dx-g-blue-vibrant-60),
-        inset 0 0 0 4px white;
-}
-
-/* A selected item keeps its left bar, inside the ring, when it also has keyboard focus. */
-:host
-    .sidebar-item:is(
-        .sidebar-item-selected,
-        .sidebar-item-selected-text
-    ):focus-visible::after {
-    box-shadow: inset 0 0 0 2px var(--dx-g-blue-vibrant-60),
-        inset 0 0 0 4px white,
-        inset calc(2 * var(--dx-g-spacing-xs)) 0 0 0 var(--dx-g-blue-vibrant-40);
-}

package/src/modules/dx/treeTile/treeTile.ts

@@ -28,12 +28,10 @@ export default class TreeTile extends LightningElement {
     @api isExpanded = false;
     @api hasChildren = false;
     @api isSelected = false;
-    @api isContainedSelection = false;
     @api href!: string;
     @api showArrow = false;
     @api target!: string;
     @api isExternalLink = false;
-    @api hasVersionPicker = false;
 
     get tileAriaLevel() {
         return this.treeNode.level + 2;
@@ -45,21 +43,18 @@ export default class TreeTile extends LightningElement {
      * screen reader users (WCAG 2.4.4)
      */
     get linkAriaLabel(): string | null {
-        if (!this.treeNode.redirectToChild) {
+        if (!this.treeNode.redirectToChild || !this.treeNode.link?.href) {
             return null;
         }
         /**
          * The redirect can target a deep descendant, so walk the first-child
          * chain to the node that owns the destination link and name it.
-         * The destination href may live on this anchor (parent-only topics do
-         * not copy it onto the parent node).
          */
         let destination = this.treeNode.children?.[0];
         while (destination?.redirectToChild) {
             destination = destination.children?.[0];
         }
-        const triggerHref = this.href || this.treeNode.link?.href;
-        return destination?.link?.href && destination.link.href === triggerHref
+        return destination?.link?.href === this.treeNode.link.href
             ? `${this.treeNode.label}, opens ${destination.label}`
             : null;
     }
@@ -106,11 +101,7 @@ export default class TreeTile extends LightningElement {
             "tile-root": this.isRoot,
             "tile-with-children": !this.isRoot && this.hasChildren,
             "tile-root-with-child": this.isRoot && this.showArrow,
-            "sidebar-item-selected":
-                this.isSelected && !this.isContainedSelection,
-            "sidebar-item-selected-text":
-                this.isSelected && this.isContainedSelection,
-            "tile-with-version-picker": this.hasVersionPicker
+            "sidebar-item-selected": this.isSelected
         });
     }
 

package/src/modules/dx/typeBadge/typeBadge.ts

@@ -7,7 +7,6 @@ import {
     IconSprite,
     IconData,
     IconSymbol,
-    StatusBadgeVariant,
     TypeBadgeSize
 } from "typings/custom";
 import { colorToDxColors, buildStyleColorVariables } from "dxUtils/css";
@@ -21,16 +20,9 @@ import {
     getContentTypeColorVariables
 } from "dxUtils/contentTypes";
 
-// Opt-in solid status variants (status-success/-warning/-error).
-export const STATUS_BADGE_VARIANTS: StatusBadgeVariant[] = [
-    "status-success",
-    "status-warning",
-    "status-error"
-];
-
 export default class TypeBadge extends LightningElement {
     @api size: TypeBadgeSize = "default";
-    @api variant: Brand | ContentType | StatusBadgeVariant = "default";
+    @api variant: Brand | ContentType = "default";
     @api color?: Color;
     @api dark?: false;
 
@@ -95,24 +87,11 @@ export default class TypeBadge extends LightningElement {
         return isContentType(this.variant);
     }
 
-    private get isStatus(): boolean {
-        return STATUS_BADGE_VARIANTS.includes(
-            this.variant as StatusBadgeVariant
-        );
-    }
-
     private get className(): string {
-        return cx(
-            "dx-badge",
-            `size-${this.size}`,
-            this.isStatus && this.variant
-        );
+        return cx("dx-badge", `size-${this.size}`);
     }
 
     private get style(): string {
-        if (this.isStatus) {
-            return "";
-        }
         if (this.dark) {
             return buildStyleColorVariables({
                 background: "--dx-g-purple-vibrant-40",

package/src/modules/dxBaseElements/headerBase/headerBase.ts

@@ -155,7 +155,12 @@ export abstract class HeaderBase extends LightningElement {
             setTimeout(() => {
                 const id = hash.replace("#", "");
                 const element = document.getElementById(id);
-                if (element && element.scrollIntoView) {
+                // doc-heading targets are scrolled by doc-content-layout once the page has rendered
+                if (
+                    element &&
+                    element.tagName !== "DOC-HEADING" &&
+                    element.scrollIntoView
+                ) {
                     element.scrollIntoView();
                 }
             }, 0);

package/src/modules/dxHelpers/commonSidebar/commonSidebar.css

@@ -11,7 +11,7 @@
     --dx-c-sidebar-button-border-hover: var(--dx-g-blue-vibrant-50);
     --dx-c-sidebar-left-padding: var(--dx-g-global-header-padding-horizontal);
     --dx-c-sidebar-vertical-padding: var(--dx-g-spacing-md);
-    --dx-version-picker-width: 296px;
+    --doc-version-picker-width: 296px;
 }
 
 .header {
@@ -170,9 +170,9 @@
     margin-bottom: var(--dx-g-spacing-2xl);
 }
 
-@media screen and (max-width: 768px) {
+@media screen and (max-width: 767px) {
     :host {
-        --dx-version-picker-width: calc(
+        --doc-version-picker-width: calc(
             100vw - var(--dx-c-sidebar-left-padding) - var(--dx-g-spacing-lg)
         );
     }

package/src/modules/dxHelpers/commonTreeItem/commonTreeItem.css

@@ -13,10 +13,6 @@
     color: var(--dx-g-blue-vibrant-40) !important;
 }
 
-.sidebar-item-selected-text {
-    color: var(--dx-g-blue-vibrant-40) !important;
-}
-
 .sidebar-item {
     padding: 6px var(--dx-g-spacing-lg) 6px
         var(--dx-g-global-header-padding-horizontal);

package/src/modules/dxHelpers/typeBadge/typeBadge.css

@@ -26,28 +26,6 @@
     --height: var(--dx-g-spacing-mlg);
 }
 
-.dx-badge.status-success,
-.dx-badge.status-warning,
-.dx-badge.status-error {
-    /* No spacing token maps to 10px; status badges need this exact padding. */
-    --horizontal-spacing: 10px;
-}
-
-.dx-badge.status-success {
-    --color: var(--sds-g-gray-1);
-    --background: var(--dx-g-green-vibrant-50);
-}
-
-.dx-badge.status-warning {
-    --color: var(--dx-g-gray-15);
-    --background: var(--dx-g-yellow-vibrant-80);
-}
-
-.dx-badge.status-error {
-    --color: var(--sds-g-gray-1);
-    --background: var(--dx-g-red-vibrant-40);
-}
-
 svg,
 dx-icon {
     margin-right: var(--dx-g-spacing-sm);