@salesforcedevs/dx-components 1.39.0-alpha1 → 1.40.0-docs-feedback

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforcedevs/dx-components",
-  "version": "1.39.0-alpha1",
+  "version": "1.40.0-docs-feedback",
   "description": "DX Lightning web components",
   "license": "MIT",
   "engines": {
@@ -44,5 +44,5 @@
     "luxon": "3.4.4",
     "msw": "^2.12.4"
   },
-  "stableVersion": "1.39.0"
+  "stableVersion": "1.40.0"
 }

package/src/modules/dx/footer/footer.ts

@@ -103,9 +103,7 @@ class Footer extends LightningElement {
 // This encapsulates the old non-MFE footer functionality that should be removed once the footer MFE supports rendering in non-full-width contexts.
 // It's encapsulated like this solely for ease of deletion later.
 function augmentWithNonMFEFooterFunctionality(FooterClass: typeof Footer) {
-    // Prefix with the deploy asset base path (e.g. "/PR-123"); empty in local dev.
-    const assetBasePath = (globalThis as any)?.LWR?.env?.assetBasePath || "";
-    const baseSocialIconUrl = `${assetBasePath}/assets/icons/brand-sprite/svg/symbols.svg`;
+    const baseSocialIconUrl = `/assets/icons/brand-sprite/svg/symbols.svg`;
 
     return class NonMFEFooter extends FooterClass {
         private didRequestFooterConfig = false;

package/src/modules/dx/icon/icon.ts

@@ -40,10 +40,7 @@ export default class Icon extends LightningElement {
     }
 
     private get assetUrl() {
-        // Prefix with the deploy asset base path (e.g. "/PR-123") so icons resolve
-        // when the site is served under a sub-path. Empty in local dev, so no-op there.
-        const assetBasePath = (globalThis as any)?.LWR?.env?.assetBasePath || "";
-        return `${assetBasePath}/assets/icons/${this.sprite}-sprite/svg/symbols.svg`;
+        return `/assets/icons/${this.sprite}-sprite/svg/symbols.svg`;
     }
 
     private get href() {

package/src/modules/dx/searchResults/resultsTemplate.js

@@ -5,9 +5,6 @@
 */
 const html = String.raw;
 
-// Prefix hardcoded asset URLs with the deploy asset base path (e.g. "/PR-123"); empty in local dev.
-const assetBasePath = (globalThis && globalThis.LWR && globalThis.LWR.env && globalThis.LWR.env.assetBasePath) || "";
-
 export default html`
     <div class="coveo-show-if-no-results">
         <div class="no-results">
@@ -73,7 +70,7 @@ export default html`
                 >
                     <%- title %>
                     <% if (!raw.uri.includes('developer.salesforce.com') && !raw.uri.includes('developer-website-s.herokuapp.com')) { %>
-                        <svg xmlns="http://www.w3.org/2000/svg" style="display: inline; vertical-align: baseline;" fill="var(--dx-g-blue-vibrant-20)" width="20" height="20" part="svg" aria-hidden="true"><use xlink:href="${assetBasePath}/assets/icons/utility-sprite/svg/symbols.svg#new_window"></use></svg>
+                        <svg xmlns="http://www.w3.org/2000/svg" style="display: inline; vertical-align: baseline;" fill="var(--dx-g-blue-vibrant-20)" width="20" height="20" part="svg" aria-hidden="true"><use xlink:href="/assets/icons/utility-sprite/svg/symbols.svg#new_window"></use></svg>
                     <% } %>
                 </a>
                 <span class="CoveoFieldValue" data-field="@sflastmodifieddate" data-helper="postedDate" data-html-value="true"></span>
@@ -124,7 +121,7 @@ export default html`
                         <%- uri %>
                     <% } %>
                     <% if (!raw.uri.includes('developer.salesforce.com') && !raw.uri.includes('developer-website-s.herokuapp.com')) { %>
-                            <svg xmlns="http://www.w3.org/2000/svg" style="display: inline; vertical-align: baseline;" fill="var(--dx-g-blue-vibrant-20)" width="20" height="20" part="svg" aria-hidden="true"><use xlink:href="${assetBasePath}/assets/icons/utility-sprite/svg/symbols.svg#new_window"></use></svg>
+                            <svg xmlns="http://www.w3.org/2000/svg" style="display: inline; vertical-align: baseline;" fill="var(--dx-g-blue-vibrant-20)" width="20" height="20" part="svg" aria-hidden="true"><use xlink:href="/assets/icons/utility-sprite/svg/symbols.svg#new_window"></use></svg>
                     <% } %>
                 </a>
                 <span class="CoveoFieldValue" data-field="@sflastmodifieddate" data-helper="postedDate" data-html-value="true"></span>

package/src/modules/dx/searchResults/searchResults.ts

@@ -54,8 +54,6 @@ const buildTemplateHelperBadge = (value: keyof typeof CONTENT_TYPE_LABELS) => {
     const style = getContentTypeColorVariables(value);
     const label = CONTENT_TYPE_LABELS[value];
     const { iconSprite, iconSymbol } = CONTENT_TYPE_ICONS[value];
-    // Prefix with the deploy asset base path (e.g. "/PR-123"); empty in local dev.
-    const assetBasePath = (globalThis as any)?.LWR?.env?.assetBasePath || "";
     return `
             <div style="${style}" class="dx-badge">
                 <svg

package/src/modules/dx/sidebarOld/sidebarOld.html

@@ -30,7 +30,6 @@
                     <div class="header-wrapper">
                         <div lwc:if={devCenter} class="link-row">
                             <a href={devCenter.link}>
-                                <dx-icon symbol="back"></dx-icon>
                                 <dx-icon
                                     class="brand-icon"
                                     lwc:if={devCenter.icon}

package/src/modules/dx/sidebarSearch/sidebarSearch.ts

@@ -317,12 +317,9 @@ export default class SidebarSearch extends LightningElement {
 
         // discussion about this normalization here: https://salesforce-internal.slack.com/archives/C020S6784JX/p1639506238376600
 
-        // Deploy base path (e.g. "/PR-123"); empty in local dev. window.location.pathname
-        // is served under this prefix, so route hrefs and comparisons must include it.
-        const basePath = (globalThis as any)?.LWR?.env?.basePath || "";
         let pathname, queryParam;
         if (sfhtml_url__c) {
-            pathname = `${basePath}/docs/${sfhtml_url__c}`;
+            pathname = `/docs/${sfhtml_url__c}`;
         } else {
             const isNestedGuide = clickUri.includes("/guide/");
             const url = new URL(clickUri);

package/src/modules/dx/treeItem/treeItem.ts

@@ -49,6 +49,16 @@ export default class TreeItem extends LightningElement {
         return this.hasChildren || this.isChildrenLoading;
     }
 
+    private get isContentlessParent(): boolean {
+        const href = this._treeNode?.link?.href;
+        return (
+            this.isParent &&
+            !!href &&
+            !this.isExternalLink &&
+            href !== this._treeNode.name
+        );
+    }
+
     private get showChildren(): boolean {
         return this.isExpanded && this.hasChildren;
     }
@@ -140,6 +150,15 @@ export default class TreeItem extends LightningElement {
     private onLinkClick(event: Event): void {
         this.preventDefaultLinkBehavior(event);
 
+        /**
+         * For Docs content-type only redirect, content-less parents to their first content child.
+         * Let navigation handle selection and ancestor expansion to avoid flicker.
+         */
+        if (this.isContentlessParent) {
+            this.sendGtm(event);
+            return;
+        }
+
         if (this.isParent) {
             const isSelectAction = true;
             this.doExpand(isSelectAction);