@salesforcedevs/dx-components 1.18.9-add-scroll → 1.18.9-rnb-scroll1

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@salesforcedevs/dx-components",
-    "version": "1.18.9-add-scroll",
+    "version": "1.18.9-rnb-scroll1",
     "description": "DX Lightning web components",
     "license": "MIT",
     "engines": {

package/src/modules/dx/sidebar/sidebar.ts

@@ -5,13 +5,10 @@ import { getSidebarSearchParams } from "dxUtils/coveo";
 import { toJson } from "dxUtils/normalizers";
 import SidebarSearch from "dx/sidebarSearch";
 import { SidebarBase } from "dxBaseElements/sidebarBase";
-import { handleScroll } from 'dxUtils/handleScroll';
 
 const MOBILE_SIZE_MATCH = "768px";
 
 export default class Sidebar extends SidebarBase {
-    handleScroll: (e: any) => void = () => {};
-
     @api coveoOrganizationId!: string;
     @api coveoPublicAccessToken!: string;
     @api coveoSearchHub!: string;
@@ -145,8 +142,6 @@ export default class Sidebar extends SidebarBase {
     }
 
     connectedCallback() {
-        this.handleScroll = handleScroll.bind(this);
-
         this.matchMedia = window.matchMedia(
             `(max-width: ${MOBILE_SIZE_MATCH})`
         );

package/src/modules/dx/toc/toc.css

@@ -30,7 +30,7 @@
 }
 
 .toc-content-header[show-shadow="true"] {
-    box-shadow: 0 4px 2px -2px var(--dx-g-gray-90);
+    box-shadow: 0 4px 4px -2px var(--dx-g-gray-90);
 }
 
 .toc-content-header[show-shadow="true"] .toc_title {

package/src/modules/dx/toc/toc.ts

@@ -7,8 +7,7 @@ import { handleScroll } from 'dxUtils/handleScroll';
 
 export default class Toc extends LightningElement {
     showBoxShadow: boolean = false;
-    private scrolling: boolean = false;
-    handleScroll: (e: any) => void = () => {};
+    handleScroll = handleScroll.bind(this);
 
     @api header!: string;
 
@@ -43,10 +42,6 @@ export default class Toc extends LightningElement {
 
     @track _options!: Array<ContentElement>;
 
-    connectedCallback() {
-        this.handleScroll = handleScroll.bind(this);
-    }
-
     private onClick(e: Event) {
         const target = e.currentTarget as HTMLElement;
         const id = target.getAttribute("contentid");

package/src/modules/dxBaseElements/sidebarBase/sidebarBase.ts

@@ -2,12 +2,14 @@ import { LightningElement, api } from "lwc";
 import type { OptionWithLink } from "typings/custom";
 import { toJson } from "dxUtils/normalizers";
 import { Brand, DevCenterConfig } from "typings/custom";
+import { handleScroll } from 'dxUtils/handleScroll';
 
 export const HEIGHT_OF_SIDEBAR_ITEM = 32;
 export const WAIT_TIME_BEFORE_SCROLL_IN_MS = 500;
 
 export class SidebarBase extends LightningElement {
     _sidebarContent: HTMLElement | null = null;
+    handleScroll = handleScroll.bind(this);
 
     selectedElement: HTMLElement | null = null;
     timerId: ReturnType<typeof setTimeout> | null = null;
@@ -16,7 +18,6 @@ export class SidebarBase extends LightningElement {
     expanded: boolean = true;
     _value?: string = undefined;
     showBoxShadow: boolean = false;
-    private scrolling: boolean = false;
     _devCenter!: DevCenterConfig;
 
     @api langValuePath: string = "id";

package/src/modules/dxUtils/handleScroll/handleScroll.ts

@@ -1,5 +1,4 @@
 export function handleScroll(this: any, scrollEvent: any) {
-  console.log('calling')
   const list = scrollEvent.target;
   
   setTimeout(() => {