@salesforcedevs/dx-components 0.43.3-tree-selected-scroll-3 → 0.43.3-tree-selected-scroll-4

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@salesforcedevs/dx-components",
-    "version": "0.43.3-tree-selected-scroll-3",
+    "version": "0.43.3-tree-selected-scroll-4",
     "description": "DX Lightning web components",
     "license": "MIT",
     "engines": {

package/src/modules/base-elements/sidebarBase/sidebarBase.ts

@@ -4,9 +4,6 @@ export const HEIGHT_OF_SIDEBAR_ITEM = 32;
 
 export class SidebarBase extends LightningElement {
     _sidebarContent: HTMLElement | null = null;
-    private selectedTreeItem: HTMLElement | null = null;
-    private isSidebarRendered = false;
-
     get sidebarContent() {
         if (!this._sidebarContent) {
             this._sidebarContent = this.template.querySelector(
@@ -16,19 +13,13 @@ export class SidebarBase extends LightningElement {
         return this._sidebarContent;
     }
 
+    /*Scroll to selected tree item */
     private onSelectedItemRendered(event: CustomEvent) {
         event.stopPropagation();
-        this.selectedTreeItem = event.detail.element;
-        if (this.isSidebarRendered) {
-            this.scrollToSelectedItem();
-        }
-    }
-
-    /*Scroll to selected tree item */
-    private scrollToSelectedItem(): void {
-        if (this.selectedTreeItem && this.sidebarContent) {
+        const selectedTreeItem = event.detail.element;
+        if (selectedTreeItem && this.sidebarContent) {
             const scrollHeight: number =
-                this.selectedTreeItem.getBoundingClientRect().bottom -
+                selectedTreeItem.getBoundingClientRect().bottom -
                 this.sidebarContent.getBoundingClientRect().bottom + // We need to remove parent bottom
                 HEIGHT_OF_SIDEBAR_ITEM * 3; // add height of 3 more items so that user can see at least three more items after selected item
             this.sidebarContent.scrollTo({
@@ -36,11 +27,5 @@ export class SidebarBase extends LightningElement {
                 behavior: "smooth"
             });
         }
-        this.selectedTreeItem = null;
-    }
-
-    renderedCallback(): void {
-        this.isSidebarRendered = true;
-        this.scrollToSelectedItem();
     }
 }

package/src/modules/dx/sidebar/sidebar.ts

@@ -145,7 +145,6 @@ export default class Sidebar extends SidebarBase {
     }
 
     renderedCallback() {
-        super.renderedCallback()
         this.initializeSearchScrollPosition();
     }
 

package/src/modules/dx/sidebarOld/sidebarOld.ts

@@ -81,10 +81,6 @@ export default class Sidebar extends SidebarBase {
         this.matchMedia.addEventListener("change", this.onMediaChange);
     }
 
-    renderedCallback(): void {
-        super.renderedCallback();
-    }
-
     disconnectedCallback() {
         this.matchMedia.removeEventListener("change", this.onMediaChange);
     }