@salesforcedevs/dx-components 0.16.3 → 0.17.1-review-diff1

package/src/modules/dx/dropdown/__tests__/dropdown.test.ts

@@ -1,172 +0,0 @@
-import Dropdown from "dx/dropdown";
-import DropdownOption from "dx/dropdownOption";
-import Popover from "dx/popover";
-import { getOptionsCount } from "utils/options";
-import { createRenderComponent } from "utils/tests";
-import mockNestedOptions from "./mockNestedOptions";
-import mockProps from "./mockProps";
-
-const TAG = "dx-dropdown";
-const render = createRenderComponent(TAG, Dropdown);
-
-describe(TAG, () => {
-    describe("render", () => {
-        it("renders all options when open", () => {
-            const component = render({ ...mockProps, open: true });
-
-            const menuDiv: HTMLElement = component.shadowRoot.querySelector(
-                ".menu_list"
-            );
-            expect(menuDiv).not.toBeNull();
-            expect(menuDiv.getAttribute("role")).toBe("menu");
-
-            const options = component.shadowRoot.querySelectorAll(
-                "dx-dropdown-option"
-            );
-            expect(options.length).toEqual(mockProps.options.length);
-            return expect(component).toBeAccessible();
-        });
-
-        it("renders all nested options and the callout link when open", () => {
-            const component = render({
-                ...mockProps,
-                options: mockNestedOptions,
-                open: true
-            });
-
-            const options: Array<DropdownOption> = Array.from(
-                component.shadowRoot.querySelectorAll("dx-dropdown-option")
-            );
-            const link = component.shadowRoot.querySelector(".callout_link");
-            const count = getOptionsCount(mockNestedOptions);
-            expect(options.length).toEqual(count);
-
-            options.forEach(({ keyValue, option }) => {
-                expect(keyValue).not.toBeFalsy();
-                expect(keyValue).toBe(option.id);
-            });
-            expect(link).not.toBeNull();
-            return expect(component).toBeAccessible();
-        });
-
-        it("value prop activates the selected option", () => {
-            const component = render({ ...mockProps, open: true });
-            const options = Array.from(
-                component.shadowRoot.querySelectorAll("dx-dropdown-option")
-            );
-            const selectedOption = options.find(
-                // @ts-ignore
-                (option: HTMLElement) => option.active === true
-            );
-            // @ts-ignore
-            const id = selectedOption.option.id;
-            expect(id).toEqual(mockProps.value);
-            return expect(component).toBeAccessible();
-        });
-
-        it("renders with menu-offset-small and menu-hidden", () => {
-            const component = render({ offset: "small", options: [] });
-            const popover: Popover = component.shadowRoot.querySelector(
-                "dx-popover"
-            );
-            expect(popover).not.toBeNull();
-
-            expect(popover.classList).toContain("menu-offset-small");
-            expect(popover.classList).toContain("menu-hidden");
-
-            const options = component.shadowRoot.querySelectorAll(
-                "dx-dropdown-option"
-            );
-            expect(options).toHaveLength(0);
-
-            return expect(component).toBeAccessible();
-        });
-    });
-
-    describe("interactions", () => {
-        it("doesn't close after onchange when stayOpenAfterChange is true", async () => {
-            const component = render({
-                ...mockProps,
-                stayOpenAfterChange: true,
-                open: true
-            });
-            const mockClose = jest.fn();
-
-            const popover = component.shadowRoot.querySelector("dx-popover");
-            popover.addEventListener("close", mockClose);
-
-            const option = component.shadowRoot.querySelector(
-                "dx-dropdown-option"
-            );
-            const id = option.option.id;
-            option.dispatchEvent(new CustomEvent("select", { detail: id }));
-
-            expect(mockClose).not.toHaveBeenCalled();
-            expect(component.open).toEqual(true);
-
-            return expect(component).toBeAccessible();
-        });
-
-        it("closes after onchange when stayOpenAfterChange is false", async () => {
-            const component = render({
-                ...mockProps,
-                open: true
-            });
-            const mockClose = jest.fn();
-
-            const popover = component.shadowRoot.querySelector("dx-popover");
-            popover.addEventListener("close", mockClose);
-
-            const option: DropdownOption = component.shadowRoot.querySelector(
-                "dx-dropdown-option"
-            );
-            const id = option.option.id;
-            option.dispatchEvent(new CustomEvent("select", { detail: id }));
-
-            expect(mockClose).toHaveBeenCalledTimes(1);
-            return expect(component).toBeAccessible();
-        });
-
-        it("handles keydown event with ArrowDown key", () => {
-            const [firstOption] = mockProps.options;
-            const component = render({ ...mockProps, value: null, open: true });
-            expect(component.focusedValue).toBeNull();
-
-            component.dispatchEvent(
-                new KeyboardEvent("keydown", { key: "ArrowDown" })
-            );
-            expect(component.focusedValue).toBe(firstOption.id);
-        });
-
-        it("ignores other click keys", () => {
-            const component = render({ ...mockProps, open: true });
-
-            component.dispatchEvent(
-                new KeyboardEvent("keydown", { key: "ArrowDown" })
-            );
-            expect(component.focusedValue).toBe(mockProps.value);
-
-            component.dispatchEvent(
-                new KeyboardEvent("keydown", { key: "ArrowLeft" })
-            );
-
-            expect(component.focusedValue).toBe(mockProps.value);
-        });
-
-        it("handles close event from popover", () => {
-            const component = render({ ...mockProps, open: true });
-
-            component.dispatchEvent(
-                new KeyboardEvent("keydown", { key: "ArrowDown" })
-            );
-            expect(component.focusedValue).toBe(mockProps.value);
-
-            const popover: HTMLElement = component.shadowRoot.querySelector(
-                "dx-popover"
-            );
-            expect(popover).not.toBeNull();
-            popover.dispatchEvent(new CustomEvent("close"));
-            expect(component.focusedValue).toBeNull();
-        });
-    });
-});

package/src/modules/dx/dropdown/__tests__/mockNestedOptions.ts

@@ -1,96 +0,0 @@
-export default [
-    {
-        label: "Products",
-        id: "brands",
-        calloutLink: {
-            href: "www.google.com",
-            target: "_blank",
-            label: "View all Products"
-        },
-        options: [
-            {
-                label: "Heroku",
-                id: "heroku",
-                iconSymbol: "heroku",
-                iconSprite: "salesforcebrand"
-            },
-            {
-                label: "Tableau",
-                id: "tableau",
-                iconSymbol: "analytics",
-                iconSprite: "salesforcebrand"
-            },
-            {
-                label: "Quip",
-                id: "quip",
-                iconSymbol: "collaboration",
-                iconSprite: "salesforcebrand"
-            },
-            {
-                label: "MuleSoft",
-                id: "mulesoft",
-                iconSymbol: "integration",
-                iconSprite: "salesforcebrand"
-            }
-        ]
-    },
-    {
-        label: "Platform",
-        id: "platform",
-        options: [
-            {
-                label: "Apex",
-                id: "apex"
-            },
-            {
-                label: "Lightning Web Components",
-                id: "LWC"
-            },
-            {
-                label: "Mobile",
-                id: "mobile"
-            },
-            {
-                label: "Apex Other",
-                id: "apex2"
-            },
-            {
-                label: "Lightning Web Runtime",
-                id: "LWR"
-            },
-            {
-                label: "Apex Legends",
-                id: "legends"
-            },
-            {
-                label: "Einstein",
-                id: "einstein"
-            },
-            {
-                label: "Mobile SDK",
-                id: "mobilesdk"
-            }
-        ]
-    },
-    {
-        label: "Sandwich",
-        id: "sandwich",
-        options: [
-            {
-                label: "Bread",
-                description: "Lets get this bread.",
-                id: "bread"
-            },
-            {
-                label: "Peanut Butter",
-                description: "This is tasty PB.",
-                id: "pb"
-            },
-            {
-                label: "Jelly",
-                description: "This is jelly, maybe grape jelly.",
-                id: "jelly"
-            }
-        ]
-    }
-];

package/src/modules/dx/dropdown/__tests__/mockOptions.ts

@@ -1,10 +0,0 @@
-export default [
-    { label: "Banana", id: "banana" },
-    { label: "Orange", id: "orange" },
-    { label: "Potato", id: "potato" },
-    { label: "Shoe", id: "shoe" },
-    { label: "Broom", id: "broom" },
-    { label: "Spaghetti", id: "spaghetti" },
-    { label: "Tater Tot", id: "tater" },
-    { label: "Lint", id: "lint" }
-];

package/src/modules/dx/dropdown/__tests__/mockProps.ts

@@ -1,6 +0,0 @@
-import mockOptions from "./mockOptions";
-
-export default {
-    value: "potato",
-    options: mockOptions
-};

package/src/modules/dx/dropdown/dropdown.stories.ts

@@ -1,89 +0,0 @@
-import { html } from "lit-html";
-import mockOptions from "./__tests__/mockOptions";
-import mockNestedOptions from "./__tests__/mockNestedOptions";
-
-export default {
-    title: "dx/dx-dropdown",
-    component: "dx-dropdown"
-};
-
-const options = JSON.stringify(mockOptions);
-const nestedOptions = JSON.stringify(mockNestedOptions);
-const nestedOptionsTwoItems = JSON.stringify(mockNestedOptions.slice(0, 2));
-
-// prettier-ignore
-const styles = () => html`
-    <style>
-        #root {
-            display: grid;
-            grid-template-columns: repeat(3, 1fr);
-            grid-gap: 20px;
-            justify-items: center;
-        }
-    </style>
-`;
-
-// prettier-ignore
-export const Base = () => html`
-    ${styles()}
-    <dx-dropdown options="${options}">
-        <dx-button icon-symbol="chevrondown">
-            Default
-        </dx-button>
-    </dx-dropdown>
-
-    <br />
-
-    <dx-dropdown stay-open-after-change="true" options="${options}">
-        <dx-button icon-symbol="chevrondown">
-            Stay Open After Change
-        </dx-button>
-    </dx-dropdown>
-
-    <br />
-
-    <dx-dropdown
-        options="${nestedOptions}"
-        placement="bottom"
-        offset="medium"
-    >
-        <dx-button icon-symbol="chevrondown">
-            Nested Options
-        </dx-button>
-    </dx-dropdown>
-
-    <br />
-
-    <dx-dropdown
-        options="${nestedOptionsTwoItems}"
-        placement="bottom"
-        offset="medium"
-    >
-        <dx-button icon-symbol="chevrondown">
-            Nested Options 2 Items
-        </dx-button>
-    </dx-dropdown>
-
-    <br />
-
-    <dx-dropdown
-        options="${nestedOptionsTwoItems}"
-        placement="bottom"
-        offset="medium"
-        open-on-hover="true"
-        stay-open-after-change="true"
-    >
-        <dx-button icon-symbol="chevrondown">
-            Hover Me
-        </dx-button>
-    </dx-dropdown>
-`;
-
-export const DisabledControl = () => html`
-    ${styles()}
-    <dx-dropdown options="${options}">
-        <dx-button icon-symbol="chevrondown" disabled="true">
-            I'm disabled
-        </dx-button>
-    </dx-dropdown>
-`;

package/src/modules/dx/dropdownOption/__tests__/dropdownOption.test.ts

@@ -1,112 +0,0 @@
-import DropdownOption from "dx/dropdownOption";
-import { createRenderComponent } from "utils/tests";
-import { MOCK_BUTTON_PROPS, MOCK_LINK_PROPS } from "./mockProps";
-import * as instrumentation from "dx/instrumentation";
-
-const TAG = "dx-dropdown-option";
-const render = createRenderComponent(TAG, DropdownOption);
-
-const appendToMenu = (element: HTMLElement) => {
-    const menu = document.createElement("DIV");
-    document.body.appendChild(menu);
-    menu.setAttribute("role", "menu");
-    menu.appendChild(element);
-};
-
-describe(TAG, () => {
-    beforeEach(() => {
-        jest.clearAllMocks();
-    });
-
-    it("renders a button by default", () => {
-        const component = render(MOCK_BUTTON_PROPS);
-        expect(component.shadowRoot.querySelector("button")).not.toBeNull();
-
-        appendToMenu(component);
-        return expect(component).toBeAccessible();
-    });
-
-    it("renders the correct label, description, and img", () => {
-        const component = render(MOCK_BUTTON_PROPS);
-        const label =
-            component.shadowRoot.querySelector(".option_label").textContent;
-        expect(label).toEqual(MOCK_BUTTON_PROPS.option.label);
-
-        const description = component.shadowRoot.querySelector(
-            ".option_description"
-        ).textContent;
-        expect(description).toEqual(MOCK_BUTTON_PROPS.option.description);
-
-        const img = component.shadowRoot.querySelector(".option_icon");
-        expect(img).not.toBeNull();
-
-        appendToMenu(component);
-        return expect(component).toBeAccessible();
-    });
-
-    it("renders a link with the correct href when given link props", () => {
-        const component = render(MOCK_LINK_PROPS);
-
-        const href = component.shadowRoot
-            .querySelector("a")
-            .getAttribute("href");
-        expect(href).toEqual(MOCK_LINK_PROPS.option.link.href);
-
-        appendToMenu(component);
-        return expect(component).toBeAccessible();
-    });
-
-    it("applies the active class correctly", () => {
-        const component = render({ ...MOCK_BUTTON_PROPS, active: true });
-        const optionEl = component.shadowRoot.querySelector(".option-active");
-        expect(optionEl).not.toBeNull();
-
-        appendToMenu(component);
-        return expect(component).toBeAccessible();
-    });
-
-    it("can focus itself", () => {
-        const component = render(MOCK_BUTTON_PROPS);
-        component.focus();
-
-        expect(document.activeElement).toEqual(component);
-    });
-
-    it("onClick function is fired when button is clicked", () => {
-        const onClickMock = jest.fn();
-        const component = render({
-            ...MOCK_BUTTON_PROPS,
-            onclick: onClickMock
-        });
-
-        const option = component.shadowRoot.querySelector(".option");
-        option.click();
-
-        expect(onClickMock).toBeCalled();
-    });
-
-    it("fires analytics when given an analytics event", () => {
-        const track = jest.spyOn(instrumentation, "track");
-
-        const component = render({
-            ...MOCK_BUTTON_PROPS,
-            analyticsEvent: "mock"
-        });
-
-        const option = component.shadowRoot.querySelector(".option");
-        option.click();
-
-        expect(track).toHaveBeenCalledTimes(1);
-    });
-
-    it("doesn't fire analytics when not given an analytics event", () => {
-        const track = jest.spyOn(instrumentation, "track");
-
-        const component = render(MOCK_BUTTON_PROPS);
-
-        const option = component.shadowRoot.querySelector(".option");
-        option.click();
-
-        expect(track).not.toHaveBeenCalled();
-    });
-});

package/src/modules/dx/dropdownOption/__tests__/mockProps.ts

@@ -1,20 +0,0 @@
-export const MOCK_BUTTON_PROPS = {
-    option: {
-        id: "documentation",
-        label: "Documentation",
-        description: "Documentation is kewl",
-        iconSymbol: "heroku",
-        iconSprite: "salesforcebrand"
-    }
-};
-
-export const MOCK_LINK_PROPS = {
-    option: {
-        id: "documentation",
-        label: "Documentation",
-        link: {
-            href: "/documentation",
-            target: null
-        }
-    }
-};

package/src/modules/dx/emptyState/__tests__/emptyState.test.ts

@@ -1,52 +0,0 @@
-import EmptyState from "dx/emptyState";
-import { createRenderComponent } from "utils/tests";
-import mockProps from "./mockProps";
-
-const TAG = "dx-empty-state";
-const render = createRenderComponent(TAG, EmptyState);
-
-describe(TAG, () => {
-    it("renders", () => {
-        const element = render(mockProps);
-        const container: HTMLElement =
-            element.shadowRoot.querySelector(".container");
-        const renderedTitle: HTMLElement =
-            element.shadowRoot.querySelector("h3");
-        const renderedSubTitle: HTMLElement =
-            element.shadowRoot.querySelector("p");
-        const image: HTMLImageElement = element.shadowRoot.querySelector("img");
-
-        expect(renderedTitle).not.toBeNull();
-        expect(renderedSubTitle).not.toBeNull();
-        expect(container).not.toBeNull();
-        expect(image).not.toBeNull();
-
-        expect(renderedSubTitle.textContent).toEqual(mockProps.subtitle);
-        expect(renderedTitle.textContent).toEqual(mockProps.title);
-
-        return expect(element).toBeAccessible();
-    });
-
-    it("renders as the large variant by default", () => {
-        const element = render(mockProps);
-        const container: HTMLElement =
-            element.shadowRoot.querySelector(".container");
-        const image: HTMLImageElement = element.shadowRoot.querySelector("img");
-        expect(container.classList).toContain("size-large");
-        expect(container.classList).toHaveLength(2);
-        expect(image.src).not.toContain("-small.svg");
-    });
-
-    it("renders as the small variant when specified", () => {
-        const element = render({
-            ...mockProps,
-            size: "small"
-        });
-        const container: HTMLElement =
-            element.shadowRoot.querySelector(".container");
-        const image: HTMLImageElement = element.shadowRoot.querySelector("img");
-        expect(container.classList).toContain("size-small");
-        expect(container.classList).toHaveLength(2);
-        expect(image.src).toContain("-small.svg");
-    });
-});

package/src/modules/dx/emptyState/__tests__/mockProps.ts

@@ -1,4 +0,0 @@
-export default {
-    title: "No matches",
-    subtitle: "Try searching for different words"
-};

package/src/modules/dx/emptyState/emptyState.stories.ts

@@ -1,45 +0,0 @@
-import { html } from "lit-html";
-
-export default {
-    title: "dx/dx-empty-state",
-    component: "dx-empty-state"
-};
-
-const createStyles = () => html`
-    <style>
-        body {
-            padding: 12px !important;
-        }
-        .title {
-            font-weight: bold;
-            margin: 24px;
-        }
-        #styled {
-            --dx-c-empty-state-background: var(--sds-g-gray-2);
-            --dx-c-empty-state-image-width: 400px;
-            width: 300px;
-            display: block;
-        }
-        .small-container {
-            width: 250px;
-        }
-    </style>
-`;
-
-const title = (value: string) => html`<p class="title">${value}</p>`;
-
-export const Base = () => html`
-    ${createStyles()} ${title("Default")}
-    <dx-empty-state
-        title="Beep boop. That did not compute."
-        subtitle="No results"
-    ></dx-empty-state>
-
-    ${title("No subtitle and customized with style hooks")}
-    <dx-empty-state id="styled" title="No Results"></dx-empty-state>
-
-    ${title("Small variant")}
-    <div class="small-container">
-        <dx-empty-state title="No Results" size="small"></dx-empty-state>
-    </div>
-`;

package/src/modules/dx/feature/__tests__/feature.test.ts

@@ -1,50 +0,0 @@
-import Feature from "dx/feature";
-import { createRenderComponent } from "utils/tests";
-import mockProps from "./mockProps";
-
-const TAG = "dx-feature";
-const render = createRenderComponent(TAG, Feature);
-
-const dataCodeSample = {
-    title: "Redwoods Insurance",
-    label: "Featured Demo",
-    buttonHref: "https://github.com/trailheadapps/ebikes-lwc",
-    buttonLabel: "Explore on Github",
-    imageSrc: "https://d12fd6m9xo0jeo.cloudfront.net/0953ee82-173a-484d-b4f4-7467bce5e200.jpg",
-    isExternalLink: "true",
-    variant: "display"
-}
-
-describe(TAG, () => {
-    it("renders an accessible feature with description on the left by default", () => {
-        const element = render(mockProps);
-        const sectionEl = element.shadowRoot.querySelector("section");
-        expect(sectionEl).not.toBeNull();
-        expect(sectionEl.className).toBe("description-left");
-        expect(element.shadowRoot.querySelector(".image-container")).toBe(null);
-        return expect(sectionEl).toBeAccessible();
-    });
-
-    it("renders a feature with description on the rigth", () => {
-        const element = render(mockProps);
-        element.descriptionPosition = "right";
-        document.body.appendChild(element);
-        const sectionEl = element.shadowRoot.querySelector("section");
-        expect(sectionEl).not.toBeNull();
-        expect(sectionEl.className).toBe("description-right");
-        expect(element.shadowRoot.querySelector(".image-container")).toBe(null);
-        return expect(element).toBeAccessible();
-    });
-
-    it("renders a feature for code-samples", () => {
-        const element = render(dataCodeSample);
-        document.body.appendChild(element);
-        const sectionEl = element.shadowRoot.querySelector("section");
-        expect(sectionEl).not.toBeNull();
-        expect(sectionEl.className).toBe("description-left");
-        const imgContainer = element.shadowRoot.querySelector(".image-container");
-        expect(imgContainer).not.toBe(null);
-        return expect(element).toBeAccessible();
-    });
-
-});

package/src/modules/dx/feature/__tests__/mockProps.ts

@@ -1,8 +0,0 @@
-export default {
-    title: "Einstein Prediction Builder",
-    buttonHref: "https://lmgtfy.app",
-    buttonLabel: "Build a predictive app",
-    imageSrc: "https://i.imgur.com/FUsyxR5.jpg",
-    body:
-        "Build AI predictions into your <b>Salesforce</b> app for data stored in standard or custom objects using only clicks—then deploy and embed predictions onto any page in Salesforce."
-};