@salesforce/ui-bundle-template-feature-react-authentication 3.0.0 → 3.1.0

package/dist/force-app/main/default/uiBundles/feature-react-authentication/src/features/authentication/pages/ResetPassword.tsx

@@ -8,13 +8,13 @@ import { useAppForm } from "../hooks/form";
 import { createDataSDK } from "@salesforce/platform-sdk-data";
 import { ROUTES, AUTH_PLACEHOLDERS } from "../authenticationConfig";
 import { newPasswordSchema } from "../authHelpers";
-import { handleApiResponse, getErrorMessage } from "../utils/helpers";
+import { ApiError, handleApiResponse } from "../utils/helpers";
 
 export default function ResetPassword() {
 	const [searchParams] = useSearchParams();
 	const token = searchParams.get("token");
 	const [success, setSuccess] = useState(false);
-	const [submitError, setSubmitError] = useState<string | null>(null);
+	const [submitError, setSubmitError] = useState<React.ReactNode>(null);
 
 	const form = useAppForm({
 		defaultValues: { newPassword: "", confirmPassword: "" },
@@ -34,12 +34,27 @@ export default function ResetPassword() {
 						Accept: "application/json",
 					},
 				});
-				await handleApiResponse(response, "Password reset failed");
+				await handleApiResponse(response);
 				setSuccess(true);
 				// Scroll to top of page after successful submission so user sees it
 				window.scrollTo({ top: 0, behavior: "smooth" });
 			} catch (err) {
-				setSubmitError(getErrorMessage(err, "Password reset failed"));
+				console.error("Password reset failed", err);
+				if (err instanceof ApiError) {
+					setSubmitError(
+						err.errors.length === 1 ? (
+							err.errors[0]
+						) : (
+							<ul>
+								{err.errors.map((e, i) => (
+									<li key={i}>{e}</li>
+								))}
+							</ul>
+						),
+					);
+				} else {
+					setSubmitError("Password reset failed");
+				}
 			}
 		},
 		onSubmitInvalid: () => {},

package/dist/force-app/main/default/uiBundles/feature-react-authentication/src/features/authentication/utils/helpers.ts

@@ -1,29 +1,22 @@
 /**
- * MAINTAINABILITY: Robust error extraction.
- * Handles strings, objects, and standard Error instances.
- *
- * @param err - The error object (unknown type)
- * @param fallback - Fallback message if error doesn't have a message property
- * @returns The error message string
+ * Error thrown when the API returns a non-OK response with structured error messages.
+ * The `errors` array contains user-facing messages that are safe to display —
+ * backend Apex classes guarantee that system exceptions are never exposed.
  */
-export function getErrorMessage(err: unknown, fallback: string): string {
-	if (err instanceof Error) return err.message;
-	if (typeof err === "string") return err;
-	// Check if it's an object with a message property
-	if (typeof err === "object" && err !== null && "message" in err) {
-		return String((err as { message: unknown }).message);
+export class ApiError extends Error {
+	errors: string[];
+	constructor(errors: string[]) {
+		super(errors[0]);
+		this.name = "ApiError";
+		this.errors = errors;
 	}
-	return fallback;
 }
 
 /**
  * [Dev Note] Helper to parse the fetch Response.
  * It handles the distinction between success (JSON) and failure (throwing Error).
  */
-export async function handleApiResponse<T = unknown>(
-	response: Response,
-	fallbackError: string,
-): Promise<T> {
+export async function handleApiResponse<T = unknown>(response: Response): Promise<T> {
 	// 1. Robustness: Handle 204 No Content gracefully
 	if (response.status === 204) {
 		return {} as T;
@@ -41,9 +34,11 @@ export async function handleApiResponse<T = unknown>(
 	}
 
 	if (!response.ok) {
-		// [Dev Note] Throwing here allows the calling component to catch and
-		// display the error via getErrorMessage()
-		throw new Error(parseApiResponseError(data, fallbackError));
+		console.error("API request failed", data);
+		if (data?.errors?.length) {
+			throw new ApiError(data.errors);
+		}
+		throw new Error("An unexpected error occurred");
 	}
 
 	return data as T;
@@ -87,35 +82,3 @@ export function flattenGraphQLRecord<T>(
 		]),
 	) as T;
 }
-
-/**
- * [Dev Note] Salesforce APIs may return errors as an array or a single object.
- * This helper standardizes the extraction of the error message string.
- *
- * @param data - The response data.
- * @param fallbackError - Fallback error message if response doesn't have a message property
- * @returns The error message string
- */
-function parseApiResponseError(
-	data: any,
-	fallbackError: string = "An unknown error occurred",
-): string {
-	if (data?.message) {
-		return data.message;
-	}
-	if (data?.error) {
-		return data.error;
-	}
-	if (data?.errors && Array.isArray(data.errors) && data.errors.length > 0) {
-		return data.errors.join(" ") || fallbackError;
-	}
-	if (Array.isArray(data) && data.length > 0) {
-		return (
-			data
-				.map((e) => e?.message)
-				.filter(Boolean)
-				.join(" ") || fallbackError
-		);
-	}
-	return fallbackError;
-}

package/dist/force-app/main/default/uiBundles/feature-react-authentication/src/hooks/useAsyncData.ts

@@ -0,0 +1,67 @@
+import { useEffect, useRef, useState } from 'react';
+
+interface UseAsyncDataResult<T> {
+  data: T | null;
+  loading: boolean;
+  error: string | null;
+}
+
+/**
+ * Runs an async fetcher on mount and whenever `deps` change.
+ * Returns the loading/error/data state. Does not cache — every call
+ * to the fetcher hits the source directly.
+ *
+ * A cleanup flag prevents state updates if the component unmounts
+ * or deps change before the fetch completes (avoids React warnings
+ * and stale updates from out-of-order responses).
+ */
+export function useAsyncData<T>(
+  fetcher: () => Promise<T>,
+  deps: React.DependencyList
+): UseAsyncDataResult<T> {
+  const [data, setData] = useState<T | null>(null);
+  const [loading, setLoading] = useState(true);
+  const [error, setError] = useState<string | null>(null);
+  const [generation, setGeneration] = useState(0);
+
+  const fetcherRef = useRef(fetcher);
+  useEffect(() => {
+    fetcherRef.current = fetcher;
+  });
+
+  // Detect dep changes during render to reset loading state and bump generation
+  const [prevDeps, setPrevDeps] = useState(deps);
+  if (
+    deps.length !== prevDeps.length ||
+    deps.some((d, i) => d !== prevDeps[i])
+  ) {
+    setPrevDeps(deps);
+    setGeneration(g => g + 1);
+    if (!loading) setLoading(true);
+    if (error !== null) setError(null);
+  }
+
+  useEffect(() => {
+    let cancelled = false;
+
+    fetcherRef
+      .current()
+      .then(result => {
+        if (!cancelled) setData(result);
+      })
+      .catch(err => {
+        console.error(err);
+        if (!cancelled)
+          setError(err instanceof Error ? err.message : 'An error occurred');
+      })
+      .finally(() => {
+        if (!cancelled) setLoading(false);
+      });
+
+    return () => {
+      cancelled = true;
+    };
+  }, [generation]);
+
+  return { data, loading, error };
+}

package/dist/force-app/main/default/uiBundles/feature-react-authentication/src/routes.tsx

@@ -8,7 +8,6 @@ import ForgotPassword from "./features/authentication/pages/ForgotPassword";
 import ResetPassword from "./features/authentication/pages/ResetPassword";
 import Profile from "./features/authentication/pages/Profile";
 import ChangePassword from "./features/authentication/pages/ChangePassword";
-import AuthenticationRoute from "./features/authentication/layouts/authenticationRouteLayout";
 import PrivateRoute from "./features/authentication/layouts/privateRouteLayout";
 import { ROUTES } from "./features/authentication/authenticationConfig";
 
@@ -27,32 +26,27 @@ export const routes: RouteObject[] = [
         element: <NotFound />
       },
       {
-        element: <AuthenticationRoute />,
-        children: [
-          {
-            path: ROUTES.LOGIN.PATH,
-            element: <Login />,
-            handle: { showInNavigation: false, label: "Login", title: ROUTES.LOGIN.TITLE }
-          },
-          {
-            path: ROUTES.REGISTER.PATH,
-            element: <Register />,
-            handle: { showInNavigation: false, title: ROUTES.REGISTER.TITLE }
-          },
-          {
-            path: ROUTES.FORGOT_PASSWORD.PATH,
-            element: <ForgotPassword />,
-            handle: { showInNavigation: false, title: ROUTES.FORGOT_PASSWORD.TITLE }
-          },
-          {
-            path: ROUTES.RESET_PASSWORD.PATH,
-            element: <ResetPassword />,
-            handle: { showInNavigation: false, title: ROUTES.RESET_PASSWORD.TITLE }
-          }
-        ]
+        path: ROUTES.LOGIN.PATH,
+        element: <Login />,
+        handle: { showInNavigation: false, label: "Login", title: ROUTES.LOGIN.TITLE }
+      },
+      {
+        path: ROUTES.REGISTER.PATH,
+        element: <Register />,
+        handle: { showInNavigation: false, title: ROUTES.REGISTER.TITLE }
+      },
+      {
+        path: ROUTES.FORGOT_PASSWORD.PATH,
+        element: <ForgotPassword />,
+        handle: { showInNavigation: false, title: ROUTES.FORGOT_PASSWORD.TITLE }
+      },
+      {
+        path: ROUTES.RESET_PASSWORD.PATH,
+        element: <ResetPassword />,
+        handle: { showInNavigation: false, title: ROUTES.RESET_PASSWORD.TITLE }
       },
       {
-        element: <PrivateRoute showCardSkeleton />,
+        element: <PrivateRoute />,
         children: [
           {
             path: ROUTES.PROFILE.PATH,

package/dist/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@salesforce/webapp-template-base-sfdx-project-experimental",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@salesforce/webapp-template-base-sfdx-project-experimental",
-      "version": "3.0.0",
+      "version": "3.1.0",
       "license": "SEE LICENSE IN LICENSE.txt",
       "devDependencies": {
         "@lwc/eslint-plugin-lwc": "^3.3.0",

package/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/ui-bundle-template-base-sfdx-project",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "description": "Base SFDX project template",
   "license": "SEE LICENSE IN LICENSE.txt",
   "publishConfig": {

package/dist/scripts/org-setup.config.json

@@ -1,6 +1,5 @@
 {
   "permsetAssignments": {
-    "defaultAssignee": "currentUser",
     "assignments": {}
   }
 }