@salesforce/sfdx-agent-harness-mastra 0.27.0 → 0.28.0

package/CHANGELOG.md

@@ -3,6 +3,11 @@
 All notable changes to `@salesforce/sfdx-agent-harness-mastra` are documented in this file.
 Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
+## [0.28.0] - 2026-07-02
+
+### Fixes
+- **harness-mastra,harness-claude**: honor mid-turn remembered tool-policy rules @W-23294201 ([#639](https://github.com/forcedotcom/agentic-dx/pull/639))
+
 ## [0.27.0] - 2026-06-30
 
 ### Features

package/dist/mastra-harness.d.ts

@@ -450,6 +450,29 @@ export declare class MastraHarness implements MastraAgentHarness {
      * cross-tier deny-wins, so the capability-discovery meta-tools stay
      * auto-approved even under legacy gating.
      *
+     * **Live config read (#638).** `lookupPolicy` reads `agentState.config` on
+     * every call rather than closing over a snapshot taken at stream start. A
+     * mid-turn `updateAgentConfig` — notably the `source: 'remember'` rule an
+     * "Allow always" / "Deny always" click appends — reassigns `state.config`
+     * (in place, on this same `agentState`; the in-flight coordinator is not
+     * disposed), so a snapshot would be stale for approvals 2..N in the turn
+     * that persisted the rule. Reading live makes the remembered decision
+     * auto-resolve subsequent matching tool calls within the same turn.
+     *
+     * Two decisions stay **frozen at stream start** and MUST NOT be recomputed
+     * live:
+     *  - `gatingActive` — the turn either told Mastra to suspend tools
+     *    (`requireToolApproval: true`) or it didn't; gating cannot begin
+     *    mid-turn. The closure is built (and returned) iff gating engaged now.
+     *  - `applyLegacyBridge` (`!hasPolicy && legacyGating`) — whether the
+     *    deprecation bridge injects `defaultToolDecision: 'require-approval'`.
+     *    If this were recomputed live, the FIRST remembered rule would flip
+     *    `hasPolicy` false→true, turn the bridge OFF mid-turn, and silently drop
+     *    the effective default back to the resolver's `'allow'` — auto-approving
+     *    every remaining legacy-gated tool. Freezing the boolean and applying it
+     *    to the live config preserves legacy all-or-none semantics while still
+     *    honoring any rule the turn appends.
+     *
      * `batchApprovals` is the serial-vs-batch emission axis: the explicit
      * `StreamOptions.batchApprovals` OR the legacy `requireToolApproval: 'batch'`.
      */

package/dist/mastra-harness.js

@@ -1365,6 +1365,29 @@ export class MastraHarness {
      * cross-tier deny-wins, so the capability-discovery meta-tools stay
      * auto-approved even under legacy gating.
      *
+     * **Live config read (#638).** `lookupPolicy` reads `agentState.config` on
+     * every call rather than closing over a snapshot taken at stream start. A
+     * mid-turn `updateAgentConfig` — notably the `source: 'remember'` rule an
+     * "Allow always" / "Deny always" click appends — reassigns `state.config`
+     * (in place, on this same `agentState`; the in-flight coordinator is not
+     * disposed), so a snapshot would be stale for approvals 2..N in the turn
+     * that persisted the rule. Reading live makes the remembered decision
+     * auto-resolve subsequent matching tool calls within the same turn.
+     *
+     * Two decisions stay **frozen at stream start** and MUST NOT be recomputed
+     * live:
+     *  - `gatingActive` — the turn either told Mastra to suspend tools
+     *    (`requireToolApproval: true`) or it didn't; gating cannot begin
+     *    mid-turn. The closure is built (and returned) iff gating engaged now.
+     *  - `applyLegacyBridge` (`!hasPolicy && legacyGating`) — whether the
+     *    deprecation bridge injects `defaultToolDecision: 'require-approval'`.
+     *    If this were recomputed live, the FIRST remembered rule would flip
+     *    `hasPolicy` false→true, turn the bridge OFF mid-turn, and silently drop
+     *    the effective default back to the resolver's `'allow'` — auto-approving
+     *    every remaining legacy-gated tool. Freezing the boolean and applying it
+     *    to the live config preserves legacy all-or-none semantics while still
+     *    honoring any rule the turn appends.
+     *
      * `batchApprovals` is the serial-vs-batch emission axis: the explicit
      * `StreamOptions.batchApprovals` OR the legacy `requireToolApproval: 'batch'`.
      */
@@ -1377,10 +1400,20 @@ export class MastraHarness {
         if (!gatingActive) {
             return { batchApprovals: false };
         }
-        // Apply the deprecation bridge only when the gate engages purely from
-        // the legacy flag (no explicit policy of any kind).
-        const resolverConfig = !hasPolicy && legacyGating ? { ...config, defaultToolDecision: 'require-approval' } : config;
-        const lookupPolicy = (invocation) => resolveToolApprovalPolicy(invocation, resolverConfig, { harness: MASTRA_BUILT_IN_TOOL_POLICIES }).decision;
+        // Freeze the deprecation-bridge decision at stream start (see JSDoc) —
+        // whether to inject `defaultToolDecision: 'require-approval'` must not
+        // change when a mid-turn remember rule flips `hasPolicy`.
+        const applyLegacyBridge = !hasPolicy && legacyGating;
+        const lookupPolicy = (invocation) => {
+            // Read the config live so a mid-turn `updateAgentConfig` (e.g. a
+            // remembered rule) is honored for the rest of this turn.
+            const liveConfig = agentState.config;
+            const resolverConfig = applyLegacyBridge
+                ? { ...liveConfig, defaultToolDecision: 'require-approval' }
+                : liveConfig;
+            return resolveToolApprovalPolicy(invocation, resolverConfig, { harness: MASTRA_BUILT_IN_TOOL_POLICIES })
+                .decision;
+        };
         return { lookupPolicy, batchApprovals };
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/sfdx-agent-harness-mastra",
-  "version": "0.27.0",
+  "version": "0.28.0",
   "description": "Mastra-backed AgentHarness implementation for @salesforce/sfdx-agent-sdk",
   "type": "module",
   "main": "dist/index.js",
@@ -40,11 +40,11 @@
     "openai": "^6.0.0"
   },
   "peerDependencies": {
-    "@salesforce/sfdx-agent-sdk": "0.28.0"
+    "@salesforce/sfdx-agent-sdk": "0.29.0"
   },
   "devDependencies": {
     "@eslint/js": "^10.0.1",
-    "@salesforce/sfdx-agent-sdk": "0.28.0",
+    "@salesforce/sfdx-agent-sdk": "0.29.0",
     "@types/node": "^22.20.0",
     "@vitest/coverage-istanbul": "^4.1.8",
     "@vitest/eslint-plugin": "^1.6.20",