@salesforce/packaging 5.0.10 → 5.0.12

package/lib/package/packageConvert.js

@@ -205,6 +205,7 @@ async function createPackageVersionCreateRequest(context, packageId, apiVersion,
     const seedMetadataPath = context.seedmetadata ?? packageDescriptorJson.seedMetadata?.path;
     const hasSeedMetadata = await new packageVersionCreate_1.MetadataResolver().resolveMetadata(seedMetadataPath, seedMetadataFolder, 'seedMDDirectoryDoesNotExist', apiVersion);
     if (context.codecoverage) {
+        assertPackagePropertiesAreResolvable(project);
         const unpackagedMetadataPath = packageDescriptorJson.unpackagedMetadata?.path;
         const hasUnpackaged = await new packageVersionCreate_1.MetadataResolver().resolveMetadata(unpackagedMetadataPath, unpackagedMetadataFolder, 'unpackagedMDDirectoryDoesNotExist', apiVersion);
         if (hasUnpackaged) {
@@ -251,6 +252,24 @@ function buildPackageDescriptorJson(args) {
     }
     return descriptor;
 }
+// These properties only resolve when their packageDirectories entry has a `package` that maps to a
+// packageAliases key; otherwise they're silently dropped, so fail fast here instead.
+function assertPackagePropertiesAreResolvable(project) {
+    const packageScopedProperties = ['unpackagedMetadata', 'apexTestAccess'];
+    for (const dir of project?.getPackageDirectories() ?? []) {
+        const declared = packageScopedProperties.find((property) => property in dir);
+        if (!declared)
+            continue;
+        if (!(0, project_1.isPackagingDirectory)(dir)) {
+            throw messages.createError('missingPackagePropertyForDirectory');
+        }
+        // Package directory entries support either an alias or a literal 0Ho ID for backward compatibility.
+        const resolvedPackageId = project?.getPackageIdFromAlias(dir.package) ?? dir.package;
+        if (!pkgUtils.validateIdNoThrow(pkgUtils.BY_LABEL.PACKAGE_ID, resolvedPackageId)) {
+            throw messages.createError('unresolvedPackageAliasForDirectory', [dir.package]);
+        }
+    }
+}
 async function createRequestObject(packageId, options, packageVersTmpRoot, packageVersBlobZipFile) {
     const zipFileBase64 = (await node_fs_1.default.promises.readFile(packageVersBlobZipFile)).toString('base64');
     const requestObject = {

package/messages/package_version_create.md

@@ -131,6 +131,14 @@ Could not find a package in sfdx-project.json file using "path" %s. Add it to th
 
 Couldn't find a package directory for package using %s %s. Add it to the packageDirectories section and add the alias to packageAliases with its 0Ho ID.
 
+# missingPackagePropertyForDirectory
+
+Can't convert package. Your project configuration file (sfdx-project.json) specifies unpackagedMetadata or apexTestAccess, but the attribute can't be resolved because the packageDirectories entry doesn't specify the package parameter. Specify a valid 0Ho package ID or a package alias.
+
+# unresolvedPackageAliasForDirectory
+
+Can't convert package. Your project configuration file (sfdx-project.json) specifies unpackagedMetadata or apexTestAccess, but the attribute can't be resolved because the package specified as "%s" isn't a valid package ID or package alias. Specify a valid 0Ho package ID or a package alias that resolves to a valid 0Ho package ID.
+
 # noSourceInRootDirectory
 
 No matching source was found within the package root directory: %s

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/packaging",
-  "version": "5.0.10",
+  "version": "5.0.12",
   "description": "Packaging library for the Salesforce packaging platform",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",
@@ -42,11 +42,11 @@
     "!lib/**/*.map"
   ],
   "dependencies": {
-    "@jsforce/jsforce-node": "^3.10.19",
-    "@salesforce/core": "^9.0.0",
+    "@jsforce/jsforce-node": "^3.10.24",
+    "@salesforce/core": "^9.1.9",
     "@salesforce/kit": "^4.0.0",
     "@salesforce/schemas": "^1.10.3",
-    "@salesforce/source-deploy-retrieve": "^13.0.1",
+    "@salesforce/source-deploy-retrieve": "^13.3.0",
     "@salesforce/ts-types": "^3.0.1",
     "@salesforce/types": "^1.8.0",
     "fast-xml-parser": "^5.10.1",