@salesforce/packaging 2.4.20 → 2.4.21

package/lib/package/packageVersionCreate.js

@@ -531,11 +531,11 @@ class PackageVersionCreate {
     async validateOptionsForPackageType() {
         if ((await this.getPackageType()) === 'Unlocked') {
             // Don't allow scripts in unlocked packages
-            if (this.options.postinstallscript || this.options.uninstallscript) {
+            if (Boolean(this.options.postinstallscript) || this.options.uninstallscript) {
                 throw messages.createError('errorScriptsNotApplicableToUnlockedPackage');
             }
             // Don't allow ancestor in unlocked packages
-            if (this.packageObject.ancestorId || this.packageObject.ancestorVersion) {
+            if (Boolean(this.packageObject.ancestorId) || this.packageObject.ancestorVersion) {
                 throw messages.createError('errorAncestorNotApplicableToUnlockedPackage');
             }
         }

package/lib/package/packageVersionCreateRequest.js

@@ -9,10 +9,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.byId = exports.list = void 0;
 const util = require("node:util");
 const core_1 = require("@salesforce/core");
+const interfaces_1 = require("../interfaces");
 const packageUtils_1 = require("../utils/packageUtils");
 core_1.Messages.importMessagesDirectory(__dirname);
 const messages = core_1.Messages.loadMessages('@salesforce/packaging', 'package_version_create');
-const STATUS_ERROR = 'Error';
 const QUERY = 'SELECT Id, Status, Package2Id, Package2VersionId, Package2Version.SubscriberPackageVersionId, Tag, Branch, ' +
     'CreatedDate, Package2Version.HasMetadataRemoved, CreatedById, IsConversionRequest, Package2Version.ConvertedFromVersionId ' +
     'FROM Package2VersionCreateRequest ' +
@@ -37,7 +37,7 @@ async function list(connection, options) {
 exports.list = list;
 async function byId(packageVersionCreateRequestId, connection) {
     const results = await query(util.format(QUERY, `WHERE Id = '${packageVersionCreateRequestId}' `), connection);
-    if (results && results.length === 1 && results[0].Status === STATUS_ERROR) {
+    if (results && results.length === 1 && results[0].Status === interfaces_1.PackagingSObjects.Package2VersionStatus.error) {
         results[0].Error = await queryForErrors(packageVersionCreateRequestId, connection);
     }
     return results;

package/lib/package/subscriberPackageVersion.js

@@ -291,7 +291,7 @@ class SubscriberPackageVersion {
      * @returns {PackagingSObjects.SubscriberPackageVersion} SObject data.
      */
     async getData(options = { force: false, includeHighCostFields: false }) {
-        if (!this.data || options.force || options.includeHighCostFields) {
+        if (!this.data || Boolean(options.force) || options.includeHighCostFields) {
             const queryFields = this.getFieldsForQuery(options);
             if (queryFields.length === 0) {
                 return this.data;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/packaging",
-  "version": "2.4.20",
+  "version": "2.4.21",
   "description": "Packaging library for the Salesforce packaging platform",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",
@@ -45,7 +45,7 @@
     "@salesforce/core": "^5.3.14",
     "@salesforce/kit": "^3.0.15",
     "@salesforce/schemas": "^1.6.1",
-    "@salesforce/source-deploy-retrieve": "^9.8.3",
+    "@salesforce/source-deploy-retrieve": "^9.8.5",
     "@salesforce/ts-types": "^2.0.9",
     "fast-xml-parser": "^4.3.1",
     "globby": "^11",
@@ -56,35 +56,15 @@
     "jszip": "^3.10.1"
   },
   "devDependencies": {
-    "@salesforce/cli-plugins-testkit": "^4.4.8",
-    "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/dev-scripts": "^5.12.2",
-    "@salesforce/prettier-config": "^0.0.3",
+    "@salesforce/cli-plugins-testkit": "^4.4.12",
+    "@salesforce/dev-scripts": "^6.0.3",
     "@salesforce/ts-sinon": "^1.4.19",
     "@types/globby": "^9.1.0",
     "@types/jszip": "^3.4.1",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
-    "chai": "^4.3.10",
-    "eslint": "^8.53.0",
-    "eslint-config-prettier": "^8.10.0",
-    "eslint-config-salesforce": "^2.0.2",
-    "eslint-config-salesforce-license": "^0.2.0",
-    "eslint-config-salesforce-typescript": "^2.0.0",
-    "eslint-plugin-header": "3.1.1",
-    "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-jsdoc": "^46.8.2",
-    "eslint-plugin-sf-plugin": "^1.16.13",
-    "husky": "^8.0.3",
-    "mocha": "^10.2.0",
-    "nyc": "^15.1.0",
-    "prettier": "^2.8.8",
-    "pretty-quick": "^3.1.3",
+    "eslint-plugin-sf-plugin": "^1.16.14",
     "shelljs": "0.8.5",
-    "sinon": "14.0.2",
     "ts-node": "^10.9.1",
-    "typescript": "^5.2.2",
-    "wireit": "^0.14.1"
+    "typescript": "^5.2.2"
   },
   "publishConfig": {
     "access": "public"