@salesforce/packaging 0.1.8 → 0.1.10

package/lib/package/packageProfileApi.js

@@ -186,7 +186,7 @@ class PackageProfileApi extends kit_1.AsyncCreatable {
     filterAndGenerateProfilesForManifest(typesArr, excludedDirectories = []) {
         const profilePaths = this.findAllProfiles(excludedDirectories);
         // Filter all profiles
-        typesArr = typesArr.filter((kvp) => kvp.name[0] !== 'Profile');
+        typesArr = (typesArr || []).filter((kvp) => kvp.name[0] !== 'Profile');
         if (profilePaths) {
             const members = [];
             profilePaths.forEach((profilePath) => {

package/lib/package/packageVersionCreate.d.ts

@@ -30,6 +30,7 @@ export declare class PackageVersionCreate {
      * @private
      */
     private createPackageVersionCreateRequestFromOptions;
+    private verifyHasSource;
     private cleanGeneratedPackage;
     private resolveApexTestPermissions;
     private resolveUnpackagedMetadata;

package/lib/package/packageVersionCreate.js

@@ -70,6 +70,7 @@ class PackageVersionCreate {
             convertResult.packagePath = outputDirectory;
             return convertResult;
         }
+        return convertResult;
     }
     async validateDependencyValues(dependency) {
         // If valid 04t package, just return it to be used straight away.
@@ -249,7 +250,8 @@ class PackageVersionCreate {
         await fs.promises.mkdir(packageVersBlobDirectory, { recursive: true });
         const settingsGenerator = new scratchOrgSettingsGenerator_1.default({ asDirectory: true });
         // Copy all the metadata from the workspace to a tmp folder
-        await this.generateMDFolderForArtifact(mdOptions);
+        const componentSet = await this.generateMDFolderForArtifact(mdOptions);
+        this.verifyHasSource(componentSet);
         const packageDescriptorJson = this.packageObject;
         if (packageDescriptorJson.package) {
             delete packageDescriptorJson.package;
@@ -305,6 +307,11 @@ class PackageVersionCreate {
         await this.cleanGeneratedPackage(packageVersMetadataFolder, packageVersProfileFolder, unpackagedMetadataFolder, metadataZipFile, settingsZipFile, packageVersBlobDirectory, packageVersBlobZipFile, unpackagedMetadataZipFile, clientSideInfo, settingsGenerator);
         return this.createRequestObject(preserveFiles, packageVersTmpRoot, packageVersBlobZipFile);
     }
+    verifyHasSource(componentSet) {
+        if (componentSet.converted.length === 0) {
+            throw messages.createError('noSourceInRootDirectory', [this.packageObject.path ?? '<unknown>']);
+        }
+    }
     async cleanGeneratedPackage(packageVersMetadataFolder, packageVersProfileFolder, unpackagedMetadataFolder, metadataZipFile, settingsZipFile, packageVersBlobDirectory, packageVersBlobZipFile, unpackagedMetadataZipFile, clientSideInfo, settingsGenerator) {
         // As part of the source convert process, the package.xml has been written into the tmp metadata directory.
         // The package.xml may need to be manipulated due to processing profiles in the workspace or additional
@@ -312,6 +319,12 @@ class PackageVersionCreate {
         const currentPackageXml = await fs.promises.readFile(path.join(packageVersMetadataFolder, 'package.xml'), 'utf8');
         // convert to json
         const packageJson = await xml2js.parseStringPromise(currentPackageXml);
+        if (!packageJson?.Package) {
+            throw messages.createError('packageXmlDoesNotContainPackage');
+        }
+        if (!packageJson?.Package.types) {
+            throw messages.createError('packageXmlDoesNotContainPackageTypes');
+        }
         fs.mkdirSync(packageVersMetadataFolder, { recursive: true });
         fs.mkdirSync(packageVersProfileFolder, { recursive: true });
         // Apply any necessary exclusions to typesArr.

package/messages/package_version_create.md

@@ -122,3 +122,15 @@ Could not find a package in sfdx-project.json file using "path" %s. Add it to th
 # errorCouldNotFindPackageDir
 
 Couldn't find a package directory for package using %s %s. Add it to the packageDirectories section and add the alias to packageAliases with its 0Ho ID.
+
+# noSourceInRootDirectory
+
+No matching source was found within the package root directory: %s
+
+# packageXmlDoesNotContainPackage
+
+While preparing package version create request, the calculated package.xml for the package does not contain a <Package> element.
+
+# packageXmlDoesNotContainPackageTypes
+
+While preparing package version create request, the calculated package.xml for the package does not contain a <Package><types> element.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/packaging",
-  "version": "0.1.8",
+  "version": "0.1.10",
   "description": "packing libraries to Salesforce packaging platform",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",
@@ -35,7 +35,7 @@
     "!lib/**/*.map"
   ],
   "dependencies": {
-    "@oclif/core": "^1.18.0",
+    "@oclif/core": "^1.19.1",
     "@salesforce/core": "^3.31.11",
     "@salesforce/kit": "^1.7.0",
     "@salesforce/schemas": "^1.1.3",