@salesforce/packaging 0.1.17 → 0.1.18

package/lib/package/packageAncestry.d.ts

@@ -23,29 +23,29 @@ export declare class PackageAncestry extends AsyncCreatable<PackageAncestryOptio
     /**
      * Convenience method to get the json representation of the package ancestry graph.
      */
-    getJsonProducer(): Promise<AncestryRepresentationProducer>;
+    getJsonProducer(): AncestryRepresentationProducer;
     /**
      * Convenience method to get the CliUx.Tree representation of the package ancestry graph.
      */
-    getTreeProducer(verbose: boolean): Promise<AncestryRepresentationProducer>;
+    getTreeProducer(verbose: boolean): AncestryRepresentationProducer;
     /**
      * Convenience method to get the dot representation of the package ancestry graph.
      */
-    getDotProducer(): Promise<AncestryRepresentationProducer>;
+    getDotProducer(): AncestryRepresentationProducer;
     /**
      * Returns the producer representation of the package ancestry graph.
      *
      * @param producerCtor - function that returns a new instance of the producer
      * @param root - the subscriber package version id of the root node
      */
-    getRepresentationProducer(producerCtor: (options?: AncestryRepresentationProducerOptions) => AncestryRepresentationProducer, root: string | undefined): Promise<AncestryRepresentationProducer>;
+    getRepresentationProducer(producerCtor: (options?: AncestryRepresentationProducerOptions) => AncestryRepresentationProducer, root: string | undefined): AncestryRepresentationProducer;
     /**
      * Returns a list of ancestry nodes that represent the path from subscriber package version id to the root of the
      * package ancestry tree.
      *
      * @param subscriberPackageVersionId
      */
-    getLeafPathToRoot(subscriberPackageVersionId?: string): Promise<PackageAncestryNode[][]>;
+    getLeafPathToRoot(subscriberPackageVersionId?: string): PackageAncestryNode[][];
     private buildAncestryTree;
     private getRoots;
     private findRootsForPackageVersion;

package/lib/package/packageAncestry.js

@@ -65,19 +65,19 @@ class PackageAncestry extends kit_1.AsyncCreatable {
     /**
      * Convenience method to get the json representation of the package ancestry graph.
      */
-    async getJsonProducer() {
+    getJsonProducer() {
         return this.getRepresentationProducer((opts) => new AncestryJsonProducer(opts), this.requestedPackageId);
     }
     /**
      * Convenience method to get the CliUx.Tree representation of the package ancestry graph.
      */
-    async getTreeProducer(verbose) {
+    getTreeProducer(verbose) {
         return this.getRepresentationProducer((opts) => new AncestryTreeProducer({ ...opts, verbose: !!verbose }), this.requestedPackageId);
     }
     /**
      * Convenience method to get the dot representation of the package ancestry graph.
      */
-    async getDotProducer() {
+    getDotProducer() {
         return this.getRepresentationProducer((opts) => new AncestryDotProducer(opts), this.requestedPackageId);
     }
     /**
@@ -86,7 +86,7 @@ class PackageAncestry extends kit_1.AsyncCreatable {
      * @param producerCtor - function that returns a new instance of the producer
      * @param root - the subscriber package version id of the root node
      */
-    async getRepresentationProducer(producerCtor, root) {
+    getRepresentationProducer(producerCtor, root) {
         const treeRoot = root
             ? this.graph.findNode((node, attributes) => attributes.node.SubscriberPackageVersionId === root)
             : undefined;
@@ -122,12 +122,12 @@ class PackageAncestry extends kit_1.AsyncCreatable {
      *
      * @param subscriberPackageVersionId
      */
-    async getLeafPathToRoot(subscriberPackageVersionId) {
+    getLeafPathToRoot(subscriberPackageVersionId) {
         const root = this.graph.findNode((node, attributes) => attributes.node.AncestorId === null);
         const paths = [];
         let path = [];
         let previousDepth = 0;
-        (0, graphology_traversal_1.dfsFromNode)(this.graph, root, function (node, attr, depth) {
+        (0, graphology_traversal_1.dfsFromNode)(this.graph, root, (node, attr, depth) => {
             if (depth === 0) {
                 paths.push(path);
                 path = [];
@@ -141,15 +141,19 @@ class PackageAncestry extends kit_1.AsyncCreatable {
         });
         // push remaining path
         paths.push(path);
-        return paths
-            .filter((path) => path.length > 0 && // don't care about zero length paths
+        return (paths
+            .filter(
+        // eslint-disable-next-line @typescript-eslint/no-shadow
+        (path) => path.length > 0 && // don't care about zero length paths
             (!subscriberPackageVersionId ||
                 path.some((node) => node.SubscriberPackageVersionId === subscriberPackageVersionId)))
+            // eslint-disable-next-line @typescript-eslint/no-shadow
             .map((path) => path.reverse())
+            // eslint-disable-next-line @typescript-eslint/no-shadow
             .map((path) => {
             const subscriberPackageVersionIdIndex = path.findIndex((node) => node.SubscriberPackageVersionId === subscriberPackageVersionId);
             return path.slice(subscriberPackageVersionIdIndex === -1 ? 0 : subscriberPackageVersionIdIndex);
-        });
+        }));
     }
     async buildAncestryTree() {
         this.roots = await this.getRoots();
@@ -177,6 +181,7 @@ class PackageAncestry extends kit_1.AsyncCreatable {
         // Start with the node, and shoot up
         let node = await this.getPackageVersion(this.requestedPackageId);
         while (node.AncestorId !== null) {
+            // eslint-disable-next-line no-await-in-loop
             const ancestor = await this.getPackageVersion(node.AncestorId);
             this.addToGraph(ancestor, node);
             node = ancestor;
@@ -241,6 +246,7 @@ class PackageAncestry extends kit_1.AsyncCreatable {
     async buildAncestryTreeFromRoots(roots) {
         while (roots.length > 0) {
             const subscriberPackageVersion = roots.shift();
+            // eslint-disable-next-line no-await-in-loop
             const descendants = await this.addDescendantsFromPackageVersion(subscriberPackageVersion);
             roots.push(...descendants);
         }
@@ -443,6 +449,7 @@ class PackageAncestryNode extends kit_1.AsyncCreatable {
     getVersion() {
         return __classPrivateFieldGet(this, _PackageAncestryNode_version, "f").toString();
     }
+    // eslint-disable-next-line class-methods-use-this
     init() {
         return Promise.resolve();
     }

package/lib/package/packageConvert.js

@@ -76,7 +76,7 @@ async function convertPackage(pkg, connection, options, project) {
     // TODO: a lot of this is duplicated from PC, PVC, and PVCR.
     const createResult = await connection.tooling.create('Package2VersionCreateRequest', request);
     if (!createResult.success) {
-        const errStr = createResult.errors && createResult.errors.length ? createResult.errors.join(', ') : createResult.errors;
+        const errStr = createResult?.errors.length ? createResult.errors.join(', ') : createResult.errors;
         throw messages.createError('failedToCreatePVCRequest', [
             createResult.id ? ` [${createResult.id}]` : '',
             errStr.toString(),
@@ -169,9 +169,9 @@ async function pollForStatusWithInterval(id, retries, packageId, branch, withPro
     const pollingClient = await core_1.PollingClient.create({
         poll: async () => {
             const results = await pvcr.byId(id, connection);
-            if (_isStatusEqualTo(results, [Package2VersionStatus.success, Package2VersionStatus.error])) {
+            if (isStatusEqualTo(results, [Package2VersionStatus.success, Package2VersionStatus.error])) {
                 // complete
-                if (_isStatusEqualTo(results, [Package2VersionStatus.success])) {
+                if (isStatusEqualTo(results, [Package2VersionStatus.success])) {
                     // update sfdx-project.json
                     let projectUpdated = false;
                     if (withProject && !process.env.SFDX_PROJECT_AUTOUPDATE_DISABLE_FOR_PACKAGE_VERSION_CREATE) {
@@ -183,8 +183,8 @@ async function pollForStatusWithInterval(id, retries, packageId, branch, withPro
                             const record = pkgQueryResult.records[0];
                             return `${record.MajorVersion}.${record.MinorVersion}.${record.PatchVersion}-${record.BuildNumber}`;
                         });
-                        const [alias, id] = await (0, utils_1.generatePackageAliasEntry)(connection, withProject, results[0].SubscriberPackageVersionId, packageVersionVersionString, branch, packageId);
-                        withProject.getSfProjectJson().addPackageAlias(alias, id);
+                        const [alias, writtenId] = await (0, utils_1.generatePackageAliasEntry)(connection, withProject, results[0].SubscriberPackageVersionId, packageVersionVersionString, branch, packageId);
+                        withProject.getSfProjectJson().addPackageAlias(alias, writtenId);
                         await withProject.getSfProjectJson().write();
                     }
                     await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageEvents.convert.success, {
@@ -238,7 +238,7 @@ async function pollForStatusWithInterval(id, retries, packageId, branch, withPro
  * @param statuses array of statuses to look for
  * @returns {boolean} if one of the values in status is found.
  */
-function _isStatusEqualTo(results, statuses) {
+function isStatusEqualTo(results, statuses) {
     return results?.length <= 0 ? false : statuses?.some((status) => results[0].Status === status);
 }
 //# sourceMappingURL=packageConvert.js.map

package/lib/package/packageProfileApi.js

@@ -169,6 +169,7 @@ class PackageProfileApi extends kit_1.AsyncCreatable {
                 }
                 catch (err) {
                     // It is normal for the file to not exist if the profile is in the workspace but not in the directory being packaged.
+                    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
                     if (err.code !== 'ENOENT') {
                         throw err;
                     }
@@ -215,20 +216,18 @@ class PackageProfileApi extends kit_1.AsyncCreatable {
         // eslint-disable-next-line @typescript-eslint/prefer-for-of
         for (let i = 0; i < nodes.length; i++) {
             const name = nodes[i].getElementsByTagName(childElement)[0].childNodes[0].nodeValue;
-            if (members.indexOf(name) >= 0) {
+            if (members.includes(name)) {
                 // appendChild will take the passed in node (newNode) and find the parent if it exists and then remove
                 // the newNode from the parent.  This causes issues with the way this is copying the nodes, so pass in a clone instead.
                 const currentNode = nodes[i].cloneNode(true);
                 appendToNode.appendChild(currentNode);
                 nodesAdded = true;
             }
-            else {
+            else if (this.generateProfileInformation) {
                 // Tell the user which profile setting has been removed from the package
-                if (this.generateProfileInformation) {
-                    const profile = this.profiles.find(({ ProfileName }) => ProfileName === profileName);
-                    if (profile) {
-                        profile.appendRemovedSetting(name);
-                    }
+                const profile = this.profiles.find(({ ProfileName }) => ProfileName === profileName);
+                if (profile) {
+                    profile.appendRemovedSetting(name);
                 }
             }
         }

package/lib/package/packageUninstall.js

@@ -21,7 +21,7 @@ async function getUninstallErrors(conn, id) {
 }
 exports.getUninstallErrors = getUninstallErrors;
 async function pollUninstall(uninstallRequestId, conn, frequency, wait) {
-    const poll = async (id, conn) => {
+    const poll = async (id) => {
         const uninstallRequest = (await conn.tooling
             .sobject('SubscriberPackageVersionUninstallRequest')
             .retrieve(id));
@@ -46,7 +46,7 @@ async function pollUninstall(uninstallRequestId, conn, frequency, wait) {
         }
     };
     const pollingClient = await core_1.PollingClient.create({
-        poll: () => poll(uninstallRequestId, conn),
+        poll: () => poll(uninstallRequestId),
         frequency,
         timeout: wait,
     });
@@ -64,7 +64,7 @@ async function uninstallPackage(id, conn, frequency = kit_1.Duration.seconds(0),
                 .retrieve(uninstallRequest.id));
         }
         else {
-            return pollUninstall(uninstallRequest.id, conn, frequency, wait);
+            return await pollUninstall(uninstallRequest.id, conn, frequency, wait);
         }
     }
     catch (err) {

package/lib/package/packageVersion.d.ts

@@ -45,6 +45,8 @@ export declare class PackageVersion {
      * progress and current status. Events also carry a payload of type PackageVersionCreateRequestResult.
      *
      * @param createPackageVersionRequestId
+     * @param connection Connection to the org
+     * @param project SfProject to read/write aliases from
      * @param polling frequency and timeout Durations to be used in polling
      * */
     static pollCreateStatus(createPackageVersionRequestId: string, connection: Connection, project: SfProject, polling: {

package/lib/package/packageVersion.js

@@ -15,6 +15,7 @@ const packageVersionCreate_1 = require("./packageVersionCreate");
 const packageVersionReport_1 = require("./packageVersionReport");
 const packageVersionCreateRequestReport_1 = require("./packageVersionCreateRequestReport");
 const packageVersionCreateRequest_1 = require("./packageVersionCreateRequest");
+var Package2VersionStatus = interfaces_1.PackagingSObjects.Package2VersionStatus;
 core_1.Messages.importMessagesDirectory(__dirname);
 const messages = core_1.Messages.loadMessages('@salesforce/packaging', 'package_version');
 exports.Package2VersionFields = [
@@ -84,7 +85,7 @@ class PackageVersion {
     }) {
         const pvc = new packageVersionCreate_1.PackageVersionCreate({ ...options });
         const createResult = await pvc.createPackageVersion();
-        return await PackageVersion.pollCreateStatus(createResult.Id, options.connection, options.project, polling).catch((err) => {
+        return PackageVersion.pollCreateStatus(createResult.Id, options.connection, options.project, polling).catch((err) => {
             // TODO
             // until package2 is GA, wrap perm-based errors w/ 'contact sfdc' action (REMOVE once package2 is GA'd)
             throw (0, utils_1.applyErrorAction)((0, utils_1.massageErrorMessage)(err));
@@ -97,7 +98,7 @@ class PackageVersion {
      * @param connection
      */
     static async getCreateStatus(createPackageRequestId, connection) {
-        return await (0, packageVersionCreateRequestReport_1.getCreatePackageVersionCreateRequestReport)({
+        return (0, packageVersionCreateRequestReport_1.getCreatePackageVersionCreateRequestReport)({
             createPackageVersionRequestId: createPackageRequestId,
             connection,
         }).catch((err) => {
@@ -123,6 +124,8 @@ class PackageVersion {
      * progress and current status. Events also carry a payload of type PackageVersionCreateRequestResult.
      *
      * @param createPackageVersionRequestId
+     * @param connection Connection to the org
+     * @param project SfProject to read/write aliases from
      * @param polling frequency and timeout Durations to be used in polling
      * */
     static async pollCreateStatus(createPackageVersionRequestId, connection, project, polling) {
@@ -135,19 +138,19 @@ class PackageVersion {
             poll: async () => {
                 report = await this.getCreateStatus(createPackageVersionRequestId, connection);
                 switch (report.Status) {
-                    case 'Queued':
+                    case Package2VersionStatus.queued:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.enqueued, { ...report, remainingWaitTime });
                         remainingWaitTime = kit_1.Duration.seconds(remainingWaitTime.seconds - polling.frequency.seconds);
                         return {
                             completed: false,
                             payload: report,
                         };
-                    case 'InProgress':
-                    case 'Initializing':
-                    case 'VerifyingFeaturesAndSettings':
-                    case 'VerifyingDependencies':
-                    case 'VerifyingMetadata':
-                    case 'FinalizingPackageVersion':
+                    case Package2VersionStatus.inProgress:
+                    case Package2VersionStatus.initializing:
+                    case Package2VersionStatus.verifyingFeaturesAndSettings:
+                    case Package2VersionStatus.verifyingDependencies:
+                    case Package2VersionStatus.verifyingMetadata:
+                    case Package2VersionStatus.finalizingPackageVersion:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.progress, {
                             ...report,
                             remainingWaitTime,
@@ -157,7 +160,7 @@ class PackageVersion {
                             completed: false,
                             payload: report,
                         };
-                    case 'Success': {
+                    case Package2VersionStatus.success: {
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.success, report);
                         const packageVersion = new PackageVersion({
                             connection,
@@ -167,7 +170,7 @@ class PackageVersion {
                         await packageVersion.updateProjectWithPackageVersion(report);
                         return { completed: true, payload: report };
                     }
-                    case 'Error':
+                    case Package2VersionStatus.error:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.error, report);
                         return { completed: true, payload: report };
                 }
@@ -176,7 +179,7 @@ class PackageVersion {
             timeout: polling.timeout,
         });
         try {
-            return pollingClient.subscribe();
+            return await pollingClient.subscribe();
         }
         catch (err) {
             await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create['timed-out'], report);
@@ -190,7 +193,7 @@ class PackageVersion {
      * @param connection
      */
     static async getCreateVersionReport(createPackageRequestId, connection) {
-        return await (0, packageVersionCreateRequestReport_1.getCreatePackageVersionCreateRequestReport)({
+        return (0, packageVersionCreateRequestReport_1.getCreatePackageVersionCreateRequestReport)({
             createPackageVersionRequestId: createPackageRequestId,
             connection,
         }).catch((err) => {
@@ -220,19 +223,19 @@ class PackageVersion {
             poll: async () => {
                 report = await this.getCreateVersionReport(createPackageVersionRequestId, connection);
                 switch (report.Status) {
-                    case 'Queued':
+                    case Package2VersionStatus.queued:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.enqueued, { ...report, remainingWaitTime });
                         remainingWaitTime = kit_1.Duration.seconds(remainingWaitTime.seconds - polling.frequency.seconds);
                         return {
                             completed: false,
                             payload: report,
                         };
-                    case 'InProgress':
-                    case 'Initializing':
-                    case 'VerifyingFeaturesAndSettings':
-                    case 'VerifyingDependencies':
-                    case 'VerifyingMetadata':
-                    case 'FinalizingPackageVersion':
+                    case Package2VersionStatus.inProgress:
+                    case Package2VersionStatus.initializing:
+                    case Package2VersionStatus.verifyingFeaturesAndSettings:
+                    case Package2VersionStatus.verifyingDependencies:
+                    case Package2VersionStatus.verifyingMetadata:
+                    case Package2VersionStatus.finalizingPackageVersion:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.progress, {
                             ...report,
                             remainingWaitTime,
@@ -242,7 +245,7 @@ class PackageVersion {
                             completed: false,
                             payload: report,
                         };
-                    case 'Success':
+                    case Package2VersionStatus.success:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.success, report);
                         await new PackageVersion({
                             idOrAlias: report.SubscriberPackageVersionId,
@@ -250,7 +253,7 @@ class PackageVersion {
                             connection,
                         }).updateProjectWithPackageVersion(report);
                         return { completed: true, payload: report };
-                    case 'Error':
+                    case Package2VersionStatus.error:
                         await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create.error, report);
                         return { completed: true, payload: report };
                 }
@@ -259,7 +262,7 @@ class PackageVersion {
             timeout: polling.timeout,
         });
         try {
-            return pollingClient.subscribe();
+            return await pollingClient.subscribe();
         }
         catch (err) {
             await core_1.Lifecycle.getInstance().emit(interfaces_1.PackageVersionEvents.create['timed-out'], report);
@@ -417,7 +420,7 @@ class PackageVersion {
         const pvc = new packageVersionCreate_1.PackageVersionCreate({ ...options, ...this.options });
         const createResult = await pvc.createPackageVersion();
         if (polling.timeout?.milliseconds > 0) {
-            return await PackageVersion.waitForCreateVersion(createResult.Id, this.project, this.connection, polling).catch((err) => {
+            return PackageVersion.waitForCreateVersion(createResult.Id, this.project, this.connection, polling).catch((err) => {
                 // TODO
                 // until package2 is GA, wrap perm-based errors w/ 'contact sfdc' action (REMOVE once package2 is GA'd)
                 throw (0, utils_1.applyErrorAction)((0, utils_1.massageErrorMessage)(err));

package/lib/package/packageVersionCreate.js

@@ -276,8 +276,10 @@ class PackageVersionCreate {
                 throw messages.createError('signupDuplicateSettingsSpecified');
             }
             ['country', 'edition', 'language', 'features', 'orgPreferences', 'snapshot', 'release', 'sourceOrg'].forEach((prop) => {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                 const propValue = definitionFileJson[prop];
                 if (propValue) {
+                    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
                     packageDescriptorJson[prop] = propValue;
                 }
             });
@@ -318,7 +320,7 @@ class PackageVersionCreate {
         // metadata exclusions. If necessary, read the existing package.xml and then re-write it.
         const currentPackageXml = await fs.promises.readFile(path.join(packageVersMetadataFolder, 'package.xml'), 'utf8');
         // convert to json
-        const packageJson = await xml2js.parseStringPromise(currentPackageXml);
+        const packageJson = (await xml2js.parseStringPromise(currentPackageXml));
         if (!packageJson?.Package) {
             throw messages.createError('packageXmlDoesNotContainPackage');
         }
@@ -346,7 +348,7 @@ class PackageVersionCreate {
         }, [clientSideInfo.get('UnpackagedMetadataPath')]);
         if (excludedProfiles.length > 0) {
             const profileIdx = typesArr.findIndex((e) => e.name[0] === 'Profile');
-            typesArr[profileIdx].members = typesArr[profileIdx].members.filter((e) => excludedProfiles.indexOf(e) === -1);
+            typesArr[profileIdx].members = typesArr[profileIdx].members.filter((e) => !excludedProfiles.includes(e));
         }
         packageJson.Package.types = typesArr;
         // Re-write the package.xml in case profiles have been added or removed
@@ -443,7 +445,7 @@ class PackageVersionCreate {
             packageName = pkg.startsWith('0Ho') ? this.project.getAliasesFromPackageId(pkg).find((alias) => alias) : pkg;
             if (!packageName)
                 throw messages.createError('errorMissingPackage', [this.options.packageId]);
-            this.packageObject = this.project.findPackage((pkg) => pkg.package === packageName || pkg.name === packageName);
+            this.packageObject = this.project.findPackage((namedPackageDir) => namedPackageDir.package === packageName || namedPackageDir.name === packageName);
         }
         else {
             // We'll either have a package ID or alias, or a directory path
@@ -498,7 +500,7 @@ class PackageVersionCreate {
     }
     async resolveUserLicenses(includeUserLicenses) {
         const shouldGenerateProfileInformation = this.logger.shouldLog(core_1.LoggerLevel.INFO) || this.logger.shouldLog(core_1.LoggerLevel.DEBUG);
-        return await packageProfileApi_1.PackageProfileApi.create({
+        return packageProfileApi_1.PackageProfileApi.create({
             project: this.project,
             includeUserLicenses,
             generateProfileInformation: shouldGenerateProfileInformation,
@@ -519,6 +521,7 @@ class PackageVersionCreate {
     /**
      * Cleans invalid attribute(s) from the packageDescriptorJSON
      */
+    // eslint-disable-next-line class-methods-use-this
     cleanPackageDescriptorJson(packageDescriptorJson) {
         delete packageDescriptorJson.default; // for client-side use only, not needed
         delete packageDescriptorJson.includeProfileUserLicenses; // for client-side use only, not needed
@@ -570,6 +573,7 @@ class PackageVersionCreate {
             packageDescriptorJson.uninstallScript = options.uninstallscript;
         }
     }
+    // eslint-disable-next-line class-methods-use-this
     validateVersionNumber(versionNumberString, supportedBuildNumberToken, supportedBuildNumberToken2) {
         const versionNumber = utils_1.VersionNumber.from(versionNumberString);
         // build number can be a number or valid token
@@ -651,16 +655,16 @@ class PackageVersionCreate {
         }
         if (!explicitUseNoAncestor && packageDescriptorJson.ancestorVersion) {
             const regNumbers = new RegExp('^[0-9]+$');
-            const versionNumber = packageDescriptorJson.ancestorVersion.split(utils_2.VERSION_NUMBER_SEP);
-            if (versionNumber.length < 3 ||
-                versionNumber.length > 4 ||
-                !versionNumber[0].match(regNumbers) ||
-                !versionNumber[1].match(regNumbers) ||
-                !versionNumber[2].match(regNumbers)) {
+            const versionNumberSplit = packageDescriptorJson.ancestorVersion.split(utils_2.VERSION_NUMBER_SEP);
+            if (versionNumberSplit.length < 3 ||
+                versionNumberSplit.length > 4 ||
+                !versionNumberSplit[0].match(regNumbers) ||
+                !versionNumberSplit[1].match(regNumbers) ||
+                !versionNumberSplit[2].match(regNumbers)) {
                 throw new Error(messages.getMessage('errorInvalidAncestorVersionFormat', [packageDescriptorJson.ancestorVersion]));
             }
             const query = 'SELECT Id, IsReleased FROM Package2Version ' +
-                `WHERE Package2Id = '${packageId}' AND MajorVersion = ${versionNumber[0]} AND MinorVersion = ${versionNumber[1]} AND PatchVersion = ${versionNumber[2]}`;
+                `WHERE Package2Id = '${packageId}' AND MajorVersion = ${versionNumberSplit[0]} AND MinorVersion = ${versionNumberSplit[1]} AND PatchVersion = ${versionNumberSplit[2]}`;
             let queriedAncestorId;
             const ancestorVersionResult = await this.connection.tooling.query(query);
             if (!ancestorVersionResult || !ancestorVersionResult.totalSize) {
@@ -687,6 +691,7 @@ class PackageVersionCreate {
         }
         return this.validateAncestorId(ancestorId, highestReleasedVersion, explicitUseNoAncestor, versionNumber.patch !== '0', skipAncestorCheck, origSpecifiedAncestor);
     }
+    // eslint-disable-next-line class-methods-use-this
     validateAncestorId(ancestorId, highestReleasedVersion, explicitUseNoAncestor, isPatch, skipAncestorCheck, origSpecifiedAncestor) {
         if (explicitUseNoAncestor) {
             if (!highestReleasedVersion) {
@@ -716,7 +721,10 @@ class PackageVersionCreate {
     async getAncestorIdHighestRelease(packageId, versionNumberString, explicitUseHighestRelease, skipAncestorCheck) {
         const versionNumber = versionNumberString.split(utils_2.VERSION_NUMBER_SEP);
         const isPatch = versionNumber[2] !== '0';
-        const result = { finalAncestorId: null, highestReleasedVersion: null };
+        const result = {
+            finalAncestorId: null,
+            highestReleasedVersion: null,
+        };
         if (isPatch && explicitUseHighestRelease) {
             // based on server-side validation, whatever ancestor is specified for a patch is
             // tightly controlled; therefore we only need concern ourselves if explicitUseHighestRelease == true;
@@ -743,7 +751,7 @@ class PackageVersionCreate {
                 'ORDER BY MajorVersion Desc, MinorVersion Desc, PatchVersion Desc, BuildNumber Desc LIMIT 1';
             const highestVersionResult = await this.connection.tooling.query(query);
             const highestVersionRecords = highestVersionResult.records;
-            if (highestVersionRecords && highestVersionRecords[0]) {
+            if (highestVersionRecords?.[0]) {
                 result.highestReleasedVersion = highestVersionRecords[0];
                 if (explicitUseHighestRelease) {
                     result.finalAncestorId = result.highestReleasedVersion.Id;

package/lib/package/packageVersionCreateRequest.js

@@ -18,16 +18,13 @@ const QUERY = 'SELECT Id, Status, Package2Id, Package2VersionId, Package2Version
     'FROM Package2VersionCreateRequest ' +
     '%s' + // WHERE, if applicable
     'ORDER BY CreatedDate desc';
-const ERROR_QUERY = "SELECT Message FROM Package2VersionCreateRequestError WHERE ParentRequest.Id = '%s'";
 function formatDate(date) {
-    const pad = (num) => {
-        return num < 10 ? `0${num}` : `${num}`;
-    };
+    const pad = (num) => (num < 10 ? `0${num}` : `${num}`);
     return `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())} ${pad(date.getHours())}:${pad(date.getMinutes())}`;
 }
 async function list(options) {
     try {
-        const whereClause = _constructWhere(options);
+        const whereClause = constructWhere(options);
         return await query(util.format(QUERY, whereClause), options.connection);
     }
     catch (err) {
@@ -38,11 +35,12 @@ exports.list = list;
 async function byId(packageVersionCreateRequestId, connection) {
     const results = await query(util.format(QUERY, `WHERE Id = '${packageVersionCreateRequestId}' `), connection);
     if (results && results.length === 1 && results[0].Status === STATUS_ERROR) {
-        results[0].Error = await _queryErrors(packageVersionCreateRequestId, connection);
+        results[0].Error = await queryForErrors(packageVersionCreateRequestId, connection);
     }
     return results;
 }
 exports.byId = byId;
+// eslint-disable-next-line @typescript-eslint/no-shadow
 async function query(query, connection) {
     const queryResult = await connection.autoFetchQuery(query, { tooling: true });
     return (queryResult.records ? queryResult.records : []).map((record) => ({
@@ -59,9 +57,9 @@ async function query(query, connection) {
         CreatedBy: record.CreatedById,
     }));
 }
-async function _queryErrors(packageVersionCreateRequestId, connection) {
+async function queryForErrors(packageVersionCreateRequestId, connection) {
     const errorResults = [];
-    const queryResult = await connection.tooling.query(util.format(ERROR_QUERY, packageVersionCreateRequestId));
+    const queryResult = await connection.tooling.query(util.format("SELECT Message FROM Package2VersionCreateRequestError WHERE ParentRequest.Id = '%s'", packageVersionCreateRequestId));
     if (queryResult.records) {
         queryResult.records.forEach((record) => {
             errorResults.push(record.Message);
@@ -69,7 +67,7 @@ async function _queryErrors(packageVersionCreateRequestId, connection) {
     }
     return errorResults;
 }
-function _constructWhere(options) {
+function constructWhere(options) {
     const where = [];
     if (options?.id) {
         where.push(`Id = '${options.id}'`);

package/lib/package/packageVersionReport.js

@@ -48,11 +48,9 @@ async function getPackageVersionReport(options) {
             const ancestorVersionMap = await pkgUtils.getPackageVersionStrings([record.AncestorId], options.connection);
             record.AncestorVersion = ancestorVersionMap.get(record.AncestorId);
         }
-        else {
-            if (record.PackageType !== 'Managed') {
-                record.AncestorVersion = null;
-                record.AncestorId = null;
-            }
+        else if (record.PackageType !== 'Managed') {
+            record.AncestorVersion = null;
+            record.AncestorId = null;
         }
         record.HasPassedCodeCoverageCheck =
             record.Package2.IsOrgDependent === true || record.ValidationSkipped === true

package/lib/package/subscriberPackageVersion.js

@@ -297,7 +297,7 @@ class SubscriberPackageVersion {
             // before starting the install, check to see if the package version is available for install
             await (0, packageInstall_1.waitForPublish)(this.connection, await this.getId(), options.publishFrequency, options.publishTimeout, pkgInstallCreateRequest.Password);
             const pkgVersionInstallRequest = await (0, packageInstall_1.createPackageInstallRequest)(this.connection, pkgInstallCreateRequest, await this.getPackageType());
-            return SubscriberPackageVersion.installStatus(this.connection, pkgVersionInstallRequest.Id, pkgInstallCreateRequest.Password, options);
+            return await SubscriberPackageVersion.installStatus(this.connection, pkgVersionInstallRequest.Id, pkgInstallCreateRequest.Password, options);
         }
         catch (e) {
             throw (0, utils_1.applyErrorAction)((0, utils_1.massageErrorMessage)(e));
@@ -310,7 +310,7 @@ class SubscriberPackageVersion {
      * @param wait
      */
     async uninstall(frequency = kit_1.Duration.milliseconds(0), wait = kit_1.Duration.milliseconds(0)) {
-        return await (0, packageUninstall_1.uninstallPackage)(await this.getId(), this.connection, frequency, wait);
+        return (0, packageUninstall_1.uninstallPackage)(await this.getId(), this.connection, frequency, wait);
     }
     /**
      * Returns an array of RSS and CSP external sites for the package.
@@ -338,6 +338,7 @@ class SubscriberPackageVersion {
         }
         return Reflect.get(this.data || {}, field);
     }
+    // eslint-disable-next-line class-methods-use-this
     getFieldsForQuery(options) {
         return exports.SubscriberPackageVersionFields.filter((field) => !highCostQueryFields.includes(field) || options.includeHighCostFields);
     }

package/lib/package1/package1Version.js

@@ -104,9 +104,11 @@ class Package1Version {
                 await core_1.Lifecycle.getInstance().emit(interfaces_1.Package1VersionEvents.create.progress, { timeout, pollingResult });
                 return { completed: false, payload: pollingResult };
             default: {
-                if (pollingResult?.Errors?.errors?.length > 0) {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+                const errors = pollingResult?.Errors?.errors;
+                if (errors?.length > 0) {
                     throw messages.createError('package1VersionCreateCommandUploadFailure', [
-                        pollingResult.Errors.errors.map((e) => e.message).join(os.EOL),
+                        errors.map((e) => e.message).join(os.EOL),
                     ]);
                 }
                 else {

package/lib/utils/packageUtils.d.ts

@@ -25,7 +25,7 @@ export declare const BY_PREFIX: IdRegistry;
 export declare const BY_LABEL: IdRegistry;
 export declare function validateId(idObj: Many<IdRegistryValue>, value: string): void;
 export declare function getSourceApiVersion(project: SfProject): string;
-export declare function validateIdNoThrow(idObj: Many<IdRegistryValue>, value: any): IdRegistryValue | false;
+export declare function validateIdNoThrow(idObj: Many<IdRegistryValue>, value: string): IdRegistryValue | boolean;
 export declare function applyErrorAction(err: Error): Error;
 export declare function massageErrorMessage(err: Error): Error;
 /**

package/lib/utils/packageUtils.js

@@ -44,12 +44,8 @@ exports.DEFAULT_PACKAGE_DIR = {
     versionNumber: '0.1.0.NEXT',
     default: true,
 };
-exports.BY_PREFIX = (() => {
-    return Object.fromEntries(ID_REGISTRY.map((id) => [id.prefix, { prefix: id.prefix, label: id.label }]));
-})();
-exports.BY_LABEL = (() => {
-    return Object.fromEntries(ID_REGISTRY.map((id) => [id.label.replace(/ /g, '_').toUpperCase(), { prefix: id.prefix, label: id.label }]));
-})();
+exports.BY_PREFIX = (() => Object.fromEntries(ID_REGISTRY.map((id) => [id.prefix, { prefix: id.prefix, label: id.label }])))();
+exports.BY_LABEL = (() => Object.fromEntries(ID_REGISTRY.map((id) => [id.label.replace(/ /g, '_').toUpperCase(), { prefix: id.prefix, label: id.label }])))();
 function validateId(idObj, value) {
     if (!validateIdNoThrow(idObj, value)) {
         throw messages.createError('invalidIdOrAlias', [
@@ -61,8 +57,7 @@ function validateId(idObj, value) {
 }
 exports.validateId = validateId;
 function getSourceApiVersion(project) {
-    const apiVersion = project.getSfProjectJson().get('sourceApiVersion');
-    return apiVersion;
+    return project?.getSfProjectJson().get('sourceApiVersion');
 }
 exports.getSourceApiVersion = getSourceApiVersion;
 function validateIdNoThrow(idObj, value) {
@@ -259,6 +254,7 @@ async function queryWithInConditionChunking(query, items, replaceToken, connecti
         }
         const itemsStr = `${items.slice(itemsQueried, itemsQueried + chunkCount).join("','")}`;
         const queryChunk = query.replace(replaceToken, itemsStr);
+        // eslint-disable-next-line no-await-in-loop
         const result = await connection.tooling.query(queryChunk);
         if (result && result.records.length > 0) {
             records = records.concat(result.records);
@@ -367,9 +363,7 @@ async function generatePackageAliasEntry(connection, project, packageVersionId,
 }
 exports.generatePackageAliasEntry = generatePackageAliasEntry;
 function formatDate(date) {
-    const pad = (num) => {
-        return num < 10 ? `0${num}` : `${num}`;
-    };
+    const pad = (num) => (num < 10 ? `0${num}` : `${num}`);
     return `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())} ${pad(date.getHours())}:${pad(date.getMinutes())}`;
 }
 exports.formatDate = formatDate;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/packaging",
-  "version": "0.1.17",
+  "version": "0.1.18",
   "description": "packing libraries to Salesforce packaging platform",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",
@@ -57,7 +57,7 @@
   "devDependencies": {
     "@salesforce/cli-plugins-testkit": "^3.2.2",
     "@salesforce/dev-config": "^3.1.0",
-    "@salesforce/dev-scripts": "^2.0.4",
+    "@salesforce/dev-scripts": "^3.1.0",
     "@salesforce/prettier-config": "^0.0.2",
     "@salesforce/ts-sinon": "^1.4.1",
     "@types/debug": "4.1.7",
@@ -70,17 +70,16 @@
     "commitizen": "^4.2.4",
     "eslint": "^8.26.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-config-salesforce": "^0.1.6",
+    "eslint-config-salesforce": "^1.1.0",
     "eslint-config-salesforce-license": "^0.1.6",
-    "eslint-config-salesforce-typescript": "^0.2.8",
+    "eslint-config-salesforce-typescript": "^1.1.1",
     "eslint-plugin-header": "3.1.1",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsdoc": "^39.3.25",
-    "eslint-plugin-prettier": "^4.0.0",
     "husky": "^8.0.1",
     "mocha": "^10.0.0",
     "nyc": "^15.1.0",
-    "prettier": "^2.6.2",
+    "prettier": "^2.7.1",
     "pretty-quick": "^3.1.3",
     "shelljs": "0.8.5",
     "sinon": "14.0.1",