@salesforce/core 6.7.7-qa.1 → 7.0.0

package/lib/org/authInfo.js

@@ -647,22 +647,22 @@ class AuthInfo extends kit_1.AsyncOptionalCreatable {
         // If options were passed, use those before checking cache and reading an auth file.
         let authConfig;
         if (options) {
-            const clonedOptions = structuredClone(options);
-            if (this.isTokenOptions(clonedOptions)) {
-                authConfig = clonedOptions;
-                const userInfo = await this.retrieveUserInfo((0, ts_types_1.ensureString)(clonedOptions.instanceUrl), (0, ts_types_1.ensureString)(clonedOptions.accessToken));
+            options = structuredClone(options);
+            if (this.isTokenOptions(options)) {
+                authConfig = options;
+                const userInfo = await this.retrieveUserInfo((0, ts_types_1.ensureString)(options.instanceUrl), (0, ts_types_1.ensureString)(options.accessToken));
                 this.update({ username: userInfo?.username, orgId: userInfo?.organizationId });
             }
             else {
                 if (this.options.parentUsername) {
                     const parentFields = await this.loadDecryptedAuthFromConfig(this.options.parentUsername);
-                    clonedOptions.clientId = parentFields.clientId;
+                    options.clientId = parentFields.clientId;
                     if (process.env.SFDX_CLIENT_SECRET) {
-                        clonedOptions.clientSecret = process.env.SFDX_CLIENT_SECRET;
+                        options.clientSecret = process.env.SFDX_CLIENT_SECRET;
                     }
                     else {
                         // Grab whatever flow is defined
-                        Object.assign(clonedOptions, {
+                        Object.assign(options, {
                             clientSecret: parentFields.clientSecret,
                             privateKey: parentFields.privateKey ? (0, node_path_1.resolve)(parentFields.privateKey) : parentFields.privateKey,
                         });
@@ -670,22 +670,22 @@ class AuthInfo extends kit_1.AsyncOptionalCreatable {
                 }
                 // jwt flow
                 // Support both sfdx and jsforce private key values
-                if (!clonedOptions.privateKey && clonedOptions.privateKeyFile) {
-                    clonedOptions.privateKey = (0, node_path_1.resolve)(clonedOptions.privateKeyFile);
+                if (!options.privateKey && options.privateKeyFile) {
+                    options.privateKey = (0, node_path_1.resolve)(options.privateKeyFile);
                 }
-                if (clonedOptions.privateKey) {
-                    authConfig = await this.authJwt(clonedOptions);
+                if (options.privateKey) {
+                    authConfig = await this.authJwt(options);
                 }
-                else if (!clonedOptions.authCode && clonedOptions.refreshToken) {
+                else if (!options.authCode && options.refreshToken) {
                     // refresh token flow (from sfdxUrl or OAuth refreshFn)
-                    authConfig = await this.buildRefreshTokenConfig(clonedOptions);
+                    authConfig = await this.buildRefreshTokenConfig(options);
                 }
                 else if (this.options.oauth2 instanceof jsforce_node_1.OAuth2) {
                     // authcode exchange / web auth flow
-                    authConfig = await this.exchangeToken(clonedOptions, this.options.oauth2);
+                    authConfig = await this.exchangeToken(options, this.options.oauth2);
                 }
                 else {
-                    authConfig = await this.exchangeToken(clonedOptions);
+                    authConfig = await this.exchangeToken(options);
                 }
             }
             authConfig.isDevHub = await this.determineIfDevHub((0, ts_types_1.ensureString)(authConfig.instanceUrl), (0, ts_types_1.ensureString)(authConfig.accessToken));

package/lib/sfError.d.ts

@@ -1,4 +1,4 @@
-import { AnyJson, JsonMap } from '@salesforce/ts-types';
+import { AnyJson } from '@salesforce/ts-types';
 export type SfErrorOptions<T extends ErrorDataProperties = ErrorDataProperties> = {
     message: string;
     exitCode?: number;
@@ -10,6 +10,14 @@ export type SfErrorOptions<T extends ErrorDataProperties = ErrorDataProperties>
     actions?: string[];
 };
 type ErrorDataProperties = AnyJson;
+type SfErrorToObjectResult = {
+    name: string;
+    message: string;
+    exitCode: number;
+    actions?: string[];
+    context?: string;
+    data?: ErrorDataProperties;
+};
 /**
  * A generalized sfdx error which also contains an action. The action is used in the
  * CLI to help guide users past the error.
@@ -77,6 +85,6 @@ export declare class SfError<T extends ErrorDataProperties = ErrorDataProperties
     /**
      * Convert an {@link SfError} state to an object. Returns a plain object representing the state of this error.
      */
-    toObject(): JsonMap;
+    toObject(): SfErrorToObjectResult;
 }
 export {};

package/lib/sfError.js

@@ -60,7 +60,9 @@ class SfError extends Error {
         super(message);
         this.name = name;
         this.cause = exitCodeOrCause instanceof Error ? exitCodeOrCause : cause;
-        this.actions = actions;
+        if (actions?.length) {
+            this.actions = actions;
+        }
         if (typeof exitCodeOrCause === 'number') {
             this.exitCode = exitCodeOrCause;
         }
@@ -77,8 +79,12 @@ class SfError extends Error {
     /** like the constructor, but takes an typed object and let you also set context and data properties */
     static create(inputs) {
         const error = new SfError(inputs.message, inputs.name, inputs.actions, inputs.exitCode, inputs.cause);
-        error.data = inputs.data;
-        error.context = inputs.context;
+        if (inputs.data) {
+            error.data = inputs.data;
+        }
+        if (inputs.context) {
+            error.context = inputs.context;
+        }
         return error;
     }
     /**
@@ -134,7 +140,7 @@ class SfError extends Error {
             name: this.name,
             message: this.message ?? this.name,
             exitCode: this.exitCode,
-            actions: this.actions,
+            ...(this.actions?.length ? { actions: this.actions } : {}),
             ...(this.context ? { context: this.context } : {}),
             ...(this.data ? { data: this.data } : {}),
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core",
-  "version": "6.7.7-qa.1",
+  "version": "7.0.0",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/index",
   "types": "lib/index.d.ts",