@salesforce/core 3.8.0 → 3.8.1

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.8.1](https://github.com/forcedotcom/sfdx-core/compare/v3.8.0...v3.8.1) (2022-03-18)
+
+### Bug Fixes
+
+- adjust mock org test data to conform to v3 ([38faf50](https://github.com/forcedotcom/sfdx-core/commit/38faf5063931955066312c24b4188b12c40098a5))
+- side effects function should not save when no changes ([#541](https://github.com/forcedotcom/sfdx-core/issues/541)) ([6bfb841](https://github.com/forcedotcom/sfdx-core/commit/6bfb84172fdf74882102b9ffc6e6fbfe58e6ffbc))
+
 ## [3.8.0](https://github.com/forcedotcom/sfdx-core/compare/v3.7.9...v3.8.0) (2022-03-09)
 
 ### Features

package/lib/org/authInfo.d.ts

@@ -232,7 +232,7 @@ export declare class AuthInfo extends AsyncOptionalCreatable<AuthInfo.Options> {
     getSfdxAuthUrl(): string;
     /**
      * Convenience function to handle typical side effects encountered when dealing with an AuthInfo.
-     * Given the values supplied in parameter sideEffects, this functions will set auth alias, default auth
+     * Given the values supplied in parameter sideEffects, this function will set auth alias, default auth
      * and default dev hub.
      *
      * @param sideEffects - instance of AuthSideEffects

package/lib/org/authInfo.js

@@ -400,19 +400,21 @@ class AuthInfo extends kit_1.AsyncOptionalCreatable {
     }
     /**
      * Convenience function to handle typical side effects encountered when dealing with an AuthInfo.
-     * Given the values supplied in parameter sideEffects, this functions will set auth alias, default auth
+     * Given the values supplied in parameter sideEffects, this function will set auth alias, default auth
      * and default dev hub.
      *
      * @param sideEffects - instance of AuthSideEffects
      */
     async handleAliasAndDefaultSettings(sideEffects) {
-        if (sideEffects.alias)
-            await this.setAlias(sideEffects.alias);
-        if (sideEffects.setDefault)
-            await this.setAsDefault({ org: true });
-        if (sideEffects.setDefaultDevHub)
-            await this.setAsDefault({ devHub: true });
-        await this.save();
+        if (sideEffects.alias || sideEffects.setDefault || sideEffects.setDefaultDevHub) {
+            if (sideEffects.alias)
+                await this.setAlias(sideEffects.alias);
+            if (sideEffects.setDefault)
+                await this.setAsDefault({ org: true });
+            if (sideEffects.setDefaultDevHub)
+                await this.setAsDefault({ devHub: true });
+            await this.save();
+        }
     }
     /**
      * Set the target-env (default) or the target-dev-hub to the alias if

package/lib/testSetup.d.ts

@@ -377,7 +377,8 @@ export declare class StreamingMockCometClient extends CometClient {
  */
 export declare class MockTestOrgData {
     testId: string;
-    alias?: string;
+    aliases?: string[];
+    configs?: string[];
     username: string;
     devHubUsername?: string;
     orgId: string;
@@ -390,6 +391,9 @@ export declare class MockTestOrgData {
     refreshToken: string;
     userId: string;
     redirectUri: string;
+    isDevHub?: boolean;
+    isScratchOrg?: boolean;
+    isExpired?: boolean | 'unknown';
     constructor(id?: string, options?: {
         username: string;
     });

package/lib/testSetup.js

@@ -493,12 +493,13 @@ class MockTestOrgData {
         this.devHubUsername = username;
     }
     makeDevHub() {
-        (0, kit_1.set)(this, 'isDevHub', true);
+        this.isDevHub = true;
     }
     createUser(user) {
         const userMock = new MockTestOrgData();
         userMock.username = user;
-        userMock.alias = this.alias;
+        userMock.aliases = this.aliases;
+        userMock.configs = this.configs;
         userMock.devHubUsername = this.devHubUsername;
         userMock.orgId = this.orgId;
         userMock.loginUrl = this.loginUrl;
@@ -506,6 +507,9 @@ class MockTestOrgData {
         userMock.clientId = this.clientId;
         userMock.clientSecret = this.clientSecret;
         userMock.redirectUri = this.redirectUri;
+        userMock.isDevHub = this.isDevHub;
+        userMock.isScratchOrg = this.isScratchOrg;
+        userMock.isExpired = this.isExpired;
         return userMock;
     }
     getMockUserInfo() {
@@ -513,7 +517,8 @@ class MockTestOrgData {
             Id: this.userId,
             Username: this.username,
             LastName: `user_lastname_${this.testId}`,
-            Alias: this.alias || 'user_alias_blah',
+            Alias: this.aliases ? this.aliases[0] : 'user_alias_blah',
+            Configs: this.configs,
             TimeZoneSidKey: `user_timezonesidkey_${this.testId}`,
             LocaleSidKey: `user_localesidkey_${this.testId}`,
             EmailEncodingKey: `user_emailencodingkey_${this.testId}`,
@@ -540,14 +545,10 @@ class MockTestOrgData {
         config.createdOrgInstance = 'CS1';
         config.created = '1519163543003';
         config.userId = this.userId;
-        // config.devHubUsername = 'tn@su-blitz.org';
         if (this.devHubUsername) {
             config.devHubUsername = this.devHubUsername;
         }
-        const isDevHub = (0, ts_types_1.getBoolean)(this, 'isDevHub');
-        if (isDevHub) {
-            config.isDevHub = isDevHub;
-        }
+        config.isDevHub = this.isDevHub;
         return config;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core",
-  "version": "3.8.0",
+  "version": "3.8.1",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",