@salesforce/core 3.7.2 → 3.7.3

package/lib/testSetup.d.ts

@@ -1,4 +1,3 @@
-/// <reference types="sfdx-faye" />
 /// <reference types="node" />
 import { EventEmitter } from 'events';
 import * as sinonType from 'sinon';
@@ -391,7 +390,9 @@ export declare class MockTestOrgData {
     refreshToken: string;
     userId: string;
     redirectUri: string;
-    constructor(id?: string);
+    constructor(id?: string, options?: {
+        username: string;
+    });
     createDevHubUsername(username: string): void;
     makeDevHub(): void;
     createUser(user: string): MockTestOrgData;

package/lib/testSetup.js

@@ -66,7 +66,7 @@ function defaultFakeConnectionRequest() {
  * ```
  * @param sinon
  */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
 const instantiateContext = (sinon) => {
     if (!sinon) {
         try {
@@ -413,7 +413,7 @@ class StreamingMockCometClient extends streamingClient_1.CometClient {
      * @param {StreamingMockCometSubscriptionOptions} options Extends the StreamingClient options.
      */
     constructor(options) {
-        super(options.url);
+        super();
         this.options = options;
         if (!this.options.messagePlaylist) {
             this.options.messagePlaylist = [{ id: this.options.id }];
@@ -475,11 +475,11 @@ exports.StreamingMockCometClient = StreamingMockCometClient;
  * Mock class for OrgData.
  */
 class MockTestOrgData {
-    constructor(id = uniqid()) {
+    constructor(id = uniqid(), options) {
         this.testId = id;
         this.userId = `user_id_${this.testId}`;
         this.orgId = `${this.testId}`;
-        this.username = `admin_${this.testId}@gb.org`;
+        this.username = (options === null || options === void 0 ? void 0 : options.username) || `admin_${this.testId}@gb.org`;
         this.loginUrl = `http://login.${this.testId}.salesforce.com`;
         this.instanceUrl = `http://instance.${this.testId}.salesforce.com`;
         this.clientId = `${this.testId}/client_id`;

package/lib/util/sfdcUrl.d.ts

@@ -36,9 +36,10 @@ export declare class SfdcUrl extends URL {
      * @returns {boolean} true if this is a local machine
      */
     isLocalUrl(): boolean;
+    toLightningDomain(): string;
     /**
      * Tests whether this url has the lightning domain extension
-     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again untill timeout
+     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again until timeout
      * If SFDX_DOMAIN_RETRY environment variable is set (number) it overrides the default timeout duration (240 seconds)
      *
      * @returns {Promise<true | never>} The resolved ip address or never

package/lib/util/sfdcUrl.js

@@ -12,12 +12,13 @@ const kit_1 = require("@salesforce/kit");
 const ts_types_1 = require("@salesforce/ts-types");
 const myDomainResolver_1 = require("../status/myDomainResolver");
 const logger_1 = require("../logger");
+const lifecycleEvents_1 = require("../lifecycleEvents");
 class SfdcUrl extends url_1.URL {
     constructor(input, base) {
         super(input.toString(), base);
         if (this.protocol !== 'https:' && !SfdcUrl.cache.has(this.origin)) {
             SfdcUrl.cache.add(this.origin);
-            process.emitWarning('Using insecure protocol: ' + this.protocol + ' on url: ' + this.origin);
+            void lifecycleEvents_1.Lifecycle.getInstance().emitWarning(`Using insecure protocol: ${this.protocol} on url: ${this.origin}`);
         }
     }
     static isValidUrl(input) {
@@ -105,25 +106,31 @@ class SfdcUrl extends url_1.URL {
         const LOCAL_PARTS = ['localhost.sfdcdev.', '.internal.'];
         return LOCAL_PARTS.some((part) => this.origin.includes(part));
     }
+    toLightningDomain() {
+        if (this.origin.endsWith('.my.salesforce.mil')) {
+            return this.origin.replace('.my.salesforce.mil', '.lightning.crmforce.mil');
+        }
+        // all non-mil domains
+        return `https://${ts_types_1.ensureArray(/https?:\/\/([^.]*)/.exec(this.origin))
+            .slice(1, 2)
+            .pop()}.lightning.force.com`;
+    }
     /**
      * Tests whether this url has the lightning domain extension
-     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again untill timeout
+     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again until timeout
      * If SFDX_DOMAIN_RETRY environment variable is set (number) it overrides the default timeout duration (240 seconds)
      *
      * @returns {Promise<true | never>} The resolved ip address or never
      * @throws {@link SfdxError} If can't resolve DNS.
      */
     async checkLightningDomain() {
-        const domain = `https://${ts_types_1.ensureArray(/https?:\/\/([^.]*)/.exec(this.origin))
-            .slice(1, 2)
-            .pop()}.lightning.force.com`;
         const quantity = ts_types_1.ensureNumber(new kit_1.Env().getNumber('SFDX_DOMAIN_RETRY', 240));
         const timeout = new kit_1.Duration(quantity, kit_1.Duration.Unit.SECONDS);
         if (this.isInternalUrl() || timeout.seconds === 0) {
             return true;
         }
         const resolver = await myDomainResolver_1.MyDomainResolver.create({
-            url: new url_1.URL(domain),
+            url: new url_1.URL(this.toLightningDomain()),
             timeout,
             frequency: new kit_1.Duration(1, kit_1.Duration.Unit.SECONDS),
         });
@@ -155,6 +162,7 @@ class SfdcUrl extends url_1.URL {
      */
     isSandboxUrl(createdOrgInstance) {
         return ((createdOrgInstance && /^cs|s$/gi.test(createdOrgInstance)) ||
+            this.origin.endsWith('sandbox.my.salesforce.mil') ||
             /sandbox\.my\.salesforce\.com/gi.test(this.origin) || // enhanced domains >= 230
             /(cs[0-9]+(\.my|)\.salesforce\.com)/gi.test(this.origin) || // my domains on CS instance OR CS instance without my domain
             /([a-z]{3}[0-9]+s\.sfdc-.+\.salesforce\.com)/gi.test(this.origin) || // falcon sandbox ex: usa2s.sfdc-whatever.salesforce.com

package/messages/core.json

@@ -12,9 +12,9 @@
   "OrgDataNotAvailableErrorAction2": "Use `sfdx force:config:set` to update the defaultusername.",
   "OrgDataNotAvailableErrorAction3": "Use `sfdx force:org:create` to create a new org.",
   "OrgDataNotAvailableErrorAction4": "Use `sfdx force:auth` to authenticate an existing org.",
-  "NamedOrgNotFound": "No AuthInfo found for name %s",
-  "NoAliasesFound": "Nothing to set",
-  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s]",
+  "NamedOrgNotFound": "No authorization information found for %s %s.",
+  "NoAliasesFound": "Nothing to set.",
+  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s].",
   "NoAuthInfoFound": "No authorization information can be found.",
   "InvalidJsonCasing": "All JSON input must have heads down camelcase keys.  E.g., { sfdcLoginUrl: \"https://login.salesforce.com\" }\nFound \"%s\" at %s"
 }

package/messages/core.md

@@ -41,7 +41,7 @@ An attempt to refresh the authentication token failed with a 'Data Not Found Err
 
 # namedOrgNotFound
 
-No AuthInfo found for name %s.
+No authorization information found for %s.
 
 # noAliasesFound
 

package/messages/org.md

@@ -5,3 +5,39 @@ The provided dev hub username %s is not a valid dev hub.
 # noUsernameFound
 
 No username found.
+
+# noDevHubFound
+
+Unable to associate this scratch org with a DevHub.
+
+# deleteOrgHubError
+
+The Dev Hub org cannot be deleted.
+
+# insufficientAccessToDelete
+
+You do not have the appropriate permissions to delete a scratch org. Please contact your Salesforce admin.
+
+# scratchOrgNotFound
+
+Attempting to delete an expired or deleted org
+
+# sandboxDeleteFailed
+
+The sandbox org deletion failed with a result of %s.
+
+# sandboxNotFound
+
+We can't find a SandboxProcess for the sandbox org %s.
+
+# sandboxInfoCreateFailed
+
+The sandbox org creation failed with a result of %s.
+
+# missingAuthUsername
+
+The sandbox %s does not have an authorized username.
+
+# orgPollingTimeout
+
+Sandbox status is %s; timed out waiting for completion.

package/package.json

@@ -1,21 +1,23 @@
 {
   "name": "@salesforce/core",
-  "version": "3.7.2",
+  "version": "3.7.3",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
+  "types": "lib/exported.d.ts",
   "license": "BSD-3-Clause",
   "scripts": {
     "build": "sf-build",
     "ci-docs": "yarn sf-ci-docs",
     "clean": "sf-clean",
-    "clean-all": "-clean all",
+    "clean-all": "sf-clean all",
     "compile": "sf-compile",
     "docs": "sf-docs",
     "format": "sf-format",
     "lint": "sf-lint",
     "lint-fix": "yarn sf-lint --fix",
     "postcompile": "tsc -p test && tsc -p typedocExamples",
-    "prepack": "sf-build",
+    "prepack": "sf-prepack",
+    "prepare": "sf-install",
     "pretest": "sf-compile-test",
     "test": "sf-test"
   },
@@ -31,13 +33,6 @@
     "messages",
     "!lib/**/*.map"
   ],
-  "husky": {
-    "hooks": {
-      "commit-msg": "sf-husky-commit-msg",
-      "pre-commit": "sf-husky-pre-commit",
-      "pre-push": "sf-husky-pre-push"
-    }
-  },
   "dependencies": {
     "@salesforce/bunyan": "^2.0.0",
     "@salesforce/kit": "^1.5.8",
@@ -46,29 +41,27 @@
     "@types/graceful-fs": "^4.1.5",
     "@types/jsforce": "^1.9.29",
     "@types/mkdirp": "^1.0.1",
-    "@types/sfdx-faye": "^1.0.0",
+    "@types/semver": "^7.3.9",
     "change-case": "^4.1.2",
     "debug": "^3.1.0",
+    "faye": "^1.4.0",
     "form-data": "^4.0.0",
     "graceful-fs": "^4.2.4",
     "jsen": "0.6.6",
     "jsforce": "2.0.0-beta.7",
     "jsonwebtoken": "8.5.0",
     "mkdirp": "1.0.4",
-    "sfdx-faye": "^1.0.9",
     "ts-retry-promise": "^0.6.0"
   },
   "devDependencies": {
-    "@salesforce/dev-config": "^2.0.0",
-    "@salesforce/dev-scripts": "^0.9.18",
+    "@salesforce/dev-config": "^2.1.2",
+    "@salesforce/dev-scripts": "^1.0.2",
     "@salesforce/prettier-config": "^0.0.2",
     "@salesforce/ts-sinon": "^1.3.15",
     "@types/debug": "0.0.30",
     "@types/jsen": "0.0.19",
     "@types/jsonwebtoken": "8.3.2",
-    "@types/sfdx-faye": "^1.0.0",
     "@types/shelljs": "0.7.8",
-    "@types/sinon": "^9.0.8",
     "@typescript-eslint/eslint-plugin": "^4.2.0",
     "@typescript-eslint/parser": "4.26.0",
     "chai": "^4.2.0",
@@ -76,23 +69,22 @@
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-config-salesforce": "^0.1.6",
-    "eslint-config-salesforce-license": "^0.1.0",
+    "eslint-config-salesforce-license": "^0.1.6",
     "eslint-config-salesforce-typescript": "^0.2.7",
     "eslint-plugin-header": "^3.0.0",
     "eslint-plugin-import": "^2.20.2",
     "eslint-plugin-jsdoc": "^27.0.3",
     "eslint-plugin-prettier": "^3.1.3",
-    "husky": "^4.2.5",
-    "mocha": "^7.2.0",
+    "husky": "^7.0.4",
+    "mocha": "^8.4.0",
     "nyc": "^15.1.0",
     "prettier": "^2.0.5",
-    "pretty-quick": "^2.0.1",
+    "pretty-quick": "^3.1.0",
     "shelljs": "0.8.1",
-    "sinon": "^9.0.2",
-    "ts-node": "^8.10.2",
+    "sinon": "10.0.0",
+    "ts-node": "^10.0.0",
     "typescript": "^4.1.3"
   },
-  "types": "lib/exported.d.ts",
   "repository": {
     "type": "git",
     "url": "https://github.com/forcedotcom/sfdx-core.git"