@salesforce/core 3.30.10 → 3.30.11

package/lib/org/scratchOrgInfoGenerator.js

@@ -10,7 +10,6 @@ exports.getScratchOrgInfoPayload = exports.generateScratchOrgInfo = exports.getA
 const fs_1 = require("fs");
 const kit_1 = require("@salesforce/kit");
 const ts_types_1 = require("@salesforce/ts-types");
-const sfdc_1 = require("../util/sfdc");
 const sfProject_1 = require("../sfProject");
 const webOAuthServer_1 = require("../webOAuthServer");
 const messages_1 = require("../messages");
@@ -60,7 +59,7 @@ const getAncestorIds = async (scratchOrgInfo, projectJson, hubOrg) => {
     }
     const packagesWithAncestors = (await projectJson.getPackageDirectories())
         // check that the package has any ancestor types (id or version)
-        .filter((packageDir) => packageDir.ancestorId || packageDir.ancestorVersion);
+        .filter((packageDir) => packageDir.ancestorId ?? packageDir.ancestorVersion);
     if (packagesWithAncestors.length === 0) {
         return '';
     }
@@ -184,31 +183,19 @@ exports.generateScratchOrgInfo = generateScratchOrgInfo;
  */
 const getScratchOrgInfoPayload = async (options) => {
     let warnings = [];
-    // orgConfig input overrides definitionjson (-j option; hidden/deprecated)
-    const definitionJson = options.definitionjson ? JSON.parse(options.definitionjson) : {};
-    const orgConfigInput = { ...definitionJson, ...(options.orgConfig ?? {}) };
-    let scratchOrgInfoPayload = orgConfigInput;
-    // the -f option
-    if (options.definitionfile) {
-        try {
-            const fileData = await fs_1.promises.readFile(options.definitionfile, 'utf8');
-            const defFileContents = (0, kit_1.parseJson)(fileData);
-            // definitionjson and orgConfig override file input
-            scratchOrgInfoPayload = { ...defFileContents, ...orgConfigInput };
-        }
-        catch (err) {
-            const error = err;
-            if (error.name === 'JsonParseError') {
-                throw new sfError_1.SfError(`An error occurred parsing ${options.definitionfile}`);
-            }
-            throw sfError_1.SfError.wrap(error);
-        }
-    }
+    // orgConfig input overrides definitionjson (-j option; hidden/deprecated) overrides definitionfile (-f option)
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+    const scratchOrgInfoPayload = {
+        ...(options.definitionfile ? await parseDefinitionFile(options.definitionfile) : {}),
+        ...(options.definitionjson ? JSON.parse(options.definitionjson) : {}),
+        ...(options.orgConfig ?? {}),
+    };
     // scratchOrgInfoPayload must be heads down camelcase.
-    const upperCaseKey = sfdc_1.sfdc.findUpperCaseKeys(scratchOrgInfoPayload);
-    if (upperCaseKey) {
-        throw new sfError_1.SfError('InvalidJsonCasing', upperCaseKey);
-    }
+    Object.keys(scratchOrgInfoPayload).forEach((key) => {
+        if (key[0].toUpperCase() === key[0]) {
+            throw new sfError_1.SfError('InvalidJsonCasing', key);
+        }
+    });
     // Now run the fully resolved user input against the validator
     Object.keys(scratchOrgInfoPayload).forEach((key) => {
         optionsValidator(key, scratchOrgInfoPayload);
@@ -233,9 +220,23 @@ const getScratchOrgInfoPayload = async (options) => {
     return {
         scratchOrgInfoPayload,
         // Ignore ancestor ids only when 'nonamespace' or 'noancestors' options are specified
-        ignoreAncestorIds: options.nonamespace || options.noancestors || false,
+        ignoreAncestorIds: options.nonamespace ?? options.noancestors ?? false,
         warnings,
     };
 };
 exports.getScratchOrgInfoPayload = getScratchOrgInfoPayload;
+const parseDefinitionFile = async (definitionFile) => {
+    try {
+        const fileData = await fs_1.promises.readFile(definitionFile, 'utf8');
+        const defFileContents = (0, kit_1.parseJson)(fileData);
+        return defFileContents;
+    }
+    catch (err) {
+        const error = err;
+        if (error.name === 'JsonParseError') {
+            throw new sfError_1.SfError(`An error occurred parsing ${definitionFile}`);
+        }
+        throw sfError_1.SfError.wrap(error);
+    }
+};
 //# sourceMappingURL=scratchOrgInfoGenerator.js.map

package/lib/org/scratchOrgLifecycleEvents.js

@@ -19,9 +19,7 @@ exports.scratchOrgLifecycleStages = [
     'deploy settings',
     'done',
 ];
-const emit = async (event) => {
-    emitter.emit(exports.scratchOrgLifecycleEventName, event);
-};
+const emit = async (event) => emitter.emit(exports.scratchOrgLifecycleEventName, event);
 exports.emit = emit;
 const postOrgCreateHookFields = [
     'accessToken',
@@ -35,9 +33,7 @@ const postOrgCreateHookFields = [
     'orgId',
     'username',
 ];
-const isHookField = (key) => {
-    return postOrgCreateHookFields.includes(key);
-};
+const isHookField = (key) => postOrgCreateHookFields.includes(key);
 const emitPostOrgCreate = async (authFields) => {
     await emitter.emit('postorgcreate', Object.fromEntries(Object.entries(authFields).filter(([key]) => isHookField(key))));
 };

package/lib/org/scratchOrgSettingsGenerator.js

@@ -141,8 +141,8 @@ class SettingsGenerator {
         this.allBusinessProcesses = [];
         this.logger = logger_1.Logger.childFromRoot('SettingsGenerator');
         // If SFDX_MDAPI_TEMP_DIR is set, copy settings to that dir for people to inspect.
-        const mdApiTmpDir = options?.mdApiTmpDir || kit_1.env.getString('SFDX_MDAPI_TEMP_DIR');
-        this.shapeDirName = options?.shapeDirName || `shape_${Date.now()}`;
+        const mdApiTmpDir = options?.mdApiTmpDir ?? kit_1.env.getString('SFDX_MDAPI_TEMP_DIR');
+        this.shapeDirName = options?.shapeDirName ?? `shape_${Date.now()}`;
         this.packageFilePath = path.join(this.shapeDirName, 'package.xml');
         let storePath;
         if (!options?.asDirectory) {
@@ -155,6 +155,7 @@ class SettingsGenerator {
         }
     }
     /** extract the settings from the scratch def file, if they are present. */
+    // eslint-disable-next-line @typescript-eslint/require-await
     async extract(scratchDef) {
         this.logger.debug('extracting settings from scratch definition file');
         this.settingData = scratchDef.settings;
@@ -254,22 +255,21 @@ class SettingsGenerator {
     }
     async writeObjectSettingsIfNeeded(objectsDir, allRecordTypes, allbusinessProcesses) {
         if (this.objectSettingsData) {
-            for (const [item, value] of Object.entries(this.objectSettingsData)) {
+            await Promise.all(Object.entries(this.objectSettingsData).map(([item, value]) => {
                 const fileContent = (0, exports.createRecordTypeAndBusinessProcessFileContent)(item, value, allRecordTypes, allbusinessProcesses);
                 const xml = js2xmlparser.parse('CustomObject', fileContent);
-                await this.writer.addToStore(xml, path.join(objectsDir, (0, kit_1.upperFirst)(item) + '.object'));
-            }
+                return this.writer.addToStore(xml, path.join(objectsDir, (0, kit_1.upperFirst)(item) + '.object'));
+            }));
         }
     }
     async writeSettingsIfNeeded(settingsDir) {
         if (this.settingData) {
-            for (const item of Object.keys(this.settingData)) {
-                const value = (0, ts_types_1.getObject)(this.settingData, item);
+            await Promise.all(Object.entries(this.settingData).map(([item, value]) => {
                 const typeName = (0, kit_1.upperFirst)(item);
                 const fname = typeName.replace('Settings', '');
                 const fileContent = js2xmlparser.parse(typeName, value);
-                await this.writer.addToStore(fileContent, path.join(settingsDir, fname + '.settings'));
-            }
+                return this.writer.addToStore(fileContent, path.join(settingsDir, fname + '.settings'));
+            }));
         }
     }
 }

package/lib/org/scratchOrgTypes.d.ts

@@ -6,7 +6,7 @@ export interface ScratchOrgInfo {
     ConnectedAppConsumerKey?: string;
     Country?: string;
     Description?: string;
-    DurationDays?: string;
+    DurationDays?: number;
     Edition?: string;
     readonly ErrorCode?: string;
     readonly ExpirationDate?: string;

package/lib/org/user.js

@@ -80,6 +80,7 @@ async function retrieveUserFields(logger, username) {
         logger.debug('not a accessToken');
     }
     const fromFields = Object.keys(exports.REQUIRED_FIELDS).map(kit_1.upperFirst);
+    // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
     const requiredFieldsFromAdminQuery = `SELECT ${fromFields} FROM User WHERE Username='${username}'`;
     const result = await connection.query(requiredFieldsFromAdminQuery);
     logger.debug('Successfully retrieved the admin user for this org.');
@@ -265,9 +266,7 @@ class User extends kit_1.AsyncCreatable {
             throw messages.createError('permsetNamesAreRequired');
         }
         const assignments = await permissionSetAssignment_1.PermissionSetAssignment.init(this.org);
-        for (const permsetName of permsetNames) {
-            await assignments.create(id, permsetName);
-        }
+        await Promise.all(permsetNames.map((permsetName) => assignments.create(id, permsetName)));
     }
     /**
      * Method for creating a new User.
@@ -337,7 +336,7 @@ class User extends kit_1.AsyncCreatable {
      * ```
      */
     async retrieve(username) {
-        return await retrieveUserFields(this.logger, username);
+        return retrieveUserFields(this.logger, username);
     }
     /**
      * Helper method that verifies the server's User object is available and if so allows persisting the Auth information.
@@ -348,7 +347,7 @@ class User extends kit_1.AsyncCreatable {
         const connection = await connection_1.Connection.create({ authInfo: newUserAuthInfo });
         this.logger.debug(`Created connection for user: ${newUserAuthInfo.getUsername()}`);
         const userDescribe = await connection.describe('User');
-        if (userDescribe && userDescribe.fields) {
+        if (userDescribe?.fields) {
             await newUserAuthInfo.save();
             return newUserAuthInfo;
         }
@@ -401,6 +400,7 @@ class User extends kit_1.AsyncCreatable {
                     errors.forEach((singleMessage) => {
                         if (!(0, ts_types_1.isJsonMap)(singleMessage))
                             return;
+                        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
                         message = `${message}${os_1.EOL}${singleMessage.description}`;
                     });
                 }
@@ -419,9 +419,10 @@ class User extends kit_1.AsyncCreatable {
             userId: fields.id,
         };
     }
+    // eslint-disable-next-line class-methods-use-this
     async rawRequest(conn, options) {
         return new Promise((resolve, reject) => {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-argument
             const httpApi = new http_api_1.HttpApi(conn, options);
             httpApi.on('response', (response) => resolve(response));
             httpApi.request(options).catch(reject);

package/lib/schema/printer.d.ts

@@ -3,6 +3,8 @@ import { Logger } from '../logger';
 /**
  * Renders schema properties.  By default, this is simply an identity transform.  Subclasses may provide more
  * interesting decorations of each values, such as ANSI coloring.
+ *
+ * @deprecated
  */
 export declare class SchemaPropertyRenderer {
     /**
@@ -33,6 +35,8 @@ export declare class SchemaPropertyRenderer {
 /**
  * Prints a JSON schema in a human-friendly format.
  *
+ * @deprecated
+ *
  * ```
  * import chalk from 'chalk';
  * class MyPropertyRenderer extends SchemaPropertyRenderer {

package/lib/schema/printer.js

@@ -5,6 +5,7 @@
  * Licensed under the BSD 3-Clause license.
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
+/* eslint-disable class-methods-use-this */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SchemaPrinter = exports.SchemaPropertyRenderer = void 0;
 const ts_types_1 = require("@salesforce/ts-types");
@@ -12,6 +13,8 @@ const sfError_1 = require("../sfError");
 /**
  * Renders schema properties.  By default, this is simply an identity transform.  Subclasses may provide more
  * interesting decorations of each values, such as ANSI coloring.
+ *
+ * @deprecated
  */
 class SchemaPropertyRenderer {
     /**
@@ -51,6 +54,8 @@ exports.SchemaPropertyRenderer = SchemaPropertyRenderer;
 /**
  * Prints a JSON schema in a human-friendly format.
  *
+ * @deprecated
+ *
  * ```
  * import chalk from 'chalk';
  * class MyPropertyRenderer extends SchemaPropertyRenderer {
@@ -178,40 +183,13 @@ class SchemaProperty {
         }
         const oneOfs = (0, ts_types_1.asJsonArray)(this.rawProperty.oneOf);
         if (oneOfs && !this.rawProperty.type) {
-            this.rawProperty.type = oneOfs
-                .map((value) => {
-                return (0, ts_types_1.isJsonMap)(value) ? value.type || value.$ref : value;
-            })
-                .join('|');
+            this.rawProperty.type = oneOfs.map((value) => ((0, ts_types_1.isJsonMap)(value) ? value.type ?? value.$ref : value)).join('|');
         }
         // Handle items references
         if ((0, ts_types_1.isJsonMap)(this.items) && this.items && this.items.$ref) {
             Object.assign(this.items, resolveRef(this.schema, this.items));
         }
     }
-    renderName() {
-        return this.propertyRenderer.renderName(this.name);
-    }
-    renderTitle() {
-        return this.propertyRenderer.renderTitle(this.title || '');
-    }
-    renderDescription() {
-        return this.propertyRenderer.renderDescription(this.description || '');
-    }
-    renderType() {
-        return this.propertyRenderer.renderType(this.type || '');
-    }
-    renderHeader() {
-        return `${this.renderName()}(${this.renderType()}) - ${this.renderTitle()}: ${this.renderDescription()}`;
-    }
-    renderArrayHeader() {
-        if (!this.items) {
-            return '';
-        }
-        const minItems = this.minItems ? ` - min ${this.minItems}` : '';
-        const prop = new SchemaProperty(this.logger, this.schema, 'items', this.items, this.propertyRenderer);
-        return `items(${prop.renderType()}${minItems}) - ${prop.renderTitle()}: ${prop.renderDescription()}`;
-    }
     get title() {
         return (0, ts_types_1.asString)(this.rawProperty.title);
     }
@@ -235,11 +213,34 @@ class SchemaProperty {
     }
     getProperty(key) {
         const properties = this.getProperties();
-        return (0, ts_types_1.asJsonMap)(properties && properties[key]);
+        return (0, ts_types_1.asJsonMap)(properties?.[key]);
     }
     getProperties() {
         return (0, ts_types_1.asJsonMap)(this.rawProperty.properties);
     }
+    renderName() {
+        return this.propertyRenderer.renderName(this.name);
+    }
+    renderTitle() {
+        return this.propertyRenderer.renderTitle(this.title ?? '');
+    }
+    renderDescription() {
+        return this.propertyRenderer.renderDescription(this.description ?? '');
+    }
+    renderType() {
+        return this.propertyRenderer.renderType(this.type ?? '');
+    }
+    renderHeader() {
+        return `${this.renderName()}(${this.renderType()}) - ${this.renderTitle()}: ${this.renderDescription()}`;
+    }
+    renderArrayHeader() {
+        if (!this.items) {
+            return '';
+        }
+        const minItems = this.minItems ? ` - min ${this.minItems}` : '';
+        const prop = new SchemaProperty(this.logger, this.schema, 'items', this.items, this.propertyRenderer);
+        return `items(${prop.renderType()}${minItems}) - ${prop.renderTitle()}: ${prop.renderDescription()}`;
+    }
 }
 /**
  * Get the referenced definition by following the reference path on the current schema.

package/lib/schema/validator.d.ts

@@ -44,7 +44,7 @@ export declare class SchemaValidator {
      * @param json A JSON value to validate against this instance's target schema.
      * @returns The validated JSON data.
      */
-    validateSync(json: AnyJson): AnyJson;
+    validateSync<T extends AnyJson>(json: T): T;
     /**
      * Loads local, external schemas from URIs in the same directory as the local schema file.
      * Does not support loading from remote URIs.

package/lib/schema/validator.js

@@ -122,7 +122,7 @@ class SchemaValidator {
     loadExternalSchemas(schema) {
         return (0, kit_1.getJsonValuesByName)(schema, '$ref')
             .map((ref) => ref && RegExp(/([\w\.]+)#/).exec(ref)) // eslint-disable-line no-useless-escape
-            .map((match) => match && match[1])
+            .map((match) => match?.[1])
             .filter((uri) => !!uri)
             .map((uri) => this.loadExternalSchema(uri));
     }
@@ -149,6 +149,7 @@ class SchemaValidator {
      *
      * @param errors An array of AJV (DefinedError) objects.
      */
+    // eslint-disable-next-line class-methods-use-this
     getErrorsText(errors) {
         return errors
             .map((error) => {

package/lib/sfError.d.ts

@@ -17,6 +17,7 @@ import { JsonMap } from '@salesforce/ts-types';
  * ```
  */
 export declare class SfError extends NamedError {
+    #private;
     /**
      * Action messages. Hints to the users regarding what can be done to fix related issues.
      */
@@ -30,10 +31,6 @@ export declare class SfError extends NamedError {
      */
     context?: string;
     data?: unknown;
-    /**
-     * Some errors support `error.code` instead of `error.name`. This keeps backwards compatability.
-     */
-    private _code?;
     /**
      * Create an SfError.
      *
@@ -44,14 +41,14 @@ export declare class SfError extends NamedError {
      * @param cause The underlying error that caused this error to be raised.
      */
     constructor(message: string, name?: string, actions?: string[], exitCodeOrCause?: number | Error, cause?: Error);
+    get code(): string | undefined | any;
+    set code(code: string);
     /**
      * Convert an Error to an SfError.
      *
      * @param err The error to convert.
      */
     static wrap(err: Error | string): SfError;
-    get code(): string | undefined | any;
-    set code(code: string);
     /**
      * Sets the context of the error. For convenience `this` object is returned.
      *

package/lib/sfError.js

@@ -5,6 +5,18 @@
  * Licensed under the BSD 3-Clause license.
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
+var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
+    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
+};
+var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (receiver, state, value, kind, f) {
+    if (kind === "m") throw new TypeError("Private method is not writable");
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a setter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
+    return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
+};
+var _SfError_code;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SfdxError = exports.SfError = void 0;
 const kit_1 = require("@salesforce/kit");
@@ -37,7 +49,11 @@ class SfError extends kit_1.NamedError {
      */
     constructor(message, name, actions, exitCodeOrCause, cause) {
         cause = exitCodeOrCause instanceof Error ? exitCodeOrCause : cause;
-        super(name || 'SfError', message || name, cause);
+        super(name ?? 'SfError', message || name, cause);
+        /**
+         * Some errors support `error.code` instead of `error.name`. This keeps backwards compatability.
+         */
+        _SfError_code.set(this, void 0);
         this.actions = actions;
         if (typeof exitCodeOrCause === 'number') {
             this.exitCode = exitCodeOrCause;
@@ -46,6 +62,13 @@ class SfError extends kit_1.NamedError {
             this.exitCode = 1;
         }
     }
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    get code() {
+        return __classPrivateFieldGet(this, _SfError_code, "f") ?? this.name;
+    }
+    set code(code) {
+        __classPrivateFieldSet(this, _SfError_code, code, "f");
+    }
     /**
      * Convert an Error to an SfError.
      *
@@ -65,13 +88,6 @@ class SfError extends kit_1.NamedError {
         }
         return sfError;
     }
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    get code() {
-        return this._code || this.name;
-    }
-    set code(code) {
-        this._code = code;
-    }
     /**
      * Sets the context of the error. For convenience `this` object is returned.
      *
@@ -104,13 +120,14 @@ class SfError extends kit_1.NamedError {
             obj.context = this.context;
         }
         if (this.data) {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-assignment
             obj.data = this.data;
         }
         return obj;
     }
 }
 exports.SfError = SfError;
+_SfError_code = new WeakMap();
 /**
  * @deprecated use SfError instead
  */

package/lib/sfProject.js

@@ -87,11 +87,12 @@ class SfProjectJson extends configFile_1.ConfigFile {
     getContents() {
         return super.getContents();
     }
+    // eslint-disable-next-line class-methods-use-this
     getDefaultOptions(options) {
         const defaultOptions = {
             isState: false,
         };
-        Object.assign(defaultOptions, options || {});
+        Object.assign(defaultOptions, options ?? {});
         return defaultOptions;
     }
     /**
@@ -253,8 +254,9 @@ class SfProjectJson extends configFile_1.ConfigFile {
     /**
      * Has at least one package alias defined in the project.
      */
+    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/require-await
     async hasPackageAliases() {
-        return Object.keys(this.getContents().packageAliases || {}).length > 0;
+        return Object.keys(this.getContents().packageAliases ?? {}).length > 0;
     }
     /**
      * Get package aliases defined in the project.
@@ -309,6 +311,7 @@ class SfProjectJson extends configFile_1.ConfigFile {
             this.getContents().packageDirectories.push(packageDirEntry);
         }
     }
+    // eslint-disable-next-line class-methods-use-this
     doesPackageExist(packagePath) {
         return fs.existsSync(packagePath);
     }
@@ -349,7 +352,7 @@ class SfProject {
      * **Throws** *{@link SfError}{ name: 'InvalidProjectWorkspaceError' }* If the current folder is not located in a workspace.
      */
     static async resolve(path) {
-        path = await this.resolveProjectPath(path || process.cwd());
+        path = await this.resolveProjectPath(path ?? process.cwd());
         if (!SfProject.instances.has(path)) {
             const project = new SfProject(path);
             SfProject.instances.set(path, project);
@@ -365,7 +368,7 @@ class SfProject {
      */
     static getInstance(path) {
         // Store instance based on the path of the actual project.
-        path = this.resolveProjectPathSync(path || process.cwd());
+        path = this.resolveProjectPathSync(path ?? process.cwd());
         if (!SfProject.instances.has(path)) {
             const project = new SfProject(path);
             SfProject.instances.set(path, project);
@@ -508,7 +511,7 @@ class SfProject {
      */
     getPackageNameFromPath(path) {
         const packageDir = this.getPackageFromPath(path);
-        return packageDir ? packageDir.package || packageDir.path : undefined;
+        return packageDir ? packageDir.package ?? packageDir.path : undefined;
     }
     /**
      * Returns the package directory.
@@ -579,7 +582,7 @@ class SfProject {
             throw new sfError_1.SfError('The sfdx-project.json does not have any packageDirectories defined.');
         }
         const defaultPackage = this.findPackage((packageDir) => packageDir.default === true);
-        return defaultPackage || this.getPackageDirectories()[0];
+        return defaultPackage ?? this.getPackageDirectories()[0];
     }
     /**
      * The project config is resolved from local and global {@link SfProjectJson},
@@ -605,18 +608,23 @@ class SfProject {
             // Add fields in sfdx-config.json
             Object.assign(this.projectConfig, configAggregator.getConfig());
             // we don't have a login url yet, so use instanceUrl from config or default
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
             if (!this.projectConfig.sfdcLoginUrl) {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
                 this.projectConfig.sfdcLoginUrl = configAggregator.getConfig()['org-instance-url'] ?? sfdcUrl_1.SfdcUrl.PRODUCTION;
             }
             // LEGACY - Allow override of sfdcLoginUrl via env var FORCE_SFDC_LOGIN_URL
             if (process.env.FORCE_SFDC_LOGIN_URL) {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
                 this.projectConfig.sfdcLoginUrl = process.env.FORCE_SFDC_LOGIN_URL;
             }
             // Allow override of signupTargetLoginUrl via env var SFDX_SCRATCH_ORG_CREATION_LOGIN_URL
             if (process.env.SFDX_SCRATCH_ORG_CREATION_LOGIN_URL) {
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
                 this.projectConfig.signupTargetLoginUrl = process.env.SFDX_SCRATCH_ORG_CREATION_LOGIN_URL;
             }
         }
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-return
         return this.projectConfig;
     }
     async hasPackageAliases() {

package/lib/stateAggregator/accessors/aliasAccessor.js

@@ -14,7 +14,7 @@ class AliasAccessor extends kit_1.AsyncOptionalCreatable {
     getAll(entity) {
         // This will only return aliases under "orgs". This will need to be modified
         // if/when we want to support more aliases groups.
-        const all = (this.config.getGroup() || {});
+        const all = (this.config.getGroup() ?? {});
         if (entity) {
             const value = this.getNameOf(entity);
             return Object.entries(all)
@@ -131,6 +131,7 @@ class AliasAccessor extends kit_1.AsyncOptionalCreatable {
     /**
      * Returns the username of given aliasable entity
      */
+    // eslint-disable-next-line class-methods-use-this
     getNameOf(entity) {
         if (typeof entity === 'string')
             return entity;

package/lib/stateAggregator/accessors/orgAccessor.js

@@ -56,6 +56,7 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
                 const config = await this.initAuthFile(username);
                 this.configs.set(username, config);
             });
+            // eslint-disable-next-line no-await-in-loop
             await Promise.all(promises);
         }
         return this.getAll(decrypt);
@@ -105,7 +106,7 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
      */
     async exists(username) {
         const config = this.configs.get(username);
-        return config ? await config.exists() : false;
+        return config ? config.exists() : false;
     }
     /**
      * Return the file stats for a given userame's auth file.
@@ -114,7 +115,7 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
      */
     async stat(username) {
         const config = this.configs.get(username);
-        return config ? await config.stat() : null;
+        return config ? config.stat() : null;
     }
     /**
      * Returns true if there is an auth file for the given username
@@ -152,6 +153,7 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
             this.contents.set(username, contents);
         }
         else {
+            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
             // @ts-ignore
             org.username ?? (org.username = username);
             this.contents.set(username, org);
@@ -189,12 +191,12 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
             return (await config.write());
         }
         else {
-            const contents = this.contents.get(username) || {};
+            const contents = this.contents.get(username) ?? {};
             await this.read(username, false, false);
             // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-            const config = this.configs.get(username);
-            config.setContentsFromObject(contents);
-            return (await config.write());
+            const readConfig = this.configs.get(username);
+            readConfig.setContentsFromObject(contents);
+            return (await readConfig.write());
         }
     }
     async init() {
@@ -218,16 +220,19 @@ class BaseOrgAccessor extends kit_1.AsyncOptionalCreatable {
 }
 exports.BaseOrgAccessor = BaseOrgAccessor;
 class OrgAccessor extends BaseOrgAccessor {
+    // eslint-disable-next-line class-methods-use-this
     async initAuthFile(username, throwOnNotFound = false) {
         return authInfoConfig_1.AuthInfoConfig.create({
             ...authInfoConfig_1.AuthInfoConfig.getOptions(username),
             throwOnNotFound,
         });
     }
+    // eslint-disable-next-line class-methods-use-this
     getFileRegex() {
         // The regular expression that filters files stored in $HOME/.sfdx
         return /^[^.][^@]*@[^.]+(\.[^.\s]+)+\.json$/;
     }
+    // eslint-disable-next-line class-methods-use-this
     getFileExtension() {
         return '.json';
     }