@salesforce/core 3.24.2 → 3.24.3

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.24.3](https://github.com/forcedotcom/sfdx-core/compare/v3.24.2...v3.24.3) (2022-07-28)
+
+### Bug Fixes
+
+- handle ancestor keywords when creating scratch org ([72af55a](https://github.com/forcedotcom/sfdx-core/commit/72af55a53b87f1d81d22dc4e53891b3b0ab2966f))
+
 ### [3.24.2](https://github.com/forcedotcom/sfdx-core/compare/v3.24.1...v3.24.2) (2022-07-26)
 
 ### Bug Fixes

package/lib/org/scratchOrgInfoGenerator.js

@@ -67,13 +67,34 @@ const getAncestorIds = async (scratchOrgInfo, projectJson, hubOrg) => {
     const ancestorIds = await Promise.all(packagesWithAncestors.map(async (packageDir) => {
         // ancestorID can be 05i, or 04t, alias; OR "ancestorVersion": "4.6.0.1"
         // according to docs, 05i is not ok: https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev2gp_config_file.htm
+        // package can be an ID, but not according to docs
+        const packageAliases = projectJson.get('packageAliases');
+        const packageId = packageAliases[(0, ts_types_1.ensureString)(packageDir.package)] ?? packageDir.package;
+        // Handle HIGHEST and NONE in ancestor(Version|Id).
+        // Precedence chain: NONE -> HIGHEST -> ancestorVersion & ancestoryId
+        if (packageDir.ancestorVersion === 'NONE' || packageDir.ancestorId === 'NONE') {
+            return '';
+        }
+        else if (packageDir.ancestorVersion === 'HIGHEST' || packageDir.ancestorId === 'HIGHEST') {
+            const query = 'SELECT Id FROM Package2Version ' +
+                `WHERE Package2Id = '${packageId}' AND IsReleased = True AND IsDeprecated = False AND PatchVersion = 0 ` +
+                'ORDER BY MajorVersion Desc, MinorVersion Desc, PatchVersion Desc, BuildNumber Desc LIMIT 1';
+            try {
+                return (await hubOrg.getConnection().singleRecordQuery(query, { tooling: true })).Id;
+            }
+            catch (err) {
+                if (packageDir.ancestorVersion === 'HIGHEST') {
+                    throw new sfError_1.SfError(messages.getMessage('NoMatchingAncestorError', [packageDir.ancestorVersion, packageDir.package]), 'NoMatchingAncestorError', [messages.getMessage('AncestorNotReleasedError', [packageDir.ancestorVersion])]);
+                }
+                else {
+                    throw new sfError_1.SfError(messages.getMessage('NoMatchingAncestorIdError', [packageDir.ancestorId, packageDir.package]), 'NoMatchingAncestorIdError', [messages.getMessage('AncestorNotReleasedError', [packageDir.ancestorId])]);
+                }
+            }
+        }
         if (packageDir.ancestorVersion) {
             if (!/^[0-9]+.[0-9]+.[0-9]+(.[0-9]+)?$/.test(packageDir.ancestorVersion)) {
                 throw messages.createError('InvalidAncestorVersionFormatError', [packageDir.ancestorVersion]);
             }
-            // package can be an ID, but not according to docs
-            const packageAliases = projectJson.get('packageAliases');
-            const packageId = packageAliases[(0, ts_types_1.ensureString)(packageDir.package)] ?? packageDir.package;
             const [major, minor, patch] = packageDir.ancestorVersion.split('.');
             let releasedAncestor;
             try {
@@ -102,14 +123,14 @@ const getAncestorIds = async (scratchOrgInfo, projectJson, hubOrg) => {
                 .getConnection()
                 .singleRecordQuery(`SELECT Id FROM Package2Version WHERE SubscriberPackageVersionId = '${packageDir.ancestorId}'`, { tooling: true })).Id;
         }
-        // ancestorID can be an alias get it from projectJson
-        const packageAliases = projectJson.get('packageAliases');
+        // ancestorID can be an alias; get it from projectJson
         if (packageDir.ancestorId && packageAliases?.[packageDir.ancestorId]) {
             return packageAliases[packageDir.ancestorId];
         }
         throw new sfError_1.SfError(`Invalid ancestorId ${packageDir.ancestorId}`, 'InvalidAncestorId');
     }));
-    return Array.from(new Set(ancestorIds)).join(';');
+    // strip out '' due to NONE
+    return Array.from(new Set(ancestorIds.filter((id) => id !== ''))).join(';');
 };
 exports.getAncestorIds = getAncestorIds;
 /**

package/messages/scratchOrgInfoGenerator.md

@@ -8,7 +8,11 @@ The ancestor versionNumber must be in the format major.minor.patch but the value
 
 # NoMatchingAncestorError
 
-The ancestorId for ancestorVersion %s can't be found. Package ID %s.",
+The ancestor for ancestorVersion %s can't be found. Package ID %s.",
+
+# NoMatchingAncestorIdError
+
+The ancestor for ancestorId [%s] can't be found. Package ID %s."
 
 # AncestorNotReleasedError
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core",
-  "version": "3.24.2",
+  "version": "3.24.3",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",