@salesforce/core 3.15.4 → 3.16.1

package/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [3.16.1](https://github.com/forcedotcom/sfdx-core/compare/v3.16.0...v3.16.1) (2022-05-11)
+
+### Bug Fixes
+
+- homedir can change after Core loads ([bb1e4f5](https://github.com/forcedotcom/sfdx-core/commit/bb1e4f5b1f59269f6d48a5389b1d76eeee252db0))
+
+## [3.16.0](https://github.com/forcedotcom/sfdx-core/compare/v3.15.5...v3.16.0) (2022-05-04)
+
+### Features
+
+- force v3 release ([05620c8](https://github.com/forcedotcom/sfdx-core/commit/05620c80256052a1b814b631e9afd951d63bea9e))
+
+### Bug Fixes
+
+- disable schemaValidation ([#578](https://github.com/forcedotcom/sfdx-core/issues/578)) ([9b60cb4](https://github.com/forcedotcom/sfdx-core/commit/9b60cb4dd3181f0bfbafadb72bcd0904e851084f))
+
+### [3.15.5](https://github.com/forcedotcom/sfdx-core/compare/v3.15.4...v3.15.5) (2022-05-03)
+
+### Bug Fixes
+
+- SfdxConfigAggregator ([238ad07](https://github.com/forcedotcom/sfdx-core/commit/238ad0757cc332ecc1897bd7230140a31a559332))
+
 ### [3.15.4](https://github.com/forcedotcom/sfdx-core/compare/v3.15.3...v3.15.4) (2022-05-03)
 
 ### Bug Fixes

package/lib/config/configAggregator.d.ts

@@ -219,7 +219,7 @@ export declare namespace ConfigAggregator {
  * @deprecated
  */
 export declare class SfdxConfigAggregator extends ConfigAggregator {
-    constructor(options?: ConfigAggregator.Options);
+    static create<P, T extends AsyncOptionalCreatable<P>>(this: new (options?: ConfigAggregator.Options) => T, options?: ConfigAggregator.Options): Promise<T>;
     getPropertyMeta(key: string): ConfigPropertyMeta;
     getPropertyValue<T extends AnyJson>(key: string): Optional<T>;
     getInfo(key: string): ConfigInfo;

package/lib/config/configAggregator.js

@@ -313,14 +313,14 @@ ConfigAggregator.encrypted = true;
  * @deprecated
  */
 class SfdxConfigAggregator extends ConfigAggregator {
-    constructor(options = {}) {
+    static async create(options = {}) {
         const customConfigMeta = options.customConfigMeta || [];
         // org-metadata-rest-deploy has been moved to plugin-deploy-retrieve but we need to have a placeholder
         // for it here since sfdx needs to know how to set the deprecated restDeploy config var.
         const restDeploy = config_1.SFDX_ALLOWED_PROPERTIES.find((p) => p.key === config_1.SfdxPropertyKeys.REST_DEPLOY);
         const orgRestDeploy = Object.assign({}, restDeploy, { key: 'org-metadata-rest-deploy', deprecated: false });
         options.customConfigMeta = [...customConfigMeta, orgRestDeploy];
-        super(options);
+        return super.create(options);
     }
     getPropertyMeta(key) {
         const match = this.getAllowedProperties().find((element) => key === element.key);

package/lib/crypto/keyChainImpl.js

@@ -317,7 +317,7 @@ const _darwinImpl = {
         }
     },
 };
-const secretFile = path.join((0, os_1.homedir)(), global_1.Global.SFDX_STATE_FOLDER, 'key.json');
+const getSecretFile = () => path.join(global_1.Global.SFDX_DIR, 'key.json');
 var SecretField;
 (function (SecretField) {
     SecretField["SERVICE"] = "service";
@@ -331,6 +331,7 @@ async function _writeFile(opts, fn) {
             [SecretField.KEY]: opts.password,
             [SecretField.SERVICE]: opts.service,
         };
+        const secretFile = getSecretFile();
         await mkdirp(path.dirname(secretFile));
         await fs.promises.writeFile(secretFile, JSON.stringify(contents, null, 4), { mode: '600' });
         fn(null, contents);
@@ -341,7 +342,7 @@ async function _writeFile(opts, fn) {
 }
 async function _readFile() {
     // The file and access is validated before this method is called
-    const fileContents = (0, kit_1.parseJsonMap)(await fs.promises.readFile(secretFile, 'utf8'));
+    const fileContents = (0, kit_1.parseJsonMap)(await fs.promises.readFile(getSecretFile(), 'utf8'));
     return {
         account: (0, ts_types_1.ensureString)(fileContents[SecretField.ACCOUNT]),
         password: (0, ts_types_1.asString)(fileContents[SecretField.KEY]),
@@ -368,7 +369,7 @@ class GenericKeychainAccess {
                     else {
                         // if the service and account names don't match then maybe someone or something is editing
                         // that file. #donotallow
-                        fn(messages.createError('genericKeychainServiceError', [secretFile]));
+                        fn(messages.createError('genericKeychainServiceError', [getSecretFile()]));
                     }
                 }
                 catch (readJsonErr) {
@@ -428,6 +429,7 @@ class GenericUnixKeychainAccess extends GenericKeychainAccess {
                 await cb(err);
             }
             else {
+                const secretFile = getSecretFile();
                 const stats = await fs.promises.stat(secretFile);
                 const octalModeStr = (stats.mode & 0o777).toString(8);
                 const EXPECTED_OCTAL_PERM_VALUE = '600';
@@ -453,7 +455,7 @@ class GenericWindowsKeychainAccess extends GenericKeychainAccess {
             }
             else {
                 try {
-                    await fs.promises.access(secretFile, fs.constants.R_OK | fs.constants.W_OK);
+                    await fs.promises.access(getSecretFile(), fs.constants.R_OK | fs.constants.W_OK);
                     await cb(null);
                 }
                 catch (e) {

package/lib/global.d.ts

@@ -33,13 +33,13 @@ export declare class Global {
      *
      * **See** {@link Global.SFDX_STATE_FOLDER}
      */
-    static readonly SFDX_DIR: string;
+    static get SFDX_DIR(): string;
     /**
      * The full system path to the global sf state folder.
      *
      * **See** {@link Global.SF_STATE_FOLDER}
      */
-    static readonly SF_DIR: string;
+    static get SF_DIR(): string;
     /**
      * The full system path to the global log file.
      */

package/lib/global.js

@@ -28,6 +28,22 @@ var Mode;
  * Global constants, methods, and configuration.
  */
 class Global {
+    /**
+     * The full system path to the global sfdx state folder.
+     *
+     * **See** {@link Global.SFDX_STATE_FOLDER}
+     */
+    static get SFDX_DIR() {
+        return path.join(os.homedir(), Global.SFDX_STATE_FOLDER);
+    }
+    /**
+     * The full system path to the global sf state folder.
+     *
+     * **See** {@link Global.SF_STATE_FOLDER}
+     */
+    static get SF_DIR() {
+        return path.join(os.homedir(), Global.SF_STATE_FOLDER);
+    }
     /**
      * Gets the current mode environment variable as a {@link Mode} instance.
      *
@@ -64,18 +80,6 @@ Global.SFDX_STATE_FOLDER = '.sfdx';
  * The global folder in which sf state is stored.
  */
 Global.SF_STATE_FOLDER = '.sf';
-/**
- * The full system path to the global sfdx state folder.
- *
- * **See** {@link Global.SFDX_STATE_FOLDER}
- */
-Global.SFDX_DIR = path.join(os.homedir(), Global.SFDX_STATE_FOLDER);
-/**
- * The full system path to the global sf state folder.
- *
- * **See** {@link Global.SF_STATE_FOLDER}
- */
-Global.SF_DIR = path.join(os.homedir(), Global.SF_STATE_FOLDER);
 /**
  * The full system path to the global log file.
  */

package/lib/schema/validator.js

@@ -82,6 +82,9 @@ class SchemaValidator {
             // because the CLI team does not "own" the @salesforce/schemas repository.
             // Invalid schema would cause errors wherever SchemaValidator is used.
             strictSchema: false,
+            // If we end up getting an npm-shrinkwrap working in the future we could turn this back off.
+            // https://github.com/forcedotcom/cli/issues/1493
+            validateSchema: false,
         });
         // JSEN to AJV migration note - regarding the following "TODO":
         // I don't think that AJV has a way to throw an error if an additional property exists in the data

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core",
-  "version": "3.15.4",
+  "version": "3.16.1",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
   "types": "lib/exported.d.ts",