@salesforce/core 2.28.4 → 2.31.0

package/CHANGELOG.md

@@ -2,202 +2,209 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
-### [2.28.4](https://github.com/forcedotcom/sfdx-core/compare/v2.28.3...v2.28.4) (2021-11-10)
+## [2.31.0](https://github.com/forcedotcom/sfdx-core/compare/v2.30.1...v2.31.0) (2021-11-30)
+
+
+### Features
+
+* bump version of jsforce ([7d89024](https://github.com/forcedotcom/sfdx-core/commit/7d89024f593968c031af22ac817efc26d00fcd54))
+
+### [2.30.1](https://github.com/forcedotcom/sfdx-core/compare/v2.30.0...v2.30.1) (2021-11-30)
 
 
 ### Bug Fixes
 
-* bump jsforce types and run unit tests on Windows ([#485](https://github.com/forcedotcom/sfdx-core/issues/485)) ([3952c8f](https://github.com/forcedotcom/sfdx-core/commit/3952c8fe248531a0597477ed12240f611048caba))
+* better output for authUrl errors ([f3ec729](https://github.com/forcedotcom/sfdx-core/commit/f3ec7298bdbd3194d3d14bfea09f47f413669376))
 
-### [2.28.3](https://github.com/forcedotcom/sfdx-core/compare/v2.28.2...v2.28.3) (2021-11-08)
+## [2.30.0](https://github.com/forcedotcom/sfdx-core/compare/v2.29.0...v2.30.0) (2021-11-25)
 
 
+### Features
+
+* delete scratch orgs and sandboxes ([#491](https://github.com/forcedotcom/sfdx-core/issues/491)) ([468c348](https://github.com/forcedotcom/sfdx-core/commit/468c348f0ecc69ddeea02927bf7a26ca660a86ca))
+
+## [2.29.0](https://github.com/forcedotcom/sfdx-core/compare/v2.28.4...v2.29.0) (2021-11-17)
+
+### Features
+
+- cleans up old listeners from upgraded instance ([e3f2d69](https://github.com/forcedotcom/sfdx-core/commit/e3f2d69ccd5c096d37addb1b982e19354175f11a))
+- use warnings instead of process in sfdx-core ([c1f7e98](https://github.com/forcedotcom/sfdx-core/commit/c1f7e98f6b19d57da1a2ee0cdf58e449079f0ee7))
+- warning and telemetry events ([80a8039](https://github.com/forcedotcom/sfdx-core/commit/80a8039e2f686d973ddbc24c9a2980fb93928d13))
+- warning and telemetry events ([a04b293](https://github.com/forcedotcom/sfdx-core/commit/a04b29355c8ca6c7e37e071ccc159aff5e5e9ca0))
+
 ### Bug Fixes
 
-* fix unit test ([d903c04](https://github.com/forcedotcom/sfdx-core/commit/d903c04e5f3e4f01fccb3f00b91560c443013ddf))
-* force new release ([124bb74](https://github.com/forcedotcom/sfdx-core/commit/124bb744c5ecc28cb8babf285c6d8c3032eb7ef6))
-* improve error message when providing an invalid username ([2ab4bbd](https://github.com/forcedotcom/sfdx-core/commit/2ab4bbdefd962283d88ccb735de88c88fe189d39))
+- transfer listeners when upgrading the global instance to newer version ([0a40831](https://github.com/forcedotcom/sfdx-core/commit/0a408317c132548771ced0fe196178d2e9c76232))
 
-### [2.28.2](https://github.com/forcedotcom/sfdx-core/compare/v2.28.1...v2.28.2) (2021-10-13)
+### [2.28.4](https://github.com/forcedotcom/sfdx-core/compare/v2.28.3...v2.28.4) (2021-11-10)
+
+### Bug Fixes
+
+- bump jsforce types and run unit tests on Windows ([#485](https://github.com/forcedotcom/sfdx-core/issues/485)) ([3952c8f](https://github.com/forcedotcom/sfdx-core/commit/3952c8fe248531a0597477ed12240f611048caba))
 
+### [2.28.3](https://github.com/forcedotcom/sfdx-core/compare/v2.28.2...v2.28.3) (2021-11-08)
 
 ### Bug Fixes
 
-* support for .mil sandboxes ([9ef35c7](https://github.com/forcedotcom/sfdx-core/commit/9ef35c7b1ef0fe974c3bd3b89b862a436e00f7d9))
+- fix unit test ([d903c04](https://github.com/forcedotcom/sfdx-core/commit/d903c04e5f3e4f01fccb3f00b91560c443013ddf))
+- force new release ([124bb74](https://github.com/forcedotcom/sfdx-core/commit/124bb744c5ecc28cb8babf285c6d8c3032eb7ef6))
+- improve error message when providing an invalid username ([2ab4bbd](https://github.com/forcedotcom/sfdx-core/commit/2ab4bbdefd962283d88ccb735de88c88fe189d39))
 
-### [2.28.1](https://github.com/forcedotcom/sfdx-core/compare/v2.28.0...v2.28.1) (2021-10-06)
+### [2.28.2](https://github.com/forcedotcom/sfdx-core/compare/v2.28.1...v2.28.2) (2021-10-13)
 
+### Bug Fixes
+
+- support for .mil sandboxes ([9ef35c7](https://github.com/forcedotcom/sfdx-core/commit/9ef35c7b1ef0fe974c3bd3b89b862a436e00f7d9))
+
+### [2.28.1](https://github.com/forcedotcom/sfdx-core/compare/v2.28.0...v2.28.1) (2021-10-06)
 
 ### Bug Fixes
 
-* crmforce.mil ([e263d5d](https://github.com/forcedotcom/sfdx-core/commit/e263d5d74be9c0651e5c2676d6eec1c31fca05e4))
+- crmforce.mil ([e263d5d](https://github.com/forcedotcom/sfdx-core/commit/e263d5d74be9c0651e5c2676d6eec1c31fca05e4))
 
 ## [2.28.0](https://github.com/forcedotcom/sfdx-core/compare/v2.27.2...v2.28.0) (2021-09-16)
 
-
 ### Features
 
-* add custom templates config ([3cf8a8c](https://github.com/forcedotcom/sfdx-core/commit/3cf8a8cee1e7196efced989dcca9b545e1283386))
-* add validator for custom templates config ([dd2bcfe](https://github.com/forcedotcom/sfdx-core/commit/dd2bcfe8e7fee5c5c1c6321189ec04288103d5b6))
-* update config name ([72e84bf](https://github.com/forcedotcom/sfdx-core/commit/72e84bfacef48a1c2d00a61ebbae3f632601abbd))
+- add custom templates config ([3cf8a8c](https://github.com/forcedotcom/sfdx-core/commit/3cf8a8cee1e7196efced989dcca9b545e1283386))
+- add validator for custom templates config ([dd2bcfe](https://github.com/forcedotcom/sfdx-core/commit/dd2bcfe8e7fee5c5c1c6321189ec04288103d5b6))
+- update config name ([72e84bf](https://github.com/forcedotcom/sfdx-core/commit/72e84bfacef48a1c2d00a61ebbae3f632601abbd))
 
 ### [2.27.2](https://github.com/forcedotcom/sfdx-core/compare/v2.27.1...v2.27.2) (2021-08-05)
 
-
 ### Bug Fixes
 
-* improve error handling while removing config props ([eecf7b0](https://github.com/forcedotcom/sfdx-core/commit/eecf7b0d0cf14e1371dc4c5ef03a413f864b0a8b))
+- improve error handling while removing config props ([eecf7b0](https://github.com/forcedotcom/sfdx-core/commit/eecf7b0d0cf14e1371dc4c5ef03a413f864b0a8b))
 
 ### [2.27.1](https://github.com/forcedotcom/sfdx-core/compare/v2.27.0...v2.27.1) (2021-08-05)
 
-
 ### Bug Fixes
 
-* dont fail when trying to unset sf config keys ([#456](https://github.com/forcedotcom/sfdx-core/issues/456)) ([8aff9fd](https://github.com/forcedotcom/sfdx-core/commit/8aff9fd4bdb73ec20e58f5a16a8192a8eecba912))
+- dont fail when trying to unset sf config keys ([#456](https://github.com/forcedotcom/sfdx-core/issues/456)) ([8aff9fd](https://github.com/forcedotcom/sfdx-core/commit/8aff9fd4bdb73ec20e58f5a16a8192a8eecba912))
 
 ## [2.27.0](https://github.com/forcedotcom/sfdx-core/compare/v2.26.1...v2.27.0) (2021-07-29)
 
-
 ### Features
 
-* Core URL class SfdcUrl ([#420](https://github.com/forcedotcom/sfdx-core/issues/420)) ([66881ea](https://github.com/forcedotcom/sfdx-core/commit/66881eae2f30215c862ea398bfc1630d9a5898fe))
+- Core URL class SfdcUrl ([#420](https://github.com/forcedotcom/sfdx-core/issues/420)) ([66881ea](https://github.com/forcedotcom/sfdx-core/commit/66881eae2f30215c862ea398bfc1630d9a5898fe))
 
 ### [2.26.1](https://github.com/forcedotcom/sfdx-core/compare/v2.26.0...v2.26.1) (2021-07-19)
 
-
 ### Bug Fixes
 
-* force:org:open force:org:open --urlonly display bug ([#439](https://github.com/forcedotcom/sfdx-core/issues/439)) ([2ea0e74](https://github.com/forcedotcom/sfdx-core/commit/2ea0e74b8bf1bff6de8af70372025cac10fc8c18))
+- force:org:open force:org:open --urlonly display bug ([#439](https://github.com/forcedotcom/sfdx-core/issues/439)) ([2ea0e74](https://github.com/forcedotcom/sfdx-core/commit/2ea0e74b8bf1bff6de8af70372025cac10fc8c18))
 
 ## [2.26.0](https://github.com/forcedotcom/sfdx-core/compare/v2.25.1...v2.26.0) (2021-07-13)
 
-
 ### Features
 
-* update generate password functionality ([#432](https://github.com/forcedotcom/sfdx-core/issues/432)) ([ed65e83](https://github.com/forcedotcom/sfdx-core/commit/ed65e83da3afe0d101743ee89cc7b2a7a38d5254))
+- update generate password functionality ([#432](https://github.com/forcedotcom/sfdx-core/issues/432)) ([ed65e83](https://github.com/forcedotcom/sfdx-core/commit/ed65e83da3afe0d101743ee89cc7b2a7a38d5254))
 
 ### [2.25.1](https://github.com/forcedotcom/sfdx-core/compare/v3.1.1-3.2...v2.25.1) (2021-06-30)
 
-
 ### Bug Fixes
 
-* set retries to INFINITELY for polling client ([31539b4](https://github.com/forcedotcom/sfdx-core/commit/31539b4f0edd0cc1c049f70331ed5e40b8af55ea))
+- set retries to INFINITELY for polling client ([31539b4](https://github.com/forcedotcom/sfdx-core/commit/31539b4f0edd0cc1c049f70331ed5e40b8af55ea))
 
 ## [2.25.0](https://github.com/forcedotcom/sfdx-core/compare/v2.24.2...v2.25.0) (2021-06-30)
 
-
 ### Features
 
-* @W-9517449@ Allow signupTargetLoginUrl to be overridden via env var ([#429](https://github.com/forcedotcom/sfdx-core/issues/429)) ([e2b8b36](https://github.com/forcedotcom/sfdx-core/commit/e2b8b36b2836b5277c83ffe22922978dc32e7b11)), closes [#427](https://github.com/forcedotcom/sfdx-core/issues/427)
+- @W-9517449@ Allow signupTargetLoginUrl to be overridden via env var ([#429](https://github.com/forcedotcom/sfdx-core/issues/429)) ([e2b8b36](https://github.com/forcedotcom/sfdx-core/commit/e2b8b36b2836b5277c83ffe22922978dc32e7b11)), closes [#427](https://github.com/forcedotcom/sfdx-core/issues/427)
 
 ### [2.24.2](https://github.com/forcedotcom/sfdx-core/compare/v3.1.1-3.1...v2.24.2) (2021-06-23)
 
-
 ### Bug Fixes
 
-* puts some types back in dependencies ([94bea31](https://github.com/forcedotcom/sfdx-core/commit/94bea31037a41d4377faecb22bce8a2d12e95f4f))
+- puts some types back in dependencies ([94bea31](https://github.com/forcedotcom/sfdx-core/commit/94bea31037a41d4377faecb22bce8a2d12e95f4f))
 
 ### [2.24.1](https://github.com/forcedotcom/sfdx-core/compare/v2.24.0...v2.24.1) (2021-06-23)
 
-
 ### Bug Fixes
 
-* rewrite polling client ([8d363d1](https://github.com/forcedotcom/sfdx-core/commit/8d363d13616f5efa944d4bb717a010add3c996b5))
+- rewrite polling client ([8d363d1](https://github.com/forcedotcom/sfdx-core/commit/8d363d13616f5efa944d4bb717a010add3c996b5))
 
 ## [2.24.0](https://github.com/forcedotcom/sfdx-core/compare/v2.23.5...v2.24.0) (2021-06-08)
 
-
 ### Features
 
-* exported function checkLightningDomain() ([#415](https://github.com/forcedotcom/sfdx-core/issues/415)) ([8e75231](https://github.com/forcedotcom/sfdx-core/commit/8e752313abf4a383a6ef18250ffac78b398987dd))
+- exported function checkLightningDomain() ([#415](https://github.com/forcedotcom/sfdx-core/issues/415)) ([8e75231](https://github.com/forcedotcom/sfdx-core/commit/8e752313abf4a383a6ef18250ffac78b398987dd))
 
 ### [2.23.5](https://github.com/forcedotcom/sfdx-core/compare/v3.1.1-3.0...v2.23.5) (2021-06-07)
 
-
 ### Bug Fixes
 
-* w-9299422 (login url from config) and fs-parallelization ([043bb17](https://github.com/forcedotcom/sfdx-core/commit/043bb179dbf64f9c4522a4c0f0720ae09794227c))
+- w-9299422 (login url from config) and fs-parallelization ([043bb17](https://github.com/forcedotcom/sfdx-core/commit/043bb179dbf64f9c4522a4c0f0720ae09794227c))
 
 ### [2.23.4](https://github.com/forcedotcom/sfdx-core/compare/v2.23.3...v2.23.4) (2021-06-03)
 
-
 ### Bug Fixes
 
-* works with TS4+ and jsforce types ([#413](https://github.com/forcedotcom/sfdx-core/issues/413)) ([b77cdad](https://github.com/forcedotcom/sfdx-core/commit/b77cdad56b114290b8e5fd23d968e23e7d4eedf4))
+- works with TS4+ and jsforce types ([#413](https://github.com/forcedotcom/sfdx-core/issues/413)) ([b77cdad](https://github.com/forcedotcom/sfdx-core/commit/b77cdad56b114290b8e5fd23d968e23e7d4eedf4))
 
 ### [2.23.3](https://github.com/forcedotcom/sfdx-core/compare/v2.23.2...v2.23.3) (2021-06-03)
 
 ### [2.23.2](https://github.com/forcedotcom/sfdx-core/compare/v2.23.1...v2.23.2) (2021-06-02)
 
-
 ### Bug Fixes
 
-* authinfo returning only lowercase usernames. ([#411](https://github.com/forcedotcom/sfdx-core/issues/411)) ([243668e](https://github.com/forcedotcom/sfdx-core/commit/243668e61cd8418b6acb2f0d4806da50ccf37b29)), closes [#405](https://github.com/forcedotcom/sfdx-core/issues/405)
+- authinfo returning only lowercase usernames. ([#411](https://github.com/forcedotcom/sfdx-core/issues/411)) ([243668e](https://github.com/forcedotcom/sfdx-core/commit/243668e61cd8418b6acb2f0d4806da50ccf37b29)), closes [#405](https://github.com/forcedotcom/sfdx-core/issues/405)
 
 ### [2.23.1](https://github.com/forcedotcom/sfdx-core/compare/v2.23.0...v2.23.1) (2021-05-27)
 
 ## [2.23.0](https://github.com/forcedotcom/sfdx-core/compare/v2.22.0...v2.23.0) (2021-05-26)
 
-
 ### Features
 
-* export getJwtAudienceUrl ([e7d26d2](https://github.com/forcedotcom/sfdx-core/commit/e7d26d20106d6abb6b424936bdf26c0a9f8cd175))
-
+- export getJwtAudienceUrl ([e7d26d2](https://github.com/forcedotcom/sfdx-core/commit/e7d26d20106d6abb6b424936bdf26c0a9f8cd175))
 
 ### Bug Fixes
 
-* export library method ([d0016f9](https://github.com/forcedotcom/sfdx-core/commit/d0016f96da1246535049884c1043399239a33c00))
+- export library method ([d0016f9](https://github.com/forcedotcom/sfdx-core/commit/d0016f96da1246535049884c1043399239a33c00))
 
 ## [2.22.0](https://github.com/forcedotcom/sfdx-core/compare/v2.21.0...v2.22.0) (2021-05-24)
 
-
 ### Features
 
-* export getJwtAudienceUrl ([#407](https://github.com/forcedotcom/sfdx-core/issues/407)) ([585bb07](https://github.com/forcedotcom/sfdx-core/commit/585bb073434d73473a855ee52b7ddc6f0228aae1))
+- export getJwtAudienceUrl ([#407](https://github.com/forcedotcom/sfdx-core/issues/407)) ([585bb07](https://github.com/forcedotcom/sfdx-core/commit/585bb073434d73473a855ee52b7ddc6f0228aae1))
 
 ## [2.21.0](https://github.com/forcedotcom/sfdx-core/compare/v2.20.11...v2.21.0) (2021-05-24)
 
-
 ### Features
 
-* modify authInfo to return username for access token auth ([160b7d2](https://github.com/forcedotcom/sfdx-core/commit/160b7d20e32b80d7a54c8cf679154fcbaa9e8cda))
+- modify authInfo to return username for access token auth ([160b7d2](https://github.com/forcedotcom/sfdx-core/commit/160b7d20e32b80d7a54c8cf679154fcbaa9e8cda))
 
 ### [2.20.11](https://github.com/forcedotcom/sfdx-core/compare/v3.1.0-3.0...v2.20.11) (2021-05-12)
 
-
 ### Bug Fixes
 
-* force release ([f0b837a](https://github.com/forcedotcom/sfdx-core/commit/f0b837ab7b4d0361c2fa3ba15fe56cd2f7cc1fd0))
+- force release ([f0b837a](https://github.com/forcedotcom/sfdx-core/commit/f0b837ab7b4d0361c2fa3ba15fe56cd2f7cc1fd0))
 
 ### [2.20.10](https://github.com/forcedotcom/sfdx-core/compare/v2.20.9...v2.20.10) (2021-04-14)
 
-
 ### Bug Fixes
 
-* add another internal test env domain ([6ea538f](https://github.com/forcedotcom/sfdx-core/commit/6ea538f2ce62daba7262a247472ce821c6e2616f))
+- add another internal test env domain ([6ea538f](https://github.com/forcedotcom/sfdx-core/commit/6ea538f2ce62daba7262a247472ce821c6e2616f))
 
 ### [2.20.9](https://github.com/forcedotcom/sfdx-core/compare/v2.20.8...v2.20.9) (2021-04-05)
 
-
 ### Bug Fixes
 
-* allow = in authUrl tokens ([2337fcd](https://github.com/forcedotcom/sfdx-core/commit/2337fcddfb1907a7092cd52f5b3ad73ae963d59e))
+- allow = in authUrl tokens ([2337fcd](https://github.com/forcedotcom/sfdx-core/commit/2337fcddfb1907a7092cd52f5b3ad73ae963d59e))
 
 ### [2.20.8](https://github.com/forcedotcom/sfdx-core/compare/v2.20.7...v2.20.8) (2021-04-03)
 
-
 ### Bug Fixes
 
-* debugEnabled should be public ([dbd0124](https://github.com/forcedotcom/sfdx-core/commit/dbd01243003f555b8b4db45c83e81cc08b8cb9a1))
+- debugEnabled should be public ([dbd0124](https://github.com/forcedotcom/sfdx-core/commit/dbd01243003f555b8b4db45c83e81cc08b8cb9a1))
 
 ### [2.20.7](https://github.com/forcedotcom/sfdx-core/compare/v2.20.6...v2.20.7) (2021-04-02)
 
-
 ### Bug Fixes
 
-* add deployRecentValidation ([62d367b](https://github.com/forcedotcom/sfdx-core/commit/62d367b217e6b552573bd7176b064e28252348c5))
-* add deployRecentValidation ([a39c329](https://github.com/forcedotcom/sfdx-core/commit/a39c329b3fab603b537ae5ed8cce4773bdf24eb6))
-* add test, clarify comments ([8d5679e](https://github.com/forcedotcom/sfdx-core/commit/8d5679ecbd482af84842f5c1c8908a059d97ef3f))
+- add deployRecentValidation ([62d367b](https://github.com/forcedotcom/sfdx-core/commit/62d367b217e6b552573bd7176b064e28252348c5))
+- add deployRecentValidation ([a39c329](https://github.com/forcedotcom/sfdx-core/commit/a39c329b3fab603b537ae5ed8cce4773bdf24eb6))
+- add test, clarify comments ([8d5679e](https://github.com/forcedotcom/sfdx-core/commit/8d5679ecbd482af84842f5c1c8908a059d97ef3f))
 
 ### [2.20.6](https://github.com/forcedotcom/sfdx-core/compare/v2.20.5...v2.20.6) (2021-04-02)
 

package/lib/authInfo.d.ts

@@ -202,12 +202,7 @@ export declare class AuthInfo extends AsyncCreatable<AuthInfo.Options> {
      * ```
      * @param sfdxAuthUrl
      */
-    static parseSfdxAuthUrl(sfdxAuthUrl: string): {
-        clientId: string;
-        clientSecret: string;
-        refreshToken: string;
-        loginUrl: string;
-    };
+    static parseSfdxAuthUrl(sfdxAuthUrl: string): Pick<AuthFields, 'clientId' | 'clientSecret' | 'refreshToken' | 'loginUrl'>;
     /**
      * Get the username.
      */

package/lib/authInfo.js

@@ -87,6 +87,7 @@ class OAuth2WithVerifier extends jsforce_1.OAuth2 {
      *
      * See https://github.com/jsforce/jsforce/issues/665
      */
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     async _postParams(params, callback) {
         kit_1.set(params, 'code_verifier', this.codeVerifier);
         // @ts-ignore TODO: need better typings for jsforce
@@ -329,7 +330,7 @@ class AuthInfo extends kit_1.AsyncCreatable {
     static parseSfdxAuthUrl(sfdxAuthUrl) {
         const match = sfdxAuthUrl.match(/^force:\/\/([a-zA-Z0-9._-]+):([a-zA-Z0-9._-]*):([a-zA-Z0-9._-]+={0,2})@([a-zA-Z0-9._-]+)/);
         if (!match) {
-            throw new sfdxError_1.SfdxError('Invalid sfdx auth url. Must be in the format `force://<clientId>:<clientSecret>:<refreshToken>@<loginUrl>`. The instanceUrl must not have the protocol set.', 'INVALID_SFDX_AUTH_URL');
+            throw new sfdxError_1.SfdxError('Invalid SFDX auth URL. Must be in the format "force://<clientId>:<clientSecret>:<refreshToken>@<instanceUrl>".  Note that the SFDX auth URL uses the "force" protocol, and not "http" or "https".  Also note that the "instanceUrl" inside the SFDX auth URL doesn\'t include the protocol ("https://").', 'INVALID_SFDX_AUTH_URL');
         }
         const [, clientId, clientSecret, refreshToken, loginUrl] = match;
         return {

package/lib/connection.js

@@ -19,6 +19,7 @@ const configAggregator_1 = require("./config/configAggregator");
 const logger_1 = require("./logger");
 const sfdxError_1 = require("./sfdxError");
 const sfdc_1 = require("./util/sfdc");
+const lifecycleEvents_1 = require("./lifecycleEvents");
 /**
  * The 'async' in our request override replaces the jsforce promise with the node promise, then returns it back to
  * jsforce which expects .thenCall. Add .thenCall to the node promise to prevent breakage.
@@ -356,7 +357,7 @@ class Connection extends jsforce_1.Connection {
                 .on('end', () => {
                 const totalSize = ts_types_1.getNumber(query, 'totalSize') || 0;
                 if (totalSize > records.length) {
-                    process.emitWarning(`The query result is missing ${totalSize - records.length} records due to a ${maxFetch} record limit. Increase the number of records returned by setting the config value "maxQueryLimit" or the environment variable "SFDX_MAX_QUERY_LIMIT" to ${totalSize} or greater than ${maxFetch}.`);
+                    void lifecycleEvents_1.Lifecycle.getInstance().emitWarning(`The query result is missing ${totalSize - records.length} records due to a ${maxFetch} record limit. Increase the number of records returned by setting the config value "maxQueryLimit" or the environment variable "SFDX_MAX_QUERY_LIMIT" to ${totalSize} or greater than ${maxFetch}.`);
                 }
                 resolve({
                     done: true,

package/lib/lifecycleEvents.d.ts

@@ -16,16 +16,29 @@ declare type callback = (data: any) => Promise<void>;
  *
  * // Deep in the deploy code, fire the event for all libraries and plugins to hear.
  * Lifecycle.getInstance().emit('deploy-metadata', metadataToBeDeployed);
+ *
+ * // if you don't need to await anything
+ * use `void Lifecycle.getInstance().emit('deploy-metadata', metadataToBeDeployed)` ;
  * ```
  */
 export declare class Lifecycle {
-    private debug;
     private readonly listeners;
+    static readonly telemetryEventName = "telemetry";
+    static readonly warningEventName = "warning";
+    private debug;
     private constructor();
+    /**
+     * return the package.json version of the sfdx-core library.
+     */
+    static staticVersion(): string;
     /**
      * Retrieve the singleton instance of this class so that all listeners and emitters can interact from any library or tool
      */
     static getInstance(): Lifecycle;
+    /**
+     * return the package.json version of the sfdx-core library.
+     */
+    version(): string;
     /**
      * Remove all listeners for a given event
      *
@@ -38,6 +51,18 @@ export declare class Lifecycle {
      * @param eventName The name of the event to get listeners of
      */
     getListeners(eventName: string): callback[];
+    /**
+     * Create a listener for the `telemetry` event
+     *
+     * @param cb The callback function to run when the event is emitted
+     */
+    onTelemetry(cb: (data: Record<string, unknown>) => Promise<void>): void;
+    /**
+     * Create a listener for the `warning` event
+     *
+     * @param cb The callback function to run when the event is emitted
+     */
+    onWarning(cb: (warning: string) => Promise<void>): void;
     /**
      * Create a new listener for a given event
      *
@@ -45,6 +70,18 @@ export declare class Lifecycle {
      * @param cb The callback function to run when the event is emitted
      */
     on<T = AnyJson>(eventName: string, cb: (data: T) => Promise<void>): void;
+    /**
+     * Emit a `telemetry` event, causing all callback functions to be run in the order they were registered
+     *
+     * @param data The data to emit
+     */
+    emitTelemetry(data: AnyJson): Promise<void>;
+    /**
+     * Emit a `warning` event, causing all callback functions to be run in the order they were registered
+     *
+     * @param data The warning (string) to emit
+     */
+    emitWarning(warning: string): Promise<void>;
     /**
      * Emit a given event, causing all callback functions to be run in the order they were registered
      *

package/lib/lifecycleEvents.js

@@ -8,6 +8,10 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Lifecycle = void 0;
 const Debug = require("debug");
+const semver_1 = require("semver");
+// needed for TS to not put everything inside /lib/src
+// @ts-ignore
+const pjson = require("../package.json");
 /**
  * An asynchronous event listener and emitter that follows the singleton pattern. The singleton pattern allows lifecycle
  * events to be emitted from deep within a library and still be consumed by any other library or tool. It allows other
@@ -24,12 +28,21 @@ const Debug = require("debug");
  *
  * // Deep in the deploy code, fire the event for all libraries and plugins to hear.
  * Lifecycle.getInstance().emit('deploy-metadata', metadataToBeDeployed);
+ *
+ * // if you don't need to await anything
+ * use `void Lifecycle.getInstance().emit('deploy-metadata', metadataToBeDeployed)` ;
  * ```
  */
 class Lifecycle {
-    constructor() {
+    constructor(listeners = {}) {
+        this.listeners = listeners;
         this.debug = Debug(`sfdx:${this.constructor.name}`);
-        this.listeners = {};
+    }
+    /**
+     * return the package.json version of the sfdx-core library.
+     */
+    static staticVersion() {
+        return pjson.version;
     }
     /**
      * Retrieve the singleton instance of this class so that all listeners and emitters can interact from any library or tool
@@ -52,10 +65,29 @@ class Lifecycle {
         //
         // Nothing should EVER be removed, even across major versions.
         if (!global.salesforceCoreLifecycle) {
+            // it's not been loaded yet (basic singleton pattern)
             global.salesforceCoreLifecycle = new Lifecycle();
         }
+        else if (
+        // an older version was loaded that should be replaced
+        semver_1.compare(global.salesforceCoreLifecycle.version(), Lifecycle.staticVersion()) === -1) {
+            const oldInstance = global.salesforceCoreLifecycle;
+            // use the newer version and transfer any listeners from the old version
+            // object spread keeps them from being references
+            global.salesforceCoreLifecycle = new Lifecycle({ ...oldInstance.listeners });
+            // clean up any listeners on the old version
+            Object.keys(oldInstance.listeners).map((eventName) => {
+                oldInstance.removeAllListeners(eventName);
+            });
+        }
         return global.salesforceCoreLifecycle;
     }
+    /**
+     * return the package.json version of the sfdx-core library.
+     */
+    version() {
+        return pjson.version;
+    }
     /**
      * Remove all listeners for a given event
      *
@@ -79,6 +111,22 @@ class Lifecycle {
             return [];
         }
     }
+    /**
+     * Create a listener for the `telemetry` event
+     *
+     * @param cb The callback function to run when the event is emitted
+     */
+    onTelemetry(cb) {
+        this.on(Lifecycle.telemetryEventName, cb);
+    }
+    /**
+     * Create a listener for the `warning` event
+     *
+     * @param cb The callback function to run when the event is emitted
+     */
+    onWarning(cb) {
+        this.on(Lifecycle.warningEventName, cb);
+    }
     /**
      * Create a new listener for a given event
      *
@@ -93,6 +141,27 @@ class Lifecycle {
         listeners.push(cb);
         this.listeners[eventName] = listeners;
     }
+    /**
+     * Emit a `telemetry` event, causing all callback functions to be run in the order they were registered
+     *
+     * @param data The data to emit
+     */
+    async emitTelemetry(data) {
+        return this.emit(Lifecycle.telemetryEventName, data);
+    }
+    /**
+     * Emit a `warning` event, causing all callback functions to be run in the order they were registered
+     *
+     * @param data The warning (string) to emit
+     */
+    async emitWarning(warning) {
+        // if there are no listeners, warnings should go to the node process so they're not lost
+        // this also preserves behavior in UT where there's a spy on process.emitWarning
+        if (this.getListeners(Lifecycle.warningEventName).length === 0) {
+            process.emitWarning(warning);
+        }
+        return this.emit(Lifecycle.warningEventName, warning);
+    }
     /**
      * Emit a given event, causing all callback functions to be run in the order they were registered
      *
@@ -112,4 +181,6 @@ class Lifecycle {
     }
 }
 exports.Lifecycle = Lifecycle;
+Lifecycle.telemetryEventName = 'telemetry';
+Lifecycle.warningEventName = 'warning';
 //# sourceMappingURL=lifecycleEvents.js.map

package/lib/logger.js

@@ -343,6 +343,7 @@ class Logger {
     /**
      * Gets the underlying Bunyan logger.
      */
+    // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
     getBunyanLogger() {
         return this.bunyan;
     }

package/lib/org.d.ts

@@ -60,6 +60,11 @@ export declare class Org extends AsyncCreatable<Org.Options> {
      * @param throwWhenRemoveFails Determines if the call should throw an error or fail silently.
      */
     remove(throwWhenRemoveFails?: boolean): Promise<void>;
+    /**
+     * Check if org is a sandbox org by checking its SandboxOrgConfig.
+     *
+     */
+    isSandbox(): Promise<boolean>;
     /**
      * Check that this org is a scratch org by asking the dev hub if it knows about it.
      *
@@ -82,6 +87,16 @@ export declare class Org extends AsyncCreatable<Org.Options> {
      * dev hub**. If you need accuracy, use the {@link Org.determineIfDevHubOrg} method.
      */
     isDevHubOrg(): boolean;
+    /**
+     * Will delete 'this' instance remotely and any files locally
+     *
+     * @param controllingOrg username or Org that 'this.devhub' or 'this.production' refers to. AKA a DevHub for a scratch org, or a Production Org for a sandbox
+     */
+    deleteFrom(controllingOrg: string | Org): Promise<void>;
+    /**
+     * Will delete 'this' instance remotely and any files locally
+     */
+    delete(): Promise<void>;
     /**
      * Returns `true` if the org is a Dev Hub.
      *
@@ -177,6 +192,21 @@ export declare class Org extends AsyncCreatable<Org.Options> {
      * **Throws** *{@link SfdxError} Throws and unsupported error.
      */
     protected getDefaultOptions(): Org.Options;
+    private queryProduction;
+    /**
+     * this method will delete the sandbox org from the production org and clean up any local files
+     *
+     * @param prodOrg - Production org associated with this sandbox
+     * @private
+     */
+    private deleteSandbox;
+    /**
+     * If this Org is a scratch org, calling this method will delete the scratch org from the DevHub and clean up any local files
+     *
+     * @param devHub - optional DevHub Org of the to-be-deleted scratch org
+     * @private
+     */
+    private deleteScratchOrg;
     /**
      * Returns a promise to delete an auth info file from the local file system and any related cache information for
      * this Org.. You don't want to call this method directly. Instead consider calling Org.remove()

package/lib/org.js

@@ -72,7 +72,7 @@ class Org extends kit_1.AsyncCreatable {
             this.logger.debug(`cleaning data for path: ${dataPath}`);
         }
         catch (err) {
-            if (err.name === 'InvalidProjectWorkspace') {
+            if (err instanceof Error && err.name === 'InvalidProjectWorkspace') {
                 // If we aren't in a project dir, we can't clean up data files.
                 // If the user unlink this org outside of the workspace they used it in,
                 // data files will be left over.
@@ -110,6 +110,13 @@ class Org extends kit_1.AsyncCreatable {
         // So, just in case no users are added to this org we will try the remove again.
         await this.removeAuth();
     }
+    /**
+     * Check if org is a sandbox org by checking its SandboxOrgConfig.
+     *
+     */
+    async isSandbox() {
+        return !!(await this.getSandboxOrgConfigField(sandboxOrgConfig_1.SandboxOrgConfig.Fields.PROD_ORG_USERNAME));
+    }
     /**
      * Check that this org is a scratch org by asking the dev hub if it knows about it.
      *
@@ -133,7 +140,7 @@ class Org extends kit_1.AsyncCreatable {
             results = await devHubConnection.query(DEV_HUB_SOQL);
         }
         catch (err) {
-            if (err.name === 'INVALID_TYPE') {
+            if (err instanceof Error && err.name === 'INVALID_TYPE') {
                 throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'NotADevHub', [devHubConnection.getUsername()]);
             }
             throw err;
@@ -175,6 +182,36 @@ class Org extends kit_1.AsyncCreatable {
             return false;
         }
     }
+    /**
+     * Will delete 'this' instance remotely and any files locally
+     *
+     * @param controllingOrg username or Org that 'this.devhub' or 'this.production' refers to. AKA a DevHub for a scratch org, or a Production Org for a sandbox
+     */
+    async deleteFrom(controllingOrg) {
+        if (typeof controllingOrg === 'string') {
+            controllingOrg = await Org.create({
+                aggregator: this.configAggregator,
+                aliasOrUsername: controllingOrg,
+            });
+        }
+        if (await this.isSandbox()) {
+            await this.deleteSandbox(controllingOrg);
+        }
+        else {
+            await this.deleteScratchOrg(controllingOrg);
+        }
+    }
+    /**
+     * Will delete 'this' instance remotely and any files locally
+     */
+    async delete() {
+        if (await this.isSandbox()) {
+            await this.deleteSandbox();
+        }
+        else {
+            await this.deleteScratchOrg();
+        }
+    }
     /**
      * Returns `true` if the org is a Dev Hub.
      *
@@ -416,6 +453,98 @@ class Org extends kit_1.AsyncCreatable {
     getDefaultOptions() {
         throw new sfdxError_1.SfdxError('Not Supported');
     }
+    async queryProduction(org, field, value) {
+        return org.connection.singleRecordQuery(`SELECT SandboxInfoId FROM SandboxProcess WHERE ${field} ='${value}' AND Status NOT IN ('D', 'E')`, { tooling: true });
+    }
+    /**
+     * this method will delete the sandbox org from the production org and clean up any local files
+     *
+     * @param prodOrg - Production org associated with this sandbox
+     * @private
+     */
+    async deleteSandbox(prodOrg) {
+        prodOrg !== null && prodOrg !== void 0 ? prodOrg : (prodOrg = await Org.create({
+            aggregator: this.configAggregator,
+            aliasOrUsername: await this.getSandboxOrgConfigField(sandboxOrgConfig_1.SandboxOrgConfig.Fields.PROD_ORG_USERNAME),
+        }));
+        let result;
+        // attempt to locate sandbox id by username
+        try {
+            // try to calculate sandbox name from the production org
+            // production org: admin@integrationtesthub.org
+            // this.getUsername: admin@integrationtesthub.org.dev1
+            // sandboxName in Production: dev1
+            const sandboxName = (this.getUsername() || '').split(`${prodOrg.getUsername()}.`)[1];
+            if (!sandboxName) {
+                this.logger.debug('Could not construct a sandbox name');
+                throw new Error();
+            }
+            this.logger.debug(`attempting to locate sandbox with username ${sandboxName}`);
+            result = await this.queryProduction(prodOrg, 'SandboxName', sandboxName);
+            if (!result) {
+                this.logger.debug(`Failed to find sandbox with username: ${sandboxName}`);
+                throw new Error();
+            }
+        }
+        catch {
+            // if an error is thrown, don't panic yet. we'll try querying by orgId
+            const trimmedId = sfdc_1.sfdc.trimTo15(this.getOrgId());
+            this.logger.debug(`defaulting to trimming id from ${this.getOrgId()} to ${trimmedId}`);
+            try {
+                result = await this.queryProduction(prodOrg, 'SandboxOrganization', trimmedId);
+            }
+            catch {
+                throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'SandboxNotFound', [trimmedId]);
+            }
+        }
+        const deleteResult = await prodOrg.connection.tooling.delete('SandboxInfo', result.SandboxInfoId);
+        this.logger.debug('Return from calling tooling.delete: %o ', deleteResult);
+        await this.remove();
+        if (Array.isArray(deleteResult) || !deleteResult.success) {
+            throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'SandboxDeleteFailed', [JSON.stringify(deleteResult)]);
+        }
+    }
+    /**
+     * If this Org is a scratch org, calling this method will delete the scratch org from the DevHub and clean up any local files
+     *
+     * @param devHub - optional DevHub Org of the to-be-deleted scratch org
+     * @private
+     */
+    async deleteScratchOrg(devHub) {
+        // if we didn't get a devHub, we'll get it from the this org
+        devHub !== null && devHub !== void 0 ? devHub : (devHub = await this.getDevHubOrg());
+        if (!devHub) {
+            throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'NoDevHubFound');
+        }
+        if (devHub.getOrgId() === this.getOrgId()) {
+            // we're attempting to delete a DevHub
+            throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'DeleteOrgHubError');
+        }
+        try {
+            const devHubConn = devHub.getConnection();
+            const username = this.getUsername();
+            const activeScratchOrgRecordId = (await devHubConn.singleRecordQuery(`SELECT Id FROM ActiveScratchOrg WHERE SignupUsername='${username}'`)).Id;
+            this.logger.trace(`found matching ActiveScratchOrg with SignupUsername: ${username}.  Deleting...`);
+            await devHubConn.delete('ActiveScratchOrg', activeScratchOrgRecordId);
+            await this.remove();
+        }
+        catch (err) {
+            this.logger.info(err instanceof Error ? err.message : err);
+            if (err instanceof Error && (err.name === 'INVALID_TYPE' || err.name === 'INSUFFICIENT_ACCESS_OR_READONLY')) {
+                // most likely from devHubConn.delete
+                this.logger.info('Insufficient privilege to access ActiveScratchOrgs.');
+                throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'InsufficientAccessToDelete');
+            }
+            if (err instanceof Error && err.name === connection_1.SingleRecordQueryErrors.NoRecords) {
+                // most likely from singleRecordQuery
+                this.logger.info('The above error can be the result of deleting an expired or already deleted org.');
+                this.logger.info('attempting to cleanup the auth file');
+                await this.removeAuth();
+                throw sfdxError_1.SfdxError.create('@salesforce/core', 'org', 'ScratchOrgNotFound');
+            }
+            throw err;
+        }
+    }
     /**
      * Returns a promise to delete an auth info file from the local file system and any related cache information for
      * this Org.. You don't want to call this method directly. Instead consider calling Org.remove()
@@ -465,7 +594,6 @@ class Org extends kit_1.AsyncCreatable {
      *
      * @param throwWhenRemoveFails true if manageDelete should throw or not if the deleted fails.
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async removeUsers(throwWhenRemoveFails) {
         this.logger.debug(`Removing users associate with org: ${this.getOrgId()}`);
         const config = await this.retrieveOrgUsersConfig();

package/lib/sfdxError.d.ts

@@ -149,7 +149,7 @@ export declare class SfdxError extends NamedError {
      * @param err The error to convert.
      */
     static wrap(err: Error | string): SfdxError;
-    get code(): string;
+    get code(): string | undefined | any;
     set code(code: string);
     /**
      * Sets the name of the command. For convenience `this` object is returned.

package/lib/sfdxError.js

@@ -179,6 +179,7 @@ class SfdxError extends kit_1.NamedError {
         }
         return sfdxError;
     }
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     get code() {
         return this._code || this.name;
     }

package/lib/testSetup.d.ts

@@ -388,7 +388,9 @@ export declare class MockTestOrgData {
     refreshToken: string;
     userId: string;
     redirectUri: string;
-    constructor(id?: string);
+    constructor(id?: string, options?: {
+        username: string;
+    });
     createDevHubUsername(username: string): void;
     makeDevHub(): void;
     createUser(user: string): MockTestOrgData;

package/lib/testSetup.js

@@ -63,7 +63,7 @@ function defaultFakeConnectionRequest() {
  * ```
  * @param sinon
  */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
 const instantiateContext = (sinon) => {
     if (!sinon) {
         try {
@@ -464,11 +464,11 @@ exports.StreamingMockCometClient = StreamingMockCometClient;
  * Mock class for OrgData.
  */
 class MockTestOrgData {
-    constructor(id = uniqid()) {
+    constructor(id = uniqid(), options) {
         this.testId = id;
         this.userId = `user_id_${this.testId}`;
         this.orgId = `${this.testId}`;
-        this.username = `admin_${this.testId}@gb.org`;
+        this.username = (options === null || options === void 0 ? void 0 : options.username) || `admin_${this.testId}@gb.org`;
         this.loginUrl = `http://login.${this.testId}.salesforce.com`;
         this.instanceUrl = `http://instance.${this.testId}.salesforce.com`;
         this.clientId = `${this.testId}/client_id`;

package/lib/util/sfdcUrl.js

@@ -12,12 +12,13 @@ const kit_1 = require("@salesforce/kit");
 const ts_types_1 = require("@salesforce/ts-types");
 const myDomainResolver_1 = require("../status/myDomainResolver");
 const logger_1 = require("../logger");
+const lifecycleEvents_1 = require("../lifecycleEvents");
 class SfdcUrl extends url_1.URL {
     constructor(input, base) {
         super(input.toString(), base);
         if (this.protocol !== 'https:' && !SfdcUrl.cache.has(this.origin)) {
             SfdcUrl.cache.add(this.origin);
-            process.emitWarning('Using insecure protocol: ' + this.protocol + ' on url: ' + this.origin);
+            void lifecycleEvents_1.Lifecycle.getInstance().emitWarning(`Using insecure protocol: ${this.protocol} on url: ${this.origin}`);
         }
     }
     /**

package/messages/org.json

@@ -1,4 +1,10 @@
 {
-    "NotFoundOnDevHub": "The scratch org does not belong to the dev hub username %s.",
-    "NotADevHub": "The provided dev hub username %s is not a valid dev hub."
-}
+  "NotFoundOnDevHub": "The scratch org does not belong to the dev hub username %s.",
+  "NotADevHub": "The provided dev hub username %s is not a valid dev hub.",
+  "NoDevHubFound": "Unable to associate this scratch org with a DevHub",
+  "DeleteOrgHubError": "The Dev Hub org cannot be deleted.",
+  "InsufficientAccessToDelete": "You do not have the appropriate permissions to delete a scratch org. Please contact your Salesforce admin.",
+  "ScratchOrgNotFound": "Attempting to delete an expired or deleted org",
+  "SandboxDeleteFailed": "The sandbox org deletion failed with a result of %s.",
+  "SandboxNotFound": "We can't find a SandboxProcess for the sandbox org %s."
+}

package/package.json

@@ -1,8 +1,9 @@
 {
   "name": "@salesforce/core",
-  "version": "2.28.4",
+  "version": "2.31.0",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
+  "types": "lib/exported.d.ts",
   "license": "BSD-3-Clause",
   "scripts": {
     "build": "sf-build",
@@ -49,9 +50,10 @@
     "debug": "^3.1.0",
     "graceful-fs": "^4.2.4",
     "jsen": "0.6.6",
-    "jsforce": "^1.10.1",
+    "jsforce": "^1.11.0",
     "jsonwebtoken": "8.5.0",
     "mkdirp": "1.0.4",
+    "semver": "^7.3.5",
     "sfdx-faye": "^1.0.9",
     "ts-retry-promise": "^0.6.0"
   },
@@ -63,8 +65,9 @@
     "@types/debug": "0.0.30",
     "@types/jsen": "0.0.19",
     "@types/jsonwebtoken": "8.3.2",
+    "@types/semver": "^7.3.9",
     "@types/shelljs": "0.7.8",
-    "@types/sinon": "^9.0.8",
+    "@types/sinon": "^10.0.6",
     "@typescript-eslint/eslint-plugin": "^4.2.0",
     "@typescript-eslint/parser": "4.26.0",
     "chai": "^4.2.0",
@@ -84,11 +87,10 @@
     "prettier": "^2.0.5",
     "pretty-quick": "^2.0.1",
     "shelljs": "0.8.1",
-    "sinon": "^9.0.2",
+    "sinon": "10.0.0",
     "ts-node": "^8.10.2",
     "typescript": "^4.1.3"
   },
-  "types": "lib/exported.d.ts",
   "repository": {
     "type": "git",
     "url": "https://github.com/forcedotcom/sfdx-core.git"