@salesforce/core 2.28.0 → 2.28.4

package/CHANGELOG.md

@@ -2,6 +2,36 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [2.28.4](https://github.com/forcedotcom/sfdx-core/compare/v2.28.3...v2.28.4) (2021-11-10)
+
+
+### Bug Fixes
+
+* bump jsforce types and run unit tests on Windows ([#485](https://github.com/forcedotcom/sfdx-core/issues/485)) ([3952c8f](https://github.com/forcedotcom/sfdx-core/commit/3952c8fe248531a0597477ed12240f611048caba))
+
+### [2.28.3](https://github.com/forcedotcom/sfdx-core/compare/v2.28.2...v2.28.3) (2021-11-08)
+
+
+### Bug Fixes
+
+* fix unit test ([d903c04](https://github.com/forcedotcom/sfdx-core/commit/d903c04e5f3e4f01fccb3f00b91560c443013ddf))
+* force new release ([124bb74](https://github.com/forcedotcom/sfdx-core/commit/124bb744c5ecc28cb8babf285c6d8c3032eb7ef6))
+* improve error message when providing an invalid username ([2ab4bbd](https://github.com/forcedotcom/sfdx-core/commit/2ab4bbdefd962283d88ccb735de88c88fe189d39))
+
+### [2.28.2](https://github.com/forcedotcom/sfdx-core/compare/v2.28.1...v2.28.2) (2021-10-13)
+
+
+### Bug Fixes
+
+* support for .mil sandboxes ([9ef35c7](https://github.com/forcedotcom/sfdx-core/commit/9ef35c7b1ef0fe974c3bd3b89b862a436e00f7d9))
+
+### [2.28.1](https://github.com/forcedotcom/sfdx-core/compare/v2.28.0...v2.28.1) (2021-10-06)
+
+
+### Bug Fixes
+
+* crmforce.mil ([e263d5d](https://github.com/forcedotcom/sfdx-core/commit/e263d5d74be9c0651e5c2676d6eec1c31fca05e4))
+
 ## [2.28.0](https://github.com/forcedotcom/sfdx-core/compare/v2.27.2...v2.28.0) (2021-09-16)
 
 

package/lib/authInfo.d.ts

@@ -343,5 +343,6 @@ export declare namespace AuthInfo {
          * creation.
          */
         parentUsername?: string;
+        isDevHub?: boolean;
     }
 }

package/lib/authInfo.js

@@ -664,7 +664,10 @@ class AuthInfo extends kit_1.AsyncCreatable {
             }
             catch (e) {
                 if (e.code === 'ENOENT') {
-                    throw sfdxError_1.SfdxError.create('@salesforce/core', 'core', 'NamedOrgNotFound', [username]);
+                    throw sfdxError_1.SfdxError.create('@salesforce/core', 'core', 'NamedOrgNotFound', [
+                        this.options.isDevHub ? 'devhub username' : 'username',
+                        username,
+                    ]);
                 }
                 else {
                     throw e;

package/lib/org.js

@@ -402,6 +402,7 @@ class Org extends kit_1.AsyncCreatable {
                 // If no username is provided or resolvable from an alias, AuthInfo will throw an SfdxError.
                 authInfo: await authInfo_1.AuthInfo.create({
                     username: (username != null && (await aliases_1.Aliases.fetch(username))) || username,
+                    isDevHub: this.options.isDevHub,
                 }),
             });
         }

package/lib/util/sfdcUrl.d.ts

@@ -35,9 +35,10 @@ export declare class SfdcUrl extends URL {
      * @returns {boolean} true if this is a local machine
      */
     isLocalUrl(): boolean;
+    toLightningDomain(): string;
     /**
      * Tests whether this url has the lightning domain extension
-     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again untill timeout
+     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again until timeout
      * If SFDX_DOMAIN_RETRY environment variable is set (number) it overrides the default timeout duration (240 seconds)
      *
      * @returns {Promise<true | never>} The resolved ip address or never

package/lib/util/sfdcUrl.js

@@ -61,6 +61,7 @@ class SfdcUrl extends url_1.URL {
             '.salesforce.com',
             '.salesforceliveagent.com',
             '.secure.force.com',
+            'crmforce.mil',
         ];
         const allowlistOfSalesforceHosts = ['developer.salesforce.com', 'trailhead.salesforce.com'];
         return allowlistOfSalesforceDomainPatterns.some((pattern) => {
@@ -95,25 +96,31 @@ class SfdcUrl extends url_1.URL {
         const LOCAL_PARTS = ['localhost.sfdcdev.', '.internal.'];
         return LOCAL_PARTS.some((part) => this.origin.includes(part));
     }
+    toLightningDomain() {
+        if (this.origin.endsWith('.my.salesforce.mil')) {
+            return this.origin.replace('.my.salesforce.mil', '.lightning.crmforce.mil');
+        }
+        // all non-mil domains
+        return `https://${ts_types_1.ensureArray(/https?:\/\/([^.]*)/.exec(this.origin))
+            .slice(1, 2)
+            .pop()}.lightning.force.com`;
+    }
     /**
      * Tests whether this url has the lightning domain extension
-     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again untill timeout
+     * This method that performs the dns lookup of the host. If the lookup fails the internal polling (1 second), client will try again until timeout
      * If SFDX_DOMAIN_RETRY environment variable is set (number) it overrides the default timeout duration (240 seconds)
      *
      * @returns {Promise<true | never>} The resolved ip address or never
      * @throws {@link SfdxError} If can't resolve DNS.
      */
     async checkLightningDomain() {
-        const domain = `https://${ts_types_1.ensureArray(/https?:\/\/([^.]*)/.exec(this.origin))
-            .slice(1, 2)
-            .pop()}.lightning.force.com`;
         const quantity = ts_types_1.ensureNumber(new kit_1.Env().getNumber('SFDX_DOMAIN_RETRY', 240));
         const timeout = new kit_1.Duration(quantity, kit_1.Duration.Unit.SECONDS);
         if (this.isInternalUrl() || timeout.seconds === 0) {
             return true;
         }
         const resolver = await myDomainResolver_1.MyDomainResolver.create({
-            url: new url_1.URL(domain),
+            url: new url_1.URL(this.toLightningDomain()),
             timeout,
             frequency: new kit_1.Duration(1, kit_1.Duration.Unit.SECONDS),
         });
@@ -145,6 +152,7 @@ class SfdcUrl extends url_1.URL {
      */
     isSandboxUrl(createdOrgInstance) {
         return ((createdOrgInstance && /^cs|s$/gi.test(createdOrgInstance)) ||
+            this.origin.endsWith('sandbox.my.salesforce.mil') ||
             /sandbox\.my\.salesforce\.com/gi.test(this.origin) || // enhanced domains >= 230
             /(cs[0-9]+(\.my|)\.salesforce\.com)/gi.test(this.origin) || // my domains on CS instance OR CS instance without my domain
             /([a-z]{3}[0-9]+s\.sfdc-.+\.salesforce\.com)/gi.test(this.origin) || // falcon sandbox ex: usa2s.sfdc-whatever.salesforce.com

package/messages/core.json

@@ -12,9 +12,9 @@
   "OrgDataNotAvailableErrorAction2": "Use `sfdx force:config:set` to update the defaultusername.",
   "OrgDataNotAvailableErrorAction3": "Use `sfdx force:org:create` to create a new org.",
   "OrgDataNotAvailableErrorAction4": "Use `sfdx force:auth` to authenticate an existing org.",
-  "NamedOrgNotFound": "No AuthInfo found for name %s",
-  "NoAliasesFound": "Nothing to set",
-  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s]",
+  "NamedOrgNotFound": "No authorization information found for %s %s.",
+  "NoAliasesFound": "Nothing to set.",
+  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s].",
   "NoAuthInfoFound": "No authorization information can be found.",
   "InvalidJsonCasing": "All JSON input must have heads down camelcase keys.  E.g., { sfdcLoginUrl: \"https://login.salesforce.com\" }\nFound \"%s\" at %s"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core",
-  "version": "2.28.0",
+  "version": "2.28.4",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
   "license": "BSD-3-Clause",
@@ -8,13 +8,13 @@
     "build": "sf-build",
     "ci-docs": "yarn sf-ci-docs",
     "clean": "sf-clean",
-    "clean-all": "-clean all",
+    "clean-all": "sf-clean all",
     "compile": "sf-compile",
     "docs": "sf-docs",
     "format": "sf-format",
     "lint": "sf-lint",
     "lint-fix": "yarn sf-lint --fix",
-    "postcompile": "tsc -p test; tsc -p typedocExamples",
+    "postcompile": "tsc -p test && tsc -p typedocExamples",
     "prepack": "sf-build",
     "pretest": "sf-compile-test",
     "test": "sf-test"
@@ -44,7 +44,7 @@
     "@salesforce/schemas": "^1.0.1",
     "@salesforce/ts-types": "^1.5.13",
     "@types/graceful-fs": "^4.1.5",
-    "@types/jsforce": "^1.9.29",
+    "@types/jsforce": "^1.9.35",
     "@types/mkdirp": "^1.0.1",
     "debug": "^3.1.0",
     "graceful-fs": "^4.2.4",
@@ -57,8 +57,8 @@
   },
   "devDependencies": {
     "@salesforce/dev-config": "^2.0.0",
-    "@salesforce/dev-scripts": "^0.6.2",
-    "@salesforce/prettier-config": "^0.0.1",
+    "@salesforce/dev-scripts": "^0.9.18",
+    "@salesforce/prettier-config": "^0.0.2",
     "@salesforce/ts-sinon": "^1.3.15",
     "@types/debug": "0.0.30",
     "@types/jsen": "0.0.19",