@salesforce/core-bundle 8.0.4 → 8.0.5

package/lib/index.js

@@ -12088,7 +12088,7 @@ var require_package2 = __commonJS({
   "package.json"(exports2, module2) {
     module2.exports = {
       name: "@salesforce/core-bundle",
-      version: "8.0.4",
+      version: "8.0.5",
       description: "Core libraries to interact with SFDX projects, orgs, and APIs.",
       main: "lib/index",
       types: "lib/index.d.ts",
@@ -12124,7 +12124,7 @@ var require_package2 = __commonJS({
         "messageTransformer/messageTransformer.ts"
       ],
       dependencies: {
-        "@jsforce/jsforce-node": "^3.2.0",
+        "@jsforce/jsforce-node": "^3.2.1",
         "@salesforce/kit": "^3.1.6",
         "@salesforce/schemas": "^1.9.0",
         "@salesforce/ts-types": "^2.0.10",
@@ -31343,6 +31343,7 @@ var require_request = __commonJS({
           ...rrequest,
           ...input && /^(post|put|patch)$/i.test(request2.method) ? { body: input } : {},
           redirect: "manual",
+          // @ts-expect-error - differing types of signal? this started abruptly
           signal: controller.signal,
           agent
         };
@@ -31350,7 +31351,7 @@ var require_request = __commonJS({
           const res2 = await (0, node_fetch_1.default)(url, fetchOpts);
           if (shouldRetryRequest(retryOpts.maxRetries, res2)) {
             logger.debug(`retrying for the ${retryCount + 1} time`);
-            logger.debug(`reason: statusCode match`);
+            logger.debug("reason: statusCode match");
             await sleep(retryCount === 0 ? retryOpts.minTimeout : retryOpts.minTimeout * retryOpts.timeoutFactor ** retryCount);
             emitter.emit("retry", retryCount);
             retryCount++;
@@ -31358,18 +31359,18 @@ var require_request = __commonJS({
           }
           return res2;
         } catch (err) {
-          logger.debug(`Request failed`);
+          logger.debug("Request failed");
           const error = err;
           if (error.name === "AbortError") {
             throw error;
           }
           if (shouldRetryRequest(retryOpts.maxRetries, error)) {
             logger.debug(`retrying for the ${retryCount + 1} time`);
-            logger.debug(`Error: ${error}`);
+            logger.debug(`Error: ${err.message}`);
             await sleep(retryCount === 0 ? retryOpts.minTimeout : retryOpts.minTimeout * retryOpts.timeoutFactor ** retryCount);
             emitter.emit("retry", retryCount);
             retryCount++;
-            return await fetchWithRetries(maxRetry);
+            return fetchWithRetries(maxRetry);
           }
           logger.debug("Skipping retry...");
           if (maxRetry === retryCount) {
@@ -31726,7 +31727,7 @@ var require_transport2 = __commonJS({
       httpRequest(req, _options = {}) {
         const xdProxyUrl = this._xdProxyUrl;
         const { url, body, ...rreq } = req;
-        const canonicalUrl = url.indexOf("/") === 0 ? baseUrl + url : url;
+        const canonicalUrl = url.startsWith("/") ? baseUrl + url : url;
         const xdProxyReq = createXdProxyRequest({ ...rreq, url: canonicalUrl, body }, xdProxyUrl);
         return super.httpRequest(xdProxyReq, {
           followRedirect: (redirectUrl) => createXdProxyRequest({ ...rreq, method: "GET", url: redirectUrl }, xdProxyUrl)
@@ -31758,7 +31759,7 @@ var require_VERSION = __commonJS({
   "node_modules/@jsforce/jsforce-node/lib/VERSION.js"(exports2) {
     "use strict";
     Object.defineProperty(exports2, "__esModule", { value: true });
-    exports2.default = "2.0.0-beta.8";
+    exports2.default = "3.2.1";
   }
 });
 
@@ -31857,8 +31858,7 @@ var require_oauth2 = __commonJS({
        */
       getAuthorizationUrl(params = {}) {
         if (this.codeVerifier) {
-          const codeChallenge = base64UrlEscape((0, crypto_1.createHash)("sha256").update(this.codeVerifier).digest("base64"));
-          params.code_challenge = codeChallenge;
+          params.code_challenge = base64UrlEscape((0, crypto_1.createHash)("sha256").update(this.codeVerifier).digest("base64"));
         }
         const _params = {
           ...params,
@@ -31866,7 +31866,7 @@ var require_oauth2 = __commonJS({
           client_id: this.clientId,
           redirect_uri: this.redirectUri
         };
-        return this.authzServiceUrl + (this.authzServiceUrl.indexOf("?") >= 0 ? "&" : "?") + querystring_1.default.stringify(_params);
+        return this.authzServiceUrl + (this.authzServiceUrl.includes("?") ? "&" : "?") + querystring_1.default.stringify(_params);
       }
       /**
        * OAuth2 Refresh Token Flow
@@ -32063,7 +32063,7 @@ var require_cache2 = __commonJS({
        */
       clear(key) {
         for (const k of Object.keys(this._entries)) {
-          if (!key || k.indexOf(key) === 0) {
+          if (!key || k.startsWith(key)) {
             this._entries[k].clear();
           }
         }
@@ -42117,6 +42117,7 @@ var require_http_api = __commonJS({
       /**
        * @private
        */
+      // eslint-disable-next-line @typescript-eslint/require-await
       async parseResponseBody(response) {
         const contentType = this.getResponseContentType(response) || "";
         const parseBody = /^(text|application)\/xml(;|$)/.test(contentType) ? parseXML : /^application\/json(;|$)/.test(contentType) ? parseJSON : /^text\/csv(;|$)/.test(contentType) ? csv_1.parseCSV : parseText;
@@ -42759,7 +42760,7 @@ var require_soql_builder = __commonJS({
         op = "$in";
       } else if (typeof value === "object" && value !== null) {
         for (const k of Object.keys(value)) {
-          if (k[0] === "$") {
+          if (k.startsWith("$")) {
             op = k;
             _value = value[k];
             break;
@@ -42971,7 +42972,7 @@ var require_query = __commonJS({
           this._logger.debug(`config is locator: ${locator}`);
           this._locator = locator.includes("/") ? this.urlToLocator(locator) : locator;
         } else {
-          this._logger.debug(`config is QueryConfig: ${config}`);
+          this._logger.debug(`config is QueryConfig: ${JSON.stringify(config)}`);
           const { fields, includes, sort, ..._config } = config;
           this._config = _config;
           this.select(fields);
@@ -43234,7 +43235,7 @@ var require_query = __commonJS({
         this.totalSize = data.totalSize;
         this.records = this.records?.concat(maxFetch - this.records.length > data.records.length ? data.records : data.records.slice(0, maxFetch - this.records.length));
         this._locator = data.nextRecordsUrl ? this.urlToLocator(data.nextRecordsUrl) : void 0;
-        this._finished = this._finished || data.done || !autoFetch || // this is what the response looks like when there are no results
+        this._finished = this._finished || data.done || !autoFetch || this.records.length === maxFetch || // this is what the response looks like when there are no results
         data.records.length === 0 && data.done === void 0;
         const numRecords = data.records?.length ?? 0;
         let totalFetched = this.totalFetched;
@@ -44294,7 +44295,7 @@ var require_connection = __commonJS({
     }
     function parseSignedRequest(sr) {
       if (typeof sr === "string") {
-        if (sr[0] === "{") {
+        if (sr.startsWith("{")) {
           return JSON.parse(sr);
         }
         const msg = sr.split(".").pop();
@@ -44423,6 +44424,9 @@ var require_connection = __commonJS({
         const { loginUrl, instanceUrl, version, oauth2, maxRequest, logLevel, proxyUrl, httpProxy } = config;
         this.loginUrl = loginUrl || defaultConnectionConfig.loginUrl;
         this.instanceUrl = instanceUrl || defaultConnectionConfig.instanceUrl;
+        if (this.isLightningInstance()) {
+          throw new Error("lightning URLs are not valid as instance URLs");
+        }
         this.version = version || defaultConnectionConfig.version;
         this.oauth2 = oauth2 instanceof oauth2_1.default ? oauth2 : new oauth2_1.default({
           loginUrl: this.loginUrl,
@@ -44542,7 +44546,7 @@ var require_connection = __commonJS({
        */
       async login(username, password) {
         this._refreshDelegate = new session_refresh_delegate_1.default(this, createUsernamePasswordRefreshFn(username, password));
-        if (this.oauth2 && this.oauth2.clientId && this.oauth2.clientSecret) {
+        if (this.oauth2?.clientId && this.oauth2.clientSecret) {
           return this.loginByOAuth2(username, password);
         }
         return this.loginBySoap(username, password);
@@ -44599,6 +44603,9 @@ var require_connection = __commonJS({
           const faultstring = m && m[1];
           throw new Error(faultstring || response.body);
         }
+        if (response.body.match(/<passwordExpired>true<\/passwordExpired>/g)) {
+          throw new Error("Unable to login because the used password has expired.");
+        }
         this._logger.debug(`SOAP response = ${response.body}`);
         m = response.body.match(/<serverUrl>([^<]+)<\/serverUrl>/);
         const serverUrl = m && m[1];
@@ -44784,11 +44791,11 @@ var require_connection = __commonJS({
        * @private
        */
       _normalizeUrl(url) {
-        if (url[0] === "/") {
-          if (url.indexOf(this.instanceUrl + "/services/") === 0) {
+        if (url.startsWith("/")) {
+          if (url.startsWith(this.instanceUrl + "/services/")) {
             return url;
           }
-          if (url.indexOf("/services/") === 0) {
+          if (url.startsWith("/services/")) {
             return this.instanceUrl + url;
           }
           return this._baseUrl() + url;
@@ -44894,13 +44901,13 @@ var require_connection = __commonJS({
       /** @private */
       async _createSingle(type2, record, options) {
         const { Id, type: rtype, attributes, ...rec } = record;
-        const sobjectType = type2 || attributes && attributes.type || rtype;
+        const sobjectType = type2 || attributes?.type || rtype;
         if (!sobjectType) {
           throw new Error("No SObject Type defined in record");
         }
         const url = [this._baseUrl(), "sobjects", sobjectType].join("/");
         let contentType, body;
-        if (options && options.multipartFileFields) {
+        if (options?.multipartFileFields) {
           const form = new form_data_1.default();
           Object.entries(options.multipartFileFields).forEach(([fieldName, fileDetails]) => {
             form.append(fieldName, Buffer.from(rec[fieldName], "base64"), fileDetails);
@@ -44950,7 +44957,7 @@ var require_connection = __commonJS({
         }
         const _records = records.map((record) => {
           const { Id, type: rtype, attributes, ...rec } = record;
-          const sobjectType = type2 || attributes && attributes.type || rtype;
+          const sobjectType = type2 || attributes?.type || rtype;
           if (!sobjectType) {
             throw new Error("No SObject Type defined in record");
           }
@@ -44991,7 +44998,7 @@ var require_connection = __commonJS({
         if (!id) {
           throw new Error("Record id is not found in record.");
         }
-        const sobjectType = type2 || attributes && attributes.type || rtype;
+        const sobjectType = type2 || attributes?.type || rtype;
         if (!sobjectType) {
           throw new Error("No SObject Type defined in record");
         }
@@ -45036,7 +45043,7 @@ var require_connection = __commonJS({
           if (!id) {
             throw new Error("Record id is not found in record.");
           }
-          const sobjectType = type2 || attributes && attributes.type || rtype;
+          const sobjectType = type2 || attributes?.type || rtype;
           if (!sobjectType) {
             throw new Error("No SObject Type defined in record");
           }
@@ -45179,7 +45186,7 @@ var require_connection = __commonJS({
        * Get identity information of current user
        */
       async identity(options = {}) {
-        let url = this.userInfo && this.userInfo.url;
+        let url = this.userInfo?.url;
         if (!url) {
           const res2 = await this.request({
             method: "GET",
@@ -45297,6 +45304,9 @@ var require_connection = __commonJS({
        * Module which manages process rules and approval processes
        */
       process = new process_1.default(this);
+      isLightningInstance() {
+        return this.instanceUrl.includes(".lightning.force.com") || this.instanceUrl.includes(".lightning.crmforce.mil") || this.instanceUrl.includes(".lightning.sfcrmapps.cn");
+      }
     };
     exports2.Connection = Connection;
     exports2.default = Connection;
@@ -45324,6 +45334,7 @@ var require_base = __commonJS({
       _getConnections() {
         return this._registryConfig.connections || (this._registryConfig.connections = {});
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async getConnectionNames() {
         return Object.keys(this._getConnections());
       }
@@ -45349,6 +45360,7 @@ var require_base = __commonJS({
         }
         return connConfig_;
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async saveConnectionConfig(name, connConfig) {
         const connections = this._getConnections();
         const { oauth2, ...connConfig_ } = connConfig;
@@ -45373,23 +45385,28 @@ var require_base = __commonJS({
         }
         return null;
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async setDefaultConnection(name) {
         this._registryConfig["default"] = name;
         this._saveConfig();
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async removeConnectionConfig(name) {
         const connections = this._getConnections();
         delete connections[name];
         this._saveConfig();
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async getClientConfig(name) {
         const clients = this._getClients();
         const clientConfig = clients[name];
         return clientConfig && { ...clientConfig };
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async getClientNames() {
         return Object.keys(this._getClients());
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async registerClientConfig(name, clientConfig) {
         const clients = this._getClients();
         clients[name] = clientConfig;
@@ -45583,9 +45600,11 @@ var require_sfdx = __commonJS({
       async removeConnectionConfig(name) {
         await this._execCommand("force:org:delete", { u: name });
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async getClientConfig(_name) {
         return null;
       }
+      // eslint-disable-next-line @typescript-eslint/require-await
       async getClientNames() {
         return [];
       }
@@ -49806,6 +49825,8 @@ var require_bulk = __commonJS({
             }
           } else if (res.state === "Completed") {
             this.retrieve();
+          } else if (res.state === "NotProcessed") {
+            this.emit("error", new Error("Job has been aborted"));
           } else {
             this.emit("inProgress", res);
             setTimeout(poll, interval);
@@ -49839,6 +49860,7 @@ var require_bulk = __commonJS({
             results = res.map((ret) => ({
               id: ret.Id || null,
               success: ret.Success === "true",
+              created: ret.Created === "true",
               errors: ret.Error ? [ret.Error] : []
             }));
           }
@@ -49880,7 +49902,7 @@ var require_bulk = __commonJS({
         };
       }
       isSessionExpired(response) {
-        return response.statusCode === 400 && /<exceptionCode>InvalidSessionId<\/exceptionCode>/.test(response.body);
+        return response.statusCode === 400 && response.body.includes("<exceptionCode>InvalidSessionId</exceptionCode>");
       }
       hasErrorInResponseBody(body) {
         return !!body.error;
@@ -50020,7 +50042,7 @@ var require_bulk2 = __commonJS({
         return Array.isArray(body) && typeof body[0] === "object" && "errorCode" in body[0];
       }
       isSessionExpired(response) {
-        return response.statusCode === 401 && /INVALID_SESSION_ID/.test(response.body);
+        return response.statusCode === 401 && response.body.includes("INVALID_SESSION_ID");
       }
       parseError(body) {
         return {
@@ -50097,19 +50119,17 @@ var require_bulk2 = __commonJS({
           options.pollTimeout = this.pollTimeout;
         if (!options.pollInterval)
           options.pollInterval = this.pollInterval;
-        const job = this.createJob({
-          object: options.object,
-          operation: options.operation
-        });
+        const { pollInterval, pollTimeout, input, ...createJobOpts } = options;
+        const job = this.createJob(createJobOpts);
         try {
           await job.open();
-          await job.uploadData(options.input);
+          await job.uploadData(input);
           await job.close();
-          await job.poll(options.pollInterval, options.pollTimeout);
+          await job.poll(pollInterval, pollTimeout);
           return await job.getAllResults();
         } catch (error) {
           const err = error;
-          this.logger.error(`bulk load failed due to: ${err}`);
+          this.logger.error(`bulk load failed due to: ${err.message}`);
           if (err.name !== "JobPollingTimeoutError") {
             job.delete().catch((ignored) => ignored);
           }
@@ -50122,7 +50142,7 @@ var require_bulk2 = __commonJS({
        * Default timeout: 10000ms
        *
        * @param soql SOQL query
-       * @param BulkV2PollingOptions options object
+       * @param options
        *
        * @returns {RecordStream} - Record stream, convertible to a CSV data stream
        */
@@ -50145,7 +50165,7 @@ var require_bulk2 = __commonJS({
           queryRecordsStream.pipe(dataStream);
         } catch (error) {
           const err = error;
-          this.logger.error(`bulk query failed due to: ${err}`);
+          this.logger.error(`bulk query failed due to: ${err.message}`);
           if (err.name !== "JobPollingTimeoutError") {
             queryJob.delete().catch((ignored) => ignored);
           }
@@ -50255,7 +50275,7 @@ var require_bulk2 = __commonJS({
         const jobId = this.id;
         const startTime = Date.now();
         const endTime = startTime + timeout;
-        this.logger.debug(`Start polling for job status`);
+        this.logger.debug("Start polling for job status");
         this.logger.debug(`Polling options: timeout:${timeout}ms | interval: ${interval}ms.`);
         if (timeout === 0) {
           throw new JobPollingTimeoutError(`Skipping polling because of timeout = 0ms. Job Id = ${jobId}`, jobId);
@@ -50367,6 +50387,9 @@ var require_bulk2 = __commonJS({
       bulkJobUnprocessedRecords;
       error;
       jobInfo;
+      /**
+       *
+       */
       constructor(conn, options) {
         super();
         this.connection = conn;
@@ -50499,7 +50522,7 @@ var require_bulk2 = __commonJS({
         if (timeout === 0) {
           throw new JobPollingTimeoutError(`Skipping polling because of timeout = 0ms. Job Id = ${jobId}`, jobId);
         }
-        this.logger.debug(`Start polling for job status`);
+        this.logger.debug("Start polling for job status");
         this.logger.debug(`Polling options: timeout:${timeout}ms | interval: ${interval}ms.`);
         while (endTime > Date.now()) {
           try {
@@ -50948,11 +50971,11 @@ var require_chatter = __commonJS({
        * @private
        */
       _normalizeUrl(url) {
-        if (url.indexOf("/chatter/") === 0 || url.indexOf("/connect/") === 0) {
+        if (url.startsWith("/chatter/") || url.startsWith("/connect/")) {
           return "/services/data/v" + this._conn.version + url;
         } else if (/^\/v[\d]+\.[\d]+\//.test(url)) {
           return "/services/data" + url;
-        } else if (url.indexOf("/services/") !== 0 && url[0] === "/") {
+        } else if (!url.startsWith("/services/") && url.startsWith("/")) {
           return "/services/data/v" + this._conn.version + "/chatter" + url;
         } else {
           return url;
@@ -51065,7 +51088,7 @@ var require_soap = __commonJS({
         return Object.keys(schema_).reduce((o, k) => {
           const s = schema_[k];
           const v = obj[k];
-          const nillable2 = Array.isArray(s) && s.length === 2 && s[0] === "?" || (0, function_1.isMapObject)(s) && "?" in s || typeof s === "string" && s[0] === "?";
+          const nillable2 = Array.isArray(s) && s.length === 2 && s[0] === "?" || (0, function_1.isMapObject)(s) && "?" in s || typeof s === "string" && s.startsWith("?");
           if (typeof v === "undefined" && nillable2) {
             return o;
           }
@@ -51075,7 +51098,7 @@ var require_soap = __commonJS({
           };
         }, obj);
       } else {
-        const nillable = typeof schema === "string" && schema[0] === "?";
+        const nillable = typeof schema === "string" && schema.startsWith("?");
         const type2 = typeof schema === "string" ? nillable ? schema.substring(1) : schema : "any";
         switch (type2) {
           case "string":
@@ -51125,9 +51148,9 @@ var require_soap = __commonJS({
         if ((0, function_1.isMapObject)(value)) {
           for (const k of Object.keys(value)) {
             const v = value[k];
-            if (k[0] === "@") {
+            if (k.startsWith("@")) {
               const kk = k.substring(1);
-              attrs.push(kk + '="' + v + '"');
+              attrs.push(`${kk}="${v}"`);
             } else {
               elems.push(toXML(k, v));
             }
@@ -60592,7 +60615,7 @@ var require_metadata = __commonJS({
       async check() {
         const result = await this._promise;
         this._id = result.id;
-        return await this._meta.checkStatus(result.id);
+        return this._meta.checkStatus(result.id);
       }
       /**
        * Polling until async call status becomes complete or error
@@ -80831,7 +80854,7 @@ var require_extension = __commonJS({
           if (message.ext && message.ext[REPLAY_FROM_KEY] == true) {
             this._extensionEnabled = true;
           }
-        } else if (message.channel === this._channel && message.data && message.data.event && message.data.event.replayId) {
+        } else if (message.channel === this._channel && message.data?.event?.replayId) {
           this._replay = message.data.event.replayId;
         }
         callback(message);
@@ -80974,12 +80997,12 @@ var require_streaming = __commonJS({
       }
       /* @private */
       _createClient(forChannelName, extensions) {
-        const needsReplayFix = typeof forChannelName === "string" && forChannelName.indexOf("/u/") === 0;
+        const needsReplayFix = typeof forChannelName === "string" && forChannelName.startsWith("/u/");
         const endpointUrl = [
           this._conn.instanceUrl,
           // special endpoint "/cometd/replay/xx.x" is only available in 36.0.
           // See https://releasenotes.docs.salesforce.com/en-us/summer16/release-notes/rn_api_streaming_classic_replay.htm
-          "cometd" + (needsReplayFix === true && this._conn.version === "36.0" ? "/replay" : ""),
+          "cometd" + (needsReplayFix && this._conn.version === "36.0" ? "/replay" : ""),
           this._conn.version
         ].join("/");
         const fayeClient = new faye_1.Client(endpointUrl, {});
@@ -80998,7 +81021,7 @@ var require_streaming = __commonJS({
       }
       /** @private **/
       _getFayeClient(channelName) {
-        const isGeneric = channelName.indexOf("/u/") === 0;
+        const isGeneric = channelName.startsWith("/u/");
         const clientType = isGeneric ? "generic" : "pushTopic";
         if (!this._fayeClients[clientType]) {
           this._fayeClients[clientType] = this._createClient(channelName);
@@ -81023,7 +81046,7 @@ var require_streaming = __commonJS({
        * Subscribe topic/channel
        */
       subscribe(name, listener) {
-        const channelName = name.indexOf("/") === 0 ? name : "/topic/" + name;
+        const channelName = name.startsWith("/") ? name : "/topic/" + name;
         const fayeClient = this._getFayeClient(channelName);
         return fayeClient.subscribe(channelName, listener);
       }
@@ -81031,7 +81054,7 @@ var require_streaming = __commonJS({
        * Unsubscribe topic
        */
       unsubscribe(name, subscription) {
-        const channelName = name.indexOf("/") === 0 ? name : "/topic/" + name;
+        const channelName = name.startsWith("/") ? name : "/topic/" + name;
         const fayeClient = this._getFayeClient(channelName);
         fayeClient.unsubscribe(channelName, subscription);
         return this;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salesforce/core-bundle",
-  "version": "8.0.4",
+  "version": "8.0.5",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/index",
   "types": "lib/index.d.ts",
@@ -36,7 +36,7 @@
     "messageTransformer/messageTransformer.ts"
   ],
   "dependencies": {
-    "@jsforce/jsforce-node": "^3.2.0",
+    "@jsforce/jsforce-node": "^3.2.1",
     "@salesforce/kit": "^3.1.6",
     "@salesforce/schemas": "^1.9.0",
     "@salesforce/ts-types": "^2.0.10",