@salesforce/afv-skills 1.5.1 → 1.5.2

package/skills/generating-apex/references/AccountService.cls

@@ -1,5 +1,5 @@
 /**
- * @description Service class for Account business logic.
+ * Service class for Account business logic.
  *              Provides account deduplication, enrichment, and territory assignment.
  *              Delegates queries to AccountSelector and SObject manipulation to AccountDomain.
  * @author Generated by Apex Class Writer Skill
@@ -14,7 +14,7 @@ public with sharing class AccountService {
     // ─── Public API ──────────────────────────────────────────────────────
 
     /**
-     * @description Merges duplicate Account records into a master record.
+     * Merges duplicate Account records into a master record.
      *              The master record retains its field values; child records are reparented.
      * @param masterIds Map of master Account Id to Set of duplicate Account Ids to merge
      * @return List of master Account Ids that were successfully merged
@@ -77,7 +77,7 @@ public with sharing class AccountService {
     }
 
     /**
-     * @description Assigns accounts to territories based on Billing State/Country.
+     * Assigns accounts to territories based on Billing State/Country.
      *              Uses Custom Metadata Type (Territory_Mapping__mdt) for mappings.
      * @param accountIds Set of Account Ids to assign territories for
      * @return Number of accounts successfully updated
@@ -115,7 +115,7 @@ public with sharing class AccountService {
     // ─── Convenience Overloads ───────────────────────────────────────────
 
     /**
-     * @description Single-account territory assignment convenience method
+     * Single-account territory assignment convenience method
      * @param accountId The Account Id to assign a territory for
      * @return 1 if updated, 0 if no change needed
      */
@@ -126,7 +126,7 @@ public with sharing class AccountService {
     // ─── Private Helpers ─────────────────────────────────────────────────
 
     /**
-     * @description Loads territory mappings from Custom Metadata
+     * Loads territory mappings from Custom Metadata
      * @return Map of territory key (State:Country) to territory name
      */
     private static Map<String, String> loadTerritoryMappings() {
@@ -139,7 +139,7 @@ public with sharing class AccountService {
     }
 
     /**
-     * @description Builds a consistent territory lookup key
+     * Builds a consistent territory lookup key
      * @param state The billing state
      * @param country The billing country
      * @return A normalized key string
@@ -149,7 +149,7 @@ public with sharing class AccountService {
     }
 
     /**
-     * @description Chunks a list of Accounts into sublists of the given size
+     * Chunks a list of Accounts into sublists of the given size
      * @param accounts The accounts to chunk
      * @param chunkSize Maximum chunk size
      * @return List of account sublists
@@ -172,7 +172,7 @@ public with sharing class AccountService {
     }
 
     /**
-     * @description Counts successful results from a DML operation
+     * Counts successful results from a DML operation
      * @param results List of Database.SaveResult
      * @return Count of successful operations
      */
@@ -195,7 +195,7 @@ public with sharing class AccountService {
     // ─── Exception ───────────────────────────────────────────────────────
 
     /**
-     * @description Custom exception for AccountService errors
+     * Custom exception for AccountService errors
      */
     public class AccountServiceException extends Exception {}
 }

package/skills/generating-apex-test/CREDITS.md

@@ -0,0 +1,30 @@
+# Credits & Acknowledgments
+
+This skill was influenced by the [sf-skills](https://github.com/Jaganpro/sf-skills) repository and built upon the collective wisdom of the Salesforce developer community. We gratefully acknowledge the following authors and resources whose ideas, patterns, and best practices have shaped this skill.
+
+---
+
+## Authors & Contributors
+
+### Jag Valaiyapathy (**[Jaganpro)](https://github.com/Jaganpro)**
+
+**[sf-skills](https://github.com/Jaganpro/sf-skills)**
+
+Key contributions influencing this skill:
+
+- Pioneering open-source Salesforce skills for agentic coding tools
+- Apex code generation and review patterns
+- Best practices, anti-patterns, and design patterns reference material
+- Template library for common Apex class types
+
+This skill was influenced by the [sf-skills](https://github.com/Jaganpro/sf-skills) repository.
+
+---
+
+## Special Thanks
+
+To the entire Salesforce developer community for sharing knowledge, writing blogs, creating open-source tools, and helping each other build better solutions.
+
+---
+
+*If we've missed anyone whose work influenced these skills, please let us know so we can add proper attribution.*

package/skills/generating-apex-test/SKILL.md

@@ -1,108 +1,199 @@
 ---
 name: generating-apex-test
-description: Apex test class generation with TestDataFactory patterns, bulk testing (200+ records), mocking strategies, and assertion best practices. Use this skill when the user asks to create, write, or improve Apex test classes, add coverage, build mocks, or implement testing patterns for triggers, services, batch jobs, queueables, and integrations.
+description: Generate and validate Apex test classes with TestDataFactory patterns, bulk testing (251+ records), mocking strategies, assertion best practices, and disciplined test-fix loops. Use this skill when creating new Apex test classes, improving test coverage, debugging and fixing failing Apex tests, running test execution and coverage analysis, or implementing testing patterns for triggers, services, controllers, batch jobs, queueables, and integrations. Triggers on *Test.cls, *_Test.cls files, sf apex run test workflows, coverage reports, test-fix loops. Do NOT trigger for production Apex code (use generating-apex) or Jest/LWC tests.
 ---
 
-# Apex Test Class Skill
+# Generating Apex Tests
+
+Generate production-ready Apex test classes and run disciplined test-fix loops with coverage analysis.
 
 ## Core Principles
 
-1. **Bulkify tests** - Always test with 200+ records to catch governor limit issues
-2. **Isolate test data** - Use `@TestSetup` and TestDataFactory; never rely on org data
-3. **Assert meaningfully** - Test behavior, not just coverage; include failure messages
-4. **Mock external dependencies** - Use `HttpCalloutMock`, `Test.setMock()` for integrations
-5. **Test negative paths** - Validate error handling, not just happy paths
+1. **One behavior per method** — each test method validates a single scenario. Separate positive, negative, and bulk tests. NEVER combine related-but-distinct inputs (e.g., null and empty) in one method — create `_NullInput_` and `_EmptyInput_` as separate test methods
+2. **Bulkify tests** — test with 251+ records to cross the 200-record trigger batch boundary. **Batch Apex exception:** in test context only one `execute()` invocation runs, so set `batchSize >= testRecordCount`. See [references/async-testing.md](references/async-testing.md)
+3. **Isolate test data** — every `@TestSetup` must delegate record creation to a `TestDataFactory` class. If none exists, create one first. Never build record lists inline in `@TestSetup`. Never rely on org data (`SeeAllData=false`) or hardcoded IDs. For duplicate rule handling, see [references/test-data-factory.md](references/test-data-factory.md)
+4. **Assert meaningfully** — use exact expected values computed from test data setup. NEVER use range assertions or approximate counts when the value is deterministic. Always include failure messages. See [references/assertion-patterns.md](references/assertion-patterns.md)
+5. **Use `Assert` class only** — `Assert.areEqual`, `Assert.isTrue`, `Assert.fail`, etc. Never use legacy `System.assert`, `System.assertEquals`, or `System.assertNotEquals`
+6. **Mock external boundaries** — use `HttpCalloutMock` for callouts, `Test.setFixedSearchResults` for SOSL, DML mock classes for database isolation. Design for testability via constructor injection. See [references/mocking-patterns.md](references/mocking-patterns.md)
+7. **Test negative paths** — validate error handling and exception scenarios, not just happy paths
+8. **Wrap with start/stop** — pair `Test.startTest()` with `Test.stopTest()` to reset governor limits and force async execution
+
+## Test.startTest() / Test.stopTest()
+
+Always wrap the code under test in `Test.startTest()` / `Test.stopTest()`:
+
+- Resets governor limits so the test measures only the code under test
+- Executes async operations synchronously (queueables, batch, future methods)
+- Fires scheduled jobs immediately
+
+## Test Code Anti-Patterns
+
+| Anti-Pattern | Fix |
+|---|---|
+| SOQL/DML inside loops | Query once before the loop; use `Map<Id, SObject>` for lookups |
+| Magic numbers in assertions | Derive expected values from setup constants |
+| God test class (>500 lines) | Split into multiple test classes by behavior area |
+| Long test methods (>30 lines) | Extract Given/When/Then into helper methods |
+| Generic `Exception` catch | Catch the specific expected type (e.g., `DmlException`) |
+
+## Workflow
+
+### Step 1 — Gather Context
+
+Before generating or fixing tests, identify:
+
+- the target production class(es) under test
+- existing test classes, test data factories, and setup helpers
+- desired test scope (single class, specific methods, suite, or local tests)
+- coverage threshold (75% minimum for deploy, 90%+ recommended)
+- org alias when running tests against an org
 
-## Test Class Structure
+### Step 2 — Generate the Test Class
+
+Apply the structure, naming conventions, and patterns from the asset templates and reference docs.
+
+**MANDATORY — File Deliverables:** For every test class, create BOTH files:
+1. `{ClassName}Test.cls` — the test class (use [assets/test-class-template.cls](assets/test-class-template.cls) as starting point)
+2. `{ClassName}Test.cls-meta.xml` — the metadata file:
+
+```xml
+<?xml version="1.0" encoding="UTF-8"?>
+<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
+    <apiVersion>66.0</apiVersion>
+    <status>Active</status>
+</ApexClass>
+```
+
+If no `TestDataFactory` exists in the project, create `TestDataFactory.cls` + `TestDataFactory.cls-meta.xml` using [assets/test-data-factory-template.cls](assets/test-data-factory-template.cls).
+
+#### @TestSetup Example
+
+```apex
+@TestSetup
+static void setupTestData() {
+    List<Account> accounts = TestDataFactory.createAccounts(251, true);
+}
+```
+
+#### Test Method Structure
+
+Use Given/When/Then:
 
 ```apex
 @isTest
-private class MyServiceTest {
+static void shouldUpdateStatus_WhenValidInput() {
+    // Given
+    List<Account> accounts = [SELECT Id FROM Account];
+
+    // When
+    Test.startTest();
+    MyService.processAccounts(accounts);
+    Test.stopTest();
+
+    // Then
+    List<Account> updated = [SELECT Id, Status__c FROM Account];
+    Assert.areEqual(251, updated.size(), 'All accounts should be processed');
+}
+```
 
-    @TestSetup
-    static void setupTestData() {
-        // Create shared test data using TestDataFactory
-        List<Account> accounts = TestDataFactory.createAccounts(200, true);
-    }
+#### Negative Test — Exception Pattern
 
-    @isTest
-    static void shouldPerformExpectedBehavior_WhenValidInput() {
-        // Given: Setup specific test state
-        List<Account> accounts = [SELECT Id, Name FROM Account];
-        
-        // When: Execute the code under test
-        Test.startTest();
-        MyService.processAccounts(accounts);
-        Test.stopTest();
-        
-        // Then: Assert expected outcomes
-        List<Account> updated = [SELECT Id, Status__c FROM Account];
-        System.assertEquals(200, updated.size(), 'All accounts should be processed');
-        for (Account acc : updated) {
-            System.assertEquals('Processed', acc.Status__c, 'Status should be updated');
-        }
-    }
+Use try/catch with `Assert.fail` to verify expected exceptions:
 
-    @isTest
-    static void shouldThrowException_WhenInvalidInput() {
-        // Given
-        List<Account> emptyList = new List<Account>();
-        
-        // When/Then
-        Test.startTest();
-        try {
-            MyService.processAccounts(emptyList);
-            System.assert(false, 'Expected MyCustomException to be thrown');
-        } catch (MyCustomException e) {
-            System.assert(e.getMessage().contains('cannot be empty'), 
-                'Exception message should indicate empty input');
-        }
-        Test.stopTest();
+```apex
+@isTest
+static void shouldThrowException_WhenInvalidInput() {
+    // Given
+    List<Account> emptyList = new List<Account>();
+
+    // When/Then
+    Test.startTest();
+    try {
+        MyService.processAccounts(emptyList);
+        Assert.fail('Expected MyCustomException to be thrown');
+    } catch (MyCustomException e) {
+        Assert.isTrue(e.getMessage().contains('cannot be empty'),
+            'Exception message should indicate empty input');
     }
+    Test.stopTest();
 }
 ```
 
-## Naming Convention
+#### Naming Convention
 
-Use descriptive method names: `should[ExpectedBehavior]_When[Condition]`
+- `should[ExpectedResult]_When[Scenario]`: `shouldSendNotification_WhenOpportunityClosedWon`
+- `[SubjectOrAction]_[Scenario]_[ExpectedResult]`: `AccountUpdate_ChangeName_Success`
 
-Examples:
-- `shouldCreateContact_WhenAccountIsActive`
-- `shouldThrowException_WhenEmailIsInvalid`
-- `shouldSendNotification_WhenOpportunityClosedWon`
-- `shouldBypassTrigger_WhenRunningAsBatch`
+### Step 3 — Run Tests
 
-## Test.startTest() / Test.stopTest()
+Start narrow when debugging; widen after the fix is stable.
 
-Always wrap the code under test:
-- Resets governor limits for accurate limit testing
-- Executes async operations synchronously (queueables, batch, future)
-- Fires scheduled jobs immediately
+```bash
+# Single test class
+sf apex run test --class-names MyServiceTest --result-format human --code-coverage --target-org <alias>
 
-## Asset Templates
+# Specific test methods
+sf apex run test --tests MyServiceTest.shouldUpdateStatus_WhenValidInput --result-format human --target-org <alias>
 
-Ready-to-use scaffolds for common test patterns:
+# All local tests
+sf apex run test --test-level RunLocalTests --result-format human --code-coverage --target-org <alias>
+```
 
-- **[assets/test-class-template.cls](assets/test-class-template.cls)** - Starter test class with positive, negative, bulk, and governor limit test stubs
-- **[assets/test-data-factory-template.cls](assets/test-data-factory-template.cls)** - TestDataFactory with Account, Contact, Opportunity, User factories and field override support
+### Step 4 — Analyze Results
 
-## Reference Files
+Focus on:
 
-Detailed patterns for specific scenarios:
+- failing methods — exception types and stack traces
+- uncovered lines and weak coverage areas
+- whether failures indicate bad test data, brittle assertions, or broken production logic
 
-- **[references/test-data-factory.md](references/test-data-factory.md)** - TestDataFactory class patterns and field defaults
-- **[references/assertion-patterns.md](references/assertion-patterns.md)** - Assertion best practices and common pitfalls
-- **[references/mocking-patterns.md](references/mocking-patterns.md)** - HttpCalloutMock, Test.setMock(), stubbing
-- **[references/async-testing.md](references/async-testing.md)** - Batch, Queueable, Future, Scheduled job testing
+### Step 5 — Fix Loop
 
-## Quick Reference: What to Test
+When tests fail, run a disciplined fix loop (max 3 iterations — stop and surface root cause if still failing):
+
+1. Read the failing test class and the class under test
+2. Identify root cause from error messages and stack traces
+3. Apply fix — adjust test data or assertions for test-side issues; delegate production code issues to the `generating-apex` skill
+4. Rerun the focused test before broader regression
+5. Repeat until all tests pass, iteration limit reached, or root cause requires design change
+
+### Step 6 — Validate Coverage
+
+| Level | Coverage | Purpose |
+|-------|----------|---------|
+| Production deploy | 75% minimum | Required by Salesforce |
+| Recommended | 90%+ | Best practice target |
+| Critical paths | 100% | Business-critical code |
+
+Cover all paths: positive, negative/exception, bulk (251+ records), callout/async.
+
+## What to Test by Component
 
 | Component | Key Test Scenarios |
 |-----------|-------------------|
-| Trigger | Bulk insert/update/delete, recursion, field changes |
-| Service | Valid/invalid inputs, bulk operations, exceptions |
+| Trigger | Bulk insert/update/delete, recursion guard, field change detection |
+| Service | Valid/invalid inputs, bulk operations, exception handling |
 | Controller | Page load, action methods, view state |
-| Batch | Start/execute/finish, chunking, error records |
-| Queueable | Chaining, bulkification, error handling |
+| Batch | start/execute/finish, scope matching (batch size >= record count), `Database.Stateful` tracking, error handling, chaining (separate methods — `finish()` calling `Database.executeBatch()` throws `UnexpectedException`) |
+| Queueable | Chaining (only first job runs in tests), bulkification, error handling, callout mocks before `Test.startTest()` |
 | Callout | Success response, error response, timeout |
-| Scheduled | Execution, CRON validation |
+| Selector | Valid/null/empty inputs, bulk (251+), field population, sort order, `WITH USER_MODE` via `System.runAs` |
+| Scheduled | Direct execution via `execute(null)`, CRON registration via `CronTrigger` query |
+| Platform Event | `Test.enableChangeDataCapture()`, `Test.getEventBus().deliver()`, verify subscriber side effects |
+
+## Output Expectations
+
+Deliverables per test class:
+- `{ClassName}Test.cls` + `{ClassName}Test.cls-meta.xml` (match API version of class under test; default `66.0`)
+- `TestDataFactory.cls` + `TestDataFactory.cls-meta.xml` (if not already present)
+
+## Reference Files
+
+Load on demand for detailed patterns:
+
+| Reference | When to use |
+|-----------|-------------|
+| [references/test-data-factory.md](references/test-data-factory.md) | TestDataFactory patterns, field overrides, duplicate rule handling |
+| [references/assertion-patterns.md](references/assertion-patterns.md) | Assertion best practices, anti-patterns, common pitfalls |
+| [references/mocking-patterns.md](references/mocking-patterns.md) | HttpCalloutMock, DML mocking, StubProvider, SOSL, Email, Platform Events |
+| [references/async-testing.md](references/async-testing.md) | Batch, Queueable, Future, Scheduled job testing |

package/skills/generating-apex-test/assets/test-class-template.cls

@@ -1,51 +1,47 @@
 /**
  * @description Test class for {ClassUnderTest}.
- *              Tests bulk operations (200+ records), positive/negative paths,
+ *              Tests bulk operations (251+ records), positive/negative paths,
  *              and exception handling.
- * @author Generated by Apex Test Writer Skill
  */
 @isTest
 private class {ClassUnderTest}Test {
 
-    // ─── Test Setup ───────────────────────────────────────────────────────
-
     @TestSetup
     static void setupTestData() {
-        // Create shared test data using TestDataFactory
-        // List<Account> accounts = TestDataFactory.createAccounts(200, true);
+        List<Account> accounts = TestDataFactory.createAccounts(251, true);
     }
 
     // ─── Positive Tests ───────────────────────────────────────────────────
 
     @isTest
     static void shouldPerformExpectedBehavior_WhenValidInput() {
-        // Given: Setup specific test state
-        // List<Account> accounts = [SELECT Id, Name FROM Account];
+        // Given
+        List<Account> accounts = [SELECT Id, Name FROM Account];
 
-        // When: Execute the code under test
+        // When
         Test.startTest();
         // {ClassUnderTest}.methodUnderTest(params);
         Test.stopTest();
 
-        // Then: Assert expected outcomes
-        // System.assertEquals(expected, actual, 'Descriptive failure message');
+        // Then
+        // Assert.areEqual(expected, actual, 'Descriptive failure message');
     }
 
     @isTest
-    static void shouldHandleBulkRecords_WhenProcessing200() {
-        // Given: 200+ records to verify bulkification
-        // List<Account> accounts = [SELECT Id FROM Account];
-        // System.assertEquals(200, accounts.size(), 'Should have 200 test records');
+    static void shouldHandleBulkRecords_WhenProcessing251() {
+        // Given
+        List<Account> accounts = [SELECT Id FROM Account];
+        Assert.areEqual(251, accounts.size(), 'Should have 251 test records');
 
         // When
         Test.startTest();
         // {ClassUnderTest}.bulkMethod(accounts);
         Test.stopTest();
 
-        // Then: Verify all records processed
+        // Then
         // List<Account> results = [SELECT Id, Status__c FROM Account];
         // for (Account acc : results) {
-        //     System.assertEquals('Processed', acc.Status__c, 'All records should be processed');
+        //     Assert.areEqual('Processed', acc.Status__c, 'All records should be processed');
         // }
     }
 
@@ -53,21 +49,15 @@ private class {ClassUnderTest}Test {
 
     @isTest
     static void shouldThrowException_WhenNullInput() {
-        Boolean exceptionThrown = false;
-        String exceptionMessage = '';
-
         Test.startTest();
         try {
             // {ClassUnderTest}.methodUnderTest(null);
-        } catch (Exception e) {
-            exceptionThrown = true;
-            exceptionMessage = e.getMessage();
+            Assert.fail('Expected exception for null input');
+        } catch (MyCustomException e) {
+            Assert.isTrue(e.getMessage().contains('cannot be null'),
+                'Exception message should mention null input');
         }
         Test.stopTest();
-
-        System.assert(exceptionThrown, 'Exception should be thrown for null input');
-        System.assert(exceptionMessage.contains('cannot be null'),
-            'Exception message should mention null input');
     }
 
     @isTest
@@ -76,16 +66,16 @@ private class {ClassUnderTest}Test {
         // List<SObject> results = {ClassUnderTest}.methodUnderTest(new List<Id>());
         Test.stopTest();
 
-        // System.assert(results.isEmpty(), 'Should return empty list for empty input');
+        // Assert.isTrue(results.isEmpty(), 'Should return empty list for empty input');
     }
 
     // ─── Edge Case Tests ──────────────────────────────────────────────────
 
     @isTest
     static void shouldHandleMixedRecords_WhenSomeQualify() {
-        // Given: Mix of qualifying and non-qualifying records
-        // List<Account> accounts = [SELECT Id, Status__c FROM Account];
-        // Integer half = accounts.size() / 2;
+        // Given
+        List<Account> accounts = [SELECT Id, Status__c FROM Account];
+        Integer half = accounts.size() / 2;
         // for (Integer i = 0; i < half; i++) {
         //     accounts[i].Status__c = 'Qualifying';
         // }
@@ -96,29 +86,8 @@ private class {ClassUnderTest}Test {
         // {ClassUnderTest}.conditionalMethod(accounts);
         Test.stopTest();
 
-        // Then: Only qualifying records should be affected
+        // Then
         // List<Account> qualifying = [SELECT Id FROM Account WHERE Processed__c = true];
-        // System.assertEquals(half, qualifying.size(), 'Only qualifying records should be processed');
-    }
-
-    // ─── Governor Limit Tests ─────────────────────────────────────────────
-
-    @isTest
-    static void shouldNotExceedGovernorLimits_WhenBulkProcessing() {
-        // Given
-        // List<Account> accounts = [SELECT Id FROM Account];
-
-        Test.startTest();
-        // {ClassUnderTest}.heavyMethod(accounts);
-        Test.stopTest();
-
-        System.assert(Limits.getDmlStatements() < Limits.getLimitDmlStatements(),
-            'Should not exceed DML statement limit');
-        System.assert(Limits.getQueries() < Limits.getLimitQueries(),
-            'Should not exceed SOQL query limit');
+        // Assert.areEqual(half, qualifying.size(), 'Only qualifying records should be processed');
     }
-
-    // ─── Helper Methods ───────────────────────────────────────────────────
-
-    // Add test-specific helper methods here
 }

package/skills/generating-apex-test/assets/test-data-factory-template.cls

@@ -2,7 +2,6 @@
  * @description Centralized factory for creating test data with sensible defaults.
  *              All methods accept a doInsert flag for flexibility.
  *              Bulk methods create multiple records; single-record methods delegate to bulk.
- * @author Generated by Apex Test Writer Skill
  */
 @isTest
 public class TestDataFactory {