@salesforce-ux/eslint-plugin-slds 1.0.0-internal-alpha.0 → 1.0.1

package/build/rules/v9/no-hardcoded-values/noHardcodedValueRule.js

@@ -216,7 +216,7 @@ function toSelector(properties) {
   const selectorParts = properties.map((prop) => {
     if (prop.includes("*")) {
       const regexPattern = prop.replace(/\*/g, ".*");
-      return `Declaration[property=/${regexPattern}$/]`;
+      return `Declaration[property=/^${regexPattern}$/]`;
     } else {
       return `Declaration[property='${prop}']`;
     }
@@ -247,6 +247,42 @@ function resolvePropertyToMatch(cssProperty) {
 
 // src/utils/hardcoded-shared-utils.ts
 var import_css_tree2 = require("@eslint/css-tree");
+
+// src/utils/value-utils.ts
+var ALLOWED_UNITS = ["px", "em", "rem", "%", "ch"];
+function parseUnitValue(value) {
+  if (!value) return null;
+  const unitsPattern = ALLOWED_UNITS.join("|");
+  const regex = new RegExp(`^(-?\\d*\\.?\\d+)(${unitsPattern})?$`);
+  const match = value.match(regex);
+  if (!match) return null;
+  const number = parseFloat(match[1]);
+  const unit = match[2] ? match[2] : null;
+  if (isNaN(number)) return null;
+  return { number, unit };
+}
+function toAlternateUnitValue(numberVal, unitType) {
+  if (unitType === "px") {
+    let floatValue = parseFloat(`${numberVal / 16}`);
+    if (!isNaN(floatValue)) {
+      return {
+        unit: "rem",
+        number: parseFloat(floatValue.toFixed(4))
+      };
+    }
+  } else if (unitType === "rem") {
+    const intValue = parseInt(`${numberVal * 16}`);
+    if (!isNaN(intValue)) {
+      return {
+        unit: "px",
+        number: intValue
+      };
+    }
+  }
+  return null;
+}
+
+// src/utils/hardcoded-shared-utils.ts
 var FONT_WEIGHTS = [
   "normal",
   "bold",
@@ -356,7 +392,7 @@ function extractDimensionValue(valueNode, cssProperty) {
       const numValue = Number(valueNode.value);
       if (numValue === 0) return null;
       const unit = valueNode.unit.toLowerCase();
-      if (unit !== "px" && unit !== "rem" && unit !== "%") return null;
+      if (!ALLOWED_UNITS.includes(unit)) return null;
       return {
         number: numValue,
         unit
@@ -398,7 +434,7 @@ function extractFontValue(node) {
       const numValue = Number(node.value);
       if (numValue <= 0) return null;
       const unit = node.unit.toLowerCase();
-      if (unit !== "px" && unit !== "rem" && unit !== "%") return null;
+      if (!ALLOWED_UNITS.includes(unit)) return null;
       return {
         number: numValue,
         unit
@@ -443,6 +479,14 @@ function forEachFontValue(valueText, callback) {
   forEachValue(valueText, extractFontValue, shouldSkipFontNode, callback);
 }
 
+// src/utils/css-utils.ts
+function formatSuggestionHooks(hooks) {
+  if (hooks.length === 1) {
+    return `${hooks[0]}`;
+  }
+  return "\n" + hooks.map((hook, index) => `${index + 1}. ${hook}`).join("\n");
+}
+
 // src/rules/v9/no-hardcoded-values/handlers/colorHandler.ts
 var handleColorDeclaration = (node, context) => {
   const cssProperty = node.property.toLowerCase();
@@ -485,9 +529,8 @@ function createColorReplacement(colorValue, cssProperty, context, positionInfo,
       end,
       replacement: originalValue,
       // Use original value to preserve spacing
-      displayValue: closestHooks.join(", "),
+      displayValue: formatSuggestionHooks(closestHooks),
       hasHook: true
-      // ← THE FIX: Multiple hooks still means "has hooks"
     };
   } else {
     return {
@@ -501,37 +544,6 @@ function createColorReplacement(colorValue, cssProperty, context, positionInfo,
   }
 }
 
-// src/utils/value-utils.ts
-function parseUnitValue(value) {
-  if (!value) return null;
-  const match = value.match(/^(-?\d*\.?\d+)(px|rem|%)?$/);
-  if (!match) return null;
-  const number = parseFloat(match[1]);
-  const unit = match[2] ? match[2] : null;
-  if (isNaN(number)) return null;
-  return { number, unit };
-}
-function toAlternateUnitValue(numberVal, unitType) {
-  if (unitType === "px") {
-    let floatValue = parseFloat(`${numberVal / 16}`);
-    if (!isNaN(floatValue)) {
-      return {
-        unit: "rem",
-        number: parseFloat(floatValue.toFixed(4))
-      };
-    }
-  } else if (unitType === "rem") {
-    const intValue = parseInt(`${numberVal * 16}`);
-    if (!isNaN(intValue)) {
-      return {
-        unit: "px",
-        number: intValue
-      };
-    }
-  }
-  return null;
-}
-
 // src/utils/styling-hook-utils.ts
 function isValueMatch(valueToMatch, sldsValue) {
   if (!valueToMatch || !sldsValue) {
@@ -589,7 +601,7 @@ function createDimensionReplacement(parsedDimension, cssProperty, context, posit
       start,
       end,
       replacement: rawValue,
-      displayValue: closestHooks.join(", "),
+      displayValue: formatSuggestionHooks(closestHooks),
       hasHook: true
     };
   } else {
@@ -656,7 +668,7 @@ function createFontReplacement(fontValue, cssProperty, context, positionInfo) {
       start,
       end,
       replacement: rawValue,
-      displayValue: closestHooks.join(", "),
+      displayValue: formatSuggestionHooks(closestHooks),
       hasHook: true
     };
   } else {
@@ -783,59 +795,51 @@ function isBoxShadowMatch(parsedCssValue, parsedValueHook) {
 }
 
 // src/rules/v9/no-hardcoded-values/handlers/boxShadowHandler.ts
-function containsCssVariable(valueText) {
-  return valueText.includes("var(");
-}
-var handleBoxShadowDeclaration = (node, context) => {
-  const cssProperty = node.property.toLowerCase();
-  const valueText = context.sourceCode.getText(node.value);
-  if (containsCssVariable(valueText)) {
-    return;
-  }
-  const replacements = [];
-  const parsedCssValue = parseAndValidateBoxShadow(valueText);
-  if (parsedCssValue) {
-    const shadowHooks = getBoxShadowHooks(context.valueToStylinghook);
-    const closestHooks = findMatchingBoxShadowHooks(parsedCssValue, shadowHooks);
-    const positionInfo = {
-      start: { offset: 0, line: 1, column: 1 },
-      end: { offset: valueText.length, line: 1, column: valueText.length + 1 }
-    };
-    const replacement = createBoxShadowReplacement(
-      valueText,
-      closestHooks,
-      context,
-      positionInfo
-    );
-    if (replacement) {
-      replacements.push(replacement);
-    }
+function toBoxShadowValue(cssValue) {
+  const parsedCssValue = parseBoxShadowValue(cssValue).filter((shadow) => Object.keys(shadow).length > 0);
+  if (parsedCssValue.length === 0) {
+    return null;
   }
-  handleShorthandAutoFix(node, context, valueText, replacements);
-};
-function getBoxShadowHooks(supportedStylinghooks) {
+  return parsedCssValue;
+}
+function shadowValueToHookEntries(supportedStylinghooks) {
   return Object.entries(supportedStylinghooks).filter(([key, value]) => {
     return value.some((hook) => hook.properties.includes("box-shadow"));
   }).map(([key, value]) => {
     return [key, value.map((hook) => hook.name)];
   });
 }
-function parseAndValidateBoxShadow(cssValue) {
-  const parsedCssValue = parseBoxShadowValue(cssValue).filter((shadow) => Object.keys(shadow).length > 0);
-  if (parsedCssValue.length === 0) {
-    return null;
+var handleBoxShadowDeclaration = (node, context) => {
+  const cssProperty = node.property.toLowerCase();
+  const valueText = context.sourceCode.getText(node.value);
+  const shadowHooks = shadowValueToHookEntries(context.valueToStylinghook);
+  const parsedCssValue = toBoxShadowValue(valueText);
+  if (!parsedCssValue) {
+    return;
   }
-  return parsedCssValue;
-}
-function findMatchingBoxShadowHooks(parsedCssValue, shadowHooks) {
-  for (const [shadowHookValue, closestHooks] of shadowHooks) {
-    const parsedHookValue = parseAndValidateBoxShadow(shadowHookValue);
-    if (parsedHookValue && isBoxShadowMatch(parsedCssValue, parsedHookValue)) {
-      return closestHooks;
+  for (const [shadow, closestHooks] of shadowHooks) {
+    const parsedValueHook = toBoxShadowValue(shadow);
+    if (parsedValueHook && isBoxShadowMatch(parsedCssValue, parsedValueHook)) {
+      if (closestHooks.length > 0) {
+        const positionInfo = {
+          start: { offset: 0, line: 1, column: 1 },
+          end: { offset: valueText.length, line: 1, column: valueText.length + 1 }
+        };
+        const replacement = createBoxShadowReplacement(
+          valueText,
+          closestHooks,
+          context,
+          positionInfo
+        );
+        if (replacement) {
+          const replacements = [replacement];
+          handleShorthandAutoFix(node, context, valueText, replacements);
+        }
+      }
+      return;
     }
   }
-  return [];
-}
+};
 function createBoxShadowReplacement(originalValue, hooks, context, positionInfo) {
   if (!positionInfo?.start) {
     return null;
@@ -850,28 +854,39 @@ function createBoxShadowReplacement(originalValue, hooks, context, positionInfo)
       displayValue: hooks[0],
       hasHook: true
     };
-  } else if (hooks.length > 1) {
-    return {
-      start,
-      end,
-      replacement: originalValue,
-      displayValue: hooks.join(", "),
-      hasHook: true
-    };
   } else {
     return {
       start,
       end,
       replacement: originalValue,
-      displayValue: originalValue,
-      hasHook: false
+      displayValue: formatSuggestionHooks(hooks),
+      hasHook: true
     };
   }
 }
 
+// src/utils/rule-utils.ts
+function isRuleEnabled(context, ruleName) {
+  try {
+    const rules = context.settings?.sldsRules || {};
+    if (ruleName in rules) {
+      const ruleConfig = rules[ruleName];
+      if (Array.isArray(ruleConfig)) {
+        return ruleConfig[0] === true;
+      } else if (ruleConfig !== void 0 && ruleConfig !== null) {
+        return true;
+      } else if (ruleConfig === false) {
+        return false;
+      }
+    }
+  } catch (error) {
+    return false;
+  }
+}
+
 // src/rules/v9/no-hardcoded-values/noHardcodedValueRule.ts
 function defineNoHardcodedValueRule(config) {
-  const { ruleConfig } = config;
+  const { ruleConfig, ruleName } = config;
   const { type, description, url, messages } = ruleConfig;
   return {
     meta: {
@@ -885,6 +900,9 @@ function defineNoHardcodedValueRule(config) {
       messages
     },
     create(context) {
+      if (ruleName === "no-hardcoded-values-slds1" && isRuleEnabled(context, "@salesforce-ux/slds/no-hardcoded-values-slds2")) {
+        return {};
+      }
       const handlerContext = {
         valueToStylinghook: config.valueToStylinghook,
         context,