@sails-pay/bachs 0.0.6 → 0.0.8

package/helpers/parameters.js

@@ -37,7 +37,8 @@ module.exports = {
   BACHS_SUCCESS_URL: {
     type: 'string',
     friendlyName: 'Success URL',
-    description: 'Default URL Bachs redirects to after pure checkout payment.'
+    description:
+      'Default URL Bachs redirects to after payment. Alias for returnUrl.'
   },
   BACHS_CANCEL_URL: {
     type: 'string',

package/helpers/payloads.js

@@ -27,7 +27,7 @@ function buildCustomerPayload(inputs) {
     })
   }
 
-  return withoutUndefined({
+  const details = withoutUndefined({
     email:
       customer.email ||
       inputs.customerEmail ||
@@ -37,6 +37,9 @@ function buildCustomerPayload(inputs) {
       customer.name || inputs.customerName || inputs.name || checkoutData.name,
     phone_number: customer.phoneNumber || inputs.phoneNumber
   })
+
+  // Omit an absent identity so hosted checkout can collect guest details.
+  return Object.keys(details).length ? details : undefined
 }
 
 function buildProductCart(items) {
@@ -88,6 +91,7 @@ function buildCheckoutSessionPayload(inputs, adapterConfig = {}) {
     cancel_url: inputs.cancelUrl || adapterConfig.cancelUrl,
     reference: inputs.reference,
     metadata: inputs.metadata || checkoutData.custom,
+    expires_in_minutes: inputs.expiresInMinutes,
     transfer_data: inputs.connect && {
       destination: inputs.connect.destination
     },
@@ -135,32 +139,6 @@ function buildPricingPayload(inputs) {
   })
 }
 
-function buildPureCheckoutPayload(inputs, adapterConfig = {}) {
-  const checkoutData = inputs.checkoutData || {}
-  const customer = inputs.customer || {}
-
-  return withoutUndefined({
-    pricing: buildPricingPayload(inputs),
-    customer_email:
-      inputs.customerEmail ||
-      inputs.email ||
-      customer.email ||
-      checkoutData.email,
-    customer_name:
-      inputs.customerName || inputs.name || customer.name || checkoutData.name,
-    success_url:
-      inputs.successUrl ||
-      inputs.returnUrl ||
-      adapterConfig.successUrl ||
-      adapterConfig.returnUrl,
-    cancel_url: inputs.cancelUrl || adapterConfig.cancelUrl,
-    reference: inputs.reference,
-    metadata: inputs.metadata || checkoutData.custom,
-    expires_in_minutes: inputs.expiresInMinutes,
-    simulated_outcome: inputs.simulatedOutcome
-  })
-}
-
 function buildRefundPayload(inputs) {
   return withoutUndefined({
     charge_id: inputs.chargeId,
@@ -176,7 +154,6 @@ function buildRefundPayload(inputs) {
 
 module.exports = {
   buildCheckoutSessionPayload,
-  buildPureCheckoutPayload,
   buildRefundPayload,
   buildProductCart,
   buildCustomerPayload,

package/machines/checkout.js

@@ -1,8 +1,5 @@
 const fetch = require('../helpers/fetch')
-const {
-  buildCheckoutSessionPayload,
-  buildPureCheckoutPayload
-} = require('../helpers/payloads')
+const { buildCheckoutSessionPayload } = require('../helpers/payloads')
 const validateCheckoutItems = require('../helpers/validate-checkout-items')
 const validateCheckoutConnect = require('../helpers/validate-checkout-connect')
 const parameters = require('../helpers/parameters')
@@ -46,8 +43,7 @@ module.exports = require('machine').build({
     },
     successUrl: {
       type: 'string',
-      description:
-        'URL Bachs redirects to after a pure checkout payment. Maps to success_url.'
+      description: 'Alias for returnUrl.'
     },
     cancelUrl: parameters.BACHS_CANCEL_URL,
     customer: {
@@ -96,23 +92,27 @@ module.exports = require('machine').build({
     },
     pricing: {
       type: 'ref',
-      description: 'Pure Checkout pricing object.'
+      description:
+        'Pricing for a checkout that sets its own price, instead of products.'
     },
     amount: {
       type: 'string',
-      description: 'Pure Checkout amount, e.g. "50.00".'
+      description:
+        'Amount for a checkout that sets its own price, e.g. "50.00".'
     },
     currency: {
       type: 'string',
-      description: 'Pure Checkout currency, e.g. "USD" or "NGN".'
+      description:
+        'Currency for a checkout that sets its own price, e.g. "USD" or "NGN".'
     },
     currencyOptions: {
       type: 'ref',
-      description: 'Pure Checkout per-currency amount overrides.'
+      description:
+        'Per-currency amount overrides for a checkout that sets its own price.'
     },
     expiresInMinutes: {
       type: 'number',
-      description: 'Pure Checkout expiry in minutes.'
+      description: 'Checkout expiry in minutes.'
     },
     simulatedOutcome: {
       type: 'string',
@@ -150,13 +150,12 @@ module.exports = require('machine').build({
     const hasPricing = Boolean(
       inputs.pricing || inputs.amount !== undefined || inputs.currency
     )
-    // A split belongs to the platform, and Bachs only splits checkout
-    // sessions. A session takes products or a raw price, so a checkout that
-    // states its own amount and currency can be split too.
+    // Bachs checks out through sessions. A session takes products or a raw
+    // price, and it permits a split rather than requiring one, so a checkout
+    // that states its own amount and currency belongs here whether or not it
+    // pays a connected account.
     const shouldUseCheckoutSession =
-      hasItems ||
-      hasProductCollection ||
-      (hasPricing && inputs.connect !== undefined)
+      hasItems || hasProductCollection || hasPricing
 
     if (hasItems && hasProductCollection) {
       return exits.invalidRequest({
@@ -183,10 +182,7 @@ module.exports = require('machine').build({
       }
     }
 
-    const path = shouldUseCheckoutSession ? '/checkout-sessions' : '/checkouts'
-    const payload = shouldUseCheckoutSession
-      ? buildCheckoutSessionPayload(inputs, adapterConfig)
-      : buildPureCheckoutPayload(inputs, adapterConfig)
+    const payload = buildCheckoutSessionPayload(inputs, adapterConfig)
 
     if (
       !payload.product_cart &&
@@ -195,12 +191,12 @@ module.exports = require('machine').build({
     ) {
       return exits.invalidRequest({
         message:
-          'Provide product items/productCollectionId or pure checkout pricing.'
+          'Provide items, productCollectionId, or pricing for a Bachs checkout.'
       })
     }
 
     try {
-      const checkout = await fetch(path, {
+      const checkout = await fetch('/checkout-sessions', {
         method: 'POST',
         apiKey: inputs.apiKey || adapterConfig.apiKey,
         baseUrl: inputs.baseUrl || adapterConfig.baseUrl,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sails-pay/bachs",
-  "version": "0.0.6",
+  "version": "0.0.8",
   "description": "Bachs adapter for Sails Pay",
   "main": "adapter.js",
   "scripts": {

package/test/checkout.test.js

@@ -96,7 +96,6 @@ test('checkout sends custom pricing and the buyer-selected amount', async () =>
 
   assert.equal(checkoutUrl, 'https://pay.bachs.io/c/custom')
   assert.deepEqual(JSON.parse(calls[0].options.body), {
-    customer: {},
     product_cart: [
       {
         product_id: 'prod_custom',
@@ -112,7 +111,7 @@ test('checkout sends custom pricing and the buyer-selected amount', async () =>
   })
 })
 
-test('checkout preserves pure checkout behavior', async () => {
+test('checkout prices itself with amount and currency', async () => {
   const calls = []
 
   fetch.setFetchImplementation(async (url, options) => {
@@ -137,7 +136,10 @@ test('checkout preserves pure checkout behavior', async () => {
   })
 
   assert.equal(checkoutUrl, 'https://pay.bachs.io/c/pure')
-  assert.equal(calls[0].url, 'https://sandbox-api.bachs.io/v1/checkouts')
+  assert.equal(
+    calls[0].url,
+    'https://sandbox-api.bachs.io/v1/checkout-sessions'
+  )
   assert.equal(calls[0].options.headers['Idempotency-Key'], 'pure_123')
   assert.deepEqual(JSON.parse(calls[0].options.body), {
     pricing: {
@@ -444,7 +446,7 @@ test('checkout splits a product-less checkout session', async () => {
   assert.equal('product_cart' in body, false)
 })
 
-test('a pure checkout without connect still posts to /checkouts', async () => {
+test('a self-priced checkout without connect still uses a checkout session', async () => {
   const calls = []
 
   fetch.setFetchImplementation(async (url, options) => {
@@ -466,7 +468,10 @@ test('a pure checkout without connect still posts to /checkouts', async () => {
     customer: { email: 'sponsor@example.com' }
   })
 
-  assert.equal(calls[0].url, 'https://sandbox-api.bachs.io/v1/checkouts')
+  assert.equal(
+    calls[0].url,
+    'https://sandbox-api.bachs.io/v1/checkout-sessions'
+  )
 })
 
 test('checkout without connect sends no split fields', async () => {
@@ -573,3 +578,27 @@ for (const invalidCase of invalidConnectCases) {
     assert.equal(fetchCalls, 0)
   })
 }
+
+for (const customer of [undefined, null, {}]) {
+  test(`guest checkout omits an empty customer (${JSON.stringify(
+    customer
+  )})`, async () => {
+    let payload
+    fetch.setFetchImplementation(async (url, options) => {
+      payload = JSON.parse(options.body)
+      return {
+        ok: true,
+        text: async () =>
+          JSON.stringify({ checkout_url: 'https://pay.bachs.io/c/guest' })
+      }
+    })
+    await checkout({
+      apiKey: 'sk_sandbox_test',
+      amount: '10.00',
+      currency: 'USD',
+      customer
+    })
+    assert.equal(Object.hasOwn(payload, 'customer'), false)
+    assert.equal(Object.hasOwn(payload, 'customer_creation'), false)
+  })
+}

package/test/payloads.test.js

@@ -2,7 +2,6 @@ const test = require('node:test')
 const assert = require('node:assert/strict')
 const {
   buildCheckoutSessionPayload,
-  buildPureCheckoutPayload,
   buildRefundPayload,
   buildProductCart,
   normalizePricing
@@ -216,77 +215,6 @@ test('buildCheckoutSessionPayload maps productCollectionId and configured return
   })
 })
 
-test('buildPureCheckoutPayload maps amount checkout inputs to Bachs snake case', () => {
-  const payload = buildPureCheckoutPayload(
-    {
-      amount: '50.00',
-      currency: 'USD',
-      currencyOptions: {
-        NGN: '75000.00'
-      },
-      email: 'customer@example.com',
-      name: 'Jane Doe',
-      successUrl: 'https://example.com/success',
-      cancelUrl: 'https://example.com/cancel',
-      reference: 'order_9876',
-      metadata: {
-        orderId: '9876'
-      },
-      expiresInMinutes: 30,
-      simulatedOutcome: 'success'
-    },
-    {}
-  )
-
-  assert.deepEqual(payload, {
-    pricing: {
-      currency: 'USD',
-      amount: '50.00',
-      currency_options: {
-        NGN: '75000.00'
-      }
-    },
-    customer_email: 'customer@example.com',
-    customer_name: 'Jane Doe',
-    success_url: 'https://example.com/success',
-    cancel_url: 'https://example.com/cancel',
-    reference: 'order_9876',
-    metadata: {
-      orderId: '9876'
-    },
-    expires_in_minutes: 30,
-    simulated_outcome: 'success'
-  })
-})
-
-test('buildPureCheckoutPayload reuses advanced pricing normalization', () => {
-  const payload = buildPureCheckoutPayload({
-    pricing: {
-      type: 'custom',
-      currency: 'USD',
-      presetAmount: '10.00',
-      minimumAmount: '5.00',
-      maximumAmount: '100.00'
-    },
-    currencyOptions: {
-      NGN: '15000.00'
-    }
-  })
-
-  assert.deepEqual(payload, {
-    pricing: {
-      currency: 'USD',
-      price_type: 'custom',
-      preset_amount: '10.00',
-      minimum_amount: '5.00',
-      maximum_amount: '100.00',
-      currency_options: {
-        NGN: '15000.00'
-      }
-    }
-  })
-})
-
 test('buildRefundPayload maps refund inputs to Bachs snake case', () => {
   const payload = buildRefundPayload({
     chargeId: 'chr_123',