@sails-pay/bachs 0.0.5 → 0.0.6

package/helpers/payloads.js

@@ -65,6 +65,7 @@ function buildProductCart(items) {
 function buildCheckoutSessionPayload(inputs, adapterConfig = {}) {
   const productCollectionId =
     inputs.productCollectionId || inputs.productCollection
+  const productCart = buildProductCart(inputs.items)
   const checkoutData = inputs.checkoutData || {}
   const returnUrl =
     inputs.returnUrl ||
@@ -74,8 +75,13 @@ function buildCheckoutSessionPayload(inputs, adapterConfig = {}) {
 
   return withoutUndefined({
     customer: buildCustomerPayload(inputs),
-    product_cart: buildProductCart(inputs.items),
+    product_cart: productCart,
     product_collection_id: productCollectionId,
+    // A session prices itself with products or with a raw amount, never both.
+    pricing:
+      productCart || productCollectionId
+        ? undefined
+        : buildPricingPayload(inputs),
     billing_currency: inputs.billingCurrency,
     allowed_payment_method_types: inputs.allowedPaymentMethodTypes,
     return_url: returnUrl,

package/helpers/validate-checkout-connect.js

@@ -20,7 +20,7 @@ function validateCheckoutConnect(connect, { isCheckoutSession }) {
   if (!isCheckoutSession) {
     return invalid(
       'connect',
-      'is only supported on product checkout sessions (items or productCollectionId).'
+      'is only supported on checkout sessions (items, productCollectionId, or pricing).'
     )
   }
 

package/machines/checkout.js

@@ -147,9 +147,18 @@ module.exports = require('machine').build({
     const hasProductCollection = Boolean(
       inputs.productCollectionId || inputs.productCollection
     )
-    const shouldUseCheckoutSession = hasItems || hasProductCollection
+    const hasPricing = Boolean(
+      inputs.pricing || inputs.amount !== undefined || inputs.currency
+    )
+    // A split belongs to the platform, and Bachs only splits checkout
+    // sessions. A session takes products or a raw price, so a checkout that
+    // states its own amount and currency can be split too.
+    const shouldUseCheckoutSession =
+      hasItems ||
+      hasProductCollection ||
+      (hasPricing && inputs.connect !== undefined)
 
-    if (shouldUseCheckoutSession && hasItems === hasProductCollection) {
+    if (hasItems && hasProductCollection) {
       return exits.invalidRequest({
         message:
           'Provide exactly one of items or productCollectionId for a Bachs checkout session.'
@@ -179,7 +188,11 @@ module.exports = require('machine').build({
       ? buildCheckoutSessionPayload(inputs, adapterConfig)
       : buildPureCheckoutPayload(inputs, adapterConfig)
 
-    if (!shouldUseCheckoutSession && !payload.pricing) {
+    if (
+      !payload.product_cart &&
+      !payload.product_collection_id &&
+      !payload.pricing
+    ) {
       return exits.invalidRequest({
         message:
           'Provide product items/productCollectionId or pure checkout pricing.'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sails-pay/bachs",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "Bachs adapter for Sails Pay",
   "main": "adapter.js",
   "scripts": {

package/test/checkout.test.js

@@ -405,6 +405,70 @@ test('checkout splits a checkout session with a connected account', async () =>
   assert.equal(body.connect, undefined)
 })
 
+test('checkout splits a product-less checkout session', async () => {
+  const calls = []
+
+  fetch.setFetchImplementation(async (url, options) => {
+    calls.push({ url, options })
+
+    return {
+      ok: true,
+      status: 201,
+      statusText: 'Created',
+      text: async () =>
+        JSON.stringify({ checkout_url: 'https://pay.bachs.io/c/raw-split' })
+    }
+  })
+
+  const checkoutUrl = await checkout({
+    apiKey: 'sk_sandbox_123',
+    amount: '10500.00',
+    currency: 'NGN',
+    billingCurrency: 'NGN',
+    customer: { email: 'sponsor@example.com' },
+    reference: 'sponsorship_2',
+    connect: { destination: 'acct_123', platformFee: '500.00' }
+  })
+
+  assert.equal(checkoutUrl, 'https://pay.bachs.io/c/raw-split')
+  assert.equal(
+    calls[0].url,
+    'https://sandbox-api.bachs.io/v1/checkout-sessions'
+  )
+
+  const body = JSON.parse(calls[0].options.body)
+  assert.deepEqual(body.pricing, { currency: 'NGN', amount: '10500.00' })
+  assert.deepEqual(body.transfer_data, { destination: 'acct_123' })
+  assert.equal(body.platform_fee, '500.00')
+  assert.equal(body.billing_currency, 'NGN')
+  assert.equal('product_cart' in body, false)
+})
+
+test('a pure checkout without connect still posts to /checkouts', async () => {
+  const calls = []
+
+  fetch.setFetchImplementation(async (url, options) => {
+    calls.push({ url, options })
+
+    return {
+      ok: true,
+      status: 201,
+      statusText: 'Created',
+      text: async () =>
+        JSON.stringify({ checkout_url: 'https://pay.bachs.io/c/raw' })
+    }
+  })
+
+  await checkout({
+    apiKey: 'sk_sandbox_123',
+    amount: '10500.00',
+    currency: 'NGN',
+    customer: { email: 'sponsor@example.com' }
+  })
+
+  assert.equal(calls[0].url, 'https://sandbox-api.bachs.io/v1/checkouts')
+})
+
 test('checkout without connect sends no split fields', async () => {
   const calls = []
 
@@ -437,16 +501,6 @@ const invalidConnectCases = [
     field: 'connect',
     message: /must be an object/
   },
-  {
-    name: 'connect on a pure checkout',
-    inputs: {
-      amount: '10500.00',
-      currency: 'NGN',
-      connect: { destination: 'acct_123', platformFee: '500.00' }
-    },
-    field: 'connect',
-    message: /only supported on product checkout sessions/
-  },
   {
     name: 'connect without a destination',
     inputs: {