@saidsef/tracing-node 3.12.0 → 3.12.1

package/libs/index.mjs

@@ -309,46 +309,22 @@ export function setupTracing(options = {}) {
     }),
     new IORedisInstrumentation({
       requireParentSpan: false,
-      responseHook: (span, cmdName, cmdArgs, response) => {
-        // Set peer.service for service graph visualization
+      requestHook: (span) => {
+        // Set peer.service for service graph visualization - CRITICAL for Tempo
+        // This must be set in requestHook to ensure it's available for service graph
         span.setAttribute('peer.service', 'redis');
         span.setAttribute('db.system', 'redis');
-
-        // Add command details for better observability
-        if (cmdName) {
-          span.setAttribute('db.operation', cmdName.toUpperCase());
-        }
-
-        // Log response size if available
-        if (response !== undefined && response !== null) {
-          const responseType = typeof response;
-          span.setAttribute('db.response.type', responseType);
-
-          if (Array.isArray(response)) {
-            span.setAttribute('db.response.count', response.length);
-          }
-        }
+        
+        // Ensure span kind is CLIENT for proper service graph visualization
+        span.setAttribute('span.kind', 'CLIENT');
+        
+        // Add additional attributes for better service graph visualization
+        span.setAttribute('db.connection_string', 'redis');
+        span.setAttribute('net.peer.name', 'redis');
       },
-      requestHook: (span, cmdName, cmdArgs) => {
-        // Set peer.service for service graph visualization - CRITICAL for Tempo
+      responseHook: (span) => {
+        // Ensure peer.service persists through response
         span.setAttribute('peer.service', 'redis');
-        span.setAttribute('db.system', 'redis');
-
-        // Add command details
-        if (cmdName) {
-          span.setAttribute('db.operation', cmdName.toUpperCase());
-          span.updateName(`redis.${cmdName.toUpperCase()}`);
-        }
-
-        // Add key information (first argument is usually the key)
-        if (cmdArgs && cmdArgs.length > 0) {
-          span.setAttribute('db.redis.key', String(cmdArgs[0]));
-
-          // For operations with multiple keys or complex args
-          if (cmdArgs.length > 1) {
-            span.setAttribute('db.redis.args_count', cmdArgs.length);
-          }
-        }
       },
       dbStatementSerializer: (cmdName, cmdArgs) => {
         // Serialize command for better observability (limit arg length to avoid huge spans)
@@ -359,7 +335,19 @@ export function setupTracing(options = {}) {
         return `${cmdName} ${args.join(' ')}`;
       },
     }),
-    new ElasticsearchInstrumentation(),
+    new ElasticsearchInstrumentation({
+      suppressInternalInstrumentation: true,
+      requestHook: (span) => {
+        // Set peer.service for service graph visualization - CRITICAL for Tempo
+        span.setAttribute('peer.service', 'elasticsearch');
+        span.setAttribute('db.system', 'elasticsearch');
+      },
+      responseHook: (span) => {
+        // Ensure peer.service persists through response
+        span.setAttribute('peer.service', 'elasticsearch');
+        span.setAttribute('db.system', 'elasticsearch');
+      },
+    }),
   ];
 
   if (enableFsInstrumentation) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saidsef/tracing-node",
-  "version": "3.12.0",
+  "version": "3.12.1",
   "description": "tracing NodeJS - Wrapper for OpenTelemetry instrumentation packages",
   "main": "libs/index.mjs",
   "scripts": {