@sagentlab/navarch-runtime 0.1.96 → 0.1.98

package/dist/exit-conditions.cjs

@@ -9,6 +9,7 @@ exports.extractUsageFromCodexEvents = extractUsageFromCodexEvents;
 exports.extractFinalMessageFromCodexEvents = extractFinalMessageFromCodexEvents;
 exports.leadingVerificationVerdict = leadingVerificationVerdict;
 exports.leadWithReviewFixMarker = leadWithReviewFixMarker;
+exports.leadWithReviewAttestation = leadWithReviewAttestation;
 exports.mapExitCondition = mapExitCondition;
 /**
  * Leading text of every report for a turn the coding agent CLI refused because
@@ -242,6 +243,61 @@ function leadWithReviewFixMarker(report) {
         .trim();
     return rest ? `${line}\n\n${rest}` : line;
 }
+const REVIEW_ATTESTATION = /^(?:\[(Approve|Code Review: Blocking|Code Review: Comment)\]\s+)?NAVARCH_REVIEW_ATTESTATION:\s*(approve|request_changes|comment)\s+([0-9a-f]{40}|[0-9a-f]{64})(?:\s|$)/i;
+const REVIEW_PREFIXES = {
+    approve: "[approve]",
+    request_changes: "[code review: blocking]",
+    comment: "[code review: comment]",
+};
+function parseReviewAttestation(line) {
+    const match = REVIEW_ATTESTATION.exec(line.trim());
+    if (!match)
+        return null;
+    const verdict = (match[2] ?? "").toLowerCase();
+    if (match[1] && `[${match[1]}]`.toLowerCase() !== REVIEW_PREFIXES[verdict])
+        return null;
+    return { verdict, headSha: (match[3] ?? "").toLowerCase() };
+}
+/**
+ * Moves a review's `NAVARCH_REVIEW_ATTESTATION` line to the top of the report.
+ * The control plane accepts it only as the first line
+ * (lib/navarch/review-attestation.ts). Claude often writes a sentence of
+ * preamble before it, and every such review was rejected with
+ * `review_attestation_required` and needed a correction turn. Kept in step
+ * with leadWithPlatformReviewAttestation there; this package cannot import
+ * it. Two lines that disagree are left for the control plane to reject.
+ */
+function leadWithReviewAttestation(report) {
+    if (parseReviewAttestation(report))
+        return report;
+    const lines = report.split("\n");
+    const claims = lines
+        .map((line, index) => ({ index, line: line.trim(), parsed: parseReviewAttestation(line) }))
+        .filter((entry) => entry.parsed !== null);
+    const first = claims[0];
+    if (!first)
+        return report;
+    const agree = claims.every((entry) => entry.parsed.verdict === first.parsed.verdict && entry.parsed.headSha === first.parsed.headSha);
+    if (!agree)
+        return report;
+    const claimLines = new Set(claims.map((entry) => entry.index));
+    const rest = lines
+        .filter((_, index) => !claimLines.has(index))
+        .join("\n")
+        .replace(/\n{3,}/g, "\n\n")
+        .trim();
+    return rest ? `${first.line}\n\n${rest}` : first.line;
+}
+/**
+ * True when the report opens with `Build outcome: FAILED|BLOCKED`. Also
+ * accepts `Task outcome:` and Markdown emphasis, which is how agents write
+ * "report a failed completion". Kept in step with declaresBuildFailure in
+ * lib/navarch/build-outcome.ts.
+ */
+function declaresBuildFailure(report) {
+    const firstLine = report.split(/\r?\n/).map((line) => line.trim()).find(Boolean) ?? "";
+    return /^(?:Build|Task) outcome:[*_`~]*\s*[*_`~]*(?:FAILED|BLOCKED)(?![a-z0-9_])/i.test(firstLine.replace(/^(?:#{1,6}\s+|>\s*|[*_`~]+\s*)+/, ""));
+}
 function summarize(text, maxLen = 500) {
     const trimmed = text.trim();
     if (!trimmed)
@@ -341,7 +397,8 @@ function mapExitCondition(result) {
     // falls back to raw stdout when neither is available (see
     // parseClaudeJsonResult's doc comment).
     const reportText = result.reportText ?? parsedJson?.result ?? result.stdout;
-    const reportSummary = summarize(leadWithReviewFixMarker(reportText)) || "Adapter completed with no report text.";
+    const reportSummary = summarize(leadWithReviewAttestation(leadWithReviewFixMarker(reportText))) ||
+        "Adapter completed with no report text.";
     // A verify agent's FAIL/BLOCKED verdict is a successful agent run whose
     // conclusion is that the delivery did not pass. The completion API only
     // accepts those verdicts with a failed outcome, so map them to a failed
@@ -362,7 +419,7 @@ function mapExitCondition(result) {
     // Build agents also use an explicit outcome marker. A zero process exit
     // means the conversation finished, not that the requested build succeeded.
     if (/^blocked(?:\s|:|$)/i.test(reportText.trim()) ||
-        /^Build outcome:\s*(?:FAILED|BLOCKED)\b/i.test(reportText.trim())) {
+        declaresBuildFailure(reportText)) {
         return {
             leaseOutcome: "failed",
             exitStatus: "failed",

package/dist/session-processes.cjs

@@ -0,0 +1,265 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.listProcesses = listProcesses;
+exports.parsePsOutput = parsePsOutput;
+exports.parseLsofCwds = parseLsofCwds;
+exports.sessionProcessIds = sessionProcessIds;
+exports.sessionIdsInUse = sessionIdsInUse;
+exports.terminateProcesses = terminateProcesses;
+exports.reapSessionProcesses = reapSessionProcesses;
+exports.reapOrphanedSessionProcesses = reapOrphanedSessionProcesses;
+const node_fs_1 = require("node:fs");
+const node_os_1 = __importDefault(require("node:os"));
+const node_path_1 = __importDefault(require("node:path"));
+const logger_cjs_1 = require("./logger.cjs");
+const sandbox_cjs_1 = require("./sandbox.cjs");
+const log = (0, logger_cjs_1.createLogger)("session-processes");
+const DEFAULT_GRACE_MS = 3_000;
+const POLL_MS = 200;
+/** Every process this user owns, with its working directory where readable. */
+async function listProcesses(deps = {}) {
+    const platform = deps.platform ?? process.platform;
+    if (platform === "win32")
+        return [];
+    const runner = deps.runner ?? sandbox_cjs_1.nodeCommandRunner;
+    const listing = await runner.run("ps", ["axww", "-o", "pid=,ppid=,tty=,command="], { timeoutMs: 10_000 });
+    if (listing.code !== 0)
+        return [];
+    const processes = parsePsOutput(listing.stdout);
+    const cwds = platform === "linux"
+        ? await linuxCwds(processes, deps.readProcCwd ?? readProcCwd)
+        : await lsofCwds(runner, deps.uid ?? node_os_1.default.userInfo().uid);
+    for (const entry of processes)
+        entry.cwd = cwds.get(entry.pid);
+    return processes;
+}
+function parsePsOutput(stdout) {
+    const processes = [];
+    for (const line of stdout.split("\n")) {
+        const match = /^\s*(\d+)\s+(\d+)\s+(\S+)\s+(.*)$/.exec(line);
+        if (!match)
+            continue;
+        processes.push({ pid: Number(match[1]), ppid: Number(match[2]), tty: match[3], command: match[4] ?? "" });
+    }
+    return processes;
+}
+/** `lsof -F pn` output: a `p<pid>` line opens each process, `n<path>` is its cwd. */
+function parseLsofCwds(stdout) {
+    const cwds = new Map();
+    let pid = null;
+    for (const line of stdout.split("\n")) {
+        if (line.startsWith("p"))
+            pid = Number(line.slice(1));
+        else if (line.startsWith("n") && pid !== null && Number.isFinite(pid))
+            cwds.set(pid, line.slice(1));
+    }
+    return cwds;
+}
+async function lsofCwds(runner, uid) {
+    // lsof exits 1 when some processes could not be read; the rest is still valid.
+    const result = await runner
+        .run("lsof", ["-nP", "-a", "-u", String(uid), "-d", "cwd", "-F", "pn"], { timeoutMs: 15_000 })
+        .catch(() => null);
+    return result ? parseLsofCwds(result.stdout) : new Map();
+}
+async function linuxCwds(processes, read) {
+    const cwds = new Map();
+    await Promise.all(processes.map(async ({ pid }) => {
+        const cwd = await read(pid);
+        if (cwd)
+            cwds.set(pid, cwd);
+    }));
+    return cwds;
+}
+async function readProcCwd(pid) {
+    return node_fs_1.promises.readlink(`/proc/${pid}/cwd`).then((cwd) => cwd.replace(/ \(deleted\)$/, ""), () => undefined);
+}
+/** A process on a terminal is a person's, e.g. a shell left in a deleted session directory. */
+function isInteractive(entry) {
+    return entry.tty !== undefined && entry.tty !== "??" && entry.tty !== "?" && entry.tty !== "-";
+}
+function within(candidate, root) {
+    return candidate === root || candidate.startsWith(`${root}${node_path_1.default.sep}`);
+}
+function namesPathIn(command, root) {
+    let index = command.indexOf(root);
+    while (index !== -1) {
+        const before = index === 0 ? " " : command[index - 1];
+        const after = command[index + root.length];
+        if ((before === " " || before === "=" || before === "'" || before === '"') &&
+            (after === undefined || after === node_path_1.default.sep || after === " " || after === "'" || after === '"')) {
+            return true;
+        }
+        index = command.indexOf(root, index + 1);
+    }
+    return false;
+}
+/** The runtime and every ancestor up to init: never a session's process. */
+function protectedPids(processes, selfPid) {
+    const parentOf = new Map(processes.map((entry) => [entry.pid, entry.ppid]));
+    const protectedSet = new Set([selfPid, 0, 1]);
+    let current = parentOf.get(selfPid);
+    while (current !== undefined && !protectedSet.has(current)) {
+        protectedSet.add(current);
+        current = parentOf.get(current);
+    }
+    return protectedSet;
+}
+/**
+ * Pids tied to any of `roots` (the same directory under its spellings, e.g.
+ * /var and /private/var), with their descendants. The runtime and its
+ * ancestors are never included.
+ */
+function sessionProcessIds(processes, roots, selfPid, options = {}) {
+    const guarded = protectedPids(processes, selfPid);
+    if (options.skipInteractive) {
+        for (const entry of processes)
+            if (isInteractive(entry))
+                guarded.add(entry.pid);
+    }
+    const childrenOf = new Map();
+    for (const entry of processes) {
+        const siblings = childrenOf.get(entry.ppid) ?? [];
+        siblings.push(entry.pid);
+        childrenOf.set(entry.ppid, siblings);
+    }
+    const selected = new Set();
+    const visit = (pid) => {
+        if (guarded.has(pid) || selected.has(pid))
+            return;
+        selected.add(pid);
+        for (const child of childrenOf.get(pid) ?? [])
+            visit(child);
+    };
+    for (const entry of processes) {
+        const tied = roots.some((root) => namesPathIn(entry.command, root) || (entry.cwd !== undefined && within(entry.cwd, root)));
+        if (tied)
+            visit(entry.pid);
+    }
+    return [...selected].sort((a, b) => a - b);
+}
+/**
+ * Session ids named by processes under `sessionsRoots`, keyed to the
+ * spellings of that session's root that matched.
+ */
+function sessionIdsInUse(processes, sessionsRoots) {
+    const found = new Map();
+    for (const sessionsRoot of sessionsRoots) {
+        const prefix = `${sessionsRoot}${node_path_1.default.sep}`;
+        for (const entry of processes) {
+            for (const text of [entry.command, entry.cwd ?? ""]) {
+                let index = text.indexOf(prefix);
+                while (index !== -1) {
+                    const rest = text.slice(index + prefix.length);
+                    const sessionId = /^[A-Za-z0-9._-]+/.exec(rest)?.[0];
+                    if (sessionId && sessionId !== "." && sessionId !== "..") {
+                        const roots = found.get(sessionId) ?? new Set();
+                        roots.add(node_path_1.default.join(sessionsRoot, sessionId));
+                        found.set(sessionId, roots);
+                    }
+                    index = text.indexOf(prefix, index + 1);
+                }
+            }
+        }
+    }
+    return found;
+}
+/** SIGTERM, a grace period, then SIGKILL for anything still running. */
+async function terminateProcesses(pids, deps = {}) {
+    if (pids.length === 0)
+        return [];
+    const kill = deps.kill ?? ((pid, signal) => process.kill(pid, signal));
+    const sleep = deps.sleep ?? ((ms) => new Promise((resolve) => setTimeout(resolve, ms)));
+    const alive = (pid) => {
+        try {
+            kill(pid, 0);
+            return true;
+        }
+        catch {
+            return false;
+        }
+    };
+    const signalled = pids.filter((pid) => {
+        try {
+            kill(pid, "SIGTERM");
+            return true;
+        }
+        catch {
+            return false;
+        }
+    });
+    const graceMs = deps.graceMs ?? DEFAULT_GRACE_MS;
+    let remaining = signalled;
+    for (let waited = 0; remaining.length > 0 && waited < graceMs; waited += POLL_MS) {
+        await sleep(POLL_MS);
+        remaining = remaining.filter(alive);
+    }
+    for (const pid of remaining) {
+        try {
+            kill(pid, "SIGKILL");
+        }
+        catch { /* Exited between the check and the kill. */ }
+    }
+    return signalled;
+}
+async function spellings(root) {
+    const resolved = node_path_1.default.resolve(root);
+    const real = await node_fs_1.promises.realpath(resolved).catch(() => resolved);
+    return real === resolved ? [resolved] : [resolved, real];
+}
+/**
+ * Stops every process still tied to a finished session's directory. Never
+ * throws: a failed listing must not block worktree cleanup.
+ */
+async function reapSessionProcesses(sessionRoot, deps = {}) {
+    try {
+        const processes = await listProcesses(deps);
+        const pids = sessionProcessIds(processes, await spellings(sessionRoot), deps.selfPid ?? process.pid);
+        const stopped = await terminateProcesses(pids, deps);
+        if (stopped.length > 0) {
+            log.info(`stopped ${stopped.length} process(es) left running by ${node_path_1.default.basename(sessionRoot)}: ${stopped.join(" ")}`);
+        }
+        return stopped;
+    }
+    catch (error) {
+        log.warn(`could not stop processes left by ${node_path_1.default.basename(sessionRoot)}: ${String(error)}`);
+        return [];
+    }
+}
+/**
+ * Stops processes of sessions that no longer exist: not active in this
+ * runtime and with no directory on disk. Those are left over from a runtime
+ * that crashed, or from an older runtime that never stopped them. A session
+ * directory that still exists belongs to the janitor's age rules, which may
+ * be protecting another runtime's live session. Processes on a terminal are
+ * left alone here: by then they are more likely a person's than an agent's.
+ */
+async function reapOrphanedSessionProcesses(sessionsRoot, isSessionActive, deps = {}) {
+    try {
+        const processes = await listProcesses(deps);
+        const inUse = sessionIdsInUse(processes, await spellings(sessionsRoot));
+        const orphanRoots = [];
+        for (const [sessionId, roots] of inUse) {
+            if (isSessionActive(sessionId))
+                continue;
+            const exists = await node_fs_1.promises.stat(node_path_1.default.join(sessionsRoot, sessionId)).then(() => true, () => false);
+            if (!exists)
+                orphanRoots.push(...roots);
+        }
+        if (orphanRoots.length === 0)
+            return [];
+        const pids = sessionProcessIds(processes, orphanRoots, deps.selfPid ?? process.pid, { skipInteractive: true });
+        const stopped = await terminateProcesses(pids, deps);
+        if (stopped.length > 0) {
+            log.info(`stopped ${stopped.length} process(es) left by deleted sessions: ${stopped.join(" ")}`);
+        }
+        return stopped;
+    }
+    catch (error) {
+        log.warn(`orphaned session process sweep failed: ${String(error)}`);
+        return [];
+    }
+}

package/dist/session.cjs

@@ -21,6 +21,7 @@ const mcp_config_cjs_1 = require("./mcp-config.cjs");
 const logger_cjs_1 = require("./logger.cjs");
 const git_worktree_cjs_1 = require("./git-worktree.cjs");
 const worktree_janitor_cjs_1 = require("./worktree-janitor.cjs");
+const session_processes_cjs_1 = require("./session-processes.cjs");
 const github_pr_cjs_1 = require("./github-pr.cjs");
 const delivery_cjs_1 = require("./delivery.cjs");
 const worktree_guard_cjs_1 = require("./worktree-guard.cjs");
@@ -904,6 +905,9 @@ async function runClaimedSession(deps, claimed, sessionId, lifecycle) {
         catch (stopErr) {
             log.warn(`sandbox stop failed during teardown: ${String(stopErr)}`);
         }
+        // Dev servers the agent started detached outlive its process group. Stop
+        // them before the worktree goes, or they run on against a deleted repo.
+        await (0, session_processes_cjs_1.reapSessionProcesses)(workDir);
         if (retainWorktree) {
             await gitWorktree.retainForRecovery().catch((error) => log.error(`Recovery worktree retained at ${gitWorktree.worktreePath}, but retention setup or credential cleanup failed: ${String(error)}`));
         }

package/dist/worktree-janitor.cjs

@@ -10,9 +10,14 @@ const node_path_1 = __importDefault(require("node:path"));
 const node_fs_1 = require("node:fs");
 const logger_cjs_1 = require("./logger.cjs");
 const sandbox_cjs_1 = require("./sandbox.cjs");
+const session_processes_cjs_1 = require("./session-processes.cjs");
 const log = (0, logger_cjs_1.createLogger)("worktree-janitor");
 exports.SESSION_ACTIVITY_FILENAME = ".navarch-active";
 exports.SESSION_RECOVERY_FILENAME = ".navarch-recovery-required";
+const defaultProcessReaper = {
+    reapSession: (sessionRoot) => (0, session_processes_cjs_1.reapSessionProcesses)(sessionRoot),
+    reapOrphans: (sessionsRoot, isSessionActive) => (0, session_processes_cjs_1.reapOrphanedSessionProcesses)(sessionsRoot, isSessionActive),
+};
 /**
  * Refreshes the durable activity marker used by janitors in other runtime
  * processes that happen to share a workspace root.
@@ -33,12 +38,14 @@ class WorktreeJanitor {
     options;
     runner;
     now;
+    processReaper;
     timer = null;
     sweepInFlight = null;
     constructor(options) {
         this.options = options;
         this.runner = options.runner ?? sandbox_cjs_1.nodeCommandRunner;
         this.now = options.now ?? Date.now;
+        this.processReaper = options.processReaper ?? defaultProcessReaper;
     }
     start() {
         if (this.timer)
@@ -118,6 +125,7 @@ class WorktreeJanitor {
                     summary.skippedActive += 1;
                     continue;
                 }
+                await this.processReaper.reapSession(sessionRoot);
                 await this.removeSessionWorktree(sessionRoot);
                 summary.removed += 1;
             }
@@ -126,6 +134,9 @@ class WorktreeJanitor {
                 log.warn(`could not clean abandoned session ${sessionId}: ${String(error)}`);
             }
         }
+        // Processes can outlive their session directory: a runtime that crashed
+        // before stopping them, or a runtime older than 0.1.98.
+        await this.processReaper.reapOrphans(sessionsRoot, (sessionId) => this.options.isSessionActive?.(sessionId) ?? false);
         return summary;
     }
     async lastActivityAt(sessionRoot) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sagentlab/navarch-runtime",
-  "version": "0.1.96",
+  "version": "0.1.98",
   "description": "Navarch machine-side session manager: claims delivery tasks and runs them through local coding agents.",
   "type": "commonjs",
   "license": "MIT",