@sagentlab/navarch-runtime 0.1.96 → 0.1.97

package/dist/exit-conditions.cjs

@@ -9,6 +9,7 @@ exports.extractUsageFromCodexEvents = extractUsageFromCodexEvents;
 exports.extractFinalMessageFromCodexEvents = extractFinalMessageFromCodexEvents;
 exports.leadingVerificationVerdict = leadingVerificationVerdict;
 exports.leadWithReviewFixMarker = leadWithReviewFixMarker;
+exports.leadWithReviewAttestation = leadWithReviewAttestation;
 exports.mapExitCondition = mapExitCondition;
 /**
  * Leading text of every report for a turn the coding agent CLI refused because
@@ -242,6 +243,61 @@ function leadWithReviewFixMarker(report) {
         .trim();
     return rest ? `${line}\n\n${rest}` : line;
 }
+const REVIEW_ATTESTATION = /^(?:\[(Approve|Code Review: Blocking|Code Review: Comment)\]\s+)?NAVARCH_REVIEW_ATTESTATION:\s*(approve|request_changes|comment)\s+([0-9a-f]{40}|[0-9a-f]{64})(?:\s|$)/i;
+const REVIEW_PREFIXES = {
+    approve: "[approve]",
+    request_changes: "[code review: blocking]",
+    comment: "[code review: comment]",
+};
+function parseReviewAttestation(line) {
+    const match = REVIEW_ATTESTATION.exec(line.trim());
+    if (!match)
+        return null;
+    const verdict = (match[2] ?? "").toLowerCase();
+    if (match[1] && `[${match[1]}]`.toLowerCase() !== REVIEW_PREFIXES[verdict])
+        return null;
+    return { verdict, headSha: (match[3] ?? "").toLowerCase() };
+}
+/**
+ * Moves a review's `NAVARCH_REVIEW_ATTESTATION` line to the top of the report.
+ * The control plane accepts it only as the first line
+ * (lib/navarch/review-attestation.ts). Claude often writes a sentence of
+ * preamble before it, and every such review was rejected with
+ * `review_attestation_required` and needed a correction turn. Kept in step
+ * with leadWithPlatformReviewAttestation there; this package cannot import
+ * it. Two lines that disagree are left for the control plane to reject.
+ */
+function leadWithReviewAttestation(report) {
+    if (parseReviewAttestation(report))
+        return report;
+    const lines = report.split("\n");
+    const claims = lines
+        .map((line, index) => ({ index, line: line.trim(), parsed: parseReviewAttestation(line) }))
+        .filter((entry) => entry.parsed !== null);
+    const first = claims[0];
+    if (!first)
+        return report;
+    const agree = claims.every((entry) => entry.parsed.verdict === first.parsed.verdict && entry.parsed.headSha === first.parsed.headSha);
+    if (!agree)
+        return report;
+    const claimLines = new Set(claims.map((entry) => entry.index));
+    const rest = lines
+        .filter((_, index) => !claimLines.has(index))
+        .join("\n")
+        .replace(/\n{3,}/g, "\n\n")
+        .trim();
+    return rest ? `${first.line}\n\n${rest}` : first.line;
+}
+/**
+ * True when the report opens with `Build outcome: FAILED|BLOCKED`. Also
+ * accepts `Task outcome:` and Markdown emphasis, which is how agents write
+ * "report a failed completion". Kept in step with declaresBuildFailure in
+ * lib/navarch/build-outcome.ts.
+ */
+function declaresBuildFailure(report) {
+    const firstLine = report.split(/\r?\n/).map((line) => line.trim()).find(Boolean) ?? "";
+    return /^(?:Build|Task) outcome:[*_`~]*\s*[*_`~]*(?:FAILED|BLOCKED)(?![a-z0-9_])/i.test(firstLine.replace(/^(?:#{1,6}\s+|>\s*|[*_`~]+\s*)+/, ""));
+}
 function summarize(text, maxLen = 500) {
     const trimmed = text.trim();
     if (!trimmed)
@@ -341,7 +397,8 @@ function mapExitCondition(result) {
     // falls back to raw stdout when neither is available (see
     // parseClaudeJsonResult's doc comment).
     const reportText = result.reportText ?? parsedJson?.result ?? result.stdout;
-    const reportSummary = summarize(leadWithReviewFixMarker(reportText)) || "Adapter completed with no report text.";
+    const reportSummary = summarize(leadWithReviewAttestation(leadWithReviewFixMarker(reportText))) ||
+        "Adapter completed with no report text.";
     // A verify agent's FAIL/BLOCKED verdict is a successful agent run whose
     // conclusion is that the delivery did not pass. The completion API only
     // accepts those verdicts with a failed outcome, so map them to a failed
@@ -362,7 +419,7 @@ function mapExitCondition(result) {
     // Build agents also use an explicit outcome marker. A zero process exit
     // means the conversation finished, not that the requested build succeeded.
     if (/^blocked(?:\s|:|$)/i.test(reportText.trim()) ||
-        /^Build outcome:\s*(?:FAILED|BLOCKED)\b/i.test(reportText.trim())) {
+        declaresBuildFailure(reportText)) {
         return {
             leaseOutcome: "failed",
             exitStatus: "failed",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sagentlab/navarch-runtime",
-  "version": "0.1.96",
+  "version": "0.1.97",
   "description": "Navarch machine-side session manager: claims delivery tasks and runs them through local coding agents.",
   "type": "commonjs",
   "license": "MIT",