@safetnsr/vet 1.16.0 → 1.17.0

package/dist/checks/debt.js

@@ -8,12 +8,45 @@ function isSourceFile(f) {
     return dot !== -1 && SOURCE_EXTS.has(f.substring(dot));
 }
 function isTestFile(f) {
-    return /\.(test|spec)\.[jt]sx?$/.test(f) || f.includes('__tests__') || f.startsWith('test/') || f.startsWith('test\\');
+    return /\.(test|spec)\.[jt]sx?$/.test(f) || f.includes('__tests__') || /(?:^|[/\\])tests?[/\\]/.test(f);
 }
 function isEntryFile(f) {
     const b = basename(f);
     return /^(cli|main|index)\.[jt]sx?$/.test(b);
 }
+// Next.js / Remix / SvelteKit / Nuxt convention exports consumed by the framework, not via imports
+const FRAMEWORK_CONVENTION_EXPORTS = new Set([
+    // Next.js App Router
+    'GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD', 'OPTIONS',
+    'metadata', 'generateMetadata', 'generateStaticParams', 'generateViewport',
+    'viewport', 'runtime', 'revalidate', 'dynamic', 'dynamicParams',
+    'fetchCache', 'preferredRegion', 'maxDuration',
+    'default', // default export in page/layout/route files
+    // Next.js Pages Router
+    'getServerSideProps', 'getStaticProps', 'getStaticPaths',
+    // Remix
+    'loader', 'action', 'meta', 'links', 'headers', 'handle',
+    'shouldRevalidate', 'ErrorBoundary', 'HydrateFallback',
+    // SvelteKit
+    'load', 'prerender', 'ssr', 'csr', 'trailingSlash',
+    // Nuxt
+    'definePageMeta', 'useHead',
+]);
+function isFrameworkConventionFile(file) {
+    // Next.js app router: app/**/page.tsx, layout.tsx, route.tsx, loading.tsx, error.tsx, etc.
+    if (/\/(app|pages)\//.test(file) && /\/(page|layout|route|loading|error|not-found|template|default|middleware)\.[jt]sx?$/.test(file))
+        return true;
+    // Next.js API routes
+    if (/\/api\//.test(file) && /\/route\.[jt]sx?$/.test(file))
+        return true;
+    // Remix routes
+    if (/\/routes\//.test(file) && /\.[jt]sx?$/.test(file))
+        return true;
+    // SvelteKit
+    if (/\+(page|layout|server|error)\.[jt]s/.test(file))
+        return true;
+    return false;
+}
 function isBarrelFile(f) {
     const b = basename(f);
     return /^index\.[jt]sx?$/.test(b);
@@ -236,14 +269,14 @@ function findDuplicates(allFuncs) {
         // Downgrade to info if all functions in the group are in test directories
         // or if any function is in an examples/demo directory
         const allInTest = group.every(f => isInTestDir(f.file));
-        const anyInExample = group.some(f => /(?:^|[/\\])(?:examples?|demos?)[/\\]/.test(f.file));
+        const anyInExample = group.some(f => /(?:^|[/\\])(?:examples?|demos?|templates?|fixtures?)[/\\]/.test(f.file));
         issues.push({
             severity: (allInTest || anyInExample) ? 'info' : 'warning',
             message: `near-duplicate functions: ${locations}`,
             file: group[0].file,
             line: group[0].line,
-            fixable: true,
-            fixHint: 'extract shared logic into a single function',
+            fixable: !(allInTest || anyInExample),
+            fixHint: (allInTest || anyInExample) ? 'duplication in examples/tests is often intentional' : 'extract shared logic into a single function',
         });
     }
     // Similarity check for non-exact matches — length-bucketed to avoid O(n²) explosion
@@ -275,14 +308,14 @@ function findDuplicates(allFuncs) {
                 // Downgrade to info if both functions are in test directories
                 // or if either is in an examples/demo directory
                 const bothInTest = isInTestDir(a.file) && isInTestDir(b.file);
-                const anyInExample = /(?:^|[/\\])(?:examples?|demos?)[/\\]/.test(a.file) || /(?:^|[/\\])(?:examples?|demos?)[/\\]/.test(b.file);
+                const anyInExample = /(?:^|[/\\])(?:examples?|demos?|templates?|fixtures?)[/\\]/.test(a.file) || /(?:^|[/\\])(?:examples?|demos?|templates?|fixtures?)[/\\]/.test(b.file);
                 issues.push({
                     severity: (bothInTest || anyInExample) ? 'info' : 'warning',
                     message: `similar functions (${Math.round(sim * 100)}%): ${a.name} (${a.file}:${a.line}) and ${b.name} (${b.file}:${b.line})`,
                     file: a.file,
                     line: a.line,
-                    fixable: true,
-                    fixHint: 'consider merging or extracting shared logic',
+                    fixable: !(bothInTest || anyInExample),
+                    fixHint: (bothInTest || anyInExample) ? 'duplication in examples/tests is often intentional' : 'consider merging or extracting shared logic',
                 });
             }
         }
@@ -373,19 +406,27 @@ function findOrphanedExports(cwd, files) {
                 continue;
             const braceMatch = line.match(/^export\s*\{([^}]+)\}/);
             if (braceMatch) {
-                const names = braceMatch[1].split(',').map(n => n.trim().split(/\s+as\s+/)[0].trim()).filter(Boolean);
-                for (const name of names) {
-                    if (name === 'default' || name === 'type')
+                for (const part of braceMatch[1].split(',')) {
+                    const trimmed = part.trim();
+                    if (!trimmed)
+                        continue;
+                    // export { x as y } — use the alias (y) as the exported name, since that's what consumers see
+                    const asParts = trimmed.split(/\s+as\s+/);
+                    const exportedName = (asParts.length > 1 ? asParts[1] : asParts[0]).trim();
+                    if (exportedName === 'default' || exportedName === 'type')
                         continue;
-                    exports.push({ name, file, line: i + 1 });
+                    exports.push({ name: exportedName, file, line: i + 1 });
                 }
             }
         }
     }
-    // Scan all files for import names — collect all imported identifiers into a Set
+    // Scan ALL files (including tests) for import names — an export consumed by a test is not orphaned
     const importedNames = new Set();
     const importRe = /import\s+(?:type\s+)?(?:\{([^}]+)\}|([a-zA-Z_$][a-zA-Z0-9_$]*)(?:\s*,\s*\{([^}]+)\})?)\s+from\s+/g;
-    for (const file of sourceFiles) {
+    // Also scan for dynamic imports: require('x'), import('x') — to catch non-static usage
+    const dynamicImportRe = /(?:require|import)\s*\(\s*['"]([^'"]+)['"]\s*\)/g;
+    const allSourceFiles = files.filter(f => isSourceFile(f));
+    for (const file of allSourceFiles) {
         const content = readFile(join(cwd, file));
         if (!content)
             continue;
@@ -406,10 +447,39 @@ function findOrphanedExports(cwd, files) {
                 importedNames.add(match[2]);
         }
     }
+    // Build a cross-reference map: for each exported name, check if it appears in other files
+    // This catches hook returns ({ Component } = useHook()), dynamic usage, re-exports, JSX, etc.
+    // Only build refs for names we actually export (not all identifiers — too expensive)
+    const exportNames = new Set(exports.map(e => e.name));
+    const nameToFiles = new Map();
+    for (const name of exportNames)
+        nameToFiles.set(name, new Set());
+    for (const file of allSourceFiles) {
+        const content = readFile(join(cwd, file));
+        if (!content)
+            continue;
+        for (const name of exportNames) {
+            if (content.includes(name)) {
+                nameToFiles.get(name).add(file);
+            }
+        }
+    }
     const lib = isLibrary(cwd);
     const mono = isMonorepo(cwd);
     for (const exp of exports) {
         if (!importedNames.has(exp.name)) {
+            // Cross-reference check: if the export name appears in a different file, it's likely used
+            // (catches hook returns, JSX usage, dynamic imports, re-exports)
+            const refs = nameToFiles.get(exp.name);
+            if (refs) {
+                const otherFiles = new Set(refs);
+                otherFiles.delete(exp.file);
+                if (otherFiles.size > 0)
+                    continue; // referenced in another file → not orphaned
+            }
+            // Skip framework convention exports (Next.js, Remix, SvelteKit, Nuxt)
+            if (FRAMEWORK_CONVENTION_EXPORTS.has(exp.name) && isFrameworkConventionFile(exp.file))
+                continue;
             // In monorepos, check if the export's file is inside a workspace package that is a library
             const isLib = lib || (mono && isFileInLibraryPackage(cwd, exp.file));
             issues.push({
@@ -417,7 +487,7 @@ function findOrphanedExports(cwd, files) {
                 message: `orphaned export: "${exp.name}" is exported but never imported${isLib ? ' (library detected — exports may be consumed externally)' : ''}`,
                 file: exp.file,
                 line: exp.line,
-                fixable: true,
+                fixable: !isLib,
                 fixHint: isLib ? 'may be public API — verify if still needed' : 'remove the export keyword or delete the function',
             });
         }

package/dist/checks/deps.js

@@ -290,10 +290,27 @@ const TOOLING_PACKAGES = new Set([
     'husky', 'lint-staged', 'tsx', 'ts-node', 'concurrently', 'npm-run-all',
     'shx', 'rimraf', 'cross-env', 'nodemon', 'jest', 'vitest', 'mocha',
     'c8', 'nyc', 'turbo', 'lerna', 'changesets', '@changesets/cli',
+    '@changesets/changelog-github', '@changesets/changelog-git',
     'webpack', 'webpack-cli', 'vite', 'rollup', 'esbuild', 'swc',
     'tailwindcss', 'postcss', 'autoprefixer', 'sass', 'less',
     'commitizen', 'cz-conventional-changelog', 'semantic-release',
     '@typescript/native-preview',
+    // Linting configs (used via eslint extends, not imported)
+    'eslint-config-next', 'eslint-config-prettier', 'eslint-config-turbo',
+    '@next/eslint-plugin-next', 'eslint-plugin-react', 'eslint-plugin-react-hooks',
+    'eslint-plugin-import', 'eslint-plugin-jsx-a11y', 'eslint-plugin-tailwindcss',
+    // Commit/release tooling
+    '@commitlint/cli', '@commitlint/config-conventional',
+    'standard-version', 'release-it', 'np',
+    // Test utilities (used as test runner plugins/reporters)
+    'chai', 'sinon', 'supertest', 'nock', '@testing-library/react',
+    '@testing-library/jest-dom', '@testing-library/user-event',
+    'ts-jest', '@swc/jest', 'babel-jest',
+    // Build plugins (used via config files, not imported)
+    '@vitejs/plugin-react', '@sveltejs/adapter-auto', '@sveltejs/kit',
+    'del-cli', 'make-node',
+    // Type packages (consumed by TS compiler, not imported)
+    '@types/react', '@types/react-dom', '@types/jest', '@types/mocha',
 ]);
 // ── Collect all deps declared in workspace sub-packages ──────────────────────
 export function collectWorkspaceDeps(cwd) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@safetnsr/vet",
-  "version": "1.16.0",
+  "version": "1.17.0",
   "description": "vet your AI-generated code — one command, one score card, one letter grade",
   "type": "module",
   "bin": {