@sablier/devkit 1.6.1 → 1.8.0

package/biome/base.jsonc

@@ -6,7 +6,7 @@
 // which files to lint and format. For example:
 //
 //   {
-//     "extends": ["@sablier/devkit/biome"],
+//     "extends": ["@sablier/devkit/biome/base"],
 //     "files": {
 //       "includes": ["**/*.{css,js,jsx,json,ts,tsx}", "!node_modules"]
 //     }
@@ -38,23 +38,41 @@
   "linter": {
     "enabled": true,
     "rules": {
+      "recommended": true,
+      "complexity": {
+        "noImplicitCoercions": "error", // forbid `!!foo`, allow `Boolean(foo)`
+        "noVoid": "off" // void is useful in some cases e.g. `useEffect` callbacks
+      },
       "correctness": {
-        "noUnusedImports": "off",
-        "noUnusedVariables": "error",
-        "useExhaustiveDependencies": "error"
+        "noUnusedImports": "off", // allow unused imports during development
+        "noUnusedVariables": "error"
       },
       "nursery": {
-        "noFloatingPromises": "error"
+        "noFloatingPromises": "error", // floating promises can lead to bugs
+        "noUselessUndefined": "off" // we want explicit undefined return values
+      },
+      "performance": {
+        "noBarrelFile": "off", // barrel exports lead to cleaner imports
+        "noDelete": "off", // disabled due to https://github.com/biomejs/biome/issues/4093
+        "noNamespaceImport": "off" // namespaces are cool
       },
-      "recommended": true,
       "style": {
+        "noNamespace": "off", // namespaces are cool
+        "useDefaultSwitchClause": "off", // already handled by TypeScript
+        "useFilenamingConvention": {
+          "level": "error",
+          "options": {
+            "filenameCases": ["kebab-case", "camelCase", "PascalCase", "export"]
+          }
+        },
+        // disabled due to https://github.com/biomejs/biome/issues/8450
         "useImportType": {
           "level": "warn",
           "options": {
             "style": "separatedType"
           }
         },
-        "useTemplate": "off"
+        "useTemplate": "off" // allow string concatenation using `+`
       }
     }
   },
@@ -70,6 +88,11 @@
       "includes": ["**/*.{json,json5,jsonc}"]
     }
   ],
+  "json": {
+    "formatter": {
+      "lineWidth": 100
+    }
+  },
   "vcs": {
     "clientKind": "git",
     "enabled": true,

package/biome/ui.jsonc

@@ -1,13 +1,13 @@
 // Sablier Devkit UI configuration for Biome v2
 //
-// Standalone configuration with base rules plus UI-specific rules for
-// accessibility, Tailwind CSS class sorting, and CSS modules support.
+// Extends base configuration with UI-specific rules for accessibility,
+// Tailwind CSS class sorting, and CSS modules support.
 //
-// IMPORTANT: Consumers must add their own `files.includes` patterns to specify
-// which files to lint and format. For example:
+// IMPORTANT: Consumers must extend BOTH configs and add their own
+// `files.includes` patterns. For example:
 //
 //   {
-//     "extends": ["@sablier/devkit/biome/ui"],
+//     "extends": ["@sablier/devkit/biome/base", "@sablier/devkit/biome/ui"],
 //     "files": {
 //       "includes": ["**/*.{css,js,jsx,json,ts,tsx}", "!node_modules"]
 //     }
@@ -18,40 +18,28 @@
     "enabled": true,
     "actions": {
       "source": {
-        "organizeImports": "on",
-        "useSortedKeys": "on"
+        "useSortedAttributes": "on"
       }
     }
   },
   "css": {
+    "formatter": {
+      "lineWidth": 100
+    },
     "parser": {
       "cssModules": true,
       "tailwindDirectives": true
     }
   },
-  "files": {
-    "maxSize": 5242880 // 5MB
-  },
-  "formatter": {
-    "enabled": true,
-    "formatWithErrors": true,
-    "indentStyle": "space",
-    "lineWidth": 100
-  },
   "linter": {
-    "enabled": true,
     "rules": {
       "a11y": {
         "noSvgWithoutTitle": "off",
         "useKeyWithClickEvents": "off"
       },
-      "correctness": {
-        "noUnusedImports": "off",
-        "noUnusedVariables": "error",
-        "useExhaustiveDependencies": "error"
-      },
       "nursery": {
-        "noFloatingPromises": "error",
+        // Sort Tailwind CSS classes alphabetically
+        // See https://github.com/biomejs/biome/issues/1274#issuecomment-3490774696
         "useSortedClasses": {
           "fix": "safe",
           "level": "warn",
@@ -60,34 +48,7 @@
             "functions": ["clsx", "cva", "cn", "tv", "tw", "tw.*"]
           }
         }
-      },
-      "recommended": true,
-      "style": {
-        "useImportType": {
-          "level": "warn",
-          "options": {
-            "style": "separatedType"
-          }
-        },
-        "useTemplate": "off"
       }
     }
-  },
-  "overrides": [
-    {
-      "assist": {
-        "actions": {
-          "source": {
-            "useSortedKeys": "off"
-          }
-        }
-      },
-      "includes": ["**/*.{json,json5,jsonc}"]
-    }
-  ],
-  "vcs": {
-    "clientKind": "git",
-    "enabled": true,
-    "useIgnoreFile": true
   }
 }

package/just/csv.just

@@ -0,0 +1,102 @@
+import "./settings.just"
+
+# ---------------------------------------------------------------------------- #
+#                                    SCRIPTS                                   #
+# ---------------------------------------------------------------------------- #
+
+# Check CSV/TSV files using qsv: https://github.com/dathere/qsv
+[group("checks"), script("python3")]
+_csv-check globs="data/*/*.csv" ext="CSV" schema="" ignore="*.csv.invalid|*.csv.valid|*validation-errors.csv":
+    import fnmatch
+    import glob as globmod
+    import subprocess
+    import sys
+
+    # Check qsv is available
+    if subprocess.run(["which", "qsv"], capture_output=True).returncode != 0:
+        print("✗ qsv CLI not found")
+        print("Install it: https://github.com/dathere/qsv")
+        sys.exit(1)
+
+    ext = "{{ ext }}" or "CSV"
+    ignore_patterns = "{{ ignore }}".split("|") if "{{ ignore }}" else []
+    schema = "{{ schema }}" or None
+    globs = "{{ globs }}"
+
+    print(f"Validating {ext} files...")
+    files = globmod.glob(globs)
+
+    # Filter ignored files
+    files = [f for f in files if not any(fnmatch.fnmatch(f, p) for p in ignore_patterns)]
+
+    if not files:
+        print(f"ℹ️  No {ext} files found to validate")
+        sys.exit(0)
+
+    for file in files:
+        cmd = ["qsv", "validate", file]
+        if schema:
+            cmd.append(schema)
+        result = subprocess.run(cmd, capture_output=True)
+        if result.returncode != 0:
+            print(f"❌ Validation failed for: {file}")
+            subprocess.run(["just", "_csv-show-errors", file, ext])
+            sys.exit(1)
+
+    print(f"✅ All {ext} files are valid")
+
+# Show validation errors for a CSV/TSV file
+[group("checks"), script("python3")]
+_csv-show-errors file ext="CSV":
+    import os
+    import subprocess
+    import sys
+
+    file = "{{ file }}"
+    error_file = f"{file}.validation-errors.tsv"
+
+    if not os.path.exists(error_file):
+        print(f"Error file not found: {error_file}")
+        sys.exit(0)
+
+    # Count errors (qsv auto-detects .tsv delimiter)
+    result = subprocess.run(["qsv", "count", error_file], capture_output=True, text=True)
+    try:
+        total = int(result.stdout.strip()) if result.returncode == 0 and result.stdout.strip() else 0
+    except ValueError:
+        total = 0
+
+    print()
+    if total > 0:
+        print(f"First 20 validation errors ({total} total):")
+    else:
+        print("Validation errors:")
+    print()
+
+    # Try qsv table for nice formatting, fall back to reading file directly
+    slice_result = subprocess.run(
+        ["qsv", "slice", "--start", "0", "--len", "21", error_file],
+        capture_output=True, text=True
+    )
+    if slice_result.returncode == 0:
+        table_result = subprocess.run(
+            ["qsv", "table"],
+            input=slice_result.stdout,
+            capture_output=True, text=True
+        )
+        if table_result.returncode == 0:
+            print(table_result.stdout)
+        else:
+            print(slice_result.stdout)
+    else:
+        with open(error_file) as f:
+            for i, line in enumerate(f):
+                if i >= 21:
+                    break
+                print(line, end="")
+
+    if total > 20:
+        print()
+        print(f"... and {total - 20} more errors")
+    print()
+    print(f"Full details: {error_file}")

package/just/tsv.just

@@ -1,80 +1,15 @@
-import "./settings.just"
+import "./csv.just"
 
 # ---------------------------------------------------------------------------- #
-#                                    SCRIPTS                                   #
+#                                 TSV WRAPPERS                                 #
 # ---------------------------------------------------------------------------- #
 
 # Check TSV files using qsv: https://github.com/dathere/qsv
-[group("checks"), script("bash")]
-_tsv-check globs="data/*/*.tsv" schema="" ignore="*.tsv.invalid|*.tsv.valid|*validation-errors.tsv":
-    if ! command -v qsv >/dev/null 2>&1; then
-        echo "✗ qsv CLI not found"
-        echo "Install it: https://github.com/dathere/qsv"
-        exit 1
-    fi
-
-    echo "Validating TSV files..."
-    found=0
-    for file in {{ globs }}; do
-        # Skip validation artifact files
-        case "$file" in
-            {{ ignore }})
-                continue
-                ;;
-        esac
-
-        # Skip if no files match the pattern
-        [ -e "$file" ] || continue
-
-        found=$((found + 1))
-        schema_arg="{{ schema }}"
-        if ! qsv validate "$file" ${schema_arg:+"$schema_arg"} > /dev/null 2>&1; then
-            echo "❌ Validation failed for: $file"
-            just _tsv-show-errors "$file"
-            exit 1
-        fi
-    done
-
-    if [ "$found" -eq 0 ]; then
-        echo "ℹ️  No TSV files found to validate"
-    else
-        echo "✅ All TSV files are valid"
-    fi
+[group("checks")]
+_tsv-check globs="data/*/*.tsv" ext="TSV" schema="" ignore="*.tsv.invalid|*.tsv.valid|*validation-errors.tsv":
+    @just _csv-check "{{ globs }}" "{{ ext }}" "{{ schema }}" "{{ ignore }}"
 
 # Show validation errors for a TSV file
-[group("checks"), script("bash")]
+[group("checks")]
 _tsv-show-errors file:
-    error_file="{{ file }}.validation-errors.tsv"
-
-    if [ ! -f "$error_file" ]; then
-        echo "Error file not found: $error_file"
-        exit 0
-    fi
-
-    # Try to count total errors (subtract 1 for header row)
-    total_errors=$(qsv count "$error_file" 2>/dev/null || echo "0")
-    if [ "$total_errors" != "0" ]; then
-        total_errors=$((total_errors - 1))
-    fi
-
-    echo ""
-    if [ "$total_errors" != "0" ] && [ "$total_errors" -gt 0 ]; then
-        echo "First 20 validation errors (${total_errors} total):"
-    else
-        echo "Validation errors:"
-    fi
-    echo ""
-
-    # Try to use qsv table for nice formatting, fall back to basic display
-    if qsv slice --start 0 --len 21 "$error_file" 2>/dev/null | qsv table 2>/dev/null; then
-        :  # Success, output already shown
-    else
-        head -n 21 "$error_file"
-    fi
-
-    if [ "$total_errors" != "0" ] && [ "$total_errors" -gt 20 ]; then
-        echo ""
-        echo "... and $((total_errors - 20)) more errors"
-    fi
-    echo ""
-    echo "Full details: $error_file"
+    @just _csv-show-errors "{{ file }}" "TSV"

package/package.json

@@ -3,7 +3,7 @@
   "description": "Configuration files and reusable scripts for Sablier repositories",
   "license": "MIT",
   "type": "module",
-  "version": "1.6.1",
+  "version": "1.8.0",
   "author": {
     "name": "Sablier Labs Ltd",
     "url": "https://sablier.com"
@@ -26,6 +26,7 @@
   },
   "exports": {
     "./biome": "./biome/base.jsonc",
+    "./biome/base": "./biome/base.jsonc",
     "./biome/ui": "./biome/ui.jsonc",
     "./prettier": "./.prettierrc.json",
     "./tsconfig/base": "./tsconfig/base.json",

package/vitest/base.js

@@ -11,7 +11,7 @@ import { defineConfig, mergeConfig } from "vitest/config";
  * @param {DevkitVitestOptions} [options]
  */
 export function defineDevkitConfig(options = {}) {
-  const isCI = !!process.env.CI;
+  const isCI = Boolean(process.env.CI);
 
   const baseConfig = {
     test: {