@sabaiway/agent-workflow-memory 4.0.0 → 4.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -4,6 +4,98 @@ All notable changes to the memory substrate. Versions are this **package's** npm
4
4
  they are distinct from the **deployment-lineage** stamp written into a project's
5
5
  `docs/ai/.memory-version` (which tracks the shared `agent-workflow` lineage, head `3.0.0`).
6
6
 
7
+ ## 4.2.0 — the gates migration stops handing you a coverage checker with nothing to read (AD-089)
8
+
9
+ `migrate-gates.mjs` added the canonical `coverage-check` gate to any legacy declaration that lacked
10
+ one — whether or not anything in that declaration would ever WRITE the lcov the checker reads. The
11
+ result passes: the gate reports `skipped-no-lcov` and exits 0, so a migrated project came out with a
12
+ green matrix that certified nothing. This release stops the migration creating that pair, and makes
13
+ it say so when it finds one already there.
14
+
15
+ - **The checker is added only over a declaration that produces the lcov.** With no producer it is
16
+ WITHHELD, loudly, with the exact suite-gate line to declare first and an invitation to re-run the
17
+ migration afterwards.
18
+ - **An already-declared checker over no producer is reported as INERT** — same dead pair, made by an
19
+ earlier deployment rather than by this migration. Nothing is removed for you; the warning names
20
+ the remedy, and the result is no longer called final-run-capable.
21
+ - **`finalCapable` now means what it says.** It was computed from the review-state check alone, so a
22
+ withheld or inert checker still reported a final-run-capable result. The review-state warning is
23
+ now keyed on its own condition instead of riding that flag.
24
+ - **The "no canonical `unit-tests` entry" note stops firing over a working producer.** It was keyed
25
+ on the entry ID, but a producer is recognised under any id — the note was sending people to fix
26
+ something that was already correct.
27
+ - **The producer vocabulary is exported** (`COVERAGE_PRODUCER_BODY`, `matchesCoverageProducer`) as a
28
+ CLOSED set of the full command forms this family emits, never a substring probe. Its tail rule is
29
+ a positive path-shaped grammar rather than an operator blocklist, because
30
+ `node --test <flags> && rm -f <lcov>` runs the suite and then deletes the file. The scope is
31
+ stated in the source: recognising a producer means "configured with the reporters", never "the
32
+ lcov survives the command".
33
+
34
+ This package stays standalone — it imports nothing from the kit, and the kit imports nothing from
35
+ here. The kit carries its own byte-identical copy of the block above, held equal by a text drift
36
+ guard rather than by an import.
37
+
38
+ ## 4.1.0 — the ADR rotation carries your inbound links with it (AD-087)
39
+
40
+ Rotating `decisions.md` used to be a link-breaking event: `archive-decisions.mjs` moved ADR
41
+ blocks out of the HOT window into per-record `adr/` files while every `decisions.md#ad-NNN…`
42
+ link elsewhere in your `docs/ai/` kept pointing at a heading that was no longer there — and
43
+ neither `--check` nor `--dry-run` would say a word about it. One deployed project measured 114
44
+ such inbound anchors (23 aimed at the first tier a rotation would move) and had raised its HOT
45
+ cap twice specifically so the rotation never runs. A safety valve nobody dares open is not
46
+ shipped; this release makes the crossing carry its links:
47
+
48
+ - **Rotate and `--migrate --apply` rewrite inbound links.** Every non-fenced
49
+ `decisions.md#ad-NNN…` link under `docs/ai/` whose id is in the moved set is rewritten to the
50
+ record file. The heading-slug fragment is preserved — each record holds the verbatim
51
+ `## AD-NNN — title` block, so the same anchor resolves — and the leading relative prefix
52
+ survives (`adr/` is a sibling of `decisions.md`). Migrate additionally rewrites links into
53
+ the retired monolith archives it deletes, each target computed relative to its linking file.
54
+ - **A conservation invariant guards every rewrite.** The rewrite set is computed and verified
55
+ before the run's first write: every moved-id link rewritten, every other byte identical,
56
+ per-file and total matched-link counts equal before and after — any mismatch exits 1 with
57
+ nothing written.
58
+ - **The write order is pinned crash-safe:** records → inbound rewrites → HOT rewrite / monolith
59
+ removal. Every interrupted intermediate state re-runs to completion; previously a crash after
60
+ the HOT write re-ran as «nothing to rotate» with the orphans permanent.
61
+ - **`--check` now proves reference integrity.** A `decisions.md#ad-NNN…` anchor whose id has
62
+ left the HOT window (stale even when the id exists as an archived record) and an
63
+ `adr/AD-NNN-….md` link naming no existing record file both fail exit 1, every violation
64
+ listed with `file:line`. A tree with matches but no ADR substrate fails too; the early SKIP
65
+ remains only for trees with zero matches.
66
+ - **`--dry-run` prints the rewrite set** (`file:line`, old target → new target) alongside the
67
+ move set and writes nothing; plain `--migrate` prints the same summary, and
68
+ `--migrate --apply --dry-run` refuses loudly instead of silently writing.
69
+ - **Fail-closed edges, each red-tested:** a rewrite-form link targeting a moved id inside the
70
+ ADR corpus itself (HOT preamble or block, a record, a monolith tier) refuses pre-write with
71
+ `file:line` — convert the link (e.g. to `[[AD-NNN]]`) and re-run; a HOT block ABOUT to move
72
+ that itself links a retained id or carries a record-form link refuses pre-write (the verbatim
73
+ move would silently break the link from inside the record); symlinked `.md` files and
74
+ directories in the scan scope refuse loudly; an unparseable scanned file (unclosed fence)
75
+ aborts either write path before any write; a stale two-pass snapshot refuses instead of
76
+ rewriting from old bytes.
77
+
78
+ **Stated limitations:** the scan is line-scoped (a link hand-wrapped across a line break is not
79
+ matched — the same accepted residual as the preamble contract), inline code is not tracked (a
80
+ backtick-wrapped link counts as live), and YAML frontmatter is opaque metadata — a link inside
81
+ it is neither rewritten nor checked, and is preserved byte-exactly on every write. The boundary
82
+ is `docs/ai/` — links in README or agent entry points outside it are neither rewritten nor
83
+ checked.
84
+
85
+ **Upgrading:** the tool itself has nothing to reconfigure — the rewrite is additive, and on a
86
+ healthy tree whose links resolve the new assertions stay green. **Reaching your deployment:** a
87
+ fresh Node-project bootstrap through the memory 4.1.0 skill — or a clean-layout upgrade where
88
+ the pair is entirely absent — copies the fixed pair from this package (a No-Node project skips
89
+ the scripts; a legacy-monolith layout goes through the consented migration ask); a normal
90
+ upgrade of an already-deployed pair preserves it byte-for-byte (local edits are never
91
+ clobbered — drift repair belongs to a lineage migration), so an existing deployment is NOT
92
+ auto-refreshed by this release; a verified drift-safe refresh lane is queued family work. If
93
+ `--check` then reports a `dead ADR anchor` or `dead ADR record link`, those are real orphans it
94
+ found — each line names the file, line and dead target; fix or remove the link, or re-point it
95
+ at an existing `adr/` record (or the `[[AD-NNN]]` form); with the links live, rotation is safe
96
+ to run again, so a cap raised only to avoid it can come back down. Any other `--check` red
97
+ carries its own printed diagnosis.
98
+
7
99
  ## 4.0.0 — the archivers stop reporting green on files they did not understand (AD-084)
8
100
 
9
101
  > ### ⚠ BREAKING — the rotation gates fail CLOSED now
package/SKILL.md CHANGED
@@ -3,7 +3,7 @@ name: agent-workflow-memory
3
3
  description: Deploy or upgrade a portable AI-agent memory substrate in any project — an entry-point `AGENTS.md` (+ `CLAUDE.md` alias) and a structured `docs/ai/` context store with cap/archive/index enforcement. Use when the user wants to bootstrap `docs/ai/`, set up the Memory Map and session protocols, install the docs-rotation pre-commit hook, or run `/agent-workflow-memory` / `/agent-workflow-memory upgrade`. Triggers on "set up the memory system", "deploy the AI memory here", "bootstrap docs/ai", "upgrade the memory substrate". This is the substrate only — the workflow methodology (plan→execute→review, queue, Cleanup) is owned elsewhere and injected into AGENTS.md by the family composition root.
4
4
  disable-model-invocation: true
5
5
  metadata:
6
- version: '4.0.0'
6
+ version: '4.2.0'
7
7
  ---
8
8
 
9
9
  # agent-workflow-memory
package/capability.json CHANGED
@@ -3,7 +3,7 @@
3
3
  "schema": 1,
4
4
  "name": "agent-workflow-memory",
5
5
  "kind": "memory-substrate",
6
- "version": "4.0.0",
6
+ "version": "4.2.0",
7
7
  "provides": ["context"],
8
8
  "roles": {},
9
9
  "detect": {
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@sabaiway/agent-workflow-memory",
3
- "version": "4.0.0",
3
+ "version": "4.2.0",
4
4
  "description": "Portable, cross-agent memory substrate for AI coding agents — an AGENTS.md entry point + docs/ai context with cap/archive/index enforcement, deployable standalone or as part of the agent-workflow family. The memory layer of the agent-workflow family.",
5
5
  "keywords": [
6
6
  "ai-agents",
@@ -17,25 +17,45 @@
17
17
  // plateaus at O(governing), never O(cumulative). Not a ledger.
18
18
  //
19
19
  // Modes:
20
- // (default) rotate: explode the oldest HOT entries beyond the cap into adr/ records, then
21
- // regenerate the navigator + docs/ai/index.md (item (h)). Monoliths present → a
22
- // LOUD legacy-guard refusal ("run --migrate first"); it never half-explodes.
23
- // --check verify HOT cap + adr/ store integrity + the legacy guard + navigator freshness;
24
- // exit 1 on any breach. A STATED skip (exit 0) only when NO ADR substrate exists
25
- // (neither decisions.md NOR docs/ai/adr/).
20
+ // (default) rotate: explode the oldest HOT entries beyond the cap into adr/ records,
21
+ // REWRITE the inbound `decisions.md#ad-NNN…` links across docs/ai/** to the
22
+ // record files (fragment preserved), then regenerate the navigator +
23
+ // docs/ai/index.md (item (h)). Monoliths present a LOUD legacy-guard refusal
24
+ // ("run --migrate first"); it never half-explodes.
25
+ // --check verify HOT cap + adr/ store integrity + the legacy guard + navigator freshness
26
+ // + reference integrity (every inbound `decisions.md#ad-NNN…` anchor must
27
+ // resolve to the CURRENT HOT window — an archived id is stale, not resolving —
28
+ // and every `adr/AD-NNN-slug.md` link must name an existing record FILE); exit 1
29
+ // listing every breach with file:line. A STATED skip (exit 0) only when NO ADR
30
+ // substrate exists (neither decisions.md NOR docs/ai/adr/) AND the docs tree
31
+ // carries no matching ADR reference.
26
32
  // --migrate one-time retirement of the 3-tier monoliths → per-file adr/ records. Dry-run by
27
- // default (prints the file set + id diff + conservation proof, writes nothing).
28
- // --migrate --apply writes a durable pre-delete snapshot, writes the records, rewrites the retained
29
- // HOT preamble, and only THEN removes the monoliths gated on conservation AND
30
- // the snapshot. Re-run skips byte-identical records (crash-resumable).
33
+ // default (prints the file set + id diff + conservation proof + the planned
34
+ // inbound-rewrite set, writes nothing).
35
+ // --migrate --apply writes a durable pre-delete snapshot, writes the records, rewrites the inbound
36
+ // links (monolith-form anchors too, targets computed relative to the linking
37
+ // file) and the retained HOT preamble, and only THEN removes the monoliths —
38
+ // gated on conservation AND the snapshot. Re-run skips byte-identical records
39
+ // (crash-resumable). Combining with --dry-run is a loud pre-spend refusal.
31
40
  // --write-navigator regenerate docs/ai/adr/log.md AND re-trigger the index regen (the authoring /
32
41
  // supersession write-side; the --write-index analog). With --dry-run it runs
33
42
  // EXACTLY the same validation (parse, half-migrated guard, store integrity) and
34
43
  // stops before every write — the read-only preflight a guarded caller needs to
35
44
  // earn a go-ahead without risking a partial write.
36
- // --dry-run print the planned rotation move-set, change nothing.
45
+ // --dry-run print the planned rotation move-set + inbound-rewrite set (file:line, old
46
+ // target → new target), change nothing.
37
47
  // --today=YYYY-MM-DD pin the lastUpdated stamp (tests / reproducible runs).
38
48
  //
49
+ // Reference-scan boundary + stated limitations: the inbound-link scan covers docs/ai/** ONLY (links
50
+ // in README / agent entry points are out of scope); the ADR corpus surfaces themselves are NEVER
51
+ // rewritten — a rewrite-form link to a moved id inside decisions.md, an adr/ record or a monolith
52
+ // tier is a loud pre-write refusal (convert it, e.g. to the [[AD-NNN]] form, then re-run). Fenced
53
+ // regions never count; inline code is NOT tracked (a backtick-wrapped link is treated as live);
54
+ // matching is line-scoped — a link hand-wrapped across a line break is not matched (the same
55
+ // accepted residual as the hand-wrapped preamble continuation line below); and frontmatter is
56
+ // opaque metadata — an ADR link inside YAML frontmatter is neither rewritten nor checked (it is
57
+ // preserved byte-exactly on every write).
58
+ //
39
59
  // FAIL-LOUD invariants (the Issue-009 lesson — never silently glue an entry to the previous body):
40
60
  // • every `## ` heading MUST parse canonically as `## AD-NNN — <title>` (AD-\d{3,}) — a malformed
41
61
  // heading is exit 1 naming file:line, never a silent merge;
@@ -43,6 +63,10 @@
43
63
  // • migration is CONSERVATION-checked before any destructive write: the full multiset
44
64
  // {id → sha256(verbatim block)} across the OLD monoliths equals {retained-HOT ∪ written records};
45
65
  // a drop / renumber / edited-block / stray adr record fails exit 1 before any remove or overwrite;
66
+ // • inbound-link rewrites are CONSERVATION-checked before the run's first write: every moved-id
67
+ // link rewritten, every other byte of every scanned file identical — any mismatch is exit 1 with
68
+ // nothing written; the cross-file write order is pinned (records → inbound rewrites → HOT rewrite
69
+ // / monolith removal) so every interrupted state re-runs to completion;
46
70
  // • a legacy monolith still on disk fails LOUD on default/--check (it is a half-migrated tree).
47
71
  //
48
72
  // docs/ai here is git-ignored, so the monoliths were NEVER committed (no VCS recovery) — every
@@ -51,8 +75,8 @@
51
75
  //
52
76
  // Dependency-free, Node >= 22. Deployed into a consumer's scripts/ like its siblings.
53
77
 
54
- import { readFileSync, writeFileSync, existsSync, mkdirSync, readdirSync, rmSync } from 'node:fs';
55
- import { dirname, resolve, join } from 'node:path';
78
+ import { readFileSync, writeFileSync, existsSync, mkdirSync, readdirSync, rmSync, statSync } from 'node:fs';
79
+ import { dirname, resolve, join, posix } from 'node:path';
56
80
  import { fileURLToPath, pathToFileURL } from 'node:url';
57
81
  import { spawnSync } from 'node:child_process';
58
82
  import { createHash } from 'node:crypto';
@@ -275,6 +299,265 @@ export const verifyConservation = (oldItems, newItems) => {
275
299
  }
276
300
  };
277
301
 
302
+ // ── inbound reference integrity (the anchor-orphan fix) ─────────────────────────────────
303
+ //
304
+ // Match contract (line-scoped; fenced lines never count): a textual occurrence of the
305
+ // source-file-plus-fragment form. The lookbehind rejects a longer filename
306
+ // (`other-decisions.md#…` is a different file, never a match); a bare `#ad-NNN` has no file part.
307
+ const DOCS_AI_REL = 'docs/ai';
308
+ const HOT_LINK_RE = /(?<![\w.-])decisions\.md#(ad-(\d{3,})[\w-]*)/g;
309
+ const MONOLITH_LINK_RE = /(?<![\w.-])(?:\.\.?\/)*(?:history\/)?decisions-archive(?:-early)?\.md#(ad-(\d{3,})[\w-]*)/g;
310
+ // The right boundary mirrors the lookbehind: `…md.bak` / `…md/child` are DIFFERENT targets, never
311
+ // a match for the base record (the exact-filename contract cuts both ways).
312
+ const RECORD_LINK_RE = /(?<![\w.-])adr\/(AD-(\d{3,})-[A-Za-z0-9-]+\.md)(?![\w./-])/g;
313
+
314
+ const walkDocsMarkdown = (root) => {
315
+ const base = resolve(root, DOCS_AI_REL);
316
+ if (!existsSync(base)) return [];
317
+ const out = [];
318
+ const walk = (dir, relDir) => {
319
+ for (const entry of readdirSync(dir, { withFileTypes: true }).sort((a, b) => a.name.localeCompare(b.name))) {
320
+ const rel = `${relDir}/${entry.name}`;
321
+ if (entry.isDirectory()) {
322
+ walk(join(dir, entry.name), rel);
323
+ continue;
324
+ }
325
+ // read/write both FOLLOW a symlink (out of the tree), and silently skipping one hides a
326
+ // scannable doc or a whole subtree from the reference scan — refuse loudly either way; only
327
+ // a symlink resolving to a plain non-markdown file stays an ignored stray.
328
+ if (entry.isSymbolicLink() && !entry.name.endsWith('.md')) {
329
+ let targetIsDirectory = false;
330
+ try {
331
+ targetIsDirectory = statSync(join(dir, entry.name)).isDirectory();
332
+ } catch {
333
+ throw fail(1, `${rel}: a dangling symlink in the scan tree — the reference scan cannot classify it; remove or materialize it, then re-run`);
334
+ }
335
+ if (targetIsDirectory) {
336
+ throw fail(1, `${rel}: a symlinked directory in the scan tree would hide its subtree from the reference scan — materialize or remove it, then re-run`);
337
+ }
338
+ continue;
339
+ }
340
+ if (entry.name.endsWith('.md')) {
341
+ if (!entry.isFile()) {
342
+ throw fail(1, `${rel}: a markdown name in the scan tree is not a regular file (a symlink or special file) — the reference scan never reads or writes THROUGH it; materialize or remove it, then re-run`);
343
+ }
344
+ out.push(rel);
345
+ }
346
+ }
347
+ };
348
+ walk(base, DOCS_AI_REL);
349
+ return out;
350
+ };
351
+
352
+ // REWRITE scope: docs/ai/** minus the ADR corpus surfaces (HOT, adr/ records + navigator) and the
353
+ // retired monoliths — those are parsed, conservation-hashed and deleted in the same run; a same-run
354
+ // disk rewrite would poison the crash-resume corpus-union guard and write into removed files.
355
+ const isRewriteScope = (rel) =>
356
+ rel !== HOT_REL && rel !== WARM_REL && rel !== COLD_REL && rel !== NAV_REL && !rel.startsWith(`${ADR_DIR_REL}/`);
357
+
358
+ // The corpus surfaces are never rewritten: a rewrite-form link to a MOVED id anywhere in them is a
359
+ // loud pre-write refusal — the operator converts the link and re-runs; verbatim blocks stay absolute.
360
+ const assertAdrCorpusFreeOfMovedLinks = (root, movedById, corpusRels, linkRes) => {
361
+ const violations = [];
362
+ for (const rel of corpusRels) {
363
+ const { frontLines, lines, fencedLines } = tokenizeMarkdown(readFileSync(resolve(root, rel), 'utf8'), rel);
364
+ for (let index = 0; index < lines.length; index += 1) {
365
+ if (fencedLines.has(index)) continue;
366
+ for (const re of linkRes) {
367
+ for (const m of lines[index].matchAll(re)) {
368
+ if (movedById.has(m[2])) violations.push(`${rel}:${frontLines + index + 1}: "${m[0]}"`);
369
+ }
370
+ }
371
+ }
372
+ }
373
+ if (violations.length > 0) {
374
+ throw fail(1, `refusing pre-write: the ADR corpus itself carries rewrite-form links to a moved id — a corpus surface is never rewritten; convert each link (e.g. to the [[AD-NNN]] form), then re-run:\n ${violations.join('\n ')}`);
375
+ }
376
+ };
377
+
378
+ // A block leaving decisions.md cannot keep a RELATIVE ADR link meaningful: the block moves
379
+ // verbatim (the conservation invariant forbids editing it) while its base directory changes —
380
+ // refuse pre-write when a TO-EXPLODE block links a RETAINED id (the moved-id complement is
381
+ // refused corpus-wide by assertAdrCorpusFreeOfMovedLinks) or carries ANY record-form link
382
+ // (valid from decisions.md, broken from inside adr/).
383
+ const assertMovingBlocksFreeOfRelativeAdrLinks = (root, movedIds, retainedIds) => {
384
+ const { frontLines, lines, fencedLines, headings } = tokenizeMarkdown(readFileSync(resolve(root, HOT_REL), 'utf8'), HOT_REL);
385
+ const violations = [];
386
+ const h2 = headings.filter((h) => h.level === 2 && HEADING_RE.test(h.text));
387
+ for (let i = 0; i < h2.length; i += 1) {
388
+ if (!movedIds.has(HEADING_RE.exec(h2[i].text)[1])) continue;
389
+ const end = i + 1 < h2.length ? h2[i + 1].index : lines.length;
390
+ for (let index = h2[i].index; index < end; index += 1) {
391
+ if (fencedLines.has(index)) continue;
392
+ for (const m of lines[index].matchAll(HOT_LINK_RE)) {
393
+ if (retainedIds.has(m[2])) violations.push(`${HOT_REL}:${frontLines + index + 1}: "${m[0]}"`);
394
+ }
395
+ for (const m of lines[index].matchAll(RECORD_LINK_RE)) {
396
+ violations.push(`${HOT_REL}:${frontLines + index + 1}: "${m[0]}"`);
397
+ }
398
+ }
399
+ }
400
+ if (violations.length > 0) {
401
+ throw fail(1, `refusing pre-write: a block leaving ${HOT_REL} carries a relative ADR link (a RETAINED decisions.md#… anchor or an adr/… record link) — the block moves verbatim, so the link would change meaning inside the record; convert each link (e.g. to the [[AD-NNN]] form), then re-run:\n ${violations.join('\n ')}`);
402
+ }
403
+ };
404
+
405
+ // Migrate deletes the monolith files: a monolith-form link whose id is NOT in the moved set could
406
+ // never point at a record after --apply (D5's "all point at records" outcome) — refuse pre-write
407
+ // wherever it sits (rewrite scope, HOT, records, the monolith blocks about to become records).
408
+ const assertNoOrphanedMonolithLinks = (root, movedById, rels) => {
409
+ const violations = [];
410
+ for (const rel of rels) {
411
+ const { frontLines, lines, fencedLines } = tokenizeMarkdown(readFileSync(resolve(root, rel), 'utf8'), rel);
412
+ for (let index = 0; index < lines.length; index += 1) {
413
+ if (fencedLines.has(index)) continue;
414
+ for (const m of lines[index].matchAll(MONOLITH_LINK_RE)) {
415
+ if (!movedById.has(m[2])) violations.push(`${rel}:${frontLines + index + 1}: "${m[0]}"`);
416
+ }
417
+ }
418
+ }
419
+ if (violations.length > 0) {
420
+ throw fail(1, `refusing pre-write: monolith-form links target an id OUTSIDE the moved set — after --apply removes the monoliths these links could never resolve to a record; fix each link, then re-run:\n ${violations.join('\n ')}`);
421
+ }
422
+ };
423
+
424
+ // The inbound-rewrite plan across the REWRITE scope. HOT-form links keep their leading relative
425
+ // prefix (adr/ is a SIBLING of decisions.md, so the same prefix reaches the record and the fragment
426
+ // resolves verbatim there); monolith-form targets are computed RELATIVE TO THE LINKING FILE with
427
+ // URL-style forward-slash separators on every platform.
428
+ const planInboundRewrites = (root, movedById, withMonolithForms) => {
429
+ const plans = [];
430
+ for (const rel of walkDocsMarkdown(root).filter(isRewriteScope)) {
431
+ const { frontmatter, frontLines, lines, fencedLines } = tokenizeMarkdown(readFileSync(resolve(root, rel), 'utf8'), rel);
432
+ const rewrites = [];
433
+ const afterLines = lines.map((line, index) => {
434
+ if (fencedLines.has(index)) return line;
435
+ // Every match of every form is collected POSITIONALLY on the ORIGINAL line (the forms are
436
+ // textually disjoint), then the line is rebuilt by range-splicing — a negative sharing
437
+ // bytes with a valid link elsewhere on the line can never contaminate the rewrite or its
438
+ // re-derivation.
439
+ const matches = [];
440
+ for (const m of line.matchAll(HOT_LINK_RE)) {
441
+ const moved = movedById.get(m[2]);
442
+ if (moved) matches.push({ start: m.index, old: m[0], new: `adr/${moved.fileName}#${m[1]}` });
443
+ }
444
+ if (withMonolithForms) {
445
+ for (const m of line.matchAll(MONOLITH_LINK_RE)) {
446
+ const moved = movedById.get(m[2]);
447
+ if (moved) matches.push({ start: m.index, old: m[0], new: `${posix.relative(posix.dirname(rel), `${ADR_DIR_REL}/${moved.fileName}`)}#${m[1]}` });
448
+ }
449
+ }
450
+ if (matches.length === 0) return line;
451
+ matches.sort((a, b) => a.start - b.start);
452
+ let cursor = 0;
453
+ let next = '';
454
+ for (const match of matches) {
455
+ if (match.start < cursor) throw fail(1, `${rel}:${frontLines + index + 1}: overlapping link matches — refusing to plan a rewrite`);
456
+ next += line.slice(cursor, match.start) + match.new;
457
+ cursor = match.start + match.old.length;
458
+ rewrites.push({ index, line: frontLines + index + 1, start: match.start, old: match.old, new: match.new });
459
+ }
460
+ next += line.slice(cursor);
461
+ return next;
462
+ });
463
+ if (rewrites.length > 0) plans.push({ rel, frontmatter, frontLines, beforeLines: lines, afterLines, rewrites });
464
+ }
465
+ return plans;
466
+ };
467
+
468
+ // Conservation (fail-loud): re-derive the rewritten file from { before + planned rewrites } and
469
+ // require byte-equality — a dropped/altered link or any changed byte outside the plan is exit 1
470
+ // with nothing written. Exported so its failure paths are unit-testable directly.
471
+ export const verifyRewriteConservation = (plan) => {
472
+ const { rel, frontLines, beforeLines, afterLines, rewrites } = plan;
473
+ const refuse = (line, detail) => fail(1, `${rel}:${line}: inbound-rewrite conservation violation — ${detail}; refusing with nothing written`);
474
+ if (beforeLines.length !== afterLines.length) throw refuse(frontLines + 1, `the rewrite changed the line count (${beforeLines.length} → ${afterLines.length})`);
475
+ const byIndex = new Map();
476
+ for (const rw of rewrites) {
477
+ const list = byIndex.get(rw.index);
478
+ if (list) list.push(rw);
479
+ else byIndex.set(rw.index, [rw]);
480
+ }
481
+ for (let index = 0; index < beforeLines.length; index += 1) {
482
+ const fileLine = frontLines + index + 1;
483
+ const planned = byIndex.get(index);
484
+ if (!planned) {
485
+ if (beforeLines[index] !== afterLines[index]) throw refuse(fileLine, 'a line outside the planned rewrite set changed');
486
+ continue;
487
+ }
488
+ let expected;
489
+ if (planned.every((rw) => typeof rw.start === 'number')) {
490
+ // Range-splicing re-derivation (offsets recorded on the ORIGINAL line) — a same-bytes
491
+ // negative elsewhere on the line can never contaminate it.
492
+ const ordered = [...planned].sort((a, b) => a.start - b.start);
493
+ let cursor = 0;
494
+ expected = '';
495
+ for (const rw of ordered) {
496
+ if (rw.start < cursor) throw refuse(fileLine, 'overlapping planned rewrites');
497
+ if (beforeLines[index].slice(rw.start, rw.start + rw.old.length) !== rw.old) throw refuse(fileLine, `the planned link "${rw.old}" is not at its recorded offset in the source line`);
498
+ expected += beforeLines[index].slice(cursor, rw.start) + rw.new;
499
+ cursor = rw.start + rw.old.length;
500
+ }
501
+ expected += beforeLines[index].slice(cursor);
502
+ } else {
503
+ // Occurrence-based fallback for plans without offsets (the exported contract's original
504
+ // shape); longest-first so a link that is a textual prefix of another cannot corrupt it.
505
+ const unique = [...new Map(planned.map((rw) => [`${rw.old} ${rw.new}`, rw])).values()].sort((a, b) => b.old.length - a.old.length);
506
+ expected = beforeLines[index];
507
+ for (const rw of unique) {
508
+ if (!expected.includes(rw.old)) throw refuse(fileLine, `the planned link "${rw.old}" is absent from the source line`);
509
+ expected = expected.split(rw.old).join(rw.new);
510
+ }
511
+ }
512
+ if (afterLines[index] !== expected) throw refuse(fileLine, 'the rewritten line diverges from the planned substitution (a link would be dropped or altered)');
513
+ for (const rw of planned) {
514
+ if (!afterLines[index].includes(rw.new)) throw refuse(fileLine, `the rewritten link "${rw.new}" is missing from the output line (a link would be dropped)`);
515
+ }
516
+ }
517
+ };
518
+
519
+ const summarizeRewrites = (plans) =>
520
+ plans.flatMap((plan) => plan.rewrites.map((rw) => `${plan.rel}:${rw.line} ${rw.old} → ${rw.new}`));
521
+
522
+ export const writeInboundRewrites = (root, plans) => {
523
+ // Two passes (the plan is computed pre-write, D4): verify the LIVE bytes of EVERY planned file
524
+ // first, then write — a drift anywhere refuses with NOTHING written in the rewrite phase.
525
+ for (const plan of plans) {
526
+ if (readFileSync(resolve(root, plan.rel), 'utf8') !== `${plan.frontmatter}${plan.beforeLines.join('\n')}`) {
527
+ throw fail(1, `${plan.rel}: changed between the rewrite plan and the write — refusing to overwrite from a stale snapshot; re-run`);
528
+ }
529
+ }
530
+ for (const plan of plans) {
531
+ writeFileSync(resolve(root, plan.rel), `${plan.frontmatter}${plan.afterLines.join('\n')}`, 'utf8');
532
+ }
533
+ };
534
+
535
+ // CHECK scope (read-only, wider): docs/ai/** including decisions.md (whole file) and the adr/
536
+ // records, excluding only the generated navigator. (a) a `decisions.md#ad-NNN…` id outside the
537
+ // CURRENT HOT window is dead (an archived id is stale, not resolving); (b) an `adr/AD-NNN-slug.md`
538
+ // link must name an existing record FILE (exact filename, not id-presence).
539
+ const collectReferenceViolations = (root, hotIds, archivedIds) => {
540
+ const violations = [];
541
+ for (const rel of walkDocsMarkdown(root).filter((r) => r !== NAV_REL)) {
542
+ const { frontLines, lines, fencedLines } = tokenizeMarkdown(readFileSync(resolve(root, rel), 'utf8'), rel);
543
+ for (let index = 0; index < lines.length; index += 1) {
544
+ if (fencedLines.has(index)) continue;
545
+ const fileLine = frontLines + index + 1;
546
+ for (const m of lines[index].matchAll(HOT_LINK_RE)) {
547
+ if (hotIds.has(m[2])) continue;
548
+ const why = archivedIds.has(m[2]) ? `AD-${m[2]} is archived — repoint the link at ${ADR_DIR_REL}/` : `AD-${m[2]} is not in the current HOT window`;
549
+ violations.push(`${rel}:${fileLine}: dead ADR anchor "${m[0]}" — ${why}`);
550
+ }
551
+ for (const m of lines[index].matchAll(RECORD_LINK_RE)) {
552
+ if (!existsSync(resolve(root, ADR_DIR_REL, m[1]))) {
553
+ violations.push(`${rel}:${fileLine}: dead ADR record link "${m[0]}" — no record file ${ADR_DIR_REL}/${m[1]}`);
554
+ }
555
+ }
556
+ }
557
+ }
558
+ return violations;
559
+ };
560
+
278
561
  // ── tier / store IO ─────────────────────────────────────────────────────────────────────
279
562
 
280
563
  export const lineCountOf = (text) => text.split('\n').length - (text.endsWith('\n') ? 1 : 0);
@@ -581,6 +864,10 @@ const parseArgs = (argv) => {
581
864
  else if (arg.startsWith('--today=')) today = arg.slice('--today='.length);
582
865
  else throw fail(2, `Unknown argument: ${arg}\n${USAGE}`);
583
866
  }
867
+ // Pre-fix, --apply silently won over --dry-run and wrote — a fail-closed contract cannot keep that.
868
+ if (flags.migrate && flags.apply && flags.dryRun) {
869
+ throw fail(2, `--migrate --apply --dry-run is contradictory — plain --migrate IS the dry run; drop --apply to preview or --dry-run to apply\n${USAGE}`);
870
+ }
584
871
  return { flags, today };
585
872
  };
586
873
 
@@ -672,10 +959,23 @@ const runMigrate = (root, flags, today, deps, log, logError) => {
672
959
  for (const r of records) finalStoreById.set(r.id, { id: r.id, idNum: r.idNum, fileName: r.fileName });
673
960
  assertStoreIntegrity(retained, [...finalStoreById.values()]);
674
961
 
962
+ const movedById = new Map(records.map((r) => [r.id, r]));
963
+ assertAdrCorpusFreeOfMovedLinks(root, movedById, [HOT_REL, ...existingStore.map((e) => e.rel), ...present], [HOT_LINK_RE, MONOLITH_LINK_RE]);
964
+ assertMovingBlocksFreeOfRelativeAdrLinks(root, new Set(movedById.keys()), new Set(retained.map((e) => e.id)));
965
+ assertNoOrphanedMonolithLinks(root, movedById, [
966
+ ...walkDocsMarkdown(root).filter(isRewriteScope),
967
+ HOT_REL,
968
+ ...existingStore.map((e) => e.rel),
969
+ ...present,
970
+ ]);
971
+ const rewritePlans = planInboundRewrites(root, movedById, true);
972
+ for (const plan of rewritePlans) verifyRewriteConservation(plan);
973
+
675
974
  const summary = {
676
975
  records: records.map((r) => r.fileName),
677
976
  retainedHot: retained.map((e) => `AD-${e.id}`),
678
977
  monolithsRetired: present,
978
+ inboundRewrites: summarizeRewrites(rewritePlans),
679
979
  conservation: `${oldItems.length} corpus blocks → ${retained.length} retained-HOT + ${records.length} records (conserved)`,
680
980
  };
681
981
 
@@ -692,7 +992,9 @@ const runMigrate = (root, flags, today, deps, log, logError) => {
692
992
  ];
693
993
  const snapshot = writeSnapshot(root, snapshotFiles, deps);
694
994
 
995
+ // Pinned write order: records → inbound rewrites → HOT rewrite / monolith removal.
695
996
  writeRecords(root, records);
997
+ writeInboundRewrites(root, rewritePlans);
696
998
  const corpus = [...retained, ...loadAdrStore(root)];
697
999
  writeNavigatorFile(root, corpus, today);
698
1000
  writeHot(root, hot, retained, today);
@@ -703,6 +1005,7 @@ const runMigrate = (root, flags, today, deps, log, logError) => {
703
1005
  log('[archive-decisions] migrated the 3-tier cascade → one-file-per-ADR store:');
704
1006
  log(` snapshot: ${snapshot.dir} (${snapshot.viaGitDir ? 'git dir' : 'out-of-tree fallback'})`);
705
1007
  log(` records written: ${records.length} under ${ADR_DIR_REL}/`);
1008
+ log(` inbound links rewritten: ${summary.inboundRewrites.length} across ${rewritePlans.length} file(s)`);
706
1009
  log(` retained HOT: ${summary.retainedHot.join(', ') || '(none)'}`);
707
1010
  log(` retired monoliths: ${present.join(', ')}`);
708
1011
  log(` navigator: ${NAV_REL}`);
@@ -756,6 +1059,13 @@ const runCheck = (root, today, log, logError) => {
756
1059
  return 1;
757
1060
  }
758
1061
  if (!hasHot && !hasStore) {
1062
+ // The reference scan still runs: a matching reference over NO substrate is a dead link, never a
1063
+ // clean skip — the SKIP remains only for a tree with zero matches.
1064
+ const orphaned = collectReferenceViolations(root, new Set(), new Set());
1065
+ if (orphaned.length > 0) {
1066
+ for (const v of orphaned) logError(`[archive-decisions] FAIL: ${v}.`);
1067
+ return 1;
1068
+ }
759
1069
  log(`[archive-decisions] SKIP — no ADR substrate (neither ${HOT_REL} nor ${ADR_DIR_REL}); nothing to check.`);
760
1070
  return 0;
761
1071
  }
@@ -783,11 +1093,13 @@ const runCheck = (root, today, log, logError) => {
783
1093
  problems.push(`${NAV_REL} is stale (out of sync with the ADR corpus) — run \`node scripts/archive-decisions.mjs --write-navigator\` and commit it`);
784
1094
  }
785
1095
 
1096
+ problems.push(...collectReferenceViolations(root, new Set(hotEntries.map((e) => e.id)), new Set(adrEntries.map((e) => e.id))));
1097
+
786
1098
  if (problems.length > 0) {
787
1099
  for (const p of problems) logError(`[archive-decisions] FAIL: ${p}.`);
788
1100
  return 1;
789
1101
  }
790
- log('[archive-decisions] OK — HOT within cap, store integrity intact, navigator fresh.');
1102
+ log('[archive-decisions] OK — HOT within cap, store integrity intact, navigator fresh, inbound ADR references resolve.');
791
1103
  return 0;
792
1104
  };
793
1105
 
@@ -825,20 +1137,33 @@ const runRotate = (root, flags, today, deps, log, logError) => {
825
1137
  for (const rec of records) finalStoreById.set(rec.id, { id: rec.id, idNum: rec.idNum, fileName: rec.fileName });
826
1138
  assertStoreIntegrity(retained, [...finalStoreById.values()]);
827
1139
 
828
- const summary = { explode: records.map((r) => r.fileName), retainedHot: retained.map((e) => `AD-${e.id}`) };
1140
+ const movedById = new Map(records.map((r) => [r.id, r]));
1141
+ assertAdrCorpusFreeOfMovedLinks(root, movedById, [HOT_REL, ...existingStore.map((e) => e.rel)], [HOT_LINK_RE]);
1142
+ assertMovingBlocksFreeOfRelativeAdrLinks(root, new Set(movedById.keys()), new Set(retained.map((e) => e.id)));
1143
+ const rewritePlans = planInboundRewrites(root, movedById, false);
1144
+ for (const plan of rewritePlans) verifyRewriteConservation(plan);
1145
+
1146
+ const summary = {
1147
+ explode: records.map((r) => r.fileName),
1148
+ retainedHot: retained.map((e) => `AD-${e.id}`),
1149
+ inboundRewrites: summarizeRewrites(rewritePlans),
1150
+ };
829
1151
  if (flags.dryRun) {
830
1152
  log('[archive-decisions] DRY-RUN — no files will be changed.');
831
1153
  log(JSON.stringify(summary, null, 2));
832
1154
  return 0;
833
1155
  }
834
1156
 
1157
+ // Pinned write order: records → inbound rewrites → HOT rewrite (crash-resume idempotency).
835
1158
  writeRecords(root, records);
1159
+ writeInboundRewrites(root, rewritePlans);
836
1160
  const corpus = [...retained, ...loadAdrStore(root)];
837
1161
  writeNavigatorFile(root, corpus, today);
838
1162
  writeHot(root, hot, retained, today);
839
1163
  const regen = (deps.regenerateIndex ?? defaultRegenerateIndex)(root, today);
840
1164
  log('[archive-decisions] rotated:');
841
1165
  log(` exploded to adr/: ${summary.explode.join(', ') || '(none)'}`);
1166
+ log(` inbound links rewritten: ${summary.inboundRewrites.length} across ${rewritePlans.length} file(s)`);
842
1167
  log(` retained HOT: ${summary.retainedHot.join(', ')}`);
843
1168
  if (regen.ok) log(' regenerated docs/ai/index.md');
844
1169
  else logError(`[archive-decisions] docs/ai/index.md NOT regenerated — ${regen.detail}`);