@sabaiway/agent-workflow-kit 10.3.0 → 10.5.0

package/tools/velocity-profile.mjs

@@ -10,6 +10,8 @@ import { AUTONOMY_REL, loadAutonomy, resolveAutonomy, COMMAND_REDLINES } from '.
 // The bridge-wrappers tier's placement probe (AD-044 Plan 4, Decision 2): a tier entry derives ONLY
 // for a PLACED bridge wrapper — findOnPath is the same read-only PATH scan the backend detector uses.
 import { findOnPath } from './detect-backends.mjs';
+// The seedable-path predicate lives in the pure leaf so the renders spell a path exactly as it is seeded.
+import { SHELL_METACHARACTERS, hasShellMetacharacter, isSeedablePathToken } from './repo-lex.mjs';
 import { isDirectRun } from './direct-run.mjs';
 import { compareSemver } from './semver-lite.mjs';
 // The declared-path resolution + segment containment the allowWrite degrade shares with the
@@ -131,7 +133,7 @@ export const SHELL_READONLY = Object.freeze([
 // seed time from the RUNNING tool's own location — resolved-absolute, so a moved or reinstalled
 // skill leaves a stale rule that FAIL-SAFE prompts again (never a silent widening).
 //
-// Membership (10, frozen): the read-only kit tools plus run-gates.mjs — which is NOT read-only but
+// Membership (13, frozen): the read-only kit tools plus run-gates.mjs — which is NOT read-only but
 // project-exec (it runs the project's OWN declared gates.json commands), so it seeds as ONE exact
 // byte-string pinned to this project root (`--cwd <resolved root>`): a wildcard would be BROADER
 // than the AD-037 hook boundary (`--cwd <dir>` executes an arbitrary OTHER project's gates.json)
@@ -158,6 +160,9 @@ export const KIT_READONLY_TOOLS = Object.freeze([
   // useless approvals is mostly small path questions batched into a composed shell because no single
   // call answered them, and a lane the agent must still ask about is not a lane.
   'tools/path-inventory.mjs',
+  // The round table the procedures advisor names every review round; its path argument is resolved
+  // and compared, never opened as a pattern, so it rides the settings-level posture like the rest.
+  'tools/review-rounds-cli.mjs',
 ]);
 // Writer previews: ONLY writers whose ARG-FREE invocation is a documented dry-run ("Default is
 // --dry-run" in their usage) seed an EXACT preview byte-string — every --apply/--write/--yes keeps
@@ -269,10 +274,7 @@ export const deriveBridgeTierAllowlist = ({ findWrapper, groundingAbsPath } = {}
 // a sandbox. velocity never ADDS commit/push/publish as allow rules and keeps acceptEdits opt-in;
 // runtime closure is not something settings-level allow rules can enforce — the residual guard
 // ships as the opt-in PreToolUse hook (Mode: hook, tools/gate-hook.mjs; probe record in AD-037).
-export const SHELL_METACHARACTERS = Object.freeze([
-  '&', '|', ';', '<', '>', '$', '`', '(', ')',
-  '\n', '\r', '\t', '\\', '{', '}', '*', '?', '#', '~', '!',
-]);
+export { SHELL_METACHARACTERS };
 
 // The RUNTIME residual documented above, as data: the exact write-redirection / command-
 // substitution / bounded write-flag forms a settings-level allow rule cannot see. Consumed by
@@ -484,8 +486,6 @@ const getDefaultMode = (data) => {
     : { present: false, value: undefined };
 };
 
-const hasShellMetacharacter = (cmd) => SHELL_METACHARACTERS.some((ch) => cmd.includes(ch));
-
 const tokenizeCommand = (cmd) => cmd.trim().split(WHITESPACE_PATTERN).filter(Boolean);
 
 const getSubcommand = (tokens) => tokens.slice(1).join(' ');
@@ -504,20 +504,6 @@ const getBashExactCommand = (pattern) => {
   return match ? match[1] : undefined;
 };
 
-// Characters that survive whitespace tokenization but break an UNQUOTED byte-exact path rule:
-// shell quoting syntax and glob brackets (SHELL_METACHARACTERS owns the command-level separators/
-// redirections/expansions — `*`/`?` globs included — but not these four).
-const PATH_BREAKING_CHARACTERS = Object.freeze(["'", '"', '[', ']']);
-
-// A path token that can be seeded UNQUOTED into a byte-exact allow rule: POSIX-absolute, no
-// whitespace, no shell metacharacter, no quoting/glob syntax.
-const isSeedablePathToken = (token) =>
-  typeof token === 'string' &&
-  token.startsWith('/') &&
-  !/\s/u.test(token) &&
-  !hasShellMetacharacter(token) &&
-  !PATH_BREAKING_CHARACTERS.some((ch) => token.includes(ch));
-
 // A tier path token must be SEEDABLE (a relative or shell-syntax-carrying spelling is a dead rule
 // the screen refuses to bless) and end on a known tier-tool tail. Any seedable absolute prefix is
 // accepted — the user's own kit copy elsewhere is legitimate shape-wise; entries OUTSIDE the
@@ -794,7 +780,7 @@ export const screenAllowlistEntry = (pattern) => {
 };
 
 /**
- * Derive the opt-in kit-tools tier for a project: 9 wildcard entries (resolved-absolute script
+ * Derive the opt-in kit-tools tier for a project: 12 wildcard entries (resolved-absolute script
  * path + args wildcard), ONE exact run-gates entry pinned to the resolved project root, and the
  * writer-preview exact dry-run byte-strings. Pure derivation — a stale path simply prompts again.
  */

package/tools/view-model.mjs

@@ -54,7 +54,11 @@ const recipesVm = (r) => {
   if (r.error) return { error: r.error };
   const pairs = [];
   for (const [activity, slots] of Object.entries(r.activities ?? {})) {
-    for (const [slot, v] of Object.entries(slots)) pairs.push({ key: `${activity}.${slot}`, recipe: v.recipe });
+    // source + degradedFrom ride along: an effective recipe alone cannot tell a chosen value from a
+    // computed default, nor a degrade from a configuration that really names the resolved recipe.
+    for (const [slot, v] of Object.entries(slots)) {
+      pairs.push({ key: `${activity}.${slot}`, recipe: v.recipe, source: v.source ?? null, degradedFrom: v.degradedFrom ?? null });
+    }
   }
   return { pairs, detectError: r.detectError ?? null };
 };
@@ -76,8 +80,18 @@ const velocityVm = (v) => {
 
 const agentsVm = (a) => {
   if (!a) return null;
-  if (a.error) return { error: a.error };
-  return { bundled: a.bundled ?? 0, placed: a.placed ?? 0 };
+  if (a.error) return { error: a.error, executor: a.executor ?? null, executorReason: a.executorReason ?? null };
+  const bundled = a.bundled ?? 0;
+  return {
+    bundled,
+    placed: a.placed ?? 0,
+    // The envelope counts the read-only vehicles; an envelope predating the executor field bundled
+    // only read-only ones.
+    readOnly: a.readOnly ?? (a.executor == null ? bundled : Math.max(bundled - 1, 0)),
+    // null = an envelope predating the field (unknown), never a state.
+    executor: a.executor ?? null,
+    executorReason: a.executorReason ?? null,
+  };
 };
 
 const hookVm = (h) => {