@sabaiway/agent-workflow-kit 1.15.0 → 1.15.2

package/tools/engine-source.test.mjs

@@ -1,280 +0,0 @@
-import { describe, it } from 'node:test';
-import assert from 'node:assert/strict';
-import { join } from 'node:path';
-import {
-  resolveEngineDir,
-  detectEngine,
-  readEngineFragment,
-  ENGINE_ENV,
-  EXPECTED_ENGINE_NAME,
-  ENGINE_FRAGMENT_REL,
-  ORCHESTRATION_FRAGMENT_REL,
-  PROCEDURES_FRAGMENT_REL,
-} from './engine-source.mjs';
-
-// A valid engine dir = it exists (dir), the fragment file exists, and the validator reports a
-// VALID methodology-engine with the right name. The deps below let every branch be exercised
-// in-process without touching the real filesystem.
-const ENGINE_DIR = '/home/u/.claude/skills/agent-workflow-engine';
-
-// statType stub: ENGINE_DIR → 'dir', the fragment → 'file', everything else → null.
-const okStatType = (path) =>
-  path === ENGINE_DIR ? 'dir' : path === join(ENGINE_DIR, ENGINE_FRAGMENT_REL) ? 'file' : null;
-
-const okReport = {
-  result: 'valid',
-  kind: 'methodology-engine',
-  name: EXPECTED_ENGINE_NAME,
-  available: true,
-};
-
-const deps = (overrides = {}) => ({
-  validate: () => okReport,
-  statType: okStatType,
-  ...overrides,
-});
-
-describe('resolveEngineDir — env override vs the ~/.claude default', () => {
-  it('uses AGENT_WORKFLOW_ENGINE_DIR when set, tagging source=env', () => {
-    const out = resolveEngineDir({ env: { [ENGINE_ENV]: '/custom/engine' }, home: '/home/u' });
-    assert.deepEqual(out, { dir: '/custom/engine', source: 'env' });
-  });
-  it('falls back to ~/.claude/skills/agent-workflow-engine, tagging source=default', () => {
-    const out = resolveEngineDir({ env: {}, home: '/home/u' });
-    assert.equal(out.source, 'default');
-    assert.equal(out.dir, join('/home/u', '.claude/skills/agent-workflow-engine'));
-  });
-  it('treats an empty env value as unset (source=default)', () => {
-    const out = resolveEngineDir({ env: { [ENGINE_ENV]: '' }, home: '/home/u' });
-    assert.equal(out.source, 'default');
-  });
-});
-
-describe('detectEngine — happy path + each distinct failure reason', () => {
-  it('ok when dir exists, manifest VALID methodology-engine, right name, fragment present', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps());
-    assert.equal(out.ok, true);
-    assert.equal(out.dir, ENGINE_DIR);
-    assert.match(out.reason, /methodology-engine/);
-  });
-
-  it('env-set-but-missing: dir absent AND source=env → distinct reason', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'env' }, deps({ statType: () => null }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /env-set-but-missing/);
-  });
-
-  it('not-installed: dir absent AND source=default → not an env-set reason', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ statType: () => null }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /not installed/i);
-    assert.doesNotMatch(out.reason, /env-set-but-missing/);
-  });
-
-  it('invalid manifest → reason names the validator result', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ validate: () => ({ ...okReport, result: 'invalid' }) }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /invalid/);
-  });
-
-  it('wrong kind → reason names the kind', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ validate: () => ({ ...okReport, kind: 'memory-substrate' }) }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /kind/);
-  });
-
-  it('wrong name → reason names the name mismatch', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ validate: () => ({ ...okReport, name: 'something-else' }) }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /name/);
-  });
-
-  it('declared stub (available:false) → reason names the stub', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ validate: () => ({ ...okReport, available: false }) }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /stub|available:false/);
-  });
-
-  it('missing fragment → reason names the fragment path', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ statType: (p) => (p === ENGINE_DIR ? 'dir' : null) }));
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /fragment/);
-  });
-
-  it('a validator that THROWS (corrupt engine, e.g. EISDIR) → ok:false, no raw error escapes', () => {
-    const out = detectEngine(
-      ENGINE_DIR,
-      { source: 'default' },
-      deps({
-        validate: () => {
-          throw new Error('EISDIR: illegal operation on a directory, read');
-        },
-      }),
-    );
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /invalid/);
-  });
-});
-
-describe('readEngineFragment — live read or loud throw', () => {
-  it('returns the fragment bytes on the happy path', () => {
-    const out = readEngineFragment(ENGINE_DIR, deps({ source: 'default', readFileSync: () => 'FRAGMENT BODY' }));
-    assert.equal(out, 'FRAGMENT BODY');
-  });
-
-  it('throws naming the dir + the exact install command when the engine is absent', () => {
-    assert.throws(
-      () => readEngineFragment(ENGINE_DIR, deps({ source: 'env', statType: () => null })),
-      (err) => {
-        assert.match(err.message, /methodology engine not found\/invalid/);
-        assert.match(err.message, new RegExp(ENGINE_DIR.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')));
-        assert.match(err.message, /npx @sabaiway\/agent-workflow-engine@latest init/);
-        assert.match(err.message, new RegExp(ENGINE_ENV));
-        return true;
-      },
-    );
-  });
-
-  it('throws when the manifest is invalid (never falls back)', () => {
-    assert.throws(
-      () => readEngineFragment(ENGINE_DIR, deps({ source: 'default', validate: () => ({ ...okReport, result: 'invalid' }) })),
-      /methodology engine not found\/invalid/,
-    );
-  });
-
-  it('a THROWING validator still yields the stable install message (no raw fs error escapes)', () => {
-    assert.throws(
-      () =>
-        readEngineFragment(
-          ENGINE_DIR,
-          deps({
-            source: 'default',
-            validate: () => {
-              throw new Error('EISDIR: illegal operation on a directory, read');
-            },
-          }),
-        ),
-      (err) => {
-        assert.match(err.message, /methodology engine not found\/invalid/);
-        assert.match(err.message, /npx @sabaiway\/agent-workflow-engine@latest init/);
-        return true;
-      },
-    );
-  });
-
-  it('throws with the install command when the fragment file is unreadable', () => {
-    assert.throws(
-      () =>
-        readEngineFragment(
-          ENGINE_DIR,
-          deps({
-            source: 'default',
-            readFileSync: () => {
-              throw new Error('EISDIR');
-            },
-          }),
-        ),
-      (err) => {
-        assert.match(err.message, /fragment unreadable: EISDIR/);
-        assert.match(err.message, /npx @sabaiway\/agent-workflow-engine@latest init/);
-        return true;
-      },
-    );
-  });
-});
-
-// The orchestration fragment is a SECOND bounded fragment (Plan 4), selected via deps.rel /
-// detectEngine({ rel }) — non-breaking: the default rel stays the methodology fragment so every
-// existing methodology call site is unchanged.
-describe('detectEngine / readEngineFragment — orchestration fragment via rel', () => {
-  // statType that knows both fragments live in the engine (a current >=1.2.0 engine).
-  const bothPresent = (path) =>
-    path === ENGINE_DIR
-      ? 'dir'
-      : path === join(ENGINE_DIR, ENGINE_FRAGMENT_REL) || path === join(ENGINE_DIR, ORCHESTRATION_FRAGMENT_REL)
-        ? 'file'
-        : null;
-
-  it('verifies the orchestration fragment when rel is the orchestration path', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default', rel: ORCHESTRATION_FRAGMENT_REL }, deps({ statType: bothPresent }));
-    assert.equal(out.ok, true);
-  });
-
-  it('an older engine (no orchestration fragment) → detect not-ok, the reason names that fragment', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default', rel: ORCHESTRATION_FRAGMENT_REL }, deps()); // okStatType: only the methodology fragment is a file
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /orchestration-slot\.md/);
-  });
-
-  it('the methodology read is unaffected by the new rel default (back-compat)', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default' }, deps({ statType: bothPresent }));
-    assert.equal(out.ok, true);
-  });
-
-  it('readEngineFragment reads the orchestration fragment bytes when deps.rel is set', () => {
-    const out = readEngineFragment(
-      ENGINE_DIR,
-      deps({ source: 'default', rel: ORCHESTRATION_FRAGMENT_REL, statType: bothPresent, readFileSync: () => 'ORCH BODY' }),
-    );
-    assert.equal(out, 'ORCH BODY');
-  });
-
-  it('readEngineFragment STOPs loudly when the orchestration fragment is absent (older engine)', () => {
-    assert.throws(
-      () => readEngineFragment(ENGINE_DIR, deps({ source: 'default', rel: ORCHESTRATION_FRAGMENT_REL })),
-      (err) => {
-        assert.match(err.message, /methodology engine not found\/invalid/);
-        assert.match(err.message, /orchestration-slot\.md/);
-        assert.match(err.message, /npx @sabaiway\/agent-workflow-engine@latest init/);
-        return true;
-      },
-    );
-  });
-});
-
-// The activity-procedures canon is a THIRD live-read fragment (engine >= 1.3.0), selected the same way
-// (deps.rel / detectEngine({ rel })). An engine too old to ship it must read as not-ok naming the
-// fragment, and readEngineFragment must STOP loudly — the procedures CLI maps that to a clean exit 1.
-describe('detectEngine / readEngineFragment — procedures fragment via rel', () => {
-  const proceduresPresent = (path) =>
-    path === ENGINE_DIR
-      ? 'dir'
-      : path === join(ENGINE_DIR, ENGINE_FRAGMENT_REL) || path === join(ENGINE_DIR, PROCEDURES_FRAGMENT_REL)
-        ? 'file'
-        : null;
-
-  it('exposes the procedures fragment rel constant', () => {
-    assert.equal(PROCEDURES_FRAGMENT_REL, 'references/procedures.md');
-  });
-
-  it('verifies the procedures fragment when rel is the procedures path', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default', rel: PROCEDURES_FRAGMENT_REL }, deps({ statType: proceduresPresent }));
-    assert.equal(out.ok, true);
-  });
-
-  it('an older engine (no procedures fragment) → detect not-ok, the reason names that fragment', () => {
-    const out = detectEngine(ENGINE_DIR, { source: 'default', rel: PROCEDURES_FRAGMENT_REL }, deps()); // okStatType: only the methodology fragment is a file
-    assert.equal(out.ok, false);
-    assert.match(out.reason, /procedures\.md/);
-  });
-
-  it('readEngineFragment reads the procedures fragment bytes when deps.rel is set', () => {
-    const out = readEngineFragment(
-      ENGINE_DIR,
-      deps({ source: 'default', rel: PROCEDURES_FRAGMENT_REL, statType: proceduresPresent, readFileSync: () => 'PROCEDURES BODY' }),
-    );
-    assert.equal(out, 'PROCEDURES BODY');
-  });
-
-  it('readEngineFragment STOPs loudly when the procedures fragment is absent (engine < 1.3.0)', () => {
-    assert.throws(
-      () => readEngineFragment(ENGINE_DIR, deps({ source: 'default', rel: PROCEDURES_FRAGMENT_REL })),
-      (err) => {
-        assert.match(err.message, /methodology engine not found\/invalid/);
-        assert.match(err.message, /procedures\.md/);
-        assert.match(err.message, /npx @sabaiway\/agent-workflow-engine@latest init/);
-        return true;
-      },
-    );
-  });
-});

package/tools/family-registry.test.mjs

@@ -1,279 +0,0 @@
-import { describe, it } from 'node:test';
-import assert from 'node:assert/strict';
-import { readFileSync } from 'node:fs';
-import { resolve, dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import {
-  FAMILY_MEMBERS,
-  classifyMember,
-  surveyFamily,
-  surveyProject,
-  NOT_INSTALLED,
-  UNSUPPORTED_SCHEMA,
-  INVALID_MANIFEST,
-  STUB,
-  FOREIGN,
-  OK,
-  UNKNOWN,
-} from './family-registry.mjs';
-import { VALID, INVALID, UNSUPPORTED } from './manifest/validate.mjs';
-import { START_MARKER } from './hide-footprint.mjs';
-import { ORCHESTRATION_FRAGMENT_REL, PROCEDURES_FRAGMENT_REL } from './engine-source.mjs';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const REPO_ROOT = resolve(__dirname, '../..'); // agent-workflow-kit/tools → repo root
-
-// Build classifyMember deps that present the marker, with an injectable validate/readVersion.
-const installedDeps = ({ report, version = '9.9.9', home = '/home/test' }) => ({
-  exists: () => true,
-  stat: () => ({ isFile: () => true }),
-  getenv: {},
-  home,
-  validate: () => report,
-  readVersion: () => ({ version }),
-});
-
-const KIT = FAMILY_MEMBERS.find((m) => m.name === 'agent-workflow-kit');
-
-// ── classifyMember ───────────────────────────────────────────────────────────────
-
-describe('classifyMember', () => {
-  it('marks an absent marker as not-installed (no skillDir, no version)', () => {
-    const r = classifyMember(KIT, { exists: () => false, getenv: {}, home: '/home/test' });
-    assert.equal(r.manifestState, NOT_INSTALLED);
-    assert.equal(r.installed, false);
-    assert.equal(r.skillDir, null);
-    assert.equal(r.version, null);
-  });
-
-  it('classifies a valid matching manifest as ok and reports the authoritative version', () => {
-    const r = classifyMember(KIT, installedDeps({
-      report: { result: VALID, name: 'agent-workflow-kit', kind: 'composition-root', available: true },
-      version: '1.12.0',
-    }));
-    assert.equal(r.manifestState, OK);
-    assert.equal(r.installed, true);
-    assert.equal(r.version, '1.12.0');
-    assert.match(r.skillDir, /\.claude\/skills\/agent-workflow-kit$/);
-  });
-
-  it('classifies a wrong name/kind as foreign (never ours, never removed by uninstall)', () => {
-    const r = classifyMember(KIT, installedDeps({
-      report: { result: VALID, name: 'something-else', kind: 'composition-root', available: true },
-    }));
-    assert.equal(r.manifestState, FOREIGN);
-    assert.equal(r.version, null); // version only for ok
-  });
-
-  it('classifies available:false as a stub', () => {
-    const r = classifyMember(KIT, installedDeps({
-      report: { result: VALID, name: 'agent-workflow-kit', kind: 'composition-root', available: false },
-    }));
-    assert.equal(r.manifestState, STUB);
-  });
-
-  it('maps validator INVALID → invalid-manifest and UNSUPPORTED → unsupported-schema', () => {
-    assert.equal(classifyMember(KIT, installedDeps({ report: { result: INVALID } })).manifestState, INVALID_MANIFEST);
-    assert.equal(classifyMember(KIT, installedDeps({ report: { result: UNSUPPORTED } })).manifestState, UNSUPPORTED_SCHEMA);
-  });
-
-  it('surfaces an EACCES marker probe as "unknown" — never masked as not-installed', () => {
-    const eacces = () => { throw Object.assign(new Error('EACCES'), { code: 'EACCES' }); };
-    const r = classifyMember(KIT, { exists: eacces, getenv: {}, home: '/home/test' });
-    assert.equal(r.manifestState, UNKNOWN);
-    assert.equal(r.installed, false); // not removed — ownership could not be verified
-  });
-
-  it('resolves the skill dir from the env override when set (resolveDir reuse)', () => {
-    const r = classifyMember(KIT, {
-      exists: () => true,
-      stat: () => ({ isFile: () => true }),
-      getenv: { AGENT_WORKFLOW_KIT_DIR: '/custom/kit' },
-      home: '/home/test',
-      validate: () => ({ result: VALID, name: 'agent-workflow-kit', kind: 'composition-root', available: true }),
-      readVersion: () => ({ version: '1.12.0' }),
-    });
-    assert.equal(r.skillDir, '/custom/kit');
-  });
-});
-
-describe('surveyFamily', () => {
-  it('returns one row per member; all not-installed when no markers present', () => {
-    const rows = surveyFamily({ exists: () => false, getenv: {}, home: '/home/test' });
-    assert.equal(rows.length, FAMILY_MEMBERS.length);
-    assert.ok(rows.every((r) => r.manifestState === NOT_INSTALLED));
-  });
-
-  // Only the engine member validates as ok (its name+kind match); the others go FOREIGN under this
-  // shared validate stub — so only the engine row is eligible for the orchestration-fragment caveat.
-  const engineValidate = (dir) =>
-    String(dir).includes('agent-workflow-engine')
-      ? { result: VALID, name: 'agent-workflow-engine', kind: 'methodology-engine', available: true }
-      : { result: VALID, name: 'x', kind: 'x', available: true };
-
-  // The caveats mirror the consumers: each reads a live engine fragment (readEngineFragment) — the
-  // recipes pointer (orchestration-slot.md, engine >= 1.2.0) AND the activity-procedures canon
-  // (procedures.md, engine >= 1.3.0). An absent / non-file / unreadable fragment surfaces as a DISTINCT
-  // caveat in `row.caveats` (an array, so missing BOTH surfaces BOTH); a current readable
-  // fragment never gets one. Helpers below model each fragment's on-disk state independently.
-  const engineDeps = (over) => ({
-    exists: () => true, // SKILL.md marker present (classifyMember)
-    stat: () => ({ isFile: () => true }),
-    getenv: {},
-    home: '/home/test',
-    validate: engineValidate,
-    readVersion: () => ({ version: '1.3.0' }),
-    ...over,
-  });
-  // statType where each fragment is independently a readable file ('file') or absent (null); the engine
-  // dir + everything else is a 'dir'. readFileSync returns content for a present fragment.
-  // Pin the mock to the AUTHORITATIVE engine-source constants (mirrors engine-source.test.mjs), so a
-  // fragment-path rename follows here instead of silently passing against the old basename.
-  const fragmentStat = ({ orch = 'file', proc = 'file' }) => (p) => {
-    const s = String(p);
-    if (s.endsWith(ORCHESTRATION_FRAGMENT_REL)) return orch;
-    if (s.endsWith(PROCEDURES_FRAGMENT_REL)) return proc;
-    return 'dir';
-  };
-  const caveatsOf = (rows) => rows.find((r) => r.kind === 'methodology-engine').caveats ?? [];
-
-  it('a current engine WITH BOTH fragments readable carries NO caveat', () => {
-    const rows = surveyFamily(engineDeps({ statType: fragmentStat({}), readFileSync: () => '> a bounded fragment' }));
-    const engine = rows.find((r) => r.kind === 'methodology-engine');
-    assert.equal(engine.manifestState, OK);
-    assert.equal(engine.caveats, undefined, 'no caveats when both live fragments are present + readable');
-  });
-
-  it('an OK engine MISSING the orchestration fragment gets the recipes caveat (only)', () => {
-    const rows = surveyFamily(engineDeps({
-      readVersion: () => ({ version: '1.2.0' }),
-      statType: fragmentStat({ orch: null }), // recipes fragment ABSENT, procedures present
-      readFileSync: () => '> a bounded fragment',
-    }));
-    const caveats = caveatsOf(rows);
-    assert.equal(caveats.length, 1);
-    assert.match(caveats[0], /recipes pointer/i);
-  });
-
-  it('an OK engine MISSING the procedures canon gets the activity-procedures caveat (only)', () => {
-    // The realistic post-release case: an engine at 1.2.0 ships the recipes pointer but not procedures.md.
-    const rows = surveyFamily(engineDeps({
-      readVersion: () => ({ version: '1.2.0' }),
-      statType: fragmentStat({ proc: null }), // procedures canon ABSENT, recipes present
-      readFileSync: () => '> a bounded fragment',
-    }));
-    const caveats = caveatsOf(rows);
-    assert.equal(caveats.length, 1);
-    assert.match(caveats[0], /activity-procedures|procedures canon/i);
-  });
-
-  it('an engine MISSING BOTH fragments surfaces BOTH caveats (neither overwrites the other)', () => {
-    const rows = surveyFamily(engineDeps({
-      readVersion: () => ({ version: '1.1.0' }),
-      statType: fragmentStat({ orch: null, proc: null }),
-    }));
-    const caveats = caveatsOf(rows);
-    assert.equal(caveats.length, 2, 'both missing fragments are reported');
-    assert.ok(caveats.some((c) => /recipes pointer/i.test(c)));
-    assert.ok(caveats.some((c) => /activity-procedures|procedures canon/i.test(c)));
-  });
-
-  it('a broken engine whose fragments are DIRECTORIES is NOT a false "ok"', () => {
-    const rows = surveyFamily(engineDeps({ statType: () => 'dir' })); // every fragment path is a dir
-    assert.equal(caveatsOf(rows).length, 2, 'non-file fragments are caveated');
-  });
-
-  it('a fragment PRESENT but UNREADABLE is NOT a false "ok" (mirrors the consumer STOP)', () => {
-    const rows = surveyFamily(engineDeps({
-      statType: fragmentStat({}), // both present as files
-      readFileSync: () => {
-        throw Object.assign(new Error('EACCES'), { code: 'EACCES' }); // but unreadable
-      },
-    }));
-    assert.equal(caveatsOf(rows).length, 2, 'unreadable fragments are caveated, not reported clean');
-  });
-});
-
-// ── surveyProject ────────────────────────────────────────────────────────────────
-
-describe('surveyProject', () => {
-  const projectDeps = ({ files }) => ({
-    exists: (p) => Object.prototype.hasOwnProperty.call(files, p) || Object.keys(files).some((k) => k === p),
-    readFile: (p) => {
-      if (!Object.prototype.hasOwnProperty.call(files, p)) throw Object.assign(new Error('ENOENT'), { code: 'ENOENT' });
-      return files[p];
-    },
-  });
-
-  it('reports deployed + stamps + docs/ai + hidden fence', () => {
-    const dir = '/proj';
-    const files = {
-      [join(dir, 'docs/ai/.workflow-version')]: '1.3.0\n',
-      [join(dir, 'docs/ai/.memory-version')]: '1.1.1\n',
-      [join(dir, 'docs', 'ai')]: '',
-      [join(dir, '.git', 'info', 'exclude')]: `# user rule\n${START_MARKER}\n/AGENTS.md\n`,
-    };
-    const r = surveyProject(dir, projectDeps({ files }));
-    assert.equal(r.deployed, true);
-    assert.equal(r.docsAiPresent, true);
-    assert.equal(r.hiddenFence, true);
-    assert.deepEqual(
-      r.stamps.map((s) => [s.name, s.version]),
-      [['agent-workflow-kit', '1.3.0'], ['agent-workflow-memory', '1.1.1']],
-    );
-  });
-
-  it('reports not-deployed when there is no docs/ai and no stamp', () => {
-    const r = surveyProject('/empty', projectDeps({ files: {} }));
-    assert.equal(r.deployed, false);
-    assert.equal(r.hiddenFence, false);
-    assert.ok(r.stamps.every((s) => s.version === null));
-  });
-});
-
-// ── drift-guard: FAMILY_MEMBERS ⟷ the 5 in-repo capability.json (the AD-008 lockstep pattern) ──────
-
-describe('FAMILY_MEMBERS drift-guard', () => {
-  const readManifest = (memberName) =>
-    JSON.parse(readFileSync(resolve(REPO_ROOT, memberName, 'capability.json'), 'utf8'));
-
-  // deduped roles[].cmd, in first-seen order (mirrors detect-backends' wrapperCmds derivation).
-  const dedupedCmds = (manifest) => {
-    const seen = new Set();
-    const out = [];
-    for (const role of Object.values(manifest.roles ?? {})) {
-      if (role && typeof role.cmd === 'string' && !seen.has(role.cmd)) {
-        seen.add(role.cmd);
-        out.push(role.cmd);
-      }
-    }
-    return out;
-  };
-
-  it('has exactly the five family members and no release skills', () => {
-    assert.equal(FAMILY_MEMBERS.length, 5);
-    const names = FAMILY_MEMBERS.map((m) => m.name);
-    assert.ok(!names.includes('release-engineering'));
-    assert.ok(!names.includes('release-marketing'));
-  });
-
-  for (const member of FAMILY_MEMBERS) {
-    it(`${member.name}: name/kind/detect.installed/deployed/npm/wrapperCmds match the in-repo manifest`, () => {
-      const m = readManifest(member.name);
-      assert.equal(m.name, member.name);
-      assert.equal(m.kind, member.kind);
-
-      assert.equal(m.detect.installed.env, member.installed.env);
-      assert.equal(m.detect.installed.default, member.installed.default);
-      assert.equal(m.detect.installed.file, member.installed.file);
-
-      if (member.deployed) assert.equal(m.detect.deployed.file, member.deployed.file);
-      else assert.equal(m.detect?.deployed ?? null, null);
-
-      if (member.npm) assert.equal(m.install.npm, member.npm);
-      else assert.equal(m.install?.npm ?? null, null);
-
-      assert.deepEqual(dedupedCmds(m), member.wrapperCmds);
-    });
-  }
-});