@saadnvd1/agent-os 0.3.723 → 0.3.728

package/components/Analyst/pair.ts

@@ -0,0 +1,81 @@
+"use client";
+
+import { useCallback } from "react";
+import { toast } from "sonner";
+import { usePanes } from "@/contexts/PaneContext";
+import {
+  useSessionAnalyst,
+  useStartAnalyst,
+  type StartAnalystInput,
+} from "@/data/analyst";
+import type { Session } from "@/lib/db";
+import type { AnalystLinkView, PaneSession } from "@/lib/analyst/types";
+
+// A chat's tmux name: `<agent>-<id>`, as every chat tab attaches.
+export const paneTmux = (s: PaneSession) => `${s.agentType}-${s.id}`;
+
+export type PairStatus = "paused" | "reviewing" | "recommendation" | "watching";
+
+export function pairStatus(link: AnalystLinkView): PairStatus {
+  if (link.paused) return "paused";
+  if (link.pendingDigestId) return "reviewing";
+  if (link.recommendations.some((r) => r.state === "open"))
+    return "recommendation";
+  return "watching";
+}
+
+export const PAIR_STATUS_LABEL: Record<PairStatus, string> = {
+  paused: "Paused",
+  reviewing: "Reviewing",
+  recommendation: "Prompt ready",
+  watching: "Watching",
+};
+
+// The side of a pairing a session isn't.
+export function partnerOf(link: AnalystLinkView, sessionId: string) {
+  return link.coder.id === sessionId ? link.analyst : link.coder;
+}
+
+// Starts an analyst for a chat and shows it beside the coder's pane: the
+// one given, else one showing the coder, else the focused one.
+export function useStartAnalystBeside() {
+  const start = useStartAnalyst();
+  const { openBeside, state, focusedPaneId } = usePanes();
+  const run = useCallback(
+    async (input: StartAnalystInput, paneId?: string) => {
+      try {
+        const link = await start.mutateAsync(input);
+        const showing = Object.entries(state.panes).find(([, p]) =>
+          p.tabs.some(
+            (t) => t.id === p.activeTabId && t.sessionId === link.coder.id
+          )
+        )?.[0];
+        openBeside(paneId ?? showing ?? focusedPaneId, {
+          sessionId: link.analyst.id,
+          tmux: paneTmux(link.analyst),
+        });
+        return link;
+      } catch (error) {
+        toast.error(error instanceof Error ? error.message : String(error));
+        return null;
+      }
+    },
+    [start, openBeside, state.panes, focusedPaneId]
+  );
+  return { run, isPending: start.isPending };
+}
+
+// Whether a session can be given an analyst here: a local chat that isn't
+// an orchestrator, an analyst or already paired. The server checks again.
+export function useCanAddAnalyst(session: Session | null | undefined) {
+  const chat = session?.view === "chat" ? session : null;
+  const paired = useSessionAnalyst(chat?.id).data;
+  return (
+    !!chat &&
+    !chat.role &&
+    !chat.archived_at &&
+    (chat.host_id || "local") === "local" &&
+    chat.agent_role !== "analyst" &&
+    !paired
+  );
+}

package/components/Chat/Code.tsx

@@ -12,6 +12,8 @@ import oneDark from "react-syntax-highlighter/dist/esm/styles/prism/one-dark";
 import oneLight from "react-syntax-highlighter/dist/esm/styles/prism/one-light";
 import { CopyButton } from "./CopyButton";
 import { Mermaid } from "./Mermaid";
+import { ReviewCard } from "@/components/Analyst/ReviewCard";
+import { REVIEW_FENCE } from "@/lib/analyst/parseReview";
 
 const ALIASES: Record<string, string> = {
   sh: "bash",
@@ -117,6 +119,7 @@ export function CodeBlock({
   language?: string;
 }) {
   if (language === "mermaid") return <Mermaid code={code} />;
+  if (language === REVIEW_FENCE) return <ReviewCard code={code} />;
   return (
     <div className="bg-foreground/[0.04] not-prose my-3 overflow-hidden rounded-xl">
       <div

package/components/Chat/Messages.tsx

@@ -27,6 +27,7 @@ import { openSessionLink } from "./session-link";
 import { UndoButton } from "./Undo";
 import { useRowState } from "./rowState";
 import { useBookmarkChat } from "@/components/Bookmarks/context";
+import { ChatItemContext } from "./itemContext";
 import { exportUi, exportUiActions, pickedRange } from "@/stores/exportUi";
 import {
   BookmarkButton,
@@ -299,7 +300,11 @@ export function AssistantMessage({
     <BookmarkPress itemId={item.id}>
       <div className="group">
         <div data-quotable className={cn(item.streaming && "streaming-cursor")}>
-          <Markdown text={item.text} streaming={item.streaming} />
+          <ChatItemContext.Provider
+            value={{ itemId: item.id, streaming: !!item.streaming }}
+          >
+            <Markdown text={item.text} streaming={item.streaming} />
+          </ChatItemContext.Provider>
         </div>
         {!item.streaming && (
           <div className="-ml-1.5 flex items-center">

package/components/Chat/itemContext.ts

@@ -0,0 +1,14 @@
+"use client";
+
+import { createContext, useContext } from "react";
+
+// The message a rendered block belongs to, for blocks that act on it (a
+// review card finds its stored recommendation by the item's id).
+export interface ChatItemRef {
+  itemId: string;
+  streaming: boolean;
+}
+
+export const ChatItemContext = createContext<ChatItemRef | null>(null);
+
+export const useChatItem = () => useContext(ChatItemContext);

package/components/Draft/DraftChips.tsx

@@ -4,6 +4,7 @@ import { useEffect } from "react";
 import {
   Bot,
   Cpu,
+  Eye,
   FolderGit2,
   GitBranch,
   Flag,
@@ -252,6 +253,15 @@ export function DraftChips({
           onChange={(openPr) => onChange({ openPr })}
         />
       )}
+      {project && !draft.openPr && local && draft.agentRole !== "analyst" && (
+        <ChipToggle
+          icon={Eye}
+          label="With analyst"
+          on={!!draft.withAnalyst}
+          title="A second chat reviews each turn and drafts the next prompt for you to send"
+          onChange={(withAnalyst) => onChange({ withAnalyst })}
+        />
+      )}
       {project && draft.openPr && local && (
         <ChipMenu
           icon={Cpu}

package/components/Draft/DraftPanel.tsx

@@ -23,6 +23,7 @@ import type { StartWarning } from "@/lib/claims/startWarning";
 import { usePanes } from "@/contexts/PaneContext";
 import { setPendingPrompt } from "@/stores/initialPrompt";
 import { draftsActions, draftsStore, newDraft } from "@/stores/drafts";
+import { useStartAnalystBeside } from "@/components/Analyst/pair";
 import { DraftChips } from "./DraftChips";
 import { DraftHeading } from "./DraftHeading";
 import { ModelUnavailableDialog } from "./ModelUnavailableDialog";
@@ -57,6 +58,7 @@ export function DraftPanel({
     discovers
   );
   const launch = useLaunchSession();
+  const startAnalyst = useStartAnalystBeside();
   const { workspace } = useSelectedWorkspace();
   const createTask = useCreateTask();
   const checkStart = useCheckStart();
@@ -172,6 +174,11 @@ export function DraftPanel({
         session.tmux_name ?? "",
         session.host_id
       );
+      if (draft.withAnalyst && project && draft.hostId === "local") {
+        if (session.view === "chat")
+          void startAnalyst.run({ coderSessionId: session.id }, paneId);
+        else toast("An analyst reviews chats: this session runs in a terminal");
+      }
     } catch (error) {
       if (error instanceof ModelUnavailableError) {
         setDown({ error, text, images, files });

package/components/Pane/DesktopTabBar.tsx

@@ -16,6 +16,7 @@ import { PaneViewToggle } from "./PaneViewToggle";
 import { PaneMenu } from "./PaneMenu";
 import { HostBadge } from "@/components/Hosts/HostBadge";
 import { RolePill } from "@/components/Sessions/RolePill";
+import { PairChip } from "@/components/Analyst/PairChip";
 import { usePaneBarSlots } from "./PaneBarSlots";
 import { ChatBookmarksButton } from "@/components/Bookmarks/ChatBookmarksButton";
 import type { ViewMode } from "@/contexts/PaneContext";
@@ -37,6 +38,7 @@ interface DesktopTabBarProps {
   isFocused: boolean;
   isConductor: boolean;
   hasLog?: boolean;
+  hasReport?: boolean;
   workerCount: number;
   canSplit: boolean;
   canClose: boolean;
@@ -68,6 +70,7 @@ export function DesktopTabBar({
   isFocused,
   isConductor,
   hasLog,
+  hasReport,
   workerCount,
   canSplit,
   canClose,
@@ -163,6 +166,7 @@ export function DesktopTabBar({
 
       <div className="flex shrink-0 items-center gap-1.5">
         <RolePill session={session} paneId={paneId} />
+        <PairChip session={session} paneId={paneId} />
         <HostBadge hostId={session?.host_id} />
         <ContextMeter sessionId={session?.id} />
         <SessionPrStage sessionId={session?.id} />
@@ -182,6 +186,7 @@ export function DesktopTabBar({
             isLocalSession={isLocalSession}
             isConductor={isConductor}
             hasLog={hasLog}
+            hasReport={hasReport}
             workerCount={workerCount}
             showGit={showGit}
             gitDrawerOpen={gitDrawerOpen}
@@ -194,6 +199,7 @@ export function DesktopTabBar({
         <div className="flex items-center">
           <PaneMenu
             session={session}
+            paneId={paneId}
             bookmarksSessionId={bookmarksSessionId}
             canSplit={canSplit}
             canClose={canClose}

package/components/Pane/MobileTabBar.tsx

@@ -26,6 +26,7 @@ import {
   Share2,
   Download,
   TextSearch,
+  Eye,
 } from "lucide-react";
 import { cn } from "@/lib/utils";
 import { useAwayQuery } from "@/data/away";
@@ -36,6 +37,8 @@ import { RolePill } from "@/components/Sessions/RolePill";
 import { bookmarksUiActions } from "@/stores/bookmarksUi";
 import { shareUiActions } from "@/stores/shareUi";
 import { exportUiActions } from "@/stores/exportUi";
+import { analystUiActions } from "@/stores/analystUi";
+import { useCanAddAnalyst } from "@/components/Analyst/pair";
 import { MoveMenuItems } from "@/components/Tasks/MoveMenuItems";
 import { ChatBookmarksButton } from "@/components/Bookmarks/ChatBookmarksButton";
 import type { ViewMode } from "@/contexts/PaneContext";
@@ -50,6 +53,7 @@ interface MobileTabBarProps {
   viewMode: ViewMode;
   isConductor: boolean;
   hasLog?: boolean;
+  hasReport?: boolean;
   workerCount: number;
   // Local, and the folder is not known to be outside a git repository.
   showGit: boolean;
@@ -70,6 +74,7 @@ export function MobileTabBar({
   viewMode,
   isConductor,
   hasLog,
+  hasReport,
   workerCount,
   showGit,
   onMenuClick,
@@ -128,6 +133,7 @@ export function MobileTabBar({
   };
 
   const isLocalSession = !session?.host_id || session.host_id === "local";
+  const canAddAnalyst = useCanAddAnalyst(session);
 
   return (
     <div
@@ -230,6 +236,16 @@ export function MobileTabBar({
                   <Download className="h-4 w-4" />
                   Export for AI…
                 </DropdownMenuItem>
+                {canAddAnalyst && (
+                  <DropdownMenuItem
+                    onSelect={() =>
+                      analystUiActions.open(session.id, session.name)
+                    }
+                  >
+                    <Eye className="h-4 w-4" />
+                    Add analyst…
+                  </DropdownMenuItem>
+                )}
                 <DropdownMenuSeparator />
               </>
             )}
@@ -375,6 +391,7 @@ export function MobileTabBar({
           isLocalSession={isLocalSession}
           showGit={showGit}
           hasLog={hasLog}
+          hasReport={hasReport}
           isConductor={isConductor}
           workerCount={workerCount}
         />

package/components/Pane/MobileViewPicker.tsx

@@ -7,6 +7,7 @@ import {
   GitBranch,
   Package,
   ScrollText,
+  ClipboardList,
   Terminal as TerminalIcon,
   Users,
   type LucideIcon,
@@ -31,6 +32,7 @@ export interface MobileViewAvailability {
   // Local, and the folder is not known to be outside a git repository.
   showGit: boolean;
   hasLog?: boolean;
+  hasReport?: boolean;
   isConductor: boolean;
   workerCount: number;
 }
@@ -40,6 +42,7 @@ export function mobileViews({
   isLocalSession,
   showGit,
   hasLog,
+  hasReport,
   isConductor,
   workerCount,
 }: MobileViewAvailability): MobileView[] {
@@ -48,6 +51,7 @@ export function mobileViews({
     isLocalSession && { mode: "files", label: "Files", icon: FolderOpen },
     showGit && { mode: "git", label: "Git", icon: GitBranch },
     { mode: "artifacts", label: "Artifacts", icon: Package },
+    !!hasReport && { mode: "report", label: "Report", icon: ClipboardList },
     !!hasLog && { mode: "log", label: "Log", icon: ScrollText },
     isConductor && {
       mode: "workers",

package/components/Pane/PaneMenu.test.ts

@@ -6,10 +6,12 @@ import type { Session } from "@/lib/db/types";
 import { bookmarksUi } from "@/stores/bookmarksUi";
 import { docsUi } from "@/stores/docsUi";
 import { paletteUi } from "@/stores/palette";
+import { analystUi } from "@/stores/analystUi";
 
 const data = vi.hoisted(() => ({
   bookmarks: [] as unknown[],
   docs: null as { id: string } | null,
+  canAddAnalyst: false,
 }));
 vi.mock("@/data/bookmarks", () => ({
   useSessionBookmarks: () => ({ data: data.bookmarks }),
@@ -17,6 +19,9 @@ vi.mock("@/data/bookmarks", () => ({
 vi.mock("@/data/lumifyhub/docs", () => ({
   useDocsWorkspace: () => data.docs,
 }));
+vi.mock("@/components/Analyst/pair", () => ({
+  useCanAddAnalyst: () => data.canAddAnalyst,
+}));
 vi.mock("@/components/Tasks/MoveMenuItems", () => ({
   MoveMenuItems: () => null,
 }));
@@ -60,6 +65,8 @@ describe("PaneMenu", () => {
     root = createRoot(host);
     data.bookmarks = [];
     data.docs = null;
+    data.canAddAnalyst = false;
+    analystUi.open = false;
     paletteUi.open = false;
     bookmarksUi.chatSessionId = null;
     docsUi.workspaceId = null;
@@ -73,6 +80,7 @@ describe("PaneMenu", () => {
       root.render(
         createElement(PaneMenu, {
           session,
+          paneId: "pane-1",
           bookmarksSessionId,
           canSplit: true,
           canClose: true,
@@ -115,4 +123,17 @@ describe("PaneMenu", () => {
     act(() => item("Docs")?.click());
     expect(docsUi.workspaceId).toBe("w1");
   });
+
+  it("offers Add analyst only when the chat can have one, beside this pane", () => {
+    render();
+    expect(item("Add analyst")).toBeUndefined();
+    data.canAddAnalyst = true;
+    render();
+    act(() => item("Add analyst")?.click());
+    expect(analystUi).toMatchObject({
+      open: true,
+      sessionId: "s1",
+      paneId: "pane-1",
+    });
+  });
 });

package/components/Pane/PaneMenu.tsx

@@ -12,6 +12,7 @@ import {
   SplitSquareHorizontal,
   SplitSquareVertical,
   Star,
+  Eye,
   Unplug,
   X,
 } from "lucide-react";
@@ -29,6 +30,8 @@ import { copySessionLink, writeClipboard } from "@/hooks/useCopyToClipboard";
 import type { Session } from "@/lib/db";
 import { shareUiActions } from "@/stores/shareUi";
 import { exportUiActions } from "@/stores/exportUi";
+import { analystUiActions } from "@/stores/analystUi";
+import { useCanAddAnalyst } from "@/components/Analyst/pair";
 import { useSessionBookmarks } from "@/data/bookmarks";
 import { useDocsWorkspace } from "@/data/lumifyhub/docs";
 import { bookmarksUiActions } from "@/stores/bookmarksUi";
@@ -38,6 +41,7 @@ import { MoveMenuItems } from "@/components/Tasks/MoveMenuItems";
 
 interface PaneMenuProps {
   session: Session | null | undefined;
+  paneId?: string;
   // The chat on show, for its bookmarks; null for a terminal or another view.
   bookmarksSessionId?: string | null;
   canSplit: boolean;
@@ -53,6 +57,7 @@ interface PaneMenuProps {
 // the bar.
 export function PaneMenu({
   session,
+  paneId,
   bookmarksSessionId,
   canSplit,
   canClose,
@@ -64,6 +69,7 @@ export function PaneMenu({
 }: PaneMenuProps) {
   const { data: bookmarks = [] } = useSessionBookmarks(bookmarksSessionId);
   const docs = useDocsWorkspace(session?.project_id);
+  const canAddAnalyst = useCanAddAnalyst(session);
   const copyId = async (id: string) => {
     try {
       await writeClipboard(id);
@@ -127,6 +133,16 @@ export function PaneMenu({
                 Export for AI…
               </DropdownMenuItem>
             )}
+            {canAddAnalyst && session && (
+              <DropdownMenuItem
+                onSelect={() =>
+                  analystUiActions.open(session.id, session.name, paneId)
+                }
+              >
+                <Eye className="h-4 w-4" />
+                Add analyst…
+              </DropdownMenuItem>
+            )}
             <DropdownMenuSeparator />
             <MoveMenuItems
               session={session}

package/components/Pane/PaneViewToggle.tsx

@@ -6,6 +6,7 @@ import {
   Home,
   Package,
   ScrollText,
+  ClipboardList,
   Users,
 } from "lucide-react";
 import {
@@ -27,6 +28,7 @@ interface PaneViewToggleProps {
   isConductor: boolean;
   // The task merged and has a log.
   hasLog?: boolean;
+  hasReport?: boolean;
   workerCount: number;
   gitDrawerOpen: boolean;
   shellDrawerOpen: boolean;
@@ -85,6 +87,7 @@ export function PaneViewToggle({
   showGit,
   isConductor,
   hasLog,
+  hasReport,
   workerCount,
   gitDrawerOpen,
   shellDrawerOpen,
@@ -138,6 +141,15 @@ export function PaneViewToggle({
           <Package className="h-3.5 w-3.5" />
         </ToggleButton>
       )}
+      {hasReport && (
+        <ToggleButton
+          label="Report"
+          active={viewMode === "report"}
+          onClick={() => onViewModeChange("report")}
+        >
+          <ClipboardList className="h-3.5 w-3.5" />
+        </ToggleButton>
+      )}
       {hasLog && (
         <ToggleButton
           label="Log"

package/components/Pane/index.tsx

@@ -16,6 +16,7 @@ import { cn } from "@/lib/utils";
 import { ConductorPanel } from "@/components/ConductorPanel";
 import { useFileEditor } from "@/hooks/useFileEditor";
 import { MobileTabBar } from "./MobileTabBar";
+import { PairSwitch } from "@/components/Analyst/PairSwitch";
 import { openFind } from "@/components/Chat/useFind";
 import { DesktopTabBar } from "./DesktopTabBar";
 import {
@@ -46,6 +47,10 @@ const ArtifactsPanel = dynamic(
     ),
   { ssr: false }
 );
+const ReportView = dynamic(
+  () => import("@/components/Report/ReportView").then((mod) => mod.ReportView),
+  { ssr: false }
+);
 const LogDocument = dynamic(
   () =>
     import("@/components/SessionLogs/LogDocument").then(
@@ -215,6 +220,7 @@ export const Pane = memo(function Pane({
     !!session?.task_prompt &&
     (session.task_status === "merged" || session.pr_status === "merged");
   const hasLog = !!useTaskLogQuery(session?.id, merged).data;
+  const hasReport = !!session?.task_prompt;
 
   // Get current project and its repositories
   const currentProject = useMemo(() => {
@@ -471,6 +477,7 @@ export const Pane = memo(function Pane({
           viewMode={viewMode}
           isConductor={isConductor}
           hasLog={hasLog}
+          hasReport={hasReport}
           workerCount={workerCount}
           showGit={showGit}
           onMenuClick={onMenuClick}
@@ -494,6 +501,7 @@ export const Pane = memo(function Pane({
           isFocused={isFocused}
           isConductor={isConductor}
           hasLog={hasLog}
+          hasReport={hasReport}
           workerCount={workerCount}
           canSplit={canSplit}
           canClose={canClose}
@@ -514,6 +522,7 @@ export const Pane = memo(function Pane({
           bookmarksSessionId={bookmarksSessionId}
         />
       )}
+      {isMobile && <PairSwitch session={session} paneId={paneId} />}
 
       {/* Content Area - Mobile: simple flex, Desktop: resizable panels */}
       {isMobile ? (
@@ -558,6 +567,11 @@ export const Pane = memo(function Pane({
             </div>
           )}
 
+          {/* Report */}
+          {viewMode === "report" && session && (
+            <ReportView sessionId={session.id} name={session.name} />
+          )}
+
           {/* Log */}
           {viewMode === "log" && session && (
             <LogDocument sessionId={session.id} />
@@ -629,6 +643,11 @@ export const Pane = memo(function Pane({
                     </div>
                   )}
 
+                  {/* Report */}
+                  {viewMode === "report" && session && (
+                    <ReportView sessionId={session.id} name={session.name} />
+                  )}
+
                   {/* Log */}
                   {viewMode === "log" && session && (
                     <LogDocument sessionId={session.id} />

package/components/Report/DraftCard.tsx

@@ -0,0 +1,89 @@
+"use client";
+
+import { useState } from "react";
+import { Button } from "@/components/ui/button";
+import { Textarea } from "@/components/ui/textarea";
+import { useReportDraft } from "@/data/reports";
+import type { NextPromptDraft } from "@/lib/reports/types";
+
+// The analyst's drafted next prompt, shown in full. Approve & send is the one
+// click; nothing is sent without it.
+export function DraftCard({
+  sessionId,
+  draft,
+}: {
+  sessionId: string;
+  draft: NextPromptDraft;
+}) {
+  const act = useReportDraft(sessionId);
+  const [editing, setEditing] = useState(false);
+  const [text, setText] = useState(draft.text);
+  const ref = { source: draft.source, id: draft.id, linkId: draft.linkId };
+  const decided = draft.status !== "pending";
+
+  if (decided)
+    return (
+      <p className="text-muted-foreground bg-muted/40 rounded-lg px-3 py-2 text-sm">
+        {draft.status === "sent"
+          ? "Sent to the coding agent."
+          : draft.status === "dismissed"
+            ? "Draft dismissed."
+            : "A newer report replaced this draft."}
+      </p>
+    );
+
+  return (
+    <section
+      aria-label="Drafted next prompt"
+      className="bg-card space-y-3 rounded-xl p-4 shadow-sm"
+    >
+      <h3 className="text-sm font-semibold">Drafted next prompt</h3>
+      {editing ? (
+        <Textarea
+          value={text}
+          onChange={(e) => setText(e.target.value)}
+          rows={6}
+          aria-label="Edit the prompt"
+        />
+      ) : (
+        <p className="bg-muted/50 rounded-lg p-3 text-sm whitespace-pre-wrap">
+          {draft.text}
+        </p>
+      )}
+      {act.isError && (
+        <p className="text-destructive text-sm">{act.error.message}</p>
+      )}
+      <div className="flex flex-wrap gap-2">
+        <Button
+          className="min-h-11 flex-1"
+          disabled={act.isPending || !text.trim()}
+          onClick={() =>
+            act.mutate({
+              ...ref,
+              action: "send",
+              text: editing ? text : undefined,
+            })
+          }
+        >
+          Approve &amp; send
+        </Button>
+        <Button
+          variant="secondary"
+          className="min-h-11"
+          disabled={act.isPending}
+          onClick={() => setEditing((e) => !e)}
+        >
+          {editing ? "Cancel edit" : "Edit"}
+        </Button>
+        <Button
+          variant="ghost"
+          className="min-h-11"
+          disabled={act.isPending}
+          onClick={() => act.mutate({ ...ref, action: "dismiss" })}
+        >
+          Dismiss
+        </Button>
+      </div>
+    </section>
+  );
+}