@saadnvd1/agent-os 0.3.694 → 0.3.697

package/components/Settings/NoApprovalsSection.tsx

@@ -9,7 +9,7 @@ import { useApprovalsModeQuery, useSetApprovalsMode } from "@/data/approvals";
 export const NO_APPROVALS_WARNING = [
   "Every ask is approved the moment it is raised, hard lines included: public posts and messages, money, irreversible or destructive changes, credentials.",
   "A PR stuck failing its gates, with no CI, or too big to review still merges.",
-  "Brakes stop holding new starts, and plan-only tasks go on to implement without waiting for a plan approval.",
+  "Brakes stop holding new starts. Plan-only tasks still wait for approve_plan.",
   "Every agent AgentOS starts runs with its permission prompts off, and prompts already waiting are allowed.",
 ];
 

package/lib/approvals/enable.ts

@@ -2,9 +2,7 @@
 // brings what already exists in line with it.
 
 import { db } from "../db";
-import { isRemoteHost } from "../hosts";
 import { reapplyChatModes } from "../chat/settings";
-import { approvePlanNow } from "../models/plan-step";
 import { autoApproveAsk, type AskRow } from "../orchestrator/asks";
 import { addNote } from "../orchestrator/notes";
 import { listOrchestrators } from "../orchestrator/home";
@@ -15,7 +13,7 @@ import {
 } from "./no-approvals";
 
 // Everything already waiting when the mode goes on is approved: open asks,
-// plan-only tasks at their plan, tool cards in live chats.
+// tool cards in live chats.
 async function sweep(): Promise<void> {
   const asks = db
     .prepare(`SELECT * FROM orchestrator_asks WHERE status = 'open'`)
@@ -27,24 +25,6 @@ async function sweep(): Promise<void> {
       console.error(`auto-approving ask ${ask.id} failed:`, e);
     }
   }
-  const plans = db
-    .prepare(
-      `SELECT id, host_id, plan_waits_for_caller FROM session_rows WHERE plan_phase = 'awaiting' AND task_status = 'running'`
-    )
-    .all() as {
-    id: string;
-    host_id: string;
-    plan_waits_for_caller: number | null;
-  }[];
-  for (const p of plans) {
-    // A plan placed here by another machine is that machine's to decide.
-    if (p.plan_waits_for_caller && !isRemoteHost(p.host_id)) continue;
-    try {
-      await approvePlanNow(p.id, undefined, "no-approvals");
-    } catch (e) {
-      console.error(`auto-approving plan of ${p.id} failed:`, e);
-    }
-  }
 }
 
 export async function switchNoApprovals(on: boolean): Promise<void> {

package/lib/approvals/no-approvals.ts

@@ -1,7 +1,7 @@
 /**
  * No approvals mode: while it's on, nothing AgentOS starts or runs waits on
  * a person. Asks are approved as they're raised, brakes let starts through,
- * plan-only tasks go on to implement, and agents launch with their harness's
+ * and agents launch with their harness's
  * permission prompts off. Off by default; app-wide; every point that honours
  * it reads it here and records what it did with recordAutoApproval.
  */

package/lib/models/plan-step.ts

@@ -19,7 +19,7 @@ import {
 } from "./resolve";
 import { ANTHROPIC } from "./roles";
 import { queueEvent } from "../orchestrator/events";
-import { noApprovalsOn, recordAutoApproval } from "../approvals/no-approvals";
+import { recordAutoApproval } from "../approvals/no-approvals";
 import { addNote } from "../orchestrator/notes";
 import { amendBrief, scopeChangesOf } from "../orchestrator/amendments";
 import { PIECES_PROMPT, foldedBrief, pieceBrief } from "../plans/pieces";
@@ -451,15 +451,15 @@ export async function handoffAfterPlan(
   deleteQueued(sessionId, planRetryMessageId(sessionId));
   const retried = waiting.get(sessionId)?.retried ?? false;
   forget(sessionId);
-  // No approvals mode doesn't stop at the plan to wait for one. Pieces that
-  // couldn't be registered always do: building on a guess is the bug.
-  const auto = !!s.plan_only && noApprovalsOn() && !s.plan_waits_for_caller;
+  // A plan-only task never goes on by itself, in No approvals mode too: it
+  // was asked to stop and show the plan. Pieces that couldn't be registered
+  // always hold a plan-first one: building on a guess is the bug.
   const planText = readPlan(s);
   const pieceErrors =
     (planText && !s.plan_waits_for_caller
       ? splitOf(s, planText)?.errors
       : null) ?? [];
-  if ((!s.plan_only || auto) && !pieceErrors.length) {
+  if (!s.plan_only && !pieceErrors.length) {
     const ref = await startImplementing(
       s,
       "planning",
@@ -467,14 +467,6 @@ export async function handoffAfterPlan(
       undefined,
       retried
     );
-    if (ref && auto)
-      recordAutoApproval({
-        source: "plan",
-        workspaceId: sessionWorkspace(s),
-        sessionId,
-        subject: `plan for ${s.name}`,
-        detail: "implementing without waiting for approve_plan",
-      });
     return ref !== null;
   }
   if (!advancePlan(db, sessionId, "planning", "awaiting")) return false;

package/lib/tasks/contract/plan.ts

@@ -16,10 +16,6 @@ import { isRemoteHost } from "../../hosts";
 import { peerSource } from "../../hosts/peer-load";
 import { hostLink, requireHostLink } from "../../hosts/remote-api";
 import { LOCAL, machineCapabilities } from "../../load/machines";
-import {
-  noApprovalsOn,
-  recordAutoApproval,
-} from "../../approvals/no-approvals";
 import { implementArrived, planNoteFor } from "../../models/plan-step";
 import { sessionWorkspace } from "../../models/resolve";
 import { queueEvent } from "../../orchestrator/events";
@@ -112,8 +108,7 @@ export async function planWritten(
   // As for a task planned here: a plan-first task goes on by itself, a
   // plan-only one waits unless no-approvals is on, and pieces that couldn't
   // be registered always hold it.
-  const auto = !!fresh.plan_only && noApprovalsOn();
-  const goOn = (!fresh.plan_only || auto) && !errors.length;
+  const goOn = !fresh.plan_only && !errors.length;
   const target = goOn ? implementTarget(fresh, split) : null;
   const next =
     target === "there"
@@ -148,14 +143,6 @@ export async function planWritten(
     return;
   }
   await continuePlanThere(fresh);
-  if (auto)
-    recordAutoApproval({
-      source: "plan",
-      workspaceId,
-      sessionId: s.id,
-      subject: `plan for ${s.name}`,
-      detail: "implementing without waiting for approve_plan",
-    });
 }
 
 /**

package/lib/worktree-sweep/testTemp.ts

@@ -37,6 +37,7 @@ export const TEST_TEMP_PREFIXES: readonly string[] = [
   "aos-kind-",
   "aos-launch-plain-",
   "aos-launch-repo-",
+  "aos-machine-",
   "aos-limits-",
   "aos-mcp-",
   "aos-merge-policy-",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saadnvd1/agent-os",
-  "version": "0.3.694",
+  "version": "0.3.697",
   "description": "Self-hosted web UI for managing Claude Code sessions",
   "bin": {
     "agent-os": "scripts/agent-os"

package/scripts/install-deps

@@ -13,7 +13,12 @@ source scripts/lib/pnpm.sh
 if [ -s "$HOME/.nvm/nvm.sh" ]; then
   # shellcheck disable=SC1091
   source "$HOME/.nvm/nvm.sh" >/dev/null
-  nvm use >/dev/null
+  # A box with nvm but without .nvmrc's version (a CI runner) keeps the node on PATH.
+  nvm use >/dev/null 2>&1 || true
+fi
+if [ "$(node -p 'process.versions.node.split(".")[0]')" -lt 22 ]; then
+  echo "Node 22 or newer is required (found $(node -v)); run: nvm install" >&2
+  exit 1
 fi
 use_pnpm
 

package/scripts/lib/commands.sh

@@ -189,7 +189,7 @@ cmd_stop() {
     while ps -p "$pid" &> /dev/null && [[ $count -lt 10 ]]; do
         printf "."
         sleep 1
-        ((count++))
+        count=$((count + 1))
     done
     echo ""
 

package/scripts/lib/wsl.test.ts

@@ -33,6 +33,12 @@ const TOOLS = [
   "id",
 ];
 
+// Bash 4+ (Linux, CI) fails `set -e` on `((n++))` at 0; macOS's 3.2 doesn't.
+const BASH =
+  ["/opt/homebrew/bin/bash", "/usr/local/bin/bash", "/bin/bash"].find(
+    existsSync
+  ) ?? "/bin/bash";
+
 let dir: string;
 
 function fake(name: string, body: string) {
@@ -48,7 +54,7 @@ function run(
 ) {
   writeFileSync(join(dir, "osrelease"), osrelease);
   return spawnSync(
-    "/bin/bash",
+    BASH,
     [
       "-euo",
       "pipefail",
@@ -313,3 +319,47 @@ describe("installing prerequisites", () => {
     expect(r.stdout).not.toContain("Prerequisites installed");
   });
 });
+
+describe("cmd_stop", () => {
+  // `ps` reports the server alive for the first `alive` checks, then gone.
+  // A server that takes a moment to exit used to trip `((count++))` (status 1
+  // at 0) under `set -e`, so stop exited 1 after the server had stopped.
+  const stop = (alive: number) => {
+    mkdirSync(join(dir, "home"), { recursive: true });
+    fake(
+      "ps",
+      `n=$(cat "${dir}/ps-count" 2>/dev/null || echo 0); echo $((n + 1)) > "${dir}/ps-count"; [ "$n" -lt ${alive} ]`
+    );
+    fake("sleep", "exit 0");
+    return run(
+      `AGENT_OS_HOME="${dir}/home"; PID_FILE="$AGENT_OS_HOME/agent-os.pid"; echo $$ > "$PID_FILE"; kill() { return 0; }; cmd_stop`,
+      ""
+    );
+  };
+
+  it("returns 0 when the server exits after a few checks", () => {
+    const r = stop(3);
+    expect(r.status).toBe(0);
+    expect(r.stdout).toContain("AgentOS stopped");
+    expect(existsSync(join(dir, "home", "agent-os.pid"))).toBe(false);
+  });
+
+  it("force kills and still returns 0 when it outlives the timeout", () => {
+    const r = stop(1000);
+    expect(r.status).toBe(0);
+    expect(r.stdout).toContain("Force killing");
+  });
+
+  it("has no bare ((x++)) in scripts/lib: it returns 1 at 0 under set -e", () => {
+    for (const f of [
+      "commands.sh",
+      "common.sh",
+      "machine.sh",
+      "prerequisites.sh",
+    ]) {
+      expect(readFileSync(join(LIB, f), "utf8"), f).not.toMatch(
+        /^\s*\(\(\s*\w+(\+\+|--)\s*\)\)\s*$/m
+      );
+    }
+  });
+});