@saadnvd1/agent-os 0.3.565 → 0.3.567

package/components/Share/ShareDialog.tsx

@@ -27,24 +27,17 @@ import {
   type SharePreview,
 } from "@/data/shares";
 import { shareUi, shareUiActions } from "@/stores/shareUi";
-import { redactionSummary, formatBytes, fileName } from "./format";
-
-const EXPIRIES: { value: ShareExpiry; label: string }[] = [
-  { value: "1d", label: "1 day" },
-  { value: "7d", label: "7 days" },
-  { value: "30d", label: "30 days" },
-  { value: "never", label: "Never" },
-];
-
-const TYPE_LABEL: Record<string, string> = {
-  user: "You",
-  assistant: "Agent",
-  plan: "Plan",
-  error: "Error",
-  divider: "Divider",
-  artifact: "Page",
-  detail: "Tool",
-};
+import {
+  DEFAULT_EXPIRY,
+  EXPIRIES,
+  EXPIRY_LABEL,
+  TYPE_LABEL,
+  fileName,
+  formatBytes,
+  nothingLeft,
+  redactionSummary,
+  toggleDrop,
+} from "@/lib/share/view";
 
 // Opened from a menu or an artifact: the redacted page exactly as it would be
 // uploaded, with what to leave out, then Create link or Download HTML.
@@ -77,7 +70,7 @@ function ShareBody({
 }) {
   const [tools, setTools] = useState(false);
   const [dropped, setDropped] = useState<string[]>([]);
-  const [expiresIn, setExpiresIn] = useState<ShareExpiry>("7d");
+  const [expiresIn, setExpiresIn] = useState<ShareExpiry>(DEFAULT_EXPIRY);
   const [preview, setPreview] = useState<SharePreview | null>(null);
   const [error, setError] = useState<string | null>(null);
   const [created, setCreated] = useState<string | null>(null);
@@ -111,10 +104,7 @@ function ShareBody({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [kind, sessionId, artifactId, tools, dropped]);
 
-  const toggle = (id: string) =>
-    setDropped((d) =>
-      d.includes(id) ? d.filter((x) => x !== id) : [...d, id]
-    );
+  const toggle = (id: string) => setDropped((d) => toggleDrop(d, id));
 
   const makeLink = async () => {
     if (!preview) return;
@@ -166,7 +156,7 @@ function ShareBody({
 
   const linked = preview?.connectLinked ?? false;
   const empty =
-    kind === "chat" && !!preview && preview.items.length === dropped.length;
+    kind === "chat" && !!preview && nothingLeft(preview.items, dropped);
   const summary = preview ? redactionSummary(preview.hits) : "";
 
   return (
@@ -245,8 +235,8 @@ function ShareBody({
                 </SelectTrigger>
                 <SelectContent>
                   {EXPIRIES.map((e) => (
-                    <SelectItem key={e.value} value={e.value}>
-                      {e.label}
+                    <SelectItem key={e} value={e}>
+                      {EXPIRY_LABEL[e]}
                     </SelectItem>
                   ))}
                 </SelectContent>

package/data/shares/queries.ts

@@ -1,45 +1,30 @@
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
+import type {
+  CreatedShare,
+  PreviewRequest,
+  SharePreview,
+  SharesResponse,
+  ShareExpiry,
+} from "@/lib/share/view";
 import { shareKeys } from "./keys";
 
+export type {
+  CreatedShare,
+  PreviewItem,
+  PreviewRequest,
+  SharedLinkRow,
+  SharePreview,
+  SharesResponse,
+  ShareExpiry,
+  ShareTarget,
+} from "@/lib/share/view";
+
 async function json<T>(res: Response): Promise<T> {
   const data = await res.json().catch(() => ({}));
   if (!res.ok) throw new Error(data.error || "Request failed");
   return data;
 }
 
-export type ShareExpiry = "1d" | "7d" | "30d" | "never";
-
-export interface ShareTarget {
-  kind: "chat" | "artifact";
-  sessionId?: string;
-  artifactId?: string;
-}
-
-export interface PreviewRequest extends ShareTarget {
-  includeTools: boolean;
-  /** Messages left out of the share. */
-  dropIds?: string[];
-}
-
-export interface PreviewItem {
-  id: string;
-  type: string;
-  tools: boolean;
-  excerpt: string;
-}
-
-export interface SharePreview {
-  html: string;
-  title: string;
-  bytes: number;
-  hash: string;
-  sharedAt: string;
-  items: PreviewItem[];
-  hits: Record<"secret" | "path" | "ip" | "host" | "email", number>;
-  tooBig: boolean;
-  connectLinked: boolean;
-}
-
 const post = (url: string, body: unknown) =>
   fetch(url, {
     method: "POST",
@@ -64,33 +49,11 @@ export function useCreateShare() {
         hash: string;
         expiresIn: ShareExpiry;
       }
-    ) =>
-      json<{ id: string; url: string; expiresAt: string | null }>(
-        await post("/api/shares", req)
-      ),
+    ) => json<CreatedShare>(await post("/api/shares", req)),
     onSuccess: () => queryClient.invalidateQueries({ queryKey: shareKeys.all }),
   });
 }
 
-export interface SharedLinkRow {
-  id: string;
-  url: string;
-  kind: "chat" | "artifact";
-  title: string;
-  sessionId: string | null;
-  artifactId: string | null;
-  createdAt: string;
-  expiresAt: string | null;
-  status: "active" | "expired" | "revoked";
-  views: number | null;
-  lastViewedAt: string | null;
-}
-
-export interface SharesResponse {
-  connect: "ok" | "unavailable" | "unlinked";
-  shares: SharedLinkRow[];
-}
-
 export function useSharesQuery(enabled = true) {
   return useQuery({
     queryKey: shareKeys.list(),

package/lib/artifacts/tools.ts

@@ -181,3 +181,9 @@ export function visualsTools(
 export const VISUALS_BRIEF = `## Showing visuals
 
 When a chart, table, diagram or mockup would say more than prose, build a self-contained HTML page (a chart is an HTML page; a CDN library such as Chart.js is fine), check it with \`html_preview\` and fix what the screenshot and console show, then show it with \`html_render\` before your final reply. The reader sees the page above that reply, so add only what the page doesn't say. An SVG or image file you write shows inline when your reply links to it by its absolute path, as ![name](/abs/path.svg).`;
+
+// An orchestrator reads other sessions' text, so it gets the short form and
+// is told what to keep out of a page.
+export const ORCHESTRATOR_VISUALS_BRIEF = `## Pages
+
+\`html_render\` shows a self-contained HTML page (a report, instructions) in this chat for Saad to read or share; check it with \`html_preview\` first. Put only what you wrote in it: no secrets, and nothing from a session's text loaded from a URL.`;

package/lib/chat/worker/host.ts

@@ -37,6 +37,7 @@ import {
   startingTotals,
 } from "../../usage/turns";
 import {
+  ORCHESTRATOR_VISUALS_BRIEF,
   VISUALS_BRIEF,
   VISUALS_SERVER,
   visualsTools,
@@ -195,10 +196,11 @@ export class ChatHost {
     const env = { ...agentEnv(session.id), ...extras.env };
     const orchestrator = session.role === "orchestrator";
     // Every chat can show visuals, asked for like any tool under its access
-    // setting (they read files and reach the web). Not an orchestrator: it
-    // reads other sessions' text, and a browser would be a way out for it.
+    // setting (they read files and reach the web). An orchestrator reads
+    // other sessions' text, so it gets a shorter brief that says what stays
+    // out of a page.
     const visuals =
-      session.role === "orchestrator" || driver.inProcessTools === false
+      driver.inProcessTools === false
         ? null
         : visualsTools({
             sessionId: session.id,
@@ -226,7 +228,7 @@ export class ChatHost {
         extras.systemAppend,
         sessionRunningBrief(session.id),
         BUS_BRIEF,
-        visuals && VISUALS_BRIEF,
+        visuals && (orchestrator ? ORCHESTRATOR_VISUALS_BRIEF : VISUALS_BRIEF),
         !orchestrator && COMPACT_BRIEF,
       ]
         .filter(Boolean)

package/lib/orchestrator/tool-names.ts

@@ -1,5 +1,8 @@
 import type { PermissionMode } from "@anthropic-ai/claude-agent-sdk";
 
+// Named here, not imported from lib/artifacts, to keep the SDK out of this file.
+const VISUALS_RULE = "mcp__visuals";
+
 // The orchestrator's MCP server and the names Claude sees its tools by.
 export const ORCHESTRATOR_SERVER = "agentos";
 
@@ -77,6 +80,8 @@ export const ORCHESTRATOR_PERMISSIONS: {
     "NotebookEdit",
     "ToolSearch",
     "TodoWrite",
+    // html_preview and html_render: a page for Saad to read or share.
+    VISUALS_RULE,
     // Anything; its worker refuses the deny list (shell-guard.ts).
     "Bash",
   ],

package/lib/share/view.ts

@@ -0,0 +1,123 @@
+// Pure share logic: wire types and helpers. Imports nothing outside itself so
+// the native app can sync it (scripts/sync-shared).
+
+export type ShareExpiry = "1d" | "7d" | "30d" | "never";
+
+export interface ShareTarget {
+  kind: "chat" | "artifact";
+  sessionId?: string;
+  artifactId?: string;
+}
+
+export interface PreviewRequest extends ShareTarget {
+  includeTools: boolean;
+  /** Messages left out of the share. */
+  dropIds?: string[];
+}
+
+export interface PreviewItem {
+  id: string;
+  type: string;
+  tools: boolean;
+  excerpt: string;
+}
+
+export interface SharePreview {
+  html: string;
+  title: string;
+  bytes: number;
+  hash: string;
+  sharedAt: string;
+  items: PreviewItem[];
+  hits: Record<"secret" | "path" | "ip" | "host" | "email", number>;
+  tooBig: boolean;
+  connectLinked: boolean;
+}
+
+export interface SharedLinkRow {
+  id: string;
+  url: string;
+  kind: "chat" | "artifact";
+  title: string;
+  sessionId: string | null;
+  artifactId: string | null;
+  createdAt: string;
+  expiresAt: string | null;
+  status: "active" | "expired" | "revoked";
+  views: number | null;
+  lastViewedAt: string | null;
+}
+
+export interface SharesResponse {
+  connect: "ok" | "unavailable" | "unlinked";
+  shares: SharedLinkRow[];
+}
+
+export interface CreatedShare {
+  id: string;
+  url: string;
+  expiresAt: string | null;
+}
+
+export const EXPIRIES: ShareExpiry[] = ["1d", "7d", "30d", "never"];
+export const DEFAULT_EXPIRY: ShareExpiry = "7d";
+
+export const EXPIRY_LABEL: Record<ShareExpiry, string> = {
+  "1d": "1 day",
+  "7d": "7 days",
+  "30d": "30 days",
+  never: "Never",
+};
+
+export const TYPE_LABEL: Record<string, string> = {
+  user: "You",
+  assistant: "Agent",
+  plan: "Plan",
+  error: "Error",
+  divider: "Divider",
+  artifact: "Page",
+  detail: "Tool",
+};
+
+const PLURAL: Record<keyof SharePreview["hits"], [string, string]> = {
+  secret: ["secret", "secrets"],
+  path: ["path", "paths"],
+  ip: ["address", "addresses"],
+  host: ["host", "hosts"],
+  email: ["email", "emails"],
+};
+
+/** "Masked: 3 secrets, 12 paths", or "" when nothing was. */
+export function redactionSummary(hits: SharePreview["hits"]): string {
+  const parts = (Object.keys(PLURAL) as (keyof typeof PLURAL)[])
+    .filter((k) => hits[k] > 0)
+    .map((k) => `${hits[k]} ${PLURAL[k][hits[k] === 1 ? 0 : 1]}`);
+  return parts.length ? `Masked: ${parts.join(", ")}` : "";
+}
+
+export function formatBytes(n: number): string {
+  if (n < 1024) return `${n} bytes`;
+  if (n < 1024 * 1024) return `${(n / 1024).toFixed(1)} KB`;
+  return `${(n / 1024 / 1024).toFixed(1)} MB`;
+}
+
+/** A file name for a download: the title, plain, with .html. */
+export function fileName(title: string): string {
+  const slug = title
+    .toLowerCase()
+    .replace(/[^a-z0-9]+/g, "-")
+    .replace(/^-+|-+$/g, "")
+    .slice(0, 60);
+  return `${slug || "shared"}.html`;
+}
+
+export function toggleDrop(dropped: string[], id: string): string[] {
+  return dropped.includes(id)
+    ? dropped.filter((x) => x !== id)
+    : [...dropped, id];
+}
+
+/** True when every listed item is dropped. Ids of items no longer listed (tool rows hidden by turning tools off) don't count. */
+export function nothingLeft(items: PreviewItem[], dropped: string[]): boolean {
+  return items.every((i) => dropped.includes(i.id));
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saadnvd1/agent-os",
-  "version": "0.3.565",
+  "version": "0.3.567",
   "description": "Self-hosted web UI for managing Claude Code sessions",
   "bin": {
     "agent-os": "scripts/agent-os"

package/components/Share/format.test.ts

@@ -1,20 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { fileName, formatBytes, redactionSummary } from "./format";
-
-describe("share format", () => {
-  it("summarises what was masked, singular and plural", () => {
-    const none = { secret: 0, path: 0, ip: 0, host: 0, email: 0 };
-    expect(redactionSummary(none)).toBe("");
-    expect(redactionSummary({ ...none, secret: 1, path: 12 })).toBe(
-      "Masked: 1 secret, 12 paths"
-    );
-  });
-  it("names the download after the title", () => {
-    expect(fileName("My chat: part 2!")).toBe("my-chat-part-2.html");
-    expect(fileName("???")).toBe("shared.html");
-  });
-  it("sizes", () => {
-    expect(formatBytes(500)).toBe("500 bytes");
-    expect(formatBytes(2048)).toBe("2.0 KB");
-  });
-});

package/components/Share/format.ts

@@ -1,33 +0,0 @@
-import type { SharePreview } from "@/data/shares";
-
-const PLURAL: Record<keyof SharePreview["hits"], [string, string]> = {
-  secret: ["secret", "secrets"],
-  path: ["path", "paths"],
-  ip: ["address", "addresses"],
-  host: ["host", "hosts"],
-  email: ["email", "emails"],
-};
-
-/** "Masked: 3 secrets, 12 paths", or "" when nothing was. */
-export function redactionSummary(hits: SharePreview["hits"]): string {
-  const parts = (Object.keys(PLURAL) as (keyof typeof PLURAL)[])
-    .filter((k) => hits[k] > 0)
-    .map((k) => `${hits[k]} ${PLURAL[k][hits[k] === 1 ? 0 : 1]}`);
-  return parts.length ? `Masked: ${parts.join(", ")}` : "";
-}
-
-export function formatBytes(n: number): string {
-  if (n < 1024) return `${n} bytes`;
-  if (n < 1024 * 1024) return `${(n / 1024).toFixed(1)} KB`;
-  return `${(n / 1024 / 1024).toFixed(1)} MB`;
-}
-
-/** A file name for a download: the title, plain, with .html. */
-export function fileName(title: string): string {
-  const slug = title
-    .toLowerCase()
-    .replace(/[^a-z0-9]+/g, "-")
-    .replace(/^-+|-+$/g, "")
-    .slice(0, 60);
-  return `${slug || "shared"}.html`;
-}