@saadnvd1/agent-os 0.3.539 → 0.3.542

package/components/SessionList/SessionList.types.ts

@@ -12,6 +12,7 @@ export interface SessionStatus {
   unread?: boolean;
   stalled?: boolean;
   compacting?: { since: number; before?: number };
+  background?: number;
   prStage?: PrStage;
 }
 

package/components/SessionList/SessionShelves.tsx

@@ -86,7 +86,7 @@ export function MachineShelves({ groups }: { groups: MachineGroup[] }) {
 }
 
 // The pinned orchestrator (or a row to start one), then Pinned, Needs you,
-// Working, Queued and Done: once for the whole list.
+// Working, In review, Queued and Done: once for the whole list.
 export function SessionShelves({
   shelves,
   queued,
@@ -136,6 +136,13 @@ export function SessionShelves({
           ))}
         </Shelf>
       )}
+      {shelves.inReview.length > 0 && (
+        <Shelf label="In review" count={shelves.inReview.length}>
+          {shelves.inReview.map((r) => (
+            <SessionRow key={r.session.id} row={r} />
+          ))}
+        </Shelf>
+      )}
       {queued.length > 0 && (
         <Shelf label="Queued" count={queued.length}>
           {queued.map((r) => (

package/components/SessionList/SidebarBody.tsx

@@ -65,6 +65,7 @@ export function SidebarBody({
     shelves.pinned.length +
     shelves.needsYou.length +
     shelves.working.length +
+    shelves.inReview.length +
     data.queued.length +
     shelves.done.length +
     data.machines.length;

package/components/SessionList/index.tsx

@@ -31,7 +31,7 @@ const flatten = (rows: SidebarRow[]): string[] =>
   rows.flatMap((r) => [r.session.id, ...flatten(r.workers)]);
 
 // One flat list of the workspace's sessions, on shelves: Pinned, Needs
-// you, Working, Done.
+// you, Working, In review, Done.
 export function SessionList({
   activeSessionId,
   sessionStatuses,
@@ -62,6 +62,7 @@ export function SessionList({
         ...shelves.pinned,
         ...shelves.needsYou,
         ...shelves.working,
+        ...shelves.inReview,
         ...shelves.done,
         ...data.machines.flatMap((g) => g.rows),
       ]),

package/lib/db/queries.ts

@@ -33,7 +33,7 @@ export function sessionListColumns(db: Database.Database, alias = ""): string {
     .map((c) => `${prefix}${c}`)
     .join(", ");
   // The recipe run or feature piece a session is, as JSON, for its row's chip.
-  const recipe = `(SELECT json_object('id', r.id, 'name', r.name, 'seq', rr.seq) FROM recipe_runs rr JOIN recipes r ON r.id = rr.recipe_id WHERE rr.session_id = ${alias || "sessions"}.id)`;
+  const recipe = `(SELECT json_object('id', r.id, 'name', r.name, 'seq', rr.seq, 'status', rr.status) FROM recipe_runs rr JOIN recipes r ON r.id = rr.recipe_id WHERE rr.session_id = ${alias || "sessions"}.id)`;
   const piece = `(SELECT json_object('feature', f.id, 'name', f.name, 'position', fp.position, 'total', (SELECT COUNT(*) FROM feature_pieces WHERE feature_id = f.id AND status != 'dropped')) FROM feature_pieces fp JOIN features f ON f.id = fp.feature_id WHERE fp.session_id = ${alias || "sessions"}.id)`;
   return `${list}, (${prefix}task_brief IS NOT NULL AND ${prefix}task_brief != '') AS has_brief, ${recipe} AS recipe_run, ${piece} AS feature_piece`;
 }

package/lib/orchestrator/events.ts

@@ -148,6 +148,7 @@ export function recordConditions(
     db.prepare(
       `DELETE FROM orchestrator_events WHERE workspace_id = ? AND (
          (subject IS NOT NULL
+           AND NOT (key LIKE '${ONCE}%' AND delivered_at IS NULL)
            AND subject NOT IN (SELECT id FROM sessions)
            AND subject NOT IN (SELECT id FROM stack_items)
            AND subject NOT IN (SELECT id FROM stacks))

package/lib/recipes/settle.ts

@@ -194,7 +194,7 @@ function tell(
   queueEvent(
     run.recipe.workspace_id,
     `recipe:${run.id}:${status}`,
-    run.recipe.name,
+    run.session_id,
     `Recipe "${run.recipe.name}" run #${run.seq} ${bad ? status.replace("_", " ") : "finished ok"}${reported ? `: ${untrusted(run.recipe.name, reported)}` : "."}${pr}`
   );
 }

package/lib/security/auth.ts

@@ -54,7 +54,7 @@ const TAILSCALE_V4 = /^100\.(6[4-9]|[7-9]\d|1[01]\d|12[0-7])\./;
 const LOOPBACK = new Set(["127.0.0.1", "::1"]);
 const LOOPBACK_HOSTS = new Set(["localhost", "127.0.0.1", "::1"]);
 // A proxy must send one of these, or it looks like this machine itself.
-// Proxies that send none need AGENTOS_AUTH, see README "Security".
+// Proxies that send none need AGENTOS_AUTH, see docs/reference/security.md.
 const FORWARDING = new Set([
   "forwarded",
   "via",

package/lib/sidebar/machines.ts

@@ -40,7 +40,13 @@ export function machineGroups(
       return {
         hostId,
         name,
-        rows: [...s.pinned, ...s.needsYou, ...s.working, ...s.done],
+        rows: [
+          ...s.pinned,
+          ...s.needsYou,
+          ...s.working,
+          ...s.inReview,
+          ...s.done,
+        ],
       };
     })
     .filter((g) => g.rows.length > 0)

package/lib/sidebar/rollup.ts

@@ -30,6 +30,7 @@ export function rollups(
     ...shelves.pinned,
     ...shelves.needsYou,
     ...shelves.working,
+    ...shelves.inReview,
     ...shelves.done,
   ]);
   for (const row of rows) {

package/lib/sidebar/shelves.ts

@@ -1,9 +1,9 @@
 // The sidebar's one flat list, sorted onto shelves: the workspace's pinned
-// orchestrator, Pinned, Needs you, Working, then Done. Client-safe: no database.
+// orchestrator, Pinned, Needs you, Working, In review, then Done. Client-safe: no database.
 import type { Session } from "@/lib/db/types";
 import { fromSqliteTime } from "@/lib/session-meta";
 import type { PrStage } from "@/lib/tasks/pr-stage";
-import type { TaskState } from "@/lib/tasks/state";
+import { isFinished, type TaskState } from "@/lib/tasks/state";
 
 // Why a session is blocked on you.
 export type SessionNeed =
@@ -33,6 +33,8 @@ export interface RowStatus {
   stalled?: boolean;
   // A chat summarising its context (status stays "running").
   compacting?: { since: number; before?: number };
+  // Background commands, subagents and monitors still running.
+  background?: number;
   asks?: number;
   prStage?: PrStage;
   // A program's own message (OSC 7501): untrusted, plain text only.
@@ -61,6 +63,7 @@ export interface Shelves {
   pinned: SidebarRow[];
   needsYou: SidebarRow[];
   working: SidebarRow[];
+  inReview: SidebarRow[];
   done: SidebarRow[];
 }
 
@@ -70,6 +73,17 @@ export function taskNeed(state: TaskState | undefined): SessionNeed | null {
   return null;
 }
 
+// Where a row that needs nothing and isn't running goes: an open PR or a plan
+// waiting on approval is in review, any other unfinished task is mid-job, and
+// only finished work or a plain idle session is done.
+export function quietShelf(
+  task: TaskState | undefined
+): "inReview" | "working" | "done" {
+  if (task === "review" || task === "plan-ready") return "inReview";
+  if (!task || isFinished(task)) return "done";
+  return "working";
+}
+
 // An approval or a question beats what the task says; a terminal waiting
 // for input or an errored chat only counts when the task has nothing.
 export function needOf(
@@ -118,6 +132,20 @@ const newestFirst = (a: SidebarRow, b: SidebarRow) =>
 const oldestFirst = (a: SidebarRow, b: SidebarRow) =>
   a.session.created_at.localeCompare(b.session.created_at);
 
+const OPEN_RUN = ["queued", "starting", "running"];
+
+// A recipe run that hasn't reported its result yet: its session going quiet
+// between turns (an EAS build running in the background, say) isn't it ending.
+// The list query carries the run as JSON.
+export function recipeRunOpen(session: Pick<Session, "recipe_run">): boolean {
+  if (!session.recipe_run) return false;
+  try {
+    return OPEN_RUN.includes(JSON.parse(session.recipe_run)?.status);
+  } catch {
+    return false;
+  }
+}
+
 function toRow(input: ShelfInput, session: Session): SidebarRow {
   const status = input.statuses[session.id];
   return {
@@ -125,7 +153,10 @@ function toRow(input: ShelfInput, session: Session): SidebarRow {
     status,
     need: needOf(session, status, input.tasks[session.id]),
     unread: !!status?.unread,
-    working: status?.status === "running",
+    working:
+      status?.status === "running" ||
+      (status?.background ?? 0) > 0 ||
+      recipeRunOpen(session),
     compacting: !!status?.compacting,
     workers: [],
     task: input.tasks[session.id],
@@ -169,6 +200,7 @@ export function buildShelves(input: ShelfInput): Shelves {
     pinned: [],
     needsYou: [],
     working: [],
+    inReview: [],
     done: [],
   };
   for (const row of top) {
@@ -178,12 +210,13 @@ export function buildShelves(input: ShelfInput): Shelves {
     else if (pinned && role !== "orchestrator") shelves.pinned.push(row);
     else if (row.need) shelves.needsYou.push(row);
     else if (row.working) shelves.working.push(row);
-    else shelves.done.push(row);
+    else shelves[quietShelf(row.task)].push(row);
   }
   shelves.orchestrators.sort(oldestFirst);
   shelves.pinned.sort(oldestFirst);
   shelves.needsYou.sort(newestFirst);
   shelves.working.sort(newestFirst);
+  shelves.inReview.sort(newestFirst);
   shelves.done.sort(newestFirst);
   return shelves;
 }
@@ -265,6 +298,7 @@ function sameStatus(a: RowStatus | undefined, b: RowStatus | undefined) {
     !!a.stalled === !!b.stalled &&
     (a.compacting?.since ?? null) === (b.compacting?.since ?? null) &&
     (a.compacting?.before ?? null) === (b.compacting?.before ?? null) &&
+    (a.background ?? 0) === (b.background ?? 0) &&
     a.asks === b.asks &&
     (a.prStage?.stage ?? null) === (b.prStage?.stage ?? null) &&
     (a.prStage?.number ?? null) === (b.prStage?.number ?? null) &&

package/lib/status/collect.ts

@@ -26,7 +26,7 @@ import { noteWaiting } from "../notify/push/waiting";
 import { getDb } from "../db";
 import { beginPass, chatMemo } from "./incremental";
 import { chatCompacting, chatState } from "../chat/runner";
-import { chatActivityLine, chatStall } from "../chat/activity";
+import { chatActivity, chatActivityLine, chatStall } from "../chat/activity";
 import {
   chatNeed,
   isUnread,
@@ -72,6 +72,8 @@ export interface SessionStatusResponse {
   stalled?: boolean;
   // A chat whose agent is summarising its context ("status" stays running).
   compacting?: Compacting;
+  // Background commands, subagents and monitors a chat still has running.
+  background?: number;
   // Where a task's PR is in the gates (lib/tasks/pr-stage.ts).
   prStage?: PrStage;
   // A program's own message (OSC 7501): untrusted, plain text only.
@@ -474,6 +476,7 @@ async function collect(full = false): Promise<StatusSnapshot> {
     (s) => s.view === "chat" && (!s.host_id || s.host_id === "local")
   )) {
     const state = chatState(session.id);
+    const background = chatActivity(session.id)?.background;
     const orchestrator = session.role === "orchestrator";
     // What the database says; the rest below moves with time or the process.
     const base = chatMemo(pass, session.id, orchestrator, state ?? "", () => {
@@ -498,6 +501,7 @@ async function collect(full = false): Promise<StatusSnapshot> {
       ...(chatCompacting(session.id) && {
         compacting: chatCompacting(session.id)!,
       }),
+      ...(background && { background }),
       ...(orchestrator && { asks: base.asks }),
     };
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saadnvd1/agent-os",
-  "version": "0.3.539",
+  "version": "0.3.542",
   "description": "Self-hosted web UI for managing Claude Code sessions",
   "bin": {
     "agent-os": "scripts/agent-os"

package/scripts/docs-links.test.ts

@@ -0,0 +1,160 @@
+import { execFileSync } from "node:child_process";
+import fs from "node:fs";
+import path from "node:path";
+import { describe, expect, it } from "vitest";
+
+const root = path.resolve(__dirname, "..");
+const REPO = "saadnvd1/agent-os";
+
+function slug(heading: string): string {
+  return heading
+    .trim()
+    .toLowerCase()
+    .replace(/[`*]/g, "")
+    .replace(/[^\w\- ]/g, "")
+    .replace(/ /g, "-");
+}
+
+function headingSlugs(text: string): Set<string> {
+  const seen = new Map<string, number>();
+  const out = new Set<string>();
+  let fence = false;
+  for (const line of text.split("\n")) {
+    if (line.startsWith("```")) fence = !fence;
+    const m = !fence && /^#+ (.*)$/.exec(line);
+    if (!m) continue;
+    const base = slug(m[1]);
+    const n = seen.get(base) ?? 0;
+    seen.set(base, n + 1);
+    out.add(n ? `${base}-${n}` : base);
+  }
+  return out;
+}
+
+function markdownFiles(): string[] {
+  const out = execFileSync(
+    "git",
+    ["ls-files", "--", "README.md", "docs/*.md", "docs/**/*.md"],
+    { cwd: root, encoding: "utf8" }
+  );
+  return out.split("\n").filter(Boolean);
+}
+
+/** Link targets with their line numbers, skipping code. */
+function targets(text: string): { line: number; target: string }[] {
+  const found: { line: number; target: string }[] = [];
+  let fence = false;
+  text.split("\n").forEach((raw, i) => {
+    if (raw.startsWith("```")) fence = !fence;
+    if (fence) return;
+    const line = raw.replace(/`[^`]*`/g, "");
+    for (const m of line.matchAll(/\]\(([^)\s]+)\)/g))
+      found.push({ line: i + 1, target: m[1] });
+    for (const m of line.matchAll(/(?:src|srcset)="([^"]+)"/g))
+      found.push({ line: i + 1, target: m[1] });
+  });
+  return found;
+}
+
+/** A repo path inside a link to this repository on github.com, if it is one. */
+function repoPath(target: string): string | null {
+  const m = new RegExp(
+    `^https://(?:github\\.com/${REPO}(?:/(?:blob|tree)/main)?|raw\\.githubusercontent\\.com/${REPO}/main)/?(.*)$`
+  ).exec(target);
+  return m ? m[1] : null;
+}
+
+function readTracked(rel: string): string | null {
+  const file = path.join(root, rel.replace(/\/$/, ""));
+  if (!fs.existsSync(file) || fs.statSync(file).isDirectory()) return null;
+  return fs.readFileSync(file, "utf8");
+}
+
+describe("slug", () => {
+  it("follows GitHub's anchors", () => {
+    expect(slug("Project config (`agentos.json`)")).toBe(
+      "project-config-agentosjson"
+    );
+    expect(slug("Windows (WSL2)")).toBe("windows-wsl2");
+  });
+});
+
+describe("markdown docs", () => {
+  const files = markdownFiles();
+
+  it("have links that resolve", () => {
+    const broken: string[] = [];
+    for (const file of files) {
+      const text = fs.readFileSync(path.join(root, file), "utf8");
+      const own = headingSlugs(text);
+      const inGuides = file.startsWith("docs/guides/");
+      for (const { line, target } of targets(text)) {
+        const at = `${file}:${line} -> ${target}`;
+        if (target.startsWith("mailto:")) continue;
+        let rel: string | null;
+        let anchor = "";
+        if (target.startsWith("#")) {
+          if (!own.has(target.slice(1))) broken.push(at);
+          continue;
+        }
+        if (/^https?:/.test(target)) {
+          const hash = target.indexOf("#");
+          const url = hash < 0 ? target : target.slice(0, hash);
+          anchor = hash < 0 ? "" : target.slice(hash + 1);
+          rel = repoPath(url);
+          if (rel === null) continue;
+          if (rel === "") rel = "README.md";
+        } else {
+          const [p, a = ""] = target.split("#");
+          anchor = a;
+          rel = path.posix.normalize(
+            path.posix.join(path.posix.dirname(file), p)
+          );
+          if (
+            inGuides &&
+            !rel.startsWith("docs/guides/") &&
+            !p.startsWith("http")
+          )
+            broken.push(`${at} (guides are published alone; link by full URL)`);
+        }
+        const abs = path.join(root, rel.replace(/\/$/, ""));
+        if (!fs.existsSync(abs)) {
+          broken.push(at);
+          continue;
+        }
+        if (anchor && rel.endsWith(".md")) {
+          const dest = readTracked(rel);
+          if (dest === null || !headingSlugs(dest).has(anchor)) broken.push(at);
+        }
+      }
+    }
+    expect(broken).toEqual([]);
+  });
+
+  it("keep guide front matter complete, with unique order", () => {
+    const orders = new Map<string, string>();
+    const problems: string[] = [];
+    for (const file of files) {
+      if (!file.startsWith("docs/guides/") || file.endsWith("README.md"))
+        continue;
+      const text = fs.readFileSync(path.join(root, file), "utf8");
+      const fm = /^---\n([\s\S]*?)\n---\n/.exec(text)?.[1] ?? "";
+      for (const key of ["title", "description"])
+        if (!new RegExp(`^${key}: .+`, "m").test(fm))
+          problems.push(`${file}: missing ${key}`);
+      const order = /^order: (\d+)$/m.exec(fm)?.[1];
+      if (!order) problems.push(`${file}: missing numeric order`);
+      else if (orders.has(order))
+        problems.push(`${file}: order ${order} also in ${orders.get(order)}`);
+      else orders.set(order, file);
+    }
+    expect(problems).toEqual([]);
+  });
+
+  it("keeps the README a front page", () => {
+    const lines = fs
+      .readFileSync(path.join(root, "README.md"), "utf8")
+      .split("\n").length;
+    expect(lines).toBeLessThan(250);
+  });
+});