@ryuenn3123/agentic-senior-core 6.5.1 → 6.5.3

package/.agents/plugins/agentic-senior-core/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-senior-core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "description": "Universal AI coding rules. Write code like a staff engineer.",
   "skills": "./skills/",
   "hooks": "./hooks/hooks.json",

package/.agents/plugins/agentic-senior-core/hooks/dedup-gate.js

@@ -116,18 +116,20 @@ process.stdin.on('data', chunk => {
     const config = loadDedupConfig();
     if (!isQualifyingEdit(toolName, toolInput, config)) { process.exit(0); return; }
 
+    if (hasValidInlineIgnore(filePath)) { process.exit(0); return; }
+
     const scanDir = resolveScanDir(filePath, config);
     const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'asc-dedup-'));
 
     const ignoreFlags = (config.ignoreDirs || []).map(function (d) { return '--ignore "' + d + '"'; }).join(' ');
-    const minTokens = config.minTokens || 50;
+    const minTokens = config.minTokens || 30;
     const scanCmd = ' "' + scanDir + '" --min-tokens ' + minTokens
       + ' --reporters json --silent --output "' + tmpDir + '" ' + ignoreFlags;
 
     const report = runJscpdScan(scanCmd, tmpDir);
     if (!report) { cleanup(tmpDir); process.exit(0); return; }
 
-    const finding = checkForDuplicates(report, filePath);
+    const finding = checkForDuplicates(report, filePath, config);
     if (!finding) { cleanup(tmpDir); process.exit(0); return; }
 
     const nudge = '[ASC Dedup] ' + path.basename(filePath) + ' looks similar to '
@@ -260,7 +262,7 @@ function loadDedupConfig() {
   }
   return {
     mode: 'advisory',
-    minTokens: 50,
+    minTokens: 30,
     ignoreDirs: [
       'tests', 'test', '__tests__', 'migrations', 'generated', 'node_modules',
       'dist', 'build', '.next', '.nuxt', '.expo', 'coverage', '.storybook',
@@ -298,10 +300,44 @@ function loadReport(tmpDir) {
   }
 }
 
-function checkForDuplicates(report, filePath) {
+function hasValidInlineIgnore(filePath) {
+  try {
+    if (!fs.existsSync(filePath)) return false;
+    var content = fs.readFileSync(filePath, 'utf8');
+    if (content.indexOf('jscpd:ignore-start') !== -1) return true;
+    var match = content.match(/asc-dedup:ignore\s*--\s*(.+)/i);
+    return Boolean(match && match[1] && match[1].trim().length > 0);
+  } catch (_) {
+    return false;
+  }
+}
+
+function isAllowedDuplicate(fileA, fileB, allowedDuplicates) {
+  if (!Array.isArray(allowedDuplicates) || allowedDuplicates.length === 0) return false;
+  var normA = path.resolve(fileA).replace(/\\/g, '/').toLowerCase();
+  var normB = path.resolve(fileB).replace(/\\/g, '/').toLowerCase();
+  var baseA = path.basename(fileA).toLowerCase();
+  var baseB = path.basename(fileB).toLowerCase();
+
+  for (var i = 0; i < allowedDuplicates.length; i++) {
+    var pair = allowedDuplicates[i];
+    if (!Array.isArray(pair) || pair.length < 2) continue;
+    var p0Norm = path.resolve(pair[0]).replace(/\\/g, '/').toLowerCase();
+    var p1Norm = path.resolve(pair[1]).replace(/\\/g, '/').toLowerCase();
+    var p0Base = path.basename(pair[0]).toLowerCase();
+    var p1Base = path.basename(pair[1]).toLowerCase();
+
+    if ((normA === p0Norm && normB === p1Norm) || (normA === p1Norm && normB === p0Norm)) return true;
+    if ((baseA === p0Base && baseB === p1Base) || (baseA === p1Base && baseB === p0Base)) return true;
+  }
+  return false;
+}
+
+function checkForDuplicates(report, filePath, config) {
   var duplicates = report.duplicates || [];
   if (duplicates.length === 0) return null;
 
+  var allowedDuplicates = config && config.allowedDuplicates;
   var normalizedTarget = path.resolve(filePath).replace(/\\/g, '/').toLowerCase();
   var targetBasename = path.basename(filePath);
 
@@ -314,6 +350,10 @@ function checkForDuplicates(report, filePath) {
       var otherRaw = firstName === normalizedTarget ? dup.secondFile.name : dup.firstFile.name;
       var otherBasename = path.basename(otherRaw);
 
+      if (isAllowedDuplicate(filePath, otherRaw, allowedDuplicates)) {
+        continue;
+      }
+
       // Skip framework-conventional filenames in different directories — identical names
       // are mandated by the framework (e.g. Next.js page.tsx, Angular *.component.ts),
       // not copy-paste duplication.
@@ -327,9 +367,19 @@ function checkForDuplicates(report, filePath) {
       var cwd = process.cwd();
       var matchedFile = path.relative(cwd, path.resolve(otherRaw)).replace(/\\/g, '/');
       var lines = dup.lines || 0;
-      // jscpd v5 reports fragments; estimate overlap percentage from line count
-      var totalLines = (report.statistics && report.statistics.total && report.statistics.total.lines) || 1;
-      var percent = Math.round((lines / totalLines) * 100);
+      var totalFileLines = 1;
+      try {
+        totalFileLines = fs.readFileSync(path.resolve(filePath), 'utf8').split('\n').length || 1;
+      } catch (_) {
+        totalFileLines = dup.firstFile.lines || dup.secondFile.lines || lines || 1;
+      }
+      var percent = Math.round((lines / totalFileLines) * 100);
+
+      // Skip trivial matches (import boilerplate, small overlaps)
+      if (lines < 10 && percent < 10) {
+        continue;
+      }
+
       return { matchedFile: matchedFile, lines: lines, percent: percent };
     }
   }

package/.agents/plugins/agentic-senior-core/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-senior-core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "description": "Universal AI coding rules. Because your AI writes code like it gets paid by the line.",
   "contextFileName": "rules/agentic-senior-core.md",
   "rules": [

package/.asc/dedup-config.json

@@ -1,7 +1,8 @@
 {
   "mode": "advisory",
-  "minTokens": 50,
+  "minTokens": 30,
   "scanRoot": null,
+  "allowedDuplicates": [],
   "ignoreDirs": [
     "tests", "test", "__tests__", "migrations", "generated", "node_modules",
     "dist", "build", ".next", ".nuxt", ".expo", "coverage", ".storybook",

package/gemini-extension.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-senior-core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "description": "Universal AI coding rules. Write code like a staff engineer.",
   "author": "fatidaprilian",
   "license": "MIT",

package/lib/cli/commands/git-hook-generator.mjs

@@ -27,6 +27,84 @@ const SOURCE_EXTENSIONS = new Set([${extensionsList}]);
 
 const JSCPD_TIMEOUT_MS = 10000;
 
+// Framework-conventional filenames that MUST be identical across directories by design.
+const FRAMEWORK_CONVENTIONAL_BASENAMES = new Set([
+  'page.tsx', 'page.jsx', 'page.ts', 'page.js',
+  'layout.tsx', 'layout.jsx', 'layout.ts', 'layout.js',
+  'loading.tsx', 'loading.jsx', 'loading.ts', 'loading.js',
+  'error.tsx', 'error.jsx', 'error.ts', 'error.js',
+  'not-found.tsx', 'not-found.jsx', 'not-found.ts', 'not-found.js',
+  'template.tsx', 'template.jsx', 'template.ts', 'template.js',
+  'route.tsx', 'route.ts', 'route.js',
+  'default.tsx', 'default.jsx', 'default.ts', 'default.js',
+  'root.tsx', 'root.jsx', 'root.ts', 'root.js',
+  'entry.server.tsx', 'entry.server.ts', 'entry.client.tsx', 'entry.client.ts',
+  '_layout.tsx', '_layout.jsx', '_layout.ts', '_layout.js',
+  'index.vue', 'app.vue',
+  '+page.svelte', '+layout.svelte', '+page.server.ts', '+page.server.js',
+  '+error.svelte', '+layout.server.ts', '+layout.server.js',
+  'index.ts', 'index.js', 'index.tsx', 'index.jsx',
+  'types.ts', 'types.d.ts',
+  'tailwind.config.ts', 'tailwind.config.js', 'tailwind.config.mjs',
+  'postcss.config.js', 'postcss.config.mjs', 'postcss.config.cjs',
+  'next.config.ts', 'next.config.js', 'next.config.mjs',
+  'vite.config.ts', 'vite.config.js', 'vite.config.mjs',
+  'tsconfig.json', 'jest.config.ts', 'jest.config.js', 'vitest.config.ts',
+]);
+
+const FRAMEWORK_CONVENTIONAL_SUFFIXES = [
+  '.component.ts', '.component.js', '.module.ts', '.service.ts',
+  '.pipe.ts', '.directive.ts', '.guard.ts', '.resolver.ts',
+  '.stories.tsx', '.stories.jsx', '.stories.ts', '.stories.js',
+  '.spec.ts', '.spec.tsx', '.spec.js', '.spec.jsx',
+  '.test.ts', '.test.tsx', '.test.js', '.test.jsx',
+];
+
+function isFrameworkConventional(basename) {
+  if (FRAMEWORK_CONVENTIONAL_BASENAMES.has(basename)) return true;
+  for (var i = 0; i < FRAMEWORK_CONVENTIONAL_SUFFIXES.length; i++) {
+    if (basename.endsWith(FRAMEWORK_CONVENTIONAL_SUFFIXES[i])) return true;
+  }
+  return false;
+}
+
+// Minimum blocking thresholds for Git pre-commit gate
+const MIN_BLOCKING_LINES = 15;
+const MIN_BLOCKING_PERCENT = 25;
+
+function hasValidInlineIgnore(filePath) {
+  try {
+    if (!fs.existsSync(filePath)) return false;
+    const content = fs.readFileSync(filePath, 'utf8');
+    if (content.includes('jscpd:ignore-start')) return true;
+    const match = content.match(/asc-dedup:ignore\\s*--\\s*(.+)/i);
+    return Boolean(match && match[1] && match[1].trim().length > 0);
+  } catch (_) {
+    return false;
+  }
+}
+
+function isAllowedDuplicate(fileA, fileB, allowedDuplicates) {
+  if (!Array.isArray(allowedDuplicates) || allowedDuplicates.length === 0) return false;
+  const normA = path.resolve(fileA).replace(/\\\\/g, '/').toLowerCase();
+  const normB = path.resolve(fileB).replace(/\\\\/g, '/').toLowerCase();
+  const baseA = path.basename(fileA).toLowerCase();
+  const baseB = path.basename(fileB).toLowerCase();
+
+  for (let i = 0; i < allowedDuplicates.length; i++) {
+    const pair = allowedDuplicates[i];
+    if (!Array.isArray(pair) || pair.length < 2) continue;
+    const p0Norm = path.resolve(pair[0]).replace(/\\\\/g, '/').toLowerCase();
+    const p1Norm = path.resolve(pair[1]).replace(/\\\\/g, '/').toLowerCase();
+    const p0Base = path.basename(pair[0]).toLowerCase();
+    const p1Base = path.basename(pair[1]).toLowerCase();
+
+    if ((normA === p0Norm && normB === p1Norm) || (normA === p1Norm && normB === p0Norm)) return true;
+    if ((baseA === p0Base && baseB === p1Base) || (baseA === p1Base && baseB === p0Base)) return true;
+  }
+  return false;
+}
+
 function getStagedFiles(cwd) {
   try {
     const output = execSync('git diff --cached --name-only --diff-filter=ACM', { encoding: 'utf8', cwd });
@@ -48,7 +126,14 @@ function loadDedupConfig(cwd) {
       }
     } catch (_) {}
   }
-  return { minTokens: 30, ignoreDirs: ['tests', 'migrations', 'generated', 'node_modules'] };
+  return {
+    minTokens: 30,
+    ignoreDirs: [
+      'tests', 'test', '__tests__', 'migrations', 'generated', 'node_modules',
+      'dist', 'build', '.next', '.nuxt', '.expo', 'coverage', '.storybook',
+      'prisma/migrations', 'android', 'ios',
+    ],
+  };
 }
 
 function runEslintAutoFix(cwd, stagedFiles) {
@@ -106,10 +191,11 @@ function loadReport(tmpDir) {
   }
 }
 
-function checkForDuplicates(report, stagedSourceFiles, cwd) {
+function checkForDuplicates(report, stagedSourceFiles, cwd, config) {
   const duplicates = report.duplicates || [];
   if (duplicates.length === 0) return null;
 
+  const allowedDuplicates = config && config.allowedDuplicates;
   const normalizedStagedMap = new Map();
   for (const f of stagedSourceFiles) {
     const norm = path.resolve(cwd, f).replace(/\\\\/g, '/').toLowerCase();
@@ -126,10 +212,45 @@ function checkForDuplicates(report, stagedSourceFiles, cwd) {
 
     if (isFirstStaged || isSecondStaged) {
       const stagedFile = isFirstStaged ? normalizedStagedMap.get(firstName) : normalizedStagedMap.get(secondName);
-      const matchedFile = isFirstStaged ? path.basename(dup.secondFile.name) : path.basename(dup.firstFile.name);
+      const otherRaw = isFirstStaged ? dup.secondFile.name : dup.firstFile.name;
+      const stagedPath = path.resolve(cwd, stagedFile);
+      const otherPath = path.resolve(cwd, otherRaw);
+
+      if (hasValidInlineIgnore(stagedPath) || hasValidInlineIgnore(otherPath)) {
+        continue;
+      }
+
+      if (isAllowedDuplicate(stagedPath, otherPath, allowedDuplicates)) {
+        continue;
+      }
+
+      const otherBasename = path.basename(otherRaw);
+      const stagedBasename = path.basename(stagedFile);
+
+      // Skip framework-conventional filenames in different directories
+      if (isFrameworkConventional(stagedBasename)
+          && isFrameworkConventional(otherBasename)
+          && path.dirname(stagedPath) !== path.dirname(otherPath)) {
+        continue;
+      }
+
       const lines = dup.lines || 0;
-      const totalLines = (report.statistics && report.statistics.total && report.statistics.total.lines) || 1;
-      const percent = Math.round((lines / totalLines) * 100);
+      // Calculate percent relative to the actual staged file size
+      let totalFileLines = 1;
+      try {
+        totalFileLines = fs.readFileSync(stagedPath, 'utf8').split('\\n').length || 1;
+      } catch (_) {
+        totalFileLines = dup.firstFile.lines || dup.secondFile.lines || lines || 1;
+      }
+      const percent = Math.round((lines / totalFileLines) * 100);
+
+      // Skip matches below blocking threshold
+      if (lines < MIN_BLOCKING_LINES || percent < MIN_BLOCKING_PERCENT) {
+        continue;
+      }
+
+      // Show relative path for actionable messages
+      const matchedFile = path.relative(cwd, otherPath).replace(/\\\\/g, '/');
       return { stagedFile, matchedFile, lines, percent };
     }
   }
@@ -185,8 +306,11 @@ function runPreCommitGate() {
   })));
 
   const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'asc-git-dedup-'));
-  const ignoreFlags = (config.ignoreDirs || ['tests', 'migrations', 'generated', 'node_modules'])
-    .map(d => \`--ignore "\${d}"\`).join(' ');
+  const ignoreFlags = (config.ignoreDirs || [
+    'tests', 'test', '__tests__', 'migrations', 'generated', 'node_modules',
+    'dist', 'build', '.next', '.nuxt', '.expo', 'coverage', '.storybook',
+    'prisma/migrations', 'android', 'ios',
+  ]).map(d => \`--ignore "\${d}"\`).join(' ');
   const minTokens = config.minTokens || 30;
 
   let finding = null;
@@ -195,7 +319,7 @@ function runPreCommitGate() {
     const scanCmd = \` "\${scanDir}" --min-tokens \${minTokens} --reporters json --silent --output "\${tmpDir}" \${ignoreFlags}\`;
     const report = runJscpdScan(scanCmd, cwd, tmpDir);
     if (report) {
-      finding = checkForDuplicates(report, currentStagedSource, cwd);
+      finding = checkForDuplicates(report, currentStagedSource, cwd, config);
       if (finding) break;
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ryuenn3123/agentic-senior-core",
-  "version": "6.5.1",
+  "version": "6.5.3",
   "type": "module",
   "description": "Agentic Senior Core: Universal AI coding rules and workflows. Write code like a staff engineer, not a junior.",
   "bin": {

package/plugin.yaml

@@ -1,5 +1,5 @@
 name: agentic-senior-core
-version: 6.5.1
+version: 6.5.3
 description: Universal AI coding rules. Write code like a staff engineer.
 author: fatidaprilian
 provides_hooks: