@ryuenn3123/agentic-senior-core 6.16.2 → 6.16.5

package/lib/cli/commands/global.mjs

@@ -184,7 +184,7 @@ async function ensureCodexConfigEnabled() {
 async function installCodexGlobal(target) {
   const rulesSource = path.join(REPOSITORY_ROOT, target.rulesSourcePath);
   const pluginSource = path.join(REPOSITORY_ROOT, target.pluginSourcePath);
-  const hooksSource = path.join(REPOSITORY_ROOT, '.agents', 'plugins', 'agentic-senior-core', 'hooks.json');
+  const hooksSource = path.join(REPOSITORY_ROOT, '.agents', 'plugins', 'agentic-senior-core', 'hooks', 'hooks.json');
   const singlePluginSource = path.join(REPOSITORY_ROOT, '.agents', 'plugins', 'agentic-senior-core');
   const rulesTarget = target.targetPath(); // ~/.codex/AGENTS.md
   const hooksTarget = path.join(HOME, '.codex', 'hooks.json');
@@ -372,9 +372,10 @@ async function installAntigravityIde(target) {
     'utf8'
   );
 
-  // Safely update/merge "agentic-senior-core" group key into global hooks.json (~/.gemini/config/hooks.json)
-  const masterHooksSource = path.join(REPOSITORY_ROOT, '.agents', 'plugins', 'agentic-senior-core', 'hooks.json');
-  await updateGlobalAntigravityHooks(masterHooksSource);
+  // Remove legacy global hooks.json entries (~/.gemini/config/hooks.json & ~/.gemini/antigravity-cli/hooks.json)
+  // because Antigravity executes hooks with cwd set to the directory containing hooks.json, and automatically
+  // discovers hooks.json inside ~/.gemini/config/plugins/agentic-senior-core/hooks.json without duplicate firing.
+  await cleanupLegacyGlobalAntigravityHooks();
 
   // Automatically register the plugin with Antigravity CLI if agy binary is available
   try {
@@ -389,44 +390,29 @@ async function installAntigravityIde(target) {
   return true;
 }
 
-async function updateGlobalAntigravityHooks(hooksSource) {
-  if (!(await pathExists(hooksSource))) return;
+async function cleanupLegacyGlobalAntigravityHooks() {
+  const globalHooksPath = path.join(HOME, '.gemini', 'config', 'hooks.json');
+  const legacyCliHooksPath = path.join(HOME, '.gemini', 'antigravity-cli', 'hooks.json');
 
-  try {
-    const rawMaster = JSON.parse(await fs.readFile(hooksSource, 'utf8'));
-    const masterHooks = rawMaster.hooks || rawMaster;
-
-    const formattedAscHooks = {
-      SessionStart: masterHooks.SessionStart || null,
-      PreInvocation: masterHooks.PreInvocation || null,
-      PostInvocation: masterHooks.PostInvocation || null,
-      Stop: masterHooks.Stop || null,
-      PreToolUse: masterHooks.PreToolUse || null,
-      PostToolUse: masterHooks.PostToolUse || null,
-    };
-
-    const targetPaths = [
-      path.join(HOME, '.gemini', 'config', 'hooks.json'),
-      path.join(HOME, '.gemini', 'antigravity-cli', 'hooks.json'),
-    ];
-
-    for (const targetPath of targetPaths) {
-      try {
-        await fs.mkdir(path.dirname(targetPath), { recursive: true });
-        let existingConfig = {};
-        if (await pathExists(targetPath)) {
-          try {
-            existingConfig = JSON.parse(await fs.readFile(targetPath, 'utf8'));
-          } catch (_) {}
-        }
-
-        // Safely merge "agentic-senior-core" key preserving other user keys (e.g. "well")
-        existingConfig['agentic-senior-core'] = formattedAscHooks;
+  if (await pathExists(legacyCliHooksPath)) {
+    try {
+      await fs.rm(legacyCliHooksPath, { force: true });
+    } catch (_) {}
+  }
 
-        await fs.writeFile(targetPath, JSON.stringify(existingConfig, null, 2) + '\n', 'utf8');
-      } catch (_) {}
-    }
-  } catch (_) {}
+  if (await pathExists(globalHooksPath)) {
+    try {
+      const existingConfig = JSON.parse(await fs.readFile(globalHooksPath, 'utf8'));
+      if (existingConfig && typeof existingConfig === 'object' && 'agentic-senior-core' in existingConfig) {
+        delete existingConfig['agentic-senior-core'];
+        if (Object.keys(existingConfig).length === 0) {
+          await fs.rm(globalHooksPath, { force: true });
+        } else {
+          await fs.writeFile(globalHooksPath, JSON.stringify(existingConfig, null, 2) + '\n', 'utf8');
+        }
+      }
+    } catch (_) {}
+  }
 }
 
 async function findAgyBinaryPath() {
@@ -509,7 +495,78 @@ async function installGlobalTarget(targetKey) {
   return true;
 }
 
-export async function runGlobalCommand(commandArguments) {
+export async function detectInstalledGlobalTargets() {
+  const isWin = process.platform === 'win32';
+  const { resolveWindowsExecutable } = await import('../ascx/windows-spawn.mjs');
+  const { execSync } = await import('node:child_process');
+
+  const hasBinary = (cmd) => {
+    if (isWin) {
+      return Boolean(resolveWindowsExecutable(cmd, process.env, process.cwd()));
+    }
+    try {
+      execSync(`command -v ${cmd}`, { stdio: 'ignore' });
+      return true;
+    } catch {
+      return false;
+    }
+  };
+
+  const checks = {
+    antigravity: async () => (await pathExists(path.join(HOME, '.gemini'))) || hasBinary('agy'),
+    codex: async () => (await pathExists(path.join(HOME, '.codex'))) || hasBinary('codex'),
+    opencode: async () => (await pathExists(path.join(HOME, '.config', 'opencode')))
+      || (await pathExists(path.join(HOME, '.opencode')))
+      || hasBinary('opencode'),
+    roo: async () => await pathExists(path.join(HOME, '.roo')),
+    kilocode: async () => (await pathExists(path.join(HOME, '.config', 'kilo')))
+      || (await pathExists(path.join(HOME, '.kilo')))
+      || (await pathExists(path.join(HOME, '.kilocode')))
+      || (process.env.APPDATA ? await pathExists(path.join(process.env.APPDATA, 'kilo')) : false)
+      || hasBinary('kilo'),
+    cline: async () => (await pathExists(path.join(HOME, '.cline')))
+      || (await pathExists(path.join(HOME, 'Documents', 'Cline'))),
+    kiro: async () => await pathExists(path.join(HOME, '.kiro')),
+    openhands: async () => (await pathExists(path.join(HOME, '.openhands'))) || hasBinary('openhands'),
+    windsurf: async () => (await pathExists(path.join(HOME, '.windsurf')))
+      || (await pathExists(path.join(HOME, '.codeium')))
+      || (isWin ? await pathExists(path.join(HOME, 'AppData', 'Roaming', 'Windsurf')) : false),
+    copilot: async () => (await pathExists(path.join(HOME, '.config', 'github-copilot')))
+      || (isWin ? await pathExists(path.join(HOME, 'AppData', 'Local', 'GitHub Copilot')) : false)
+      || (await pathExists(path.dirname(vscodeUserPromptsDirectory()))),
+  };
+
+  const detected = [];
+  for (const [key, check] of Object.entries(checks)) {
+    if (GLOBAL_TARGETS[key] && (await check())) {
+      detected.push(key);
+    }
+  }
+  return detected;
+}
+
+function printGlobalHelp() {
+  console.log('Agentic Senior Core -- Global Rules Installer\n');
+  console.log('Usage:');
+  console.log('  asc global              Auto-detect installed AI tools and install globally');
+  console.log('  asc global --all        Install to all supported global targets');
+  console.log('  asc global --<target>   Install to specific target(s)\n');
+  console.log('Supported automatic global targets:');
+  for (const [key, target] of Object.entries(GLOBAL_TARGETS)) {
+    console.log(`  --${key.padEnd(14)} ${target.label} (${target.note})`);
+  }
+  console.log('\nManual global setup tools:');
+  for (const manual of MANUAL_TARGETS) {
+    console.log(`  ${manual.label.padEnd(16)} ${manual.hint}`);
+  }
+}
+
+export async function runGlobalCommand(commandArguments = []) {
+  if (commandArguments.includes('--help') || commandArguments.includes('-h')) {
+    printGlobalHelp();
+    return;
+  }
+
   const requestedTargets = [];
 
   for (const argument of commandArguments) {
@@ -521,7 +578,11 @@ export async function runGlobalCommand(commandArguments) {
     const targetKey = argument.replace(/^--/, '');
     if (GLOBAL_TARGETS[targetKey]) {
       requestedTargets.push(targetKey);
-    } else if (argument.startsWith('--')) {
+    } else if (argument.startsWith('-')) {
+      console.error(`Unknown global target: ${argument}`);
+      console.log(`Available targets: ${Object.keys(GLOBAL_TARGETS).map(k => `--${k}`).join(', ')}, --all`);
+      process.exit(1);
+    } else {
       console.error(`Unknown global target: ${argument}`);
       console.log(`Available targets: ${Object.keys(GLOBAL_TARGETS).map(k => `--${k}`).join(', ')}, --all`);
       process.exit(1);
@@ -529,18 +590,13 @@ export async function runGlobalCommand(commandArguments) {
   }
 
   if (requestedTargets.length === 0) {
-    console.log('Agentic Senior Core -- Global Rules Installer\n');
-    console.log('Usage: asc global [--antigravity] [--codex] [--cline] [--roo] [--kilocode] [--opencode] [--kiro] [--openhands] [--windsurf] [--copilot] [--all]\n');
-    console.log('Installs user-level global rules that apply to ALL projects.\n');
-    console.log('Supported automatic global targets:');
-    for (const [key, target] of Object.entries(GLOBAL_TARGETS)) {
-      console.log(`  --${key.padEnd(14)} ${target.label} (${target.note})`);
-    }
-    console.log('\nManual global setup tools:');
-    for (const manual of MANUAL_TARGETS) {
-      console.log(`  ${manual.label.padEnd(16)} ${manual.hint}`);
+    const autoDetected = await detectInstalledGlobalTargets();
+    if (autoDetected.length === 0) {
+      printGlobalHelp();
+      return;
     }
-    process.exit(0);
+    console.log(`Auto-detected ${autoDetected.length} installed AI host(s): ${autoDetected.join(', ')}\n`);
+    requestedTargets.push(...autoDetected);
   }
 
   console.log('Installing global rules...\n');

package/lib/cli/commands/preview.mjs

@@ -6,8 +6,19 @@
 import fs from 'node:fs';
 import path from 'node:path';
 import os from 'node:os';
+import { pathToFileURL } from 'node:url';
 import { execSync } from 'node:child_process';
 
+function openInDefaultBrowser(targetPath) {
+  if (process.platform === 'win32') {
+    execSync(`cmd.exe /d /s /c "start "" "${targetPath}""`, { stdio: 'ignore' });
+  } else if (process.platform === 'darwin') {
+    execSync(`open "${targetPath}"`, { stdio: 'ignore' });
+  } else {
+    execSync(`xdg-open "${targetPath}"`, { stdio: 'ignore' });
+  }
+}
+
 export function getBrowserCandidates() {
   const platform = process.platform;
   const candidates = [];
@@ -161,9 +172,8 @@ export async function runPreviewCommand(args = []) {
 
   // Open in default OS browser if requested
   if (shouldOpen) {
-    const opener = process.platform === 'win32' ? 'start' : process.platform === 'darwin' ? 'open' : 'xdg-open';
     try {
-      execSync(`${opener} "" "${resolvedHtmlPath}"`, { stdio: 'ignore' });
+      openInDefaultBrowser(resolvedHtmlPath);
       console.log(`[asc preview] Opened in default browser: ${resolvedHtmlPath}`);
       return;
     } catch (err) {
@@ -175,20 +185,20 @@ export async function runPreviewCommand(args = []) {
   const browser = findBrowserExecutable();
   if (!browser) {
     console.warn('[asc preview] No supported headless browser detected (Brave, Edge, Chrome, Firefox). Falling back to OS opener.');
-    const opener = process.platform === 'win32' ? 'start' : process.platform === 'darwin' ? 'open' : 'xdg-open';
-    execSync(`${opener} "" "${resolvedHtmlPath}"`, { stdio: 'ignore' });
+    openInDefaultBrowser(resolvedHtmlPath);
     return;
   }
 
   try {
+    const fileUrl = pathToFileURL(resolvedHtmlPath).href;
     let command;
     if (browser.family === 'chromium') {
-      command = `"${browser.path}" --headless --disable-gpu --screenshot="${outputPng}" --window-size=${width},${height} "${resolvedHtmlPath}"`;
+      command = `"${browser.path}" --headless=new --disable-gpu --screenshot="${outputPng}" --window-size=${width},${height} "${fileUrl}"`;
     } else if (browser.family === 'firefox') {
-      command = `"${browser.path}" -headless -screenshot "${outputPng}" -window-size ${width},${height} "${resolvedHtmlPath}"`;
+      command = `"${browser.path}" -headless -screenshot "${outputPng}" -window-size ${width},${height} "${fileUrl}"`;
     }
 
-    execSync(command, { stdio: 'pipe' });
+    execSync(command, { stdio: 'pipe', timeout: 15000 });
 
     if (fs.existsSync(outputPng)) {
       const stat = fs.statSync(outputPng);
@@ -199,8 +209,7 @@ export async function runPreviewCommand(args = []) {
     }
   } catch (err) {
     console.warn(`[asc preview] Headless snapshot failed: ${err.message}. Falling back to OS opener.`);
-    const opener = process.platform === 'win32' ? 'start' : process.platform === 'darwin' ? 'open' : 'xdg-open';
-    execSync(`${opener} "" "${resolvedHtmlPath}"`, { stdio: 'ignore' });
+    openInDefaultBrowser(resolvedHtmlPath);
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ryuenn3123/agentic-senior-core",
-  "version": "6.16.2",
+  "version": "6.16.5",
   "type": "module",
   "description": "Agentic Senior Core: Universal AI coding rules and workflows. Write code like a staff engineer, not a junior.",
   "bin": {

package/plugin.yaml

@@ -1,5 +1,5 @@
 name: agentic-senior-core
-version: 6.16.2
+version: 6.16.5
 description: Universal AI coding rules. Write code like a staff engineer.
 author: fatidaprilian
 provides_hooks:
@@ -11,6 +11,7 @@ provides_commands:
   - asc-reference
   - asc-ui
   - asc-test
+  - asc-pentest
 provides_skills:
   - asc
   - asc-develop
@@ -18,3 +19,4 @@ provides_skills:
   - asc-review
   - asc-ui
   - asc-test
+  - asc-pentest