@ryuenn3123/agentic-senior-core 5.8.24 → 5.8.26

package/.agents/plugins/agentic-senior-core/hooks/post-edit-enforce.js

@@ -36,6 +36,10 @@ const SOURCE_EXTENSIONS = new Set([
 
 const LOC_DELTA_THRESHOLD = 30;
 const NEW_FILE_LINE_THRESHOLD = 50;
+const SESSION_DRIFT_THRESHOLD = 4;
+
+// Module-level counter for Claude Code path (resets per process spawn)
+let sourceEditCount = 0;
 
 let inputBuffer = '';
 process.stdin.setEncoding('utf8');
@@ -65,6 +69,8 @@ function handleAntigravityPostInvocation(data) {
     const lines = fs.readFileSync(data.transcriptPath, 'utf8').split('\n').filter(Boolean);
     const findings = [];
     
+    // Session drift check: count source file edits since initialNumSteps
+    let sourceEditsSinceStart = 0;
     for (let i = 0; i < lines.length; i++) {
       const step = JSON.parse(lines[i]);
       if (step.step_index >= data.initialNumSteps && step.type === 'PLANNER_RESPONSE' && step.tool_calls) {
@@ -89,6 +95,10 @@ function handleAntigravityPostInvocation(data) {
           }
           
           if (toolName) {
+            const fp = toolInput.file_path || '';
+            const ext = path.extname(fp).slice(1);
+            if (SOURCE_EXTENSIONS.has(ext)) sourceEditsSinceStart++;
+            
             processSingleEdit(toolName, toolInput, function(nudge) {
               findings.push(nudge);
             }, true);
@@ -97,6 +107,13 @@ function handleAntigravityPostInvocation(data) {
       }
     }
     
+    // Inject drift nudge if 4+ source files modified this invocation
+    if (sourceEditsSinceStart >= SESSION_DRIFT_THRESHOLD) {
+      findings.push('[ASC Session Drift] ' + sourceEditsSinceStart + ' source file edits this invocation. '
+        + 'Re-read the decision ladder before continuing: (1) Does this need to be built? '
+        + '(2) Does the codebase already have this? (3) Stdlib/native? (4) Existing dependency?');
+    }
+    
     if (findings.length > 0) {
       const injectSteps = findings.map(function(f) { return { ephemeralMessage: f }; });
       process.stdout.write(JSON.stringify({ injectSteps: injectSteps }) + '\n');
@@ -113,6 +130,17 @@ function processSingleEdit(toolName, toolInput, emitFn, skipArray) {
   if (!filePath) return;
   const findings = [];
 
+  // Increment per-process counter for Claude Code drift detection
+  const ext = path.extname(filePath).slice(1);
+  if (SOURCE_EXTENSIONS.has(ext)) {
+    sourceEditCount++;
+    if (sourceEditCount === SESSION_DRIFT_THRESHOLD) {
+      findings.push('[ASC Session Drift] ' + SESSION_DRIFT_THRESHOLD + '+ source file edits this session. '
+        + 'Re-read the decision ladder before continuing: (1) Does this need to be built? '
+        + '(2) Does the codebase already have this? (3) Stdlib/native? (4) Existing dependency?');
+    }
+  }
+
   if (filePath.endsWith('package.json')) {
     checkDependencyAddition(toolName, toolInput, findings);
   }

package/.agents/plugins/agentic-senior-core/hooks/pre-tool-dependency-gate.js

@@ -37,6 +37,29 @@ process.stdin.on('end', function () {
 
     if (isTerminal) {
       const command = toolInput.command || toolInput.CommandLine || toolInput.cmd || toolInput.commandLine || '';
+      
+      // Hard-block git commit/push unless explicitly allowed
+      if (isGitCommitOrPush(command)) {
+        const reason = '[ASC Hard-Block] git commit/push detected. Never run git commit, git push, or git push --force unless the user explicitly requests it this turn.';
+        let output;
+        if (isAntigravity) {
+          output = { decision: "deny", reason: reason };
+        } else {
+          output = {
+            allow_tool: false,
+            deny_reason: reason,
+            hookSpecificOutput: {
+              hookEventName: 'PreToolUse',
+              permissionDecision: 'deny',
+              permissionDecisionReason: reason
+            }
+          };
+        }
+        process.stdout.write(JSON.stringify(output) + '\n');
+        process.exit(2);
+        return;
+      }
+      
       added = extractCommandDeps(command);
     } else if (isFileEdit) {
       const filePath = toolInput.file_path || toolInput.TargetFile || toolInput.path || toolInput.target_file || '';
@@ -100,6 +123,12 @@ process.stdin.on('end', function () {
   process.exit(0);
 });
 
+function isGitCommitOrPush(command) {
+  // Match: git commit, git push, git push --force, git push -f
+  // Also match chained commands: git add . ; git commit, etc.
+  return /\bgit\s+(commit|push)\b/i.test(command);
+}
+
 function extractDeps(text, pattern) {
   const matches = [];
   let match;

package/.agents/plugins/agentic-senior-core/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-senior-core",
-  "version": "5.8.24",
+  "version": "5.8.26",
   "description": "Universal AI coding rules. Write code like a staff engineer.",
   "contextFileName": "rules/agentic-senior-core.md",
   "rules": [

package/.agents/plugins/agentic-senior-core/rules/agentic-senior-core.md

@@ -30,11 +30,14 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 ## Code Quality
 
 - Descriptive variable and function names. No cryptic abbreviations.
+- All identifiers (variables, functions, classes, file names, database columns) must be in English.
 - Early returns over deep nesting. Keep the main flow traceable.
 - Three similar lines is better than a premature abstraction.
 - Scope changes to what the task requires. Features, refactors, and abstractions beyond scope need explicit user confirmation.
 - Design for current requirements. Defer speculative extensions until evidence shows near-term need.
 - Delete code that carries no behavior, safety, or test value.
+- When brevity and readability conflict, readability wins.
+- Prefer named functions over closures/inline lambdas once logic exceeds a trivial expression.
 
 ## Architecture
 
@@ -42,6 +45,7 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 - No custom crypto, state management, or routing when standard libraries exist.
 - Controllers handle protocol translation only. Business logic belongs in services.
 - Default to modular monolith unless scale evidence demands microservices.
+- Match existing project structure before introducing new folders. No new top-level directory without clear necessity.
 - Direction changes require explicit user confirmation.
 
 ## Security (never skip)
@@ -66,6 +70,7 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 ## Workflow
 
 - Prefix ALL terminal commands with `ascx` to compress output and save tokens (e.g., `ascx <your_command>`).
+- Never run `git commit`, `git push`, or `git push --force` unless the user explicitly requests it this turn.
 
 Recognize the scenario and offer the matching command — user decides
 whether to invoke it. Skip this for trivial edits.
@@ -82,3 +87,4 @@ Lead with what the developer needs to act: the command, file path, code change,
 Format: direct statement, then evidence. Example — "Add `--strict` to tsconfig. Without it, nullable checks in `UserService.ts:42` are silently skipped."
 
 Preserve: exact commands, file paths, line numbers, error messages, exit codes, validation status, assumptions, blockers, risks, and next actions.
+- Before confirming a non-trivial plan, state at least one trade-off or alternative.

package/.agents/plugins/agentic-senior-core/skills/asc/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc
 description: >
-  Universal AI coding rules. Write code like a staff engineer. Use this skill when user asks for general coding guidelines, best practices, standard rules, code quality standards, or when acting as a senior/staff software engineer.
+  Trigger this skill when the user says: "what are the rules", "coding guidelines", "best practices", "code quality standards", "how should I write this", "staff engineer approach", "senior developer rules", "what does ASC say about". Also trigger for any general request about coding standards, quality guidelines, or when the user asks the agent to follow senior/staff engineering practices.
 ---
 
 # Agentic Senior Core

package/.agents/plugins/agentic-senior-core/skills/asc-adapter/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-adapter
 description: >
-  Detect installed AI coding hosts and generate adapter files for the current project. Use this skill when user asks to install, configure, setup, or initialize Agentic Senior Core rules, adapter files, or plugins for their IDE (Cursor, Windsurf, Devin, Copilot, Roo, Cline, Aider, Kiro).
+  Trigger this skill when the user says: "install ASC", "set up rules", "configure for Cursor", "add to Windsurf", "set up Copilot", "initialize plugin", "generate adapter", "install for my IDE", "set up Antigravity", "add to Kiro", "configure Roo", "set up for my editor", "install rules for this project", "add ASC to this repo". Also trigger for any request to install, configure, or initialize Agentic Senior Core rules or adapter files for an AI coding tool.
 ---
 
 # ASC Adapter

package/.agents/plugins/agentic-senior-core/skills/asc-add-feature/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-add-feature
 description: >
-  Structured brownfield workflow. Adapted from QRSPI to prevent context rot and ensure alignment before building. Use this skill when user asks to add new features, build new endpoints, extend existing functionality, implement new UI components, modify an existing codebase, or work on brownfield development.
+  Trigger this skill when the user says: "add a feature", "build this endpoint", "implement this", "add this component", "extend this", "integrate this", "wire up", "add support for", "create a new route", "add a new page", "hook this up", "connect this to", "make it do X", "add a button for". Also trigger for any non-trivial addition to an existing codebase — new endpoints, UI components, services, or integrations. Also trigger when the user describes new functionality to add to a working project.
 ---
 
 # Add Feature Workflow

package/.agents/plugins/agentic-senior-core/skills/asc-audit/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-audit
 description: >
-  Security and architecture audit. Deeper than review, focused on finding vulnerabilities and structural anti-patterns. Use this skill for deep security audits, architecture reviews, vulnerability scanning, threat modeling, finding OWASP risks (XSS, SQLi), penetration testing, or identifying structural anti-patterns.
+  Trigger this skill when the user says: "audit this", "security check", "find vulnerabilities", "is this secure", "check for XSS", "check for SQL injection", "threat model", "penetration test", "OWASP check", "architecture review", "is this safe", "check auth", "check permissions", "find security holes". Also trigger for any deep security audit, vulnerability scanning, or request to find structural anti-patterns in existing code. Also trigger when reviewing authentication, authorization, input validation, or encryption-related code.
 ---
 
 # Audit Skill

package/.agents/plugins/agentic-senior-core/skills/asc-debt/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-debt
 description: >
-  Track deferred enforcement violations. When an ASC ladder nudge fires and the shortcut is accepted rather than fixed, log it here for later resolution. Use this skill when user wants to log technical debt, track skipped rules, defer a fix, note a code smell for later, or manage deferred violations.
+  Trigger this skill when the user says: "log this debt", "skip this for now", "defer this fix", "note this smell", "track this violation", "add to debt ledger", "we'll fix this later", "accept the shortcut", "I know this is bad but", "just do it for now", "TODO later". Also trigger when an ASC ladder nudge fires and the user accepts the shortcut rather than fixing it — log the deferred violation for later resolution.
 ---
 
 # Debt Ledger

package/.agents/plugins/agentic-senior-core/skills/asc-new-project/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-new-project
 description: >
-  Structured greenfield workflow. Prevents building before alignment on what to build. Use this skill for greenfield projects, scaffolding new repositories, bootstrapping apps, starting from scratch, planning new system architectures, or creating a new project.
+  Trigger this skill when the user says: "new project", "start from scratch", "scaffold this", "bootstrap", "create a new app", "init a project", "set up a new repo", "greenfield", "plan the architecture", "design the system", "build me an app", "start a new codebase", "I want to build", "let's create". Also trigger for any request to create a new codebase, plan a new system architecture, or scaffold a new repository from zero.
 ---
 
 # New Project Workflow

package/.agents/plugins/agentic-senior-core/skills/asc-refactor/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-refactor
 description: >
-  Structured refactoring workflow. Preserves existing behavior while improving structure. Use this skill when user asks to refactor code, clean up code, improve code structure, rewrite legacy code, extract components, reduce technical debt, apply SOLID/DRY principles, or migrate codebases.
+  Trigger this skill when the user says: "refactor this", "clean up this code", "improve this structure", "rewrite this", "extract this into", "reduce duplication", "apply DRY", "apply SOLID", "migrate this", "simplify this module", "split this file", "decompose this", "this is messy", "make this cleaner", "too much coupling", "move this logic". Also trigger for any request to restructure, modernize, or improve code organization without changing behavior.
 ---
 
 # Refactor Skill

package/.agents/plugins/agentic-senior-core/skills/asc-reference/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-reference
 description: >
-  Domain-specific coding rules for testing, API design, database queries, frontend components, infrastructure configs, and service resilience. Load this skill when working on any of these domains. Use this skill for guidance on writing unit tests, designing REST/GraphQL APIs, optimizing SQL queries, writing React/frontend components, setting up Docker/CI/CD infrastructure, or improving backend service resilience.
+  Trigger this skill when the user is working on: unit tests, integration tests, REST APIs, GraphQL APIs, SQL queries, database migrations, React components, frontend layouts, Docker configs, CI/CD pipelines, Kubernetes manifests, or service resilience (retries, circuit breakers, rate limiting). Also trigger when the user says: "how should I test this", "design this API", "optimize this query", "set up Docker", "add retry logic", "write a test", "add pagination", "handle errors", "add loading state", "set up CI". Also trigger when editing files matching: `*.test.*`, `*.spec.*`, `Dockerfile`, `docker-compose.*`, `.github/workflows/*`, `*.sql`, or migration files.
 ---
 
 # ASC Domain Reference
@@ -57,3 +57,11 @@ Grounded in: WCAG 2.2 AA (accessibility), Fowler's Money Pattern (monetary types
 - Only retry idempotent operations.
 - Circuit breakers for unhealthy dependencies.
 - Graceful degradation on non-critical dependency failure.
+
+## Naming
+
+- Variables and properties are nouns: `userList`, `pageCount`, not `getUser`.
+- Functions and methods are verbs: `calculateTotal`, `fetchUsers`, not `total`.
+- Booleans prefixed with `is`/`has`/`can`: `isValid`, `hasPermission`.
+- Constants in UPPER_SNAKE_CASE: `MAX_RETRIES`, `API_BASE_URL`.
+- Follow the casing convention of the language and existing codebase. When starting fresh, use the community default for that language.

package/.agents/plugins/agentic-senior-core/skills/asc-review/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asc-review
 description: >
-  Production-risk code review. Prioritize findings by severity. Use this skill when user asks to review a pull request, perform code review, check for production risks, critique code, analyze recent changes, or provide feedback on code quality.
+  Trigger this skill when the user says: "review this code", "check this PR", "what's wrong with this", "look at my changes", "critique this", "is this production-ready", "review my pull request", "find bugs", "check for issues", "any problems here", "does this look right", "sanity check this". Also trigger for any request to evaluate code quality, analyze recent commits, or assess production risks in existing code. Also trigger when editing or viewing diff output, PR descriptions, or code review comments.
 ---
 
 # Review Skill

package/.agents/rules/agentic-senior-core.md

@@ -30,11 +30,14 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 ## Code Quality
 
 - Descriptive variable and function names. No cryptic abbreviations.
+- All identifiers (variables, functions, classes, file names, database columns) must be in English.
 - Early returns over deep nesting. Keep the main flow traceable.
 - Three similar lines is better than a premature abstraction.
 - Scope changes to what the task requires. Features, refactors, and abstractions beyond scope need explicit user confirmation.
 - Design for current requirements. Defer speculative extensions until evidence shows near-term need.
 - Delete code that carries no behavior, safety, or test value.
+- When brevity and readability conflict, readability wins.
+- Prefer named functions over closures/inline lambdas once logic exceeds a trivial expression.
 
 ## Architecture
 
@@ -42,6 +45,7 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 - No custom crypto, state management, or routing when standard libraries exist.
 - Controllers handle protocol translation only. Business logic belongs in services.
 - Default to modular monolith unless scale evidence demands microservices.
+- Match existing project structure before introducing new folders. No new top-level directory without clear necessity.
 - Direction changes require explicit user confirmation.
 
 ## Security (never skip)
@@ -65,6 +69,9 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 
 ## Workflow
 
+- Prefix ALL terminal commands with `ascx` to compress output and save tokens (e.g., `ascx <your_command>`).
+- Never run `git commit`, `git push`, or `git push --force` unless the user explicitly requests it this turn.
+
 Recognize the scenario and offer the matching command — user decides
 whether to invoke it. Skip this for trivial edits.
 
@@ -80,3 +87,4 @@ Lead with what the developer needs to act: the command, file path, code change,
 Format: direct statement, then evidence. Example — "Add `--strict` to tsconfig. Without it, nullable checks in `UserService.ts:42` are silently skipped."
 
 Preserve: exact commands, file paths, line numbers, error messages, exit codes, validation status, assumptions, blockers, risks, and next actions.
+- Before confirming a non-trivial plan, state at least one trade-off or alternative.

package/AGENTS.md

@@ -25,11 +25,14 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 ## Code Quality
 
 - Descriptive variable and function names. No cryptic abbreviations.
+- All identifiers (variables, functions, classes, file names, database columns) must be in English.
 - Early returns over deep nesting. Keep the main flow traceable.
 - Three similar lines is better than a premature abstraction.
 - Scope changes to what the task requires. Features, refactors, and abstractions beyond scope need explicit user confirmation.
 - Design for current requirements. Defer speculative extensions until evidence shows near-term need.
 - Delete code that carries no behavior, safety, or test value.
+- When brevity and readability conflict, readability wins.
+- Prefer named functions over closures/inline lambdas once logic exceeds a trivial expression.
 
 ## Architecture
 
@@ -37,6 +40,7 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 - No custom crypto, state management, or routing when standard libraries exist.
 - Controllers handle protocol translation only. Business logic belongs in services.
 - Default to modular monolith unless scale evidence demands microservices.
+- Match existing project structure before introducing new folders. No new top-level directory without clear necessity.
 - Direction changes require explicit user confirmation.
 
 ## Security (never skip)
@@ -61,6 +65,7 @@ When you pick the minimal option at step 5 or 6, and it isn't obviously trivial:
 ## Workflow
 
 - Prefix ALL terminal commands with `ascx` to compress output and save tokens (e.g., `ascx <your_command>`).
+- Never run `git commit`, `git push`, or `git push --force` unless the user explicitly requests it this turn.
 
 Recognize the scenario and offer the matching command — user decides
 whether to invoke it. Skip this for trivial edits.
@@ -77,3 +82,4 @@ Lead with what the developer needs to act: the command, file path, code change,
 Format: direct statement, then evidence. Example — "Add `--strict` to tsconfig. Without it, nullable checks in `UserService.ts:42` are silently skipped."
 
 Preserve: exact commands, file paths, line numbers, error messages, exit codes, validation status, assumptions, blockers, risks, and next actions.
+- Before confirming a non-trivial plan, state at least one trade-off or alternative.

package/README.md

@@ -13,6 +13,15 @@
 
 </div>
 
+## Project Status
+
+| Component | Status | Notes |
+|-----------|--------|-------|
+| Rules & Skills (Instructional Layer) | Stable | Universal across 23+ AI tools |
+| Hooks (Enforcement Layer) | Stable | Claude Code, Antigravity IDE, Copilot CLI, Cursor |
+| `ascx` (Output Compression) | Beta | 7 adapters (git, npm, tsc, rg); unsupported commands pass through safely |
+| CLI (`asc adapter`, `asc global`) | Stable | Install adapters for any supported host |
+
 ## How Skills & Hooks Work (Multi-Tier Architecture)
 
 Agentic Senior Core operates on a two-tier architecture:

package/gemini-extension.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-senior-core",
-  "version": "5.8.24",
+  "version": "5.8.26",
   "description": "Universal AI coding rules. Write code like a staff engineer.",
   "author": "fatidaprilian",
   "license": "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ryuenn3123/agentic-senior-core",
-  "version": "5.8.24",
+  "version": "5.8.26",
   "type": "module",
   "description": "Agentic Senior Core: Universal AI coding rules and workflows. Write code like a staff engineer, not a junior.",
   "bin": {

package/plugin.yaml

@@ -1,5 +1,5 @@
 name: agentic-senior-core
-version: 5.8.24
+version: 5.8.26
 description: Universal AI coding rules. Write code like a staff engineer.
 author: fatidaprilian
 provides_hooks: