@ryuenn3123/agentic-senior-core 5.8.21 → 5.8.23

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (68) hide show
  1. package/.agents/plugins/agentic-senior-core/hooks/post-edit-enforce.js +100 -38
  2. package/.agents/plugins/agentic-senior-core/hooks/pre-tool-dependency-gate.js +20 -11
  3. package/.agents/plugins/agentic-senior-core/hooks.json +14 -7
  4. package/.agents/plugins/agentic-senior-core/plugin.json +10 -4
  5. package/.agents/plugins/agentic-senior-core/skills/asc-new-project/SKILL.md +5 -6
  6. package/README.md +10 -20
  7. package/gemini-extension.json +12 -6
  8. package/lib/cli/commands/adapter.mjs +21 -13
  9. package/lib/cli/commands/global.mjs +21 -11
  10. package/package.json +1 -21
  11. package/plugin.yaml +1 -1
  12. package/.claude-plugin/marketplace.json +0 -17
  13. package/.claude-plugin/plugin.json +0 -17
  14. package/.clinerules/agentic-senior-core.md +0 -109
  15. package/.codex-plugin/plugin.json +0 -24
  16. package/.continue/rules/agentic-senior-core.md +0 -109
  17. package/.cursor/rules/agentic-senior-core.mdc +0 -114
  18. package/.devin/rules/agentic-senior-core.md +0 -109
  19. package/.devin-plugin/plugin.json +0 -13
  20. package/.github/copilot-instructions.md +0 -109
  21. package/.github/plugin/marketplace.json +0 -20
  22. package/.github/plugin/plugin.json +0 -16
  23. package/.kilocode/rules/agentic-senior-core.md +0 -109
  24. package/.kiro/steering/agentic-senior-core.md +0 -109
  25. package/.openclaw/skills/asc/SKILL.md +0 -36
  26. package/.openclaw/skills/asc-adapter/SKILL.md +0 -43
  27. package/.openclaw/skills/asc-add-feature/SKILL.md +0 -53
  28. package/.openclaw/skills/asc-audit/SKILL.md +0 -36
  29. package/.openclaw/skills/asc-debt/SKILL.md +0 -72
  30. package/.openclaw/skills/asc-new-project/SKILL.md +0 -62
  31. package/.openclaw/skills/asc-refactor/SKILL.md +0 -62
  32. package/.openclaw/skills/asc-reference/SKILL.md +0 -59
  33. package/.openclaw/skills/asc-review/SKILL.md +0 -63
  34. package/.opencode/plugins/agentic-senior-core.mjs +0 -31
  35. package/.openhands/microagents/agentic-senior-core.md +0 -109
  36. package/.roo/rules/agentic-senior-core.md +0 -109
  37. package/.windsurf/rules/agentic-senior-core.md +0 -109
  38. package/.zed/rules/agentic-senior-core.md +0 -109
  39. package/hooks/copilot-hooks.json +0 -30
  40. package/hooks/hooks.json +0 -86
  41. package/hooks/lib/known-duplicates.json +0 -32
  42. package/hooks/package.json +0 -3
  43. package/hooks/path-util.cjs +0 -23
  44. package/hooks/post-edit-enforce.js +0 -234
  45. package/hooks/pre-tool-dependency-gate.js +0 -155
  46. package/hooks/session-start.js +0 -36
  47. package/hooks/subagent-start.js +0 -38
  48. package/skills/asc/SKILL.md +0 -36
  49. package/skills/asc-adapter/SKILL.md +0 -43
  50. package/skills/asc-add-feature/SKILL.md +0 -53
  51. package/skills/asc-audit/SKILL.md +0 -36
  52. package/skills/asc-debt/SKILL.md +0 -72
  53. package/skills/asc-new-project/SKILL.md +0 -62
  54. package/skills/asc-refactor/SKILL.md +0 -62
  55. package/skills/asc-reference/SKILL.md +0 -59
  56. package/skills/asc-review/SKILL.md +0 -63
  57. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-add-feature.md +0 -0
  58. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-add-feature.toml +0 -0
  59. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-audit.md +0 -0
  60. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-audit.toml +0 -0
  61. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-help.md +0 -0
  62. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-help.toml +0 -0
  63. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-new-project.md +0 -0
  64. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-new-project.toml +0 -0
  65. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-refactor.md +0 -0
  66. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-refactor.toml +0 -0
  67. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-review.md +0 -0
  68. /package/{commands → .agents/plugins/agentic-senior-core/commands}/asc-review.toml +0 -0
@@ -1,43 +0,0 @@
1
- ---
2
- name: asc-adapter
3
- description: >
4
- Detect installed AI coding hosts and generate adapter files for the current project. Use this skill when user asks to install, configure, setup, or initialize Agentic Senior Core rules, adapter files, or plugins for their IDE (Cursor, Windsurf, Devin, Copilot, Roo, Cline, Aider, Kiro).
5
- ---
6
-
7
- # ASC Adapter
8
-
9
- Detect installed AI coding hosts and generate adapter files for the current project.
10
-
11
- ## When to use
12
-
13
- Run this when setting up a new project or when a developer wants ASC rules active across all their AI coding tools.
14
-
15
- ## Steps
16
-
17
- 1. Run `asc status` to detect which AI coding hosts are installed on this system.
18
- 2. Check which adapter files already exist in the current project directory.
19
- 3. For any detected host that is missing an adapter, run `asc adapter --<host>` to generate it.
20
- 4. Use `asc adapter --all` to generate adapters for all supported hosts at once.
21
-
22
- ## Supported hosts
23
-
24
- Plugin hosts (always-on, no adapter needed): Claude Code, Codex CLI, Gemini CLI, Antigravity CLI, Copilot CLI, Devin CLI, Hermes, OpenCode, OpenClaw.
25
-
26
- Adapter hosts (one file per project): Cursor, Devin Desktop, Cline, GitHub Copilot, Kiro, Continue, Zed, Aider, Kilo Code, Roo Code, OpenHands.
27
-
28
- ## Commands
29
-
30
- ```bash
31
- asc status # Show detected hosts
32
- asc adapter --all # Generate all adapters
33
- asc adapter --cursor # Generate for specific host
34
- asc uninstall # Remove all ASC adapter files
35
- asc uninstall --dry-run # Preview what would be removed
36
- ```
37
-
38
- ## Notes
39
-
40
- - Adapter files contain the ASC universal coding rules, compressed to fit within each host's size limits.
41
- - Cursor uses `.mdc` format with `alwaysApply: true` frontmatter.
42
- - Windsurf is now Devin Desktop. Use `--devin` for the preferred path, `--windsurf` for legacy.
43
- - Zed also reads `AGENTS.md` natively, so the adapter is optional.
@@ -1,53 +0,0 @@
1
- ---
2
- name: asc-add-feature
3
- description: >
4
- Structured brownfield workflow. Adapted from QRSPI to prevent context rot and ensure alignment before building. Use this skill when user asks to add new features, build new endpoints, extend existing functionality, implement new UI components, modify an existing codebase, or work on brownfield development.
5
- ---
6
-
7
- # Add Feature Workflow
8
-
9
- Structured brownfield workflow. Adapted from QRSPI to prevent context rot and ensure alignment before building.
10
-
11
- Grounded in: RPI (Dex Horthy, HumanLayer 2025) with corrections from QRSPI 8-stage evolution (Coding Agents Conference, March 2026). Plan-reading illusion fix and instruction budget constraint applied. Stages 2/5/7 adapted; stages 1/3/4/6/8 skipped as too heavyweight for individual-developer workflow.
12
-
13
- ## Gate Mechanism & Scaled Spec Requirement
14
-
15
- This workflow nudges the agent to stop at each phase boundary, same enforcement tier as the existing decision ladder — not a hard block. Bypasses are logged to the debt ledger.
16
-
17
- For brownfield feature development (`asc-add-feature`), Phase 2 requires a lightweight **PRD.md** (or feature spec in `docs/PRD.md`) defining product intent, goals, and non-goals to avoid scope creep and context rot.
18
-
19
- To track phase, write to `workflow-gate.json` via the `state_write` MCP tool.
20
- Format:
21
- ```json
22
- {
23
- "workflow": "asc-add-feature",
24
- "phase": "<current_phase>",
25
- "updatedAt": "<ISO-timestamp>"
26
- }
27
- ```
28
-
29
- ## Phase 1: Research (No Code Changes)
30
-
31
- 1. Write `workflow-gate.json` with phase `research`.
32
- 2. Map existing code: patterns, utilities, dependencies already in use.
33
- 3. Identify what must NOT be rebuilt (e.g., existing validation helpers).
34
- 4. Output a factual research summary.
35
- 5. **STOP and wait for user approval.** Do not plan or implement.
36
-
37
- ## Phase 2: Plan
38
-
39
- 1. On approval of Phase 1, update `workflow-gate.json` phase to `plan`.
40
- 2. Ensure `docs/PRD.md` or feature brief exists.
41
- 3. Create a numbered, step-by-step implementation plan with specific files, functions, and line references.
42
- 4. Include a "Don't Build" list from the research phase.
43
- 5. **Callout: Plan-Reading Illusion.** Ask the user to explicitly verify the plan against the codebase, not just skim it.
44
- 6. Output the plan.
45
- 7. **STOP and wait for user approval.** Do not implement.
46
-
47
- ## Phase 3: Implement
48
-
49
- 1. On approval of Phase 2, update `workflow-gate.json` phase to `implement`.
50
- 2. Recommend a fresh context (intentional compaction) if the context window is getting full.
51
- 3. Execute the approved plan.
52
- 4. Validate: tests pass, no duplicate code introduced, plan items checked off.
53
- 5. On completion, clear the state in `workflow-gate.json` by overwriting it with `{}`.
@@ -1,36 +0,0 @@
1
- ---
2
- name: asc-audit
3
- description: >
4
- Security and architecture audit. Deeper than review, focused on finding vulnerabilities and structural anti-patterns. Use this skill for deep security audits, architecture reviews, vulnerability scanning, threat modeling, finding OWASP risks (XSS, SQLi), penetration testing, or identifying structural anti-patterns.
5
- ---
6
-
7
- # Audit Skill
8
-
9
- Security and architecture audit. Deeper than review, focused on finding vulnerabilities and structural anti-patterns.
10
-
11
- Grounded in: OWASP Top 10 (2021), OWASP ASVS v4, CVSS vulnerability report structure, CWE classification.
12
-
13
- ## Audit Scope
14
-
15
- 1. **Trust boundaries**: Every point where external input enters the system. Validate that inputs are sanitized, normalized, and rejected when invalid.
16
- 2. **Authentication and authorization**: Verify auth checks exist on every endpoint. Check for resource-level authorization, not just identity.
17
- 3. **Data handling**: Secrets in code or logs, PII exposure, unsafe deserialization, SQL injection, command injection.
18
- 4. **Architecture boundaries**: Business logic in transport layer, shared databases between services, circular dependencies, internal model leakage through public APIs.
19
- 5. **Dependency health**: Known vulnerabilities, unmaintained packages, excessive dependency surface.
20
- 6. **Error exposure**: Stack traces, internal paths, or implementation details exposed to clients.
21
-
22
- ## For Every Finding
23
-
24
- ```
25
- Severity: critical | high | medium | low
26
- Class: vulnerability class (e.g., SQL Injection, Broken Access Control)
27
- Location: file:line
28
- Impact: who or what is affected
29
- Evidence: exact code, behavior, or command output
30
- Remediation: specific fix direction
31
- Validation: how to prove it is fixed
32
- ```
33
-
34
- ## Output
35
-
36
- Findings ordered by severity. If no findings, state that explicitly and describe audit coverage.
@@ -1,72 +0,0 @@
1
- ---
2
- name: asc-debt
3
- description: >
4
- Track deferred enforcement violations. When an ASC ladder nudge fires and the shortcut is accepted rather than fixed, log it here for later resolution. Use this skill when user wants to log technical debt, track skipped rules, defer a fix, note a code smell for later, or manage deferred violations.
5
- ---
6
-
7
- # Debt Ledger
8
-
9
- Track deferred enforcement violations. When an ASC ladder nudge fires and the shortcut is accepted rather than fixed, log it here for later resolution.
10
-
11
- Grounded in: Cunningham's technical debt metaphor (1992). Entry format (ladder step + violation + status lifecycle) is an ASC-specific implementation.
12
-
13
- ## Storage
14
-
15
- Entries persist in `.agent-context/state/debt-ledger.json` via MCP `state_read`/`state_write`. The ledger is a JSON array of entry objects.
16
-
17
- ## Entry Format
18
-
19
- ```json
20
- {
21
- "id": "sequential integer",
22
- "file": "path/to/file.ts",
23
- "ladderStep": "3",
24
- "violation": "Added axios — stdlib fetch covers this",
25
- "addedAt": "ISO-8601 timestamp",
26
- "status": "open | resolved",
27
- "resolvedAt": "ISO-8601 timestamp or null"
28
- }
29
- ```
30
-
31
- ## Operations
32
-
33
- ### Add Entry
34
-
35
- When an enforcement nudge fires and the violation is deferred:
36
-
37
- 1. Read the current ledger via `state_read` (path: `debt-ledger.json`). If missing, start with `[]`.
38
- 2. Append a new entry with the next sequential `id`, the file path, ladder step, and a one-line violation summary.
39
- 3. Write the updated ledger via `state_write` (path: `debt-ledger.json`, mode: `overwrite`).
40
- 4. Confirm: "Logged to debt ledger: [violation summary]"
41
-
42
- ### List Open Debt
43
-
44
- 1. Read the ledger via `state_read`.
45
- 2. Filter to entries where `status` is `"open"`.
46
- 3. Display as a table: ID, file, ladder step, violation, age.
47
- 4. If no open entries, say so explicitly.
48
-
49
- ### Resolve Entry
50
-
51
- When a deferred violation has been addressed:
52
-
53
- 1. Read the ledger.
54
- 2. Set the matching entry's `status` to `"resolved"` and `resolvedAt` to the current timestamp.
55
- 3. Write the updated ledger.
56
- 4. Confirm: "Resolved debt #[id]: [violation summary]"
57
-
58
- ### Summary
59
-
60
- 1. Read the ledger.
61
- 2. Report: total entries, open count, resolved count, oldest open entry age.
62
-
63
- ## When to Log
64
-
65
- Log a debt entry when ALL of these are true:
66
- - The PostToolUse enforcement hook fired a nudge
67
- - The agent acknowledged the nudge but proceeded without fixing the violation
68
- - The violation is deferrable (not a security issue — security violations must be fixed immediately)
69
-
70
- ## Integration
71
-
72
- The `/asc` skill documents the enforcement loop. This ledger captures what enforcement flags but the session defers. Use `/asc-debt` at session end or before commits to review outstanding shortcuts.
@@ -1,62 +0,0 @@
1
- ---
2
- name: asc-new-project
3
- description: >
4
- Structured greenfield workflow. Prevents building before alignment on what to build. Use this skill for greenfield projects, scaffolding new repositories, bootstrapping apps, starting from scratch, planning new system architectures, or creating a new project.
5
- ---
6
-
7
- # New Project Workflow
8
-
9
- Structured greenfield workflow. Prevents building before alignment on what to build.
10
-
11
- Grounded in: Spec-Driven Development (SDD) with scaffolding-spec approach. Core spec documents guide greenfield implementation (`PRD.md`, `Architecture.md`, `Design.md`, `Schema.md`). Once implemented, the code becomes the primary ground truth, while docs are updated on structural changes.
12
-
13
- ## Gate Mechanism & 4 Spec Document Requirement
14
-
15
- This workflow nudges the agent to stop at each phase boundary, same enforcement tier as the existing decision ladder — not a hard block. Bypasses are logged to the debt ledger.
16
-
17
- For greenfield projects (`asc-new-project`), Phase 2 requires creating the **4 Core SDD Documents** in `docs/` or project root:
18
- 1. `PRD.md` — Product intent, goals, non-goals, and user problems.
19
- 2. `Architecture.md` — System structure, module boundaries, and tech stack choices.
20
- 3. `Design.md` — UX / UI layout, component hierarchy, interaction rules.
21
- 4. `Schema.md` — Data contracts, database entities, API endpoints.
22
-
23
- *Note on Rules:* Coding conventions and project constraints are automatically loaded from global plugin rules (`agentic-senior-core.md`) or workspace `AGENTS.md`. No duplicate `docs/Rules.md` file is required.
24
-
25
- To track phase, write to `workflow-gate.json` via the `state_write` MCP tool.
26
- Format:
27
- ```json
28
- {
29
- "workflow": "asc-new-project",
30
- "phase": "<current_phase>",
31
- "updatedAt": "<ISO-timestamp>"
32
- }
33
- ```
34
-
35
- ## Phase 1: Define (No Code)
36
-
37
- 1. Write `workflow-gate.json` with phase `research`.
38
- 2. Clarify with the user: tech stack, target platform, constraints, non-goals.
39
- 3. Propose a directory structure and module boundaries.
40
- 4. Output a project brief summarizing decisions.
41
- 5. **STOP and wait for user approval.** Do not write specs or code.
42
-
43
- ## Phase 2: Spec (No Implementation Code)
44
-
45
- 1. On approval of Phase 1, update `workflow-gate.json` phase to `plan`.
46
- 2. Generate the 4 core SDD documents from templates (`docs/PRD.md`, `docs/Architecture.md`, `docs/Design.md`, `docs/Schema.md`).
47
- 3. Verify exact file naming — check for typos like `Architectyre.md`.
48
- 4. Output specs for review.
49
- 5. **STOP and wait for user approval.** Do not implement code.
50
-
51
- ## Phase 3: Implement
52
-
53
- 1. On approval of Phase 2, update `workflow-gate.json` phase to `implement`.
54
- 2. Run Anti Context-Blindness check: verify entities/tables mentioned in `Schema.md` or `Architecture.md` align with proposed code targets.
55
- 3. Build against the approved specs. Apply the ASC decision ladder on every file.
56
- 4. Run the decision ladder: does this need to exist? Does stdlib cover it? One function or full module?
57
-
58
- ## Phase 4: Validate
59
-
60
- 1. Run tests. Check each spec's acceptance criteria.
61
- 2. Confirm nothing was over-built beyond what the specs required.
62
- 3. On completion, clear the state in `workflow-gate.json` by overwriting it with `{}`.
@@ -1,62 +0,0 @@
1
- ---
2
- name: asc-refactor
3
- description: >
4
- Structured refactoring workflow. Preserves existing behavior while improving structure. Use this skill when user asks to refactor code, clean up code, improve code structure, rewrite legacy code, extract components, reduce technical debt, apply SOLID/DRY principles, or migrate codebases.
5
- ---
6
-
7
- # Refactor Skill
8
-
9
- Structured refactoring workflow. Preserves existing behavior while improving structure.
10
-
11
- Grounded in: Fowler's Refactoring (read-understand-smallest scope-preserve behavior), Rule of Three (abstraction threshold), YAGNI principle (XP/Kent Beck). Empirical evidence: agents dominate low-level refactors (rename, extract, type changes) but struggle with multi-file architectural changes (arXiv, 15k+ instance study).
12
-
13
- ## YAGNI Scan (Before Any Restructuring)
14
-
15
- Before changing structure, scan for speculative code to remove:
16
- - "Just in case" logic, unused feature flags, dead branches behind config toggles.
17
- - Abstractions wrapping a single implementation with no second consumer.
18
- - Premature extension points (plugin hooks, strategy patterns) with one concrete path.
19
-
20
- Removing speculative code is the highest-value, lowest-risk refactor type.
21
-
22
- ## Classify Before Proceeding
23
-
24
- After reading the target code, classify the refactor:
25
-
26
- - **Low-level** (rename, extract method, type safety, dead code removal): proceed after explaining the change. No approval gate needed.
27
- - **High-level** (move module, change architecture, redesign abstractions, multi-file structural changes): output a plan with specific files and rationale, then **stop and wait for user approval** before implementing.
28
-
29
- **Known limitation:** The high-level refactor gate is a skill-text instruction — the agent self-classifies and self-stops. Unlike `/asc-add-feature` and `/asc-new-project`, this gate is not backed by the PostToolUse hook or workflow-gate.json. If the agent bypasses the gate, there is no automated nudge.
30
-
31
- ## Before Editing
32
-
33
- 1. Read the target code and understand existing patterns.
34
- 2. Identify the smallest relevant scope for the refactor.
35
- 3. Classify the refactor (see above). If high-level, stop and present a plan.
36
- 4. If the change touches UI, check accessibility and responsive behavior.
37
- 5. If the change touches dependencies, verify current official docs.
38
-
39
- ## Refactor Rules
40
-
41
- - Improve clarity, boundaries, naming, validation, error handling, and tests.
42
- - Prioritize maintainability over compressed one-liners.
43
- - Keep the main flow traceable. Use early returns where they reduce nesting.
44
- - Introduce abstractions only when the repeated pattern is real and visible.
45
- - Split large files when the split makes the flow easier to understand.
46
- - Remove code that does not carry behavior, safety, clarity, maintainability, or test value.
47
- - Prefer the shorter implementation only when it keeps the same guarantees.
48
- - Run a final simplification pass before completion.
49
- - Update tests and docs whenever behavior contracts, public APIs, data shape, or UI contracts change.
50
-
51
- ## For Every Change, Explain
52
-
53
- - What risk or friction existed.
54
- - What changed.
55
- - Why the new shape is safer or easier to maintain.
56
-
57
- ## Validation
58
-
59
- - Existing behavior is preserved unless the user approved a change.
60
- - Edge cases, empty states, error paths, and rollback paths are handled.
61
- - Public contracts remain stable or are versioned.
62
- - Tests pass.
@@ -1,59 +0,0 @@
1
- ---
2
- name: asc-reference
3
- description: >
4
- Domain-specific coding rules for testing, API design, database queries, frontend components, infrastructure configs, and service resilience. Load this skill when working on any of these domains. Use this skill for guidance on writing unit tests, designing REST/GraphQL APIs, optimizing SQL queries, writing React/frontend components, setting up Docker/CI/CD infrastructure, or improving backend service resilience.
5
- ---
6
-
7
- # ASC Domain Reference
8
-
9
- Domain-specific coding rules for testing, API design, database queries, frontend components, infrastructure configs, and service resilience. Load this skill when working on any of these domains.
10
-
11
- Grounded in: WCAG 2.2 AA (accessibility), Fowler's Money Pattern (monetary types), Nygard's Release It! (resilience patterns), AWS Well-Architected Reliability Pillar (backoff/circuit breakers), OWASP Secure Coding Practices (input validation, logging).
12
-
13
- ## Testing
14
-
15
- - Write tests for business logic and boundary failures, not implementation details.
16
- - Cover happy path, error paths, edge cases, and empty states.
17
- - Tests must be fast, isolated, deterministic.
18
- - Integration tests for critical data paths.
19
- - Sensitive mutations need idempotency or duplicate-submit coverage.
20
- - CI pipelines block on test failures.
21
-
22
- ## API Design
23
-
24
- - Consistent resource naming and HTTP semantics.
25
- - Bounded list reads: always paginate or set explicit limits.
26
- - Idempotent for side-effect mutations. Document retry behavior.
27
- - Backward-compatible by default. Version breaking changes explicitly.
28
- - Sync docs in the same commit when changing API, CLI, or schema.
29
-
30
- ## Database
31
-
32
- - Use eager loading or batching to eliminate N+1 queries.
33
- - Paginate all growable datasets. No unbounded queries.
34
- - Multi-table mutations run inside transactions.
35
- - Monetary amounts: integer minor units or exact decimal. Never floats.
36
- - Timestamps in UTC. No naive timestamps.
37
- - Schema changes require versioned, reversible migrations.
38
- - Never modify merged migrations. Create new ones.
39
-
40
- ## Frontend
41
-
42
- - Semantic HTML before custom components.
43
- - WCAG 2.2 AA is the accessibility floor.
44
- - Responsive by default. Handle empty, loading, error, and offline states.
45
- - No placeholder, lorem, or TODO content in production UI.
46
-
47
- ## Infrastructure
48
-
49
- - Container configs: multi-stage builds, minimal base images, non-root users, no baked secrets.
50
- - Configuration from environment, validated at startup. Fail fast if invalid.
51
- - Structured logging with correlation IDs. No PII in logs.
52
-
53
- ## Resilience
54
-
55
- - Every outbound network call has a strict timeout.
56
- - Retries use exponential backoff with jitter and max attempt limits.
57
- - Only retry idempotent operations.
58
- - Circuit breakers for unhealthy dependencies.
59
- - Graceful degradation on non-critical dependency failure.
@@ -1,63 +0,0 @@
1
- ---
2
- name: asc-review
3
- description: >
4
- Production-risk code review. Prioritize findings by severity. Use this skill when user asks to review a pull request, perform code review, check for production risks, critique code, analyze recent changes, or provide feedback on code quality.
5
- ---
6
-
7
- # Review Skill
8
-
9
- Production-risk code review. Prioritize findings by severity.
10
-
11
- Grounded in: OWASP Risk Rating Methodology, Google Engineering Practices (code review guide), Clean Architecture (transport vs business layer separation).
12
-
13
- ## Before Reviewing
14
-
15
- 1. Read the changed files and understand the scope.
16
- 2. For UI changes, check accessibility and design consistency.
17
- 3. For API changes, check contract stability and documentation sync.
18
- 4. Walk the decision ladder for each new file or dependency: does this need to exist, could the stdlib or an existing dependency handle it?
19
-
20
- ## Finding Priority Order
21
-
22
- 1. Correctness, data loss, security, privacy, auth, and permission risks.
23
- 2. Public contract drift: APIs, events, CLI behavior, data model, UI contract, docs.
24
- 3. Missing tests for changed behavior.
25
- 4. Architecture boundary drift and maintainability risk.
26
- 5. Performance and accessibility issues with concrete impact.
27
-
28
- ## For Every Finding
29
-
30
- - Include file and line reference.
31
- - Explain the real risk.
32
- - Propose the smallest safe fix.
33
-
34
- ## Checklist
35
-
36
- ### Correctness
37
- - Changed behavior matches the user request.
38
- - Existing behavior preserved unless user approved a change.
39
- - Edge cases, empty states, error paths handled.
40
-
41
- ### Security
42
- - External input validated at trust boundaries.
43
- - Secrets, tokens, credentials not committed or logged.
44
- - Authorization enforced at a trusted boundary.
45
- - Error responses keep internal details out of client responses.
46
-
47
- ### Architecture
48
- - Layer boundaries clear. Controllers handle protocol translation only; business logic stays in services.
49
- - Abstractions backed by real duplication, not prediction. Straightforward code over clever solutions.
50
- - Complexity budget applied: fewer moving parts without losing safety.
51
-
52
- ### Testing
53
- - Changed behavior has appropriate tests.
54
- - Tests assert behavior and contracts, not implementation trivia.
55
- - Critical flows include failure-path coverage.
56
-
57
- ### Documentation
58
- - API, event, CLI, and data contract changes update docs in the same commit.
59
- - Root README exists and stays current.
60
-
61
- ## Output
62
-
63
- Report findings ordered by severity with file/line references and concrete fixes. If no findings, say so explicitly and name any residual risk.