@ryuenn3123/agentic-senior-core 4.4.0 → 5.2.0

package/scripts/validate/markdown-content.mjs

@@ -1,109 +0,0 @@
-import { dirname, join, relative, resolve } from 'node:path';
-
-export async function validateMarkdownFiles(context) {
-  const { ROOT_DIR, collectFiles, readTextFile, pass, fail } = context;
-  console.log('\nChecking markdown content...');
-
-  const markdownFilePaths = await collectFiles(ROOT_DIR, (fileName) => fileName.endsWith('.md'));
-
-  for (const markdownFilePath of markdownFilePaths) {
-    const markdownContent = await readTextFile(markdownFilePath);
-    const relativeMarkdownPath = relative(ROOT_DIR, markdownFilePath);
-
-    if (markdownContent.trim().length === 0) {
-      fail(`Empty markdown file: ${relativeMarkdownPath}`);
-      continue;
-    }
-
-    pass(`${relativeMarkdownPath} (${markdownContent.length} chars)`);
-  }
-}
-
-export async function validateCrossReferences(context) {
-  const { ROOT_DIR, collectFiles, readTextFile, fileExists, pass, fail, warn } = context;
-  console.log('\nChecking internal links...');
-
-  const markdownFilePaths = await collectFiles(ROOT_DIR, (fileName) => fileName.endsWith('.md'));
-  const linkPattern = /\[([^\]]*)\]\((?!https?:\/\/|#)([^)]+)\)/g;
-  let checkedLinkCount = 0;
-
-  for (const markdownFilePath of markdownFilePaths) {
-    const markdownContent = await readTextFile(markdownFilePath);
-    const currentFileDirectory = dirname(markdownFilePath);
-    const relativeMarkdownPath = relative(ROOT_DIR, markdownFilePath);
-    let linkMatch = linkPattern.exec(markdownContent);
-
-    while (linkMatch) {
-      const rawLinkTarget = linkMatch[2].split('#')[0];
-      if (rawLinkTarget) {
-        checkedLinkCount += 1;
-        const resolvedLinkPath = resolve(currentFileDirectory, rawLinkTarget);
-
-        if (await fileExists(resolvedLinkPath)) {
-          pass(`${relativeMarkdownPath} → ${linkMatch[2]}`);
-        } else {
-          fail(`Broken link in ${relativeMarkdownPath}: ${linkMatch[2]}`);
-        }
-      }
-
-      linkMatch = linkPattern.exec(markdownContent);
-    }
-  }
-
-  if (checkedLinkCount === 0) {
-    warn('No internal links were found in markdown files');
-  }
-}
-
-export async function validateAgentsManifest(context) {
-  const { ROOT_DIR, readTextFile, fileExists, pass, fail, warn } = context;
-  console.log('\nChecking AGENTS.md manifest links...');
-
-  const agentsContent = await readTextFile(join(ROOT_DIR, 'AGENTS.md'));
-  const fileReferencePattern = /\[`?([^`\]]+)`?\]\(([^)]+)\)/g;
-  let manifestLinkCount = 0;
-  let fileReferenceMatch = fileReferencePattern.exec(agentsContent);
-
-  while (fileReferenceMatch) {
-    const manifestLinkTarget = fileReferenceMatch[2];
-
-    if (!manifestLinkTarget.startsWith('http')) {
-      manifestLinkCount += 1;
-      const resolvedManifestLinkPath = resolve(ROOT_DIR, manifestLinkTarget);
-
-      if (await fileExists(resolvedManifestLinkPath)) {
-        pass(`AGENTS.md → ${manifestLinkTarget}`);
-      } else {
-        fail(`AGENTS.md references missing file: ${manifestLinkTarget}`);
-      }
-    }
-
-    fileReferenceMatch = fileReferencePattern.exec(agentsContent);
-  }
-
-  if (manifestLinkCount === 0) {
-    warn('AGENTS.md does not contain any local manifest links');
-  }
-}
-
-export async function validateDocumentationFlow(context) {
-  const { README_PATH, readTextFile, pass, fail } = context;
-  console.log('\nChecking documentation flow...');
-
-  const readmeContent = await readTextFile(README_PATH);
-  const requiredReadmeSnippets = [
-    'npx @ryuenn3123/agentic-senior-core init',
-    'npm run validate',
-    'docs/faq.md',
-    'docs/deep-dive.md',
-    'docs/archive/HISTORY.md',
-  ];
-
-  for (const requiredReadmeSnippet of requiredReadmeSnippets) {
-    if (readmeContent.includes(requiredReadmeSnippet)) {
-      pass(`README.md mentions ${requiredReadmeSnippet}`);
-    } else {
-      fail(`README.md must mention ${requiredReadmeSnippet}`);
-    }
-  }
-}

package/scripts/validate/project-metadata.mjs

@@ -1,166 +0,0 @@
-import { join } from 'node:path';
-import { ALLOWED_SEVERITIES } from './config.mjs';
-
-export async function validatePackageMetadata(context) {
-  const { PACKAGE_JSON_PATH, BUN_LOCK_PATH, readTextFile, fileExists, pass, fail, warn } = context;
-  console.log('\nChecking package metadata...');
-
-  const packageJson = JSON.parse(await readTextFile(PACKAGE_JSON_PATH));
-  const versionPattern = /^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?(?:\+[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?$/;
-
-  if (typeof packageJson.version !== 'string' || !versionPattern.test(packageJson.version)) {
-    fail('package.json version must be a semantic version string');
-  } else {
-    pass(`package.json version ${packageJson.version}`);
-  }
-
-  if (packageJson.scripts?.validate === 'node ./scripts/validate.mjs') {
-    pass('package.json validate script is Node-first');
-  } else {
-    fail('package.json validate script must use node ./scripts/validate.mjs');
-  }
-
-  if (packageJson.scripts?.test) {
-    pass('package.json test script exists');
-  } else {
-    fail('package.json test script is missing');
-  }
-
-  if (packageJson.devDependencies && Object.keys(packageJson.devDependencies).length > 0) {
-    warn('package.json still has devDependencies; review whether they are necessary');
-  } else {
-    pass('package.json has no unnecessary devDependencies');
-  }
-
-  if (Array.isArray(packageJson.files) && packageJson.files.includes('AGENTS.md')) {
-    pass('package.json publishes canonical AGENTS.md');
-  } else {
-    fail('package.json must publish AGENTS.md so init and upgrade can copy the canonical root instructions file');
-  }
-
-  if (await fileExists(BUN_LOCK_PATH)) {
-    fail('bun.lock must not be tracked while npm is the package manager source of truth');
-  } else {
-    pass('No bun.lock drift file present');
-  }
-}
-
-export async function validatePolicyFile(context) {
-  const { POLICY_FILE_PATH, readTextFile, pass, fail } = context;
-  console.log('\nChecking LLM Judge policy...');
-
-  const policyContent = await readTextFile(POLICY_FILE_PATH);
-  const parsedPolicy = JSON.parse(policyContent);
-  const selectedProfileName = parsedPolicy.selectedProfile;
-  const profileThresholds = parsedPolicy.profileThresholds;
-
-  if (typeof selectedProfileName !== 'string') {
-    fail('Policy file must define selectedProfile as a string');
-  } else {
-    pass(`LLM Judge selected profile: ${selectedProfileName}`);
-  }
-
-  if (!profileThresholds || typeof profileThresholds !== 'object') {
-    fail('Policy file must define profileThresholds');
-    return;
-  }
-
-  for (const [profileName, profileSettings] of Object.entries(profileThresholds)) {
-    if (!Array.isArray(profileSettings.blockingSeverities)) {
-      fail(`Policy profile ${profileName} must define blockingSeverities`);
-      continue;
-    }
-
-    const invalidSeverity = profileSettings.blockingSeverities.find((severity) => !ALLOWED_SEVERITIES.has(severity));
-    if (invalidSeverity) {
-      fail(`Policy profile ${profileName} uses unsupported severity: ${invalidSeverity}`);
-      continue;
-    }
-
-    pass(`Policy profile ${profileName} blocking severities are valid`);
-  }
-
-  if (typeof profileThresholds[selectedProfileName] === 'object') {
-    pass('Policy selectedProfile points to a valid profile');
-  } else {
-    fail('Policy selectedProfile must match one of the configured profileThresholds');
-  }
-}
-
-export async function validateVersionConsistency(context) {
-  const { ROOT_DIR, PACKAGE_JSON_PATH, CHANGELOG_PATH, PACKAGE_LOCK_PATH, GENERATED_RULE_FILES, readTextFile, fileExists, pass, fail } = context;
-  console.log('\nChecking release version consistency...');
-
-  const packageJson = JSON.parse(await readTextFile(PACKAGE_JSON_PATH));
-  const packageVersion = packageJson.version;
-  const changelogContent = await readTextFile(CHANGELOG_PATH);
-
-  if (changelogContent.includes(`## ${packageVersion}`)) {
-    pass(`CHANGELOG.md contains release entry for ${packageVersion}`);
-  } else {
-    fail(`CHANGELOG.md is missing a ## ${packageVersion} heading`);
-  }
-
-  if (await fileExists(PACKAGE_LOCK_PATH)) {
-    const packageLock = JSON.parse(await readTextFile(PACKAGE_LOCK_PATH));
-    const rootLockVersion = packageLock.packages?.['']?.version;
-    if (packageLock.version === packageVersion && rootLockVersion === packageVersion) {
-      pass(`package-lock.json matches package version ${packageVersion}`);
-    } else {
-      fail(`package-lock.json version drift: expected ${packageVersion}, found ${packageLock.version || 'missing'} / ${rootLockVersion || 'missing'}`);
-    }
-  } else {
-    fail('package-lock.json is required for npm release consistency');
-  }
-
-  for (const generatedRuleFileName of GENERATED_RULE_FILES) {
-    const generatedRuleContent = await readTextFile(join(ROOT_DIR, generatedRuleFileName));
-
-    if (generatedRuleContent.includes(`Generated by Agentic-Senior-Core CLI v${packageVersion}`)) {
-      pass(`${generatedRuleFileName} matches package version ${packageVersion}`);
-    } else {
-      fail(`${generatedRuleFileName} does not match package version ${packageVersion}`);
-    }
-  }
-}
-
-export async function validateMcpConfiguration(context) {
-  const { ROOT_DIR, readTextFile, pass, fail } = context;
-  console.log('\nChecking MCP configuration...');
-
-  const mcpConfiguration = JSON.parse(await readTextFile(join(ROOT_DIR, 'mcp.json')));
-  const workspaceMcpConfiguration = JSON.parse(await readTextFile(join(ROOT_DIR, '.vscode', 'mcp.json')));
-  const workspaceServerConfig = workspaceMcpConfiguration.servers?.['agentic-senior-core'];
-
-  if (mcpConfiguration.knowledgeLayers?.enabled === true) {
-    pass('Root MCP config has knowledgeLayers enabled');
-  } else {
-    fail('Root MCP config must have knowledgeLayers.enabled: true');
-  }
-
-  if (typeof workspaceMcpConfiguration.$schema === 'undefined') {
-    pass('Workspace MCP config omits $schema (supported by current VS Code MCP schema inference)');
-  } else if (workspaceMcpConfiguration.$schema === 'vscode://schemas/mcp') {
-    pass('Workspace MCP config uses trusted VS Code schema');
-  } else {
-    fail('Workspace MCP config $schema must be omitted or set to vscode://schemas/mcp');
-  }
-
-  if (workspaceServerConfig?.command === 'node') {
-    pass('Workspace MCP server command uses Node');
-  } else {
-    fail('Workspace MCP server command must use Node');
-  }
-
-  if (workspaceServerConfig?.cwd === '${workspaceFolder}') {
-    pass('Workspace MCP server cwd uses ${workspaceFolder}');
-  } else {
-    fail('Workspace MCP server cwd must be ${workspaceFolder}');
-  }
-
-  if (Array.isArray(workspaceServerConfig?.args) && workspaceServerConfig.args.includes('./scripts/mcp-server.mjs')) {
-    pass('Workspace MCP server points to scripts/mcp-server.mjs');
-  } else {
-    fail('Workspace MCP server must include ./scripts/mcp-server.mjs argument');
-  }
-}

package/scripts/validate/utils.mjs

@@ -1,52 +0,0 @@
-import { readdir, readFile, stat } from 'node:fs/promises';
-import { join } from 'node:path';
-
-export async function fileExists(filePath) {
-  try {
-    await stat(filePath);
-    return true;
-  } catch {
-    return false;
-  }
-}
-
-export async function readTextFile(filePath) {
-  return readFile(filePath, 'utf8');
-}
-
-export async function collectFiles(directoryPath, fileExtensionMatcher) {
-  const matchingFilePaths = [];
-
-  async function walk(currentDirectoryPath) {
-    const directoryEntries = await readdir(currentDirectoryPath, { withFileTypes: true });
-
-    for (const directoryEntry of directoryEntries) {
-      if (
-        directoryEntry.name === '.git'
-        || directoryEntry.name === 'node_modules'
-        || directoryEntry.name === '.agentic-backup'
-        || directoryEntry.name === '.benchmarks'
-      ) {
-        continue;
-      }
-
-      const entryPath = join(currentDirectoryPath, directoryEntry.name);
-
-      if (directoryEntry.isDirectory()) {
-        await walk(entryPath);
-        continue;
-      }
-
-      if (fileExtensionMatcher(directoryEntry.name)) {
-        matchingFilePaths.push(entryPath);
-      }
-    }
-  }
-
-  await walk(directoryPath);
-  return matchingFilePaths;
-}
-
-export function normalizeLineEndings(content) {
-  return content.replace(/\r\n/g, '\n').replace(/\r/g, '\n');
-}

package/scripts/validate.mjs

@@ -1,267 +0,0 @@
-#!/usr/bin/env node
-
-// Phase 1 governance refactor completed: monolithic script split into modular sub-files.
-/**
- * validate.mjs — Repository Integrity Validator
- *
- * Validates the Agentic-Senior-Core repository:
- * - Required files exist
- * - Markdown and JSON documents are readable
- * - Cross-references resolve from the correct source directory
- * - Version references stay consistent for release builds
- * - LLM Judge policy configuration is valid
- *
- * Usage: node scripts/validate.mjs
- */
-
-import { readdir, readFile, stat } from 'node:fs/promises';
-import { dirname, join, relative, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { ALLOWED_SEVERITIES } from './validate/config.mjs';
-import { runCacheLayerContractAudit } from './validate/audits/cache-layer-contract.mjs';
-import { runCachingScopeHygieneAudit } from './validate/audits/caching-scope-hygiene.mjs';
-
-import { runAuditFileSize } from './validate/audits/file-size.mjs';
-import { runReflectionCitationAudit } from './validate/audits/reflection-citations.mjs';
-import { runReleaseBundleAudit } from './validate/audits/release-bundle.mjs';
-import { runRuleIdUniquenessAudit } from './validate/audits/rule-id-uniqueness.mjs';
-import {
-  validateDependencyFreshnessAutomationCoverage,
-  validateDetectionTransparencyCoverage,
-  validateDeterministicBoundaryEnforcementCoverage,
-  validateDiagramFormatCoverage,
-  validateDockerRuntimeAutomationCoverage,
-  validateHumanWritingGovernance,
-  validateInstructionAdapters,
-  validateRulesOnlyActiveSurfaceCoverage,
-  validateSkillPurgeSurface,
-  validateStackDecisionBoundaryCoverage,
-  validateTemplateFreeBootstrapCoverage,
-  validateTerminologyMapping,
-  validateUiDesignAutomationCoverage,
-  validateUniversalSopConsolidationCoverage,
-  validateUpgradeUiContractWarningCoverage,
-} from './validate/coverage-checks.mjs';
-import {
-  validateRequiredFiles,
-  validateRuleFiles,
-  validateChecklistConsolidation,
-} from './validate/file-structure.mjs';
-import {
-  validateMarkdownFiles,
-  validateCrossReferences,
-  validateAgentsManifest,
-  validateDocumentationFlow,
-} from './validate/markdown-content.mjs';
-import {
-  validatePackageMetadata,
-  validatePolicyFile,
-  validateVersionConsistency,
-  validateMcpConfiguration,
-} from './validate/project-metadata.mjs';
-import { fileExists, readTextFile, collectFiles, normalizeLineEndings } from './validate/utils.mjs';
-
-const SCRIPT_FILE_PATH = fileURLToPath(import.meta.url);
-const ROOT_DIR = resolve(dirname(SCRIPT_FILE_PATH), '..');
-const AGENT_CONTEXT_DIR = join(ROOT_DIR, '.agent-context');
-const CANONICAL_INSTRUCTION_PATH = join(ROOT_DIR, 'AGENTS.md');
-const PACKAGE_JSON_PATH = join(ROOT_DIR, 'package.json');
-const PACKAGE_LOCK_PATH = join(ROOT_DIR, 'package-lock.json');
-const BUN_LOCK_PATH = join(ROOT_DIR, 'bun.lock');
-const CHANGELOG_PATH = join(ROOT_DIR, 'CHANGELOG.md');
-const README_PATH = join(ROOT_DIR, 'README.md');
-const POLICY_FILE_PATH = join(ROOT_DIR, '.agent-context', 'policies', 'llm-judge-threshold.json');
-const GENERATED_RULE_FILES = [];
-
-const validationResult = {
-  passed: 0,
-  failed: 0,
-  errors: [],
-  warnings: [],
-};
-
-
-
-function pass(message) {
-  validationResult.passed += 1;
-  console.log(`  PASS ${message}`);
-}
-
-function fail(message) {
-  validationResult.failed += 1;
-  validationResult.errors.push(message);
-  console.log(`  FAIL ${message}`);
-}
-
-function warn(message) {
-  validationResult.warnings.push(message);
-  console.log(`  WARN ${message}`);
-}
-
-
-
-
-async function validateFileSizeAudit() {
-  console.log('\nChecking file size threshold (audit:file-size)...');
-  const report = runAuditFileSize();
-
-  if (report.passed) {
-    pass(`File size audit clean: ${report.scannedFileCount} files scanned, ${report.exemptedCount} exempted under @file-size-exception`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`File exceeds ${report.threshold} LOC: ${violation.filePath} (${violation.lineCount} LOC). Split into focused submodules or declare a justified // @file-size-exception: <reason> marker in the first 5 lines.`);
-    }
-  }
-}
-
-async function validateCacheLayerContractAudit() {
-  console.log('\nChecking cache layer contract (audit:cache-layer-contract)...');
-  const report = runCacheLayerContractAudit();
-
-  if (report.passed) {
-    pass(`Cache layer contract audit clean: ${report.providerCount} provider(s), ${report.fixtureCount} fixture(s), ${report.resultCount} result row(s)`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`Cache layer contract violation [${violation.kind}]: ${violation.detail}`);
-    }
-  }
-}
-
-async function validateRuleIdUniquenessAudit() {
-  console.log('\nChecking rule ID uniqueness (audit:rule-id-uniqueness)...');
-  const report = runRuleIdUniquenessAudit();
-
-  if (report.passed) {
-    pass(`Rule ID audit clean: ${report.migratedFileCount} migrated rule file(s), ${report.skippedFileCount} pre-migration, ${report.knownSectionIdCount} section ID(s), ${report.refMentionCount} [REF:] mention(s) all resolve`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`Rule ID violation [${violation.kind}] in ${violation.file}: ${violation.detail}`);
-    }
-  }
-}
-
-async function validateReflectionCitationAudit() {
-  console.log('\nChecking reflection citations (audit:reflection-citations)...');
-  const report = runReflectionCitationAudit();
-
-  if (report.passed) {
-    pass(`Reflection citation audit clean: ${report.surfaceCount} surface(s), ${report.knownRuleIdCount} known rule ID(s)`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`Reflection citation violation [${violation.kind}] in ${violation.file}: ${violation.detail}`);
-    }
-  }
-}
-
-async function validateCachingScopeHygieneAudit() {
-  console.log('\nChecking caching scope hygiene (audit:caching-scope-hygiene)...');
-  const report = runCachingScopeHygieneAudit();
-
-  if (report.passed) {
-    pass(`Caching scope hygiene clean: ${report.surfaceCount} public surface(s), ${report.totalClaimCount} caching saving claim(s) all integration-scoped`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`Caching scope hygiene violation [${violation.kind}] in ${violation.file}:${violation.line}: ${violation.detail}`);
-    }
-  }
-}
-
-
-
-async function validateReleaseBundleAudit() {
-  console.log('\nChecking release benchmark bundle (audit:release-bundle)...');
-  const report = runReleaseBundleAudit();
-
-  if (report.passed) {
-    pass(`Release bundle integrity clean: ${report.artifactCount} artifact(s), release_target=${report.releaseTarget}, release_status=${report.releaseStatus}`);
-  } else {
-    for (const violation of report.violations) {
-      fail(`Release bundle violation [${violation.kind}]: ${violation.detail}`);
-    }
-  }
-}
-
-
-async function main() {
-  console.log('===============================================');
-  console.log('  Agentic-Senior-Core Repository Validator');
-  console.log('===============================================');
-
-  const coverageValidationContext = {
-    AGENT_CONTEXT_DIR,
-    CANONICAL_INSTRUCTION_PATH,
-    ROOT_DIR,
-    fail,
-    fileExists,
-    normalizeLineEndings,
-    pass,
-    readTextFile,
-  };
-
-  const generalValidationContext = {
-    ...coverageValidationContext,
-    PACKAGE_JSON_PATH,
-    PACKAGE_LOCK_PATH,
-    BUN_LOCK_PATH,
-    CHANGELOG_PATH,
-    README_PATH,
-    POLICY_FILE_PATH,
-    GENERATED_RULE_FILES,
-    collectFiles,
-    warn,
-  };
-
-  await validateRequiredFiles(generalValidationContext);
-  await validateMarkdownFiles(generalValidationContext);
-  await validateRuleFiles(generalValidationContext);
-  await validateChecklistConsolidation(generalValidationContext);
-  await validateAgentsManifest(generalValidationContext);
-  await validateCrossReferences(generalValidationContext);
-  await validatePackageMetadata(generalValidationContext);
-  await validatePolicyFile(generalValidationContext);
-  await validateVersionConsistency(generalValidationContext);
-  await validateDocumentationFlow(generalValidationContext);
-  await validateTerminologyMapping(coverageValidationContext);
-  await validateDetectionTransparencyCoverage(coverageValidationContext);
-  await validateStackDecisionBoundaryCoverage(coverageValidationContext);
-  await validateUniversalSopConsolidationCoverage(coverageValidationContext);
-  await validateDiagramFormatCoverage(coverageValidationContext);
-  await validateTemplateFreeBootstrapCoverage(coverageValidationContext);
-  await validateUpgradeUiContractWarningCoverage(coverageValidationContext);
-  await validateUiDesignAutomationCoverage(coverageValidationContext);
-  await validateDockerRuntimeAutomationCoverage(coverageValidationContext);
-  await validateDependencyFreshnessAutomationCoverage(coverageValidationContext);
-  await validateDeterministicBoundaryEnforcementCoverage(coverageValidationContext);
-  await validateRulesOnlyActiveSurfaceCoverage(coverageValidationContext);
-  await validateMcpConfiguration(generalValidationContext);
-  await validateHumanWritingGovernance(coverageValidationContext);
-  await validateInstructionAdapters(coverageValidationContext);
-  await validateSkillPurgeSurface(coverageValidationContext);
-  await validateCacheLayerContractAudit();
-  await validateReflectionCitationAudit();
-  await validateCachingScopeHygieneAudit();
-
-  await validateReleaseBundleAudit();
-  await validateFileSizeAudit();
-  await validateRuleIdUniquenessAudit();
-
-  console.log('\n===============================================');
-  console.log('  RESULTS');
-  console.log('===============================================');
-  console.log(`  Passed: ${validationResult.passed}`);
-  console.log(`  Failed: ${validationResult.failed}`);
-  console.log(`  Warnings: ${validationResult.warnings.length}`);
-  console.log('===============================================');
-
-  if (validationResult.failed > 0) {
-    console.log('\nVALIDATION FAILED\n');
-    process.exit(1);
-  }
-
-  console.log('\nALL CHECKS PASSED\n');
-}
-
-main().catch((error) => {
-  console.error('Validator crashed:', error);
-  process.exit(1);
-});